Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review167341 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review143034 --- @Shuai, did you pull the master upstream before rebasing? - Gilbe

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/ --- (Updated July 20, 2016, 6:10 a.m.) Review request for mesos, Guangya Liu and Ji

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

> On 七月 13, 2016, 1:32 p.m., Guangya Liu wrote: > > @Lin Shuai, can you please help rebase this? I did some clean up before for src/tests/containerizer/filesystem_isolator_tests.cpp here https://reviews.apache.org/r/44160/ , for the new added test cases, instead of keeping consistent, what ab

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review142113 --- Ship it! Ship It! - Gilbert Song On July 13, 2016, 9:16 a.m.

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/ --- (Updated July 13, 2016, 4:16 p.m.) Review request for mesos, Guangya Liu and Ji

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

> On July 13, 2016, 1:32 p.m., Guangya Liu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 1104 > > > > > > ```javascript > > EXPECT_TRUE(wait->has_status()); > > ``` All the other co

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review142061 --- @Lin Shuai, can you please help rebase this? src/tests/container

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review137265 --- Yu Jie, can you please help check if we can merge this? Thanks. -

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review133296 --- Ship it! Ship It! - Guangya Liu On May 14, 2016, 4:30 p.m.,

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review133285 --- Patch looks great! Reviews applied: [47095] Passed command: expo

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

> On May 14, 2016, 2:30 p.m., Guangya Liu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, lines 606-609 > > > > > > It seems a bit confuse for me: You are setting shell as false above, > > but here

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/ --- (Updated May 14, 2016, 4:30 p.m.) Review request for mesos, Guangya Liu and Jie

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review133273 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line 1064)

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review133269 --- Patch looks great! Reviews applied: [47095] Passed command: expo

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/ --- (Updated May 14, 2016, 8:55 a.m.) Review request for mesos, Guangya Liu and Jie

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132881 --- Patch looks great! Reviews applied: [47095] Passed command: expo

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

> On May 10, 2016, 8:34 a.m., Guangya Liu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 604 > > > > > > This test may fail on CentOS 7, please refer to > > https://reviews.apache.org/r/44985/

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

> On May 10, 2016, 8:34 a.m., Guangya Liu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 604 > > > > > > This test may fail on CentOS 7, please refer to > > https://reviews.apache.org/r/44985/

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/ --- (Updated May 12, 2016, 1:42 a.m.) Review request for mesos, Guangya Liu and Jie

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

- Shuai --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132207 --- On May 9, 2016, 3:51 a.m., Shuai Lin wrote: > > ---

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

> On May 10, 2016, 8:34 a.m., Guangya Liu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 604 > > > > > > This test may fail on CentOS 7, please refer to > > https://reviews.apache.org/r/44985/

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

> On May 9, 2016, 5:59 a.m., Guangya Liu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 1065 > > > > > > s/SandboxEnv/ContainerSandboxEnv ? I prefer `MesosSandboxEnv`, since that's what's be

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132393 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 604) <

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132207 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line 1065)

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132204 --- Patch looks great! Reviews applied: [47095] Passed command: expo

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/ --- (Updated May 9, 2016, 3:51 a.m.) Review request for mesos, Guangya Liu and Jie

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132192 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line 1064)

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132190 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line 1064)

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132174 --- Patch looks great! Reviews applied: [47095] Passed command: expo