Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Feb. 1, 2017, 10:36 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Jan. 31, 2017, 10:07 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Jan. 31, 2017, 10:04 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review163624 --- Bad patch! Reviews applied: [51028, 52534, 51027] Failed command

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Jan. 31, 2017, 1:41 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Jan. 30, 2017, 11:15 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Jan. 19, 2017, 3:15 a.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2994-2998 > > > > > > This test is already paused, all of these should be run with a paused > > clock, are

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Jan. 23, 2017, 11:08 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3765 > > > > > > Is `s/performing/; performed/?` better? yea I like that better - Jacob -

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Jan. 27, 2017, 2:33 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Jan. 23, 2017, 3:08 p.m., Jiang Yan Xu wrote: > > Modulo @bmahler's comments. Also this is not a complete set of tests that we should fix and we should follow up with more test fixes. - Jiang Yan --- This is an automatically gener

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review162722 --- Fix it, then Ship it! Modulo @bmahler's comments. src/tests/h

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Jan. 18, 2017, 11:29 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review162237 --- src/tests/hierarchical_allocator_tests.cpp (lines 2933 - 2936)

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 29, 2016, 3:06 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3007-3011 > > > > > > Just a question here, can we always guarantee only one `allocate()` > > will be called?

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Dec. 21, 2016, 5:58 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 29, 2016, 3:06 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3623-3627 > > > > > > Instead of killing this part, what about updating `offerCallback` > > function to recor

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 28, 2016, 11:02 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2974 > > > > > > Can you please add some comments here for why not using > > `Clock::pause()`? Added this ba

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Dec. 13, 2016, 4:30 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3005-3006 > > > > > > Similar to Guangya's suggestion, I think we can elaborate on the reason > > to use tow

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review158967 --- I think this patch can also follow /r/51027/ in the chain. src/t

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review150798 --- src/tests/hierarchical_allocator_tests.cpp (lines 3003 - 3004)

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On 九月 28, 2016, 11:02 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3674 > > > > > > It's weired that I can see all of the agents are actually allocated, > > but the `offerCallback

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review150773 --- src/tests/hierarchical_allocator_tests.cpp

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 9, 2016, 8:09 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3609 > > > > > > 1) The `allocationRuns.load()` actually include the number of > > allocations caused by adding

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 17, 2016, 3:36 a.m., Guangya Liu wrote: > > Jacob, can you help rebase? Just noting this here handled in chat, no rebase necessary. - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apach

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Sept. 28, 2016, 9:16 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 9, 2016, 8:09 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3609 > > > > > > 1) The `allocationRuns.load()` actually include the number of > > allocations caused by adding

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review149316 --- Jacob, can you help rebase? - Guangya Liu On 九月 8, 2016, 10:12

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review148318 --- This patch should actually should goes after /r/51027 , the test c

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review148314 --- src/tests/hierarchical_allocator_tests.cpp (line 2918)

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 6, 2016, 9:59 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2594 > > > > > > Seems we should also `Clock::settle();` here, otherwise, this test may > > be failed as r/5102

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Sept. 8, 2016, 10:12 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 6, 2016, 9:59 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2594 > > > > > > Seems we should also `Clock::settle();` here, otherwise, this test may > > be failed as r/5102

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On 九月 6, 2016, 9:59 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2594 > > > > > > Seems we should also `Clock::settle();` here, otherwise, this test may > > be failed as r/51027 >

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 6, 2016, 9:59 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2594 > > > > > > Seems we should also `Clock::settle();` here, otherwise, this test may > > be failed as r/5102

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

- Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review147697 --- On Aug. 23, 2016, 8:47 a.m., Jacob Janco wrote: > > ---

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 5, 2016, 11:23 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3126-3128 > > > > > > After reading this comment people could still wonder why this is > > important because

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review147809 --- src/tests/hierarchical_allocator_tests.cpp (line 2594)

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On 九月 5, 2016, 11:23 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2718-2720 > > > > > > How about: > > > > ``` > > // Wait for the allocation triggered from `addSl

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review147697 --- Could you run the allocator tests with a high number of iterations

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Aug. 17, 2016, 2:32 a.m.) Review request for mesos. Bugs: MESOS-3157