[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-16 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 Hello, sorry to bother you, but if this patch gets merged, I can work on the pylint errors and submit new PR I had to add in the ignore list of pylint. If I reenable most of them, here is

[GitHub] spark pull request #15059: [SPARK-17506][SQL] Improve the check double value...

2016-09-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15059#discussion_r79133345 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -289,13 +290,37 @@ trait

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #65481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65481/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #15108: [SPARK-17543] [Missing log4j config file for tests in co...

2016-09-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15108 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #15094: [SPARK-17534] [TESTS] Increase timeouts for DirectKafkaS...

2016-09-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15094 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #15108: [SPARK-17543] [Missing log4j config file for test...

2016-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15094: [SPARK-17534] [TESTS] Increase timeouts for Direc...

2016-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15094 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14762: [SPARK-16962][CORE][SQL] Fix misaligned record ac...

2016-09-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14762#discussion_r79135820 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java --- @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #15090: [SPARK-17073] [SQL] generate column-level statistics

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15090 **[Test build #65475 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65475/consoleFull)** for PR 15090 at commit

[GitHub] spark issue #15090: [SPARK-17073] [SQL] generate column-level statistics

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15090 **[Test build #65477 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65477/consoleFull)** for PR 15090 at commit

[GitHub] spark issue #14971: [SPARK-17410] [SPARK-17284] Move Hive-generated Stats In...

2016-09-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14971 Let me write a test case to ensure this correctly works and also put more comments in the code. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9 **[Test build #65478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65478/consoleFull)** for PR 9 at commit

[GitHub] spark pull request #15090: [SPARK-17073] [SQL] generate column-level statist...

2016-09-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15090#discussion_r79114194 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala --- @@ -0,0 +1,159 @@ +/* + * Licensed to the

[GitHub] spark issue #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65478/ Test FAILed. ---

[GitHub] spark issue #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9 **[Test build #65478 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65478/consoleFull)** for PR 9 at commit

[GitHub] spark issue #15090: [SPARK-17073] [SQL] generate column-level statistics

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15090 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65475/ Test FAILed. ---

[GitHub] spark issue #15090: [SPARK-17073] [SQL] generate column-level statistics

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15090 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15090: [SPARK-17073] [SQL] generate column-level statist...

2016-09-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15090#discussion_r79112828 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala --- @@ -0,0 +1,209 @@ +/* + * Licensed to

[GitHub] spark pull request #15090: [SPARK-17073] [SQL] generate column-level statist...

2016-09-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15090#discussion_r79113294 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala --- @@ -0,0 +1,209 @@ +/* + * Licensed to the

[GitHub] spark issue #14834: [SPARK-17163][ML] Unified LogisticRegression interface

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14834 **[Test build #65476 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65476/consoleFull)** for PR 14834 at commit

[GitHub] spark issue #14990: [SPARK-17426][SQL] Refactor `TreeNode.toJSON` to avoid O...

2016-09-16 Thread clockfly
Github user clockfly commented on the issue: https://github.com/apache/spark/pull/14990 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #15024: [SPARK-17470][SQL] unify path for data source table and ...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15024 **[Test build #65479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65479/consoleFull)** for PR 15024 at commit

[GitHub] spark issue #14971: [SPARK-17410] [SPARK-17284] Move Hive-generated Stats In...

2016-09-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14971 It does not break the existing behavior. If the MetastoreRelation has the Hive-generated table statistics, we create a statistics

[GitHub] spark pull request #15090: [SPARK-17073] [SQL] generate column-level statist...

2016-09-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15090#discussion_r79113407 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala --- @@ -0,0 +1,209 @@ +/* + * Licensed to the

[GitHub] spark pull request #14971: [SPARK-17410] [SPARK-17284] Move Hive-generated S...

2016-09-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14971#discussion_r79113972 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala --- @@ -111,23 +111,8 @@ private[hive] case class MetastoreRelation(

[GitHub] spark issue #14834: [SPARK-17163][ML] Unified LogisticRegression interface

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14834 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14834: [SPARK-17163][ML] Unified LogisticRegression interface

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14834 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65476/ Test PASSed. ---

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-09-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r79116875 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -447,17 +461,10 @@ private[spark] class

[GitHub] spark issue #15115: [SPARK-17558] Bump Hadoop 2.7 version from 2.7.2 to 2.7....

2016-09-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15115 +1, can't hurt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-09-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r79119043 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -204,13 +194,21 @@ case class

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-09-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r79118965 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -195,18 +195,31 @@ class InMemoryCatalog(

[GitHub] spark issue #14990: [SPARK-17426][SQL] Refactor `TreeNode.toJSON` to avoid O...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14990 **[Test build #65480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65480/consoleFull)** for PR 14990 at commit

[GitHub] spark pull request #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms ...

2016-09-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15105#discussion_r79145091 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -563,11 +580,16 @@ class Word2VecModel private[spark] ( ind +=

[GitHub] spark pull request #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms ...

2016-09-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15105#discussion_r79139615 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -518,25 +518,42 @@ class Word2VecModel private[spark] ( }

[GitHub] spark pull request #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms ...

2016-09-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15105#discussion_r79139237 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -227,7 +227,7 @@ class Word2VecModel private[ml] ( */

[GitHub] spark pull request #15117: [SPARK-17561] [DOCS] DataFrameWriter documentatio...

2016-09-16 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/15117 [SPARK-17561] [DOCS] DataFrameWriter documentation formatting problems ## What changes were proposed in this pull request? Fix / problems in SQL scaladoc. ## How was this

[GitHub] spark issue #15117: [SPARK-17561] [DOCS] DataFrameWriter documentation forma...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15117 **[Test build #65482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65482/consoleFull)** for PR 15117 at commit

[GitHub] spark issue #15093: [SPARK-17480][SQL][FOLLOWUP] Fix more instances which ca...

2016-09-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15093 OK, looks good. Some of these are .size -> .length changes, but I suppose those are related and positive. It avoids an extra method invocation, which might matter in a very tight loop.

[GitHub] spark issue #15078: [SPARK-17523] Support to generate build info file when b...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15078 **[Test build #3274 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3274/consoleFull)** for PR 15078 at commit

[GitHub] spark pull request #14467: [SPARK-16861][PYSPARK][CORE] Refactor PySpark acc...

2016-09-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14467#discussion_r79149813 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -866,11 +866,14 @@ class BytesToString extends

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-09-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r79119231 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -665,15 +665,7 @@ case class AlterTableSetLocationCommand(

[GitHub] spark issue #15090: [SPARK-17073] [SQL] generate column-level statistics

2016-09-16 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/15090 Yes we can keep stats of other columns, but we can't be sure if they are still correct between two analyze column commands, unless we recollect them. It's again the consistency issue, like between

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-09-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r79119152 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -204,13 +194,21 @@ case class

[GitHub] spark pull request #14971: [SPARK-17410] [SPARK-17284] Move Hive-generated S...

2016-09-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14971#discussion_r79121955 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -378,6 +380,47 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #15073: [SPARK-17518] [SQL] Block Users to Specify the In...

2016-09-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15073#discussion_r79122288 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala --- @@ -1151,6 +1152,56 @@ class MetastoreDataSourcesSuite

[GitHub] spark pull request #15073: [SPARK-17518] [SQL] Block Users to Specify the In...

2016-09-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15073#discussion_r79122430 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala --- @@ -1151,6 +1152,56 @@ class MetastoreDataSourcesSuite

[GitHub] spark pull request #15099: [SPARK-17541][SQL] fix some DDL bugs about table ...

2016-09-16 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/15099#discussion_r79122189 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -47,7 +47,11 @@ case class

[GitHub] spark pull request #15099: [SPARK-17541][SQL] fix some DDL bugs about table ...

2016-09-16 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/15099#discussion_r79122636 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -188,7 +196,7 @@ case class

[GitHub] spark issue #15078: [SPARK-17523] Support to generate build info file when b...

2016-09-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15078 + @HyukjinKwon we do windows for R --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15099: [SPARK-17541][SQL] fix some DDL bugs about table ...

2016-09-16 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/15099#discussion_r79124795 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -325,6 +325,21 @@ class SessionCatalog(

[GitHub] spark pull request #15099: [SPARK-17541][SQL] fix some DDL bugs about table ...

2016-09-16 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/15099#discussion_r79126002 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -47,7 +47,11 @@ case class

[GitHub] spark pull request #15099: [SPARK-17541][SQL] fix some DDL bugs about table ...

2016-09-16 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/15099#discussion_r79126355 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -140,7 +146,9 @@ case class

[GitHub] spark issue #15099: [SPARK-17541][SQL] fix some DDL bugs about table managem...

2016-09-16 Thread clockfly
Github user clockfly commented on the issue: https://github.com/apache/spark/pull/15099 My comments: # 1. There are too many hack about TableIdentifier. ## Problem: Currently, our current use of TableIdentifier is kind of ambiguous. ``` case class

[GitHub] spark issue #15090: [SPARK-17073] [SQL] generate column-level statistics

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15090 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65477/ Test PASSed. ---

[GitHub] spark issue #15090: [SPARK-17073] [SQL] generate column-level statistics

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15090 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-09-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r79119480 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -410,15 +417,22 @@ private[spark] class

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-09-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r79120516 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -410,15 +417,22 @@ private[spark] class

[GitHub] spark issue #15114: [SPARK-17473][SQL] fixing docker integration tests error...

2016-09-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15114 I thought Jackson 1.x and 2.x were in different namespaces so I don't think they should be able to collide? In any event, if it works, that's great, as it reduces the complexity here, but

[GitHub] spark pull request #15051: [SPARK-17499][SparkR][ML][MLLib] make the default...

2016-09-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15051#discussion_r79124867 --- Diff: R/pkg/R/mllib.R --- @@ -694,8 +694,11 @@ setMethod("predict", signature(object = "KMeansModel"), #' } #' @note spark.mlp since 2.1.0

[GitHub] spark pull request #15051: [SPARK-17499][SparkR][ML][MLLib] make the default...

2016-09-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15051#discussion_r79124966 --- Diff: R/pkg/R/mllib.R --- @@ -694,8 +694,11 @@ setMethod("predict", signature(object = "KMeansModel"), #' } #' @note spark.mlp since 2.1.0

[GitHub] spark issue #15051: [SPARK-17499][SparkR][ML][MLLib] make the default params...

2016-09-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15051 could you update the tests and add more tests for default values as discussed [here](https://github.com/apache/spark/pull/15051#issuecomment-246199557) --- If your project is set up for it,

[GitHub] spark issue #15024: [SPARK-17470][SQL] unify path for data source table and ...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15024 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15024: [SPARK-17470][SQL] unify path for data source table and ...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15024 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65479/ Test FAILed. ---

[GitHub] spark issue #15024: [SPARK-17470][SQL] unify path for data source table and ...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15024 **[Test build #65479 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65479/consoleFull)** for PR 15024 at commit

[GitHub] spark issue #15090: [SPARK-17073] [SQL] generate column-level statistics

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15090 **[Test build #65477 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65477/consoleFull)** for PR 15090 at commit

[GitHub] spark issue #14990: [SPARK-17426][SQL] Refactor `TreeNode.toJSON` to avoid O...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14990 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14990: [SPARK-17426][SQL] Refactor `TreeNode.toJSON` to avoid O...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14990 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65480/ Test PASSed. ---

[GitHub] spark issue #15078: [SPARK-17523] Support to generate build info file when b...

2016-09-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15078 Thanks for cc'ing me @felixcheung. Actually, I took a look and wanted to leave a comment but I didn't because I couldn't find a concrete reason or reference to support my opinion and also I

[GitHub] spark pull request #15084: [SPARK-17529][core] Implement BitSet.clearUntil a...

2016-09-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15084#discussion_r79137878 --- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala --- @@ -58,6 +53,19 @@ class BitSet(numBits: Int) extends Serializable { }

[GitHub] spark issue #14990: [SPARK-17426][SQL] Refactor `TreeNode.toJSON` to avoid O...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14990 **[Test build #65480 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65480/consoleFull)** for PR 14990 at commit

[GitHub] spark pull request #15084: [SPARK-17529][core] Implement BitSet.clearUntil a...

2016-09-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15084#discussion_r79138018 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala --- @@ -954,12 +954,12 @@ private class

[GitHub] spark issue #15089: [SPARK-15621] [SQL] Support spilling for Python UDF

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15089 **[Test build #65500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65500/consoleFull)** for PR 15089 at commit

[GitHub] spark issue #15024: [SPARK-17470][SQL] unify path for data source table and ...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15024 **[Test build #65497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65497/consoleFull)** for PR 15024 at commit

[GitHub] spark issue #15024: [SPARK-17470][SQL] unify path for data source table and ...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15024 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14762: [SPARK-16962][CORE][SQL] Fix misaligned record accesses ...

2016-09-16 Thread sumansomasundar
Github user sumansomasundar commented on the issue: https://github.com/apache/spark/pull/14762 Made the changes @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15089: [SPARK-15621] [SQL] Support spilling for Python UDF

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15089 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65500/ Test PASSed. ---

[GitHub] spark issue #15089: [SPARK-15621] [SQL] Support spilling for Python UDF

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15089 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15099: [SPARK-17541][SQL] fix some DDL bugs about table managem...

2016-09-16 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15099 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15103: [SPARK-17100] [SQL] fix Python udf in filter on top of o...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15103 **[Test build #65502 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65502/consoleFull)** for PR 15103 at commit

[GitHub] spark issue #14862: [SPARK-17295][SQL] Create TestHiveSessionState use refle...

2016-09-16 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/14862 What exactly does this change buy us? It doesn't allow us to remove any of the inheritance code. `TestHiveSessionState` is not fundamentally different from `HiveSessionState` so I think it's

[GitHub] spark issue #14644: [MESOS] Enable GPU support with Mesos

2016-09-16 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/14644 Tim, please file a JIRA! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15112: [SPARK-17549][sql] Only collect table size stat in drive...

2016-09-16 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15112 LGTM. Merging to master and branch 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #11105: [SPARK-12469][CORE] Data Property accumulators for Spark

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11105 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65508/ Test FAILed. ---

[GitHub] spark issue #11105: [SPARK-12469][CORE] Data Property accumulators for Spark

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11105 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15106: [SPARK-16439] [SQL] bring back the separator in SQL UI

2016-09-16 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/15106 @srowen The previous problem is caused by using the default locale of host to format the numbers, that sounds perfect by caused some problems. So we fallback to only use English as the locale, it

[GitHub] spark pull request #15112: [RFC][SPARK-17549][sql] Only collect table size s...

2016-09-16 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/15112#discussion_r79226378 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -910,14 +910,19 @@ object CodeGenerator

[GitHub] spark issue #15024: [SPARK-17470][SQL] unify path for data source table and ...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15024 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15024: [SPARK-17470][SQL] unify path for data source table and ...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15024 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65499/ Test PASSed. ---

[GitHub] spark pull request #11293: [SPARK-13080] [SQL] Implement new Catalog API usi...

2016-09-16 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11293#discussion_r79246548 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -127,33 +166,30 @@ abstract class Catalog { *

[GitHub] spark issue #13822: [SPARK-16115][SQL] Change output schema to be partition ...

2016-09-16 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/13822 By the way I'm not super active in this community anymore. If you want a quicker response you could try your luck by pinging @yhuai or @cloud-fan instead. --- If your project is set up for it,

[GitHub] spark issue #15117: [SPARK-17561] [DOCS] DataFrameWriter documentation forma...

2016-09-16 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15117 I merged this in master but there's a conflict with branch-2.0. Can you create a patch for 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #15118: Branch 2.0

2016-09-16 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/15118 @avinashkolla please close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #15112: [RFC][SPARK-17549][sql] Only collect table size s...

2016-09-16 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/15112#discussion_r79226426 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -910,14 +910,19 @@ object CodeGenerator

[GitHub] spark issue #15117: [SPARK-17561] [DOCS] DataFrameWriter documentation forma...

2016-09-16 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15117 LGTM - merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15089: [SPARK-15621] [SQL] Support spilling for Python UDF

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15089 **[Test build #65500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65500/consoleFull)** for PR 15089 at commit

[GitHub] spark issue #15112: [SPARK-17549][sql] Only collect table size stat in drive...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15112 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65501/ Test PASSed. ---

[GitHub] spark issue #15112: [SPARK-17549][sql] Only collect table size stat in drive...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15112 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15112: [SPARK-17549][sql] Only collect table size stat i...

2016-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #11105: [SPARK-12469][CORE] Data Property accumulators for Spark

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11105 **[Test build #65508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65508/consoleFull)** for PR 11105 at commit

  1   2   3   4   >