Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17434084
--- Diff:
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -45,120 +46,97 @@ class Client(clientArgs: ClientArguments, hadoopConf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17434529
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala
---
@@ -35,28 +34,57 @@ class ClientArguments(val args: Array[String
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17437304
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -396,19 +352,27 @@ trait ClientBase extends Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17437744
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -417,41 +381,136 @@ trait ClientBase extends Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17438506
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -598,46 +675,44 @@ object ClientBase extends Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17439313
--- Diff:
yarn/common/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala
---
@@ -36,113 +36,114 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17439372
--- Diff:
yarn/common/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala
---
@@ -36,113 +36,114 @@ private[spark] class
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2350#issuecomment-55326314
@andrewor14 thanks for working on this, this was next on my things to
clean up when I find some time list. :-) Didn't see anything too controversial
aside from what has
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2320#issuecomment-55327730
@huozhanfeng I don't think there's any way to transfer files securely to
workers right now. Perhaps a mode where the launcher / driver uses HDFS to
distribute files
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2357#issuecomment-55342092
This sort of conflicts with parts of #2329. Would it be possible to add a
flag to the new plugin so that it can automatically skip projects where a
certain property
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/577#discussion_r17493894
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -73,7 +73,17 @@ private[spark] class DiskStore(blockManager:
BlockManager
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2373#issuecomment-55453225
LGTM. Guess I assumed alpha would work like stable in this area...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/260#issuecomment-55462372
@mathonsunday you're the only one who can do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2320#issuecomment-55622273
... a path where the addFile HTTP server is authenticated ...
But that's just authentication, right? Or is it actually encrypting the
bytes being transferred
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2399#issuecomment-55621602
+1 yay
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2257#discussion_r17557475
--- Diff:
yarn/stable/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-55629883
I reduced the number of executors from the cluster test (from 4 to 1,
something I meant to do before but forgot) and shaved ~15s on my machine. Tests
still run sort
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-55766467
I think I have an opposite view from Andrew in that I dislike using
sys.props as an IPC mechanism, but other than that, looks good.
---
If your project is set up
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17610954
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -167,14 +167,19 @@ class HistoryServer(
* This launches
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-55777084
@andrewor14 makes sense. Yeah, that would simplify the change a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-55777341
Just to make sure, a blind `conf.set` would override anything the use has
set using system properties, which is probably not what we want. Probably beter
to use
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2399#issuecomment-55822289
@pwendell FailureSuite seems to already call into all the tests exposed by
MasterFailureSuite, which is why I filed the bug. The two files could probably
even be merged
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-55832295
Finally got around to this. Let me know what you think of the approach.
Note about the approach: adding a header to the files is not optimal
because it makes
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-55832470
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2401#issuecomment-55922361
Might want to take a look at #1391 also; that adds a similar thing for Yarn
(a multiplier for the JVM overhead), it might be worth to merge the two code
paths (or add
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2421#discussion_r17700696
--- Diff: sbin/start-thriftserver.sh ---
@@ -27,7 +27,7 @@ set -o posix
FWDIR=$(cd `dirname $0`/..; pwd)
CLASS
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17743007
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,30 +51,27 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17743439
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala ---
@@ -47,14 +48,25 @@ private[spark] class WorkerArguments(args:
Array
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17745188
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala ---
@@ -47,14 +48,25 @@ private[spark] class WorkerArguments(args:
Array
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2449#issuecomment-56099817
Hi, mostly so I understand what's going on (I've traced the code but it's
kinda hard to know if I covered everything), how are jars distributed in yarn
cluster mode after
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2449#issuecomment-56106581
Ah, I see. Missed this in SparkSubmit.scala:
OptionAssigner(args.jars, YARN, CLUSTER, clOption = --addJars),
LGTM.
---
If your project is set up
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2337#issuecomment-56107566
Ping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2452#issuecomment-56122218
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2401#issuecomment-56122505
@willb in the case of Yarn, the parameter is called overhead because it
actually sets the amount of overhead you want to add to the requested heap
memory. The PR being
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2337#discussion_r17800470
--- Diff: core/src/test/scala/org/apache/spark/FutureActionSuite.scala ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2337#discussion_r17800549
--- Diff: core/src/main/scala/org/apache/spark/FutureAction.scala ---
@@ -171,6 +179,8 @@ class ComplexFutureAction[T] extends FutureAction[T
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2401#issuecomment-56216271
So, I'm a little disappointed that this doesn't at least follow the Yarn
model of one setting that defines the overhead. Instead, it has two settings,
one for a fraction
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17807812
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,10 +51,18 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17807849
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,10 +51,18 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17807955
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,55 @@ private[spark] object Utils extends Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17808054
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,55 @@ private[spark] object Utils extends Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17808036
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,55 @@ private[spark] object Utils extends Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17808099
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -297,4 +300,21 @@ class UtilsSuite extends FunSuite
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56232823
Jenkins complained about some scalastyle issue, can you double check that
you didn't cause it? Otherwise looks good (with a few nits).
---
If your project is set up
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/2469
[SPARK-3606] [yarn] Correctly configure AmIpFilter for Yarn HA.
The existing code only considered one of the RMs when running in
Yarn HA mode, so it was possible to get errors if the active RM
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2469#issuecomment-56249340
What I tested:
- compiled for yarn-alpha but didn't test
- ran job with yarn-cluster and yarn-client on single RM yarn
- ran job with yarn-cluster and yarn
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17815609
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -417,41 +381,136 @@ trait ClientBase extends Logging
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2350#issuecomment-56250213
I gave it another look and it looks OK to me. I'm sure if there are any
regressions, we'll find that out pretty quickly.
---
If your project is set up for it, you can
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2454#issuecomment-56250584
LGTM. Could you fix the typo in the PR title (loaing)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2391#discussion_r17816145
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -38,6 +38,9 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2391#discussion_r17816156
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -214,6 +245,27 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2391#discussion_r17816167
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -214,6 +245,27 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2391#discussion_r17816209
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -214,6 +245,27 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2391#discussion_r17816237
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -214,6 +245,27 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2391#discussion_r17816266
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -214,6 +245,27 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2469#issuecomment-56252034
Test failure looks unrelated?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2337#issuecomment-56406159
Lots of questions, let's go one by one.
# Motivation
This is discussed in SPARK-2636 (and probably a coupe of others), but I'll
try to summarize
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2311#discussion_r17863114
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -119,13 +126,7 @@ private[spark] class ApplicationMaster
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2311#discussion_r17863181
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -119,13 +126,7 @@ private[spark] class ApplicationMaster
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2337#issuecomment-56407988
This is kind of messy (this isn't a documented / stable API, though).
More than that, it's `private[spark]`, which means I have to hardcode the
string in my code
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2337#issuecomment-56408155
Just to be clear, I'm ok with switching to using job groups to achieve what
HoS needs (and close this PR/bug), but even that path seems like it could use
some changes
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2311#discussion_r17864288
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -119,13 +126,7 @@ private[spark] class ApplicationMaster
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2311#issuecomment-56410208
@tgravescs this change should handle uncaught exceptions and explicit
`System.exit` in the driver code. Not sure if that covers all the issues you're
seeing
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-56412833
@witgo could you upmerge this please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-56413709
Ping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2469#issuecomment-56413627
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2469#issuecomment-56417990
BTW it would be nice to backport this to 1.1 or 1.0, but this patch won't
merge cleanly. I'll work on that when this PR is merged.
---
If your project is set up
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/2496
[SPARK-3647] Add more exceptions to Guava relocation.
Guava's Optional refers to some package private classes / methods, and
when those are relocated the code stops working, throwing exceptions
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2496#issuecomment-56454460
I verified that the test triggers the issue without the pom changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/2497
[SPARK-3606] [yarn] Correctly configure AmIpFilter for Yarn HA (1.1 vers...
...ion).
This is a backport of SPARK-3606 to branch-1.1. Some of the code had to be
duplicated since branch
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2497#issuecomment-56462789
Backport of #2469 to branch-1.1. Sending now to speed up the review
process, since the original PR doesn't merge cleanly into this branch.
---
If your project is set up
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2257#discussion_r17938584
--- Diff: yarn/pom.xml ---
@@ -126,7 +126,6 @@
configuration
environmentVariables
SPARK_HOME${basedir
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2257#discussion_r17938630
--- Diff: yarn/pom.xml ---
@@ -126,7 +126,6 @@
configuration
environmentVariables
SPARK_HOME${basedir
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2257#discussion_r17938804
--- Diff:
yarn/stable/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r17943561
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -34,10 +34,20 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r17943541
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -34,10 +34,20 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r17943630
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -100,6 +132,12 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r17943665
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -100,6 +132,12 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r17943624
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -100,6 +132,12 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r17943673
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -100,6 +132,12 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r17943683
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -214,6 +252,32 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r17943689
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -214,6 +252,32 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r17943751
--- Diff: docs/monitoring.md ---
@@ -135,6 +135,29 @@ follows:
codespark.ui.view.acls/code when the application was run will
also have
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r17943824
--- Diff: docs/monitoring.md ---
@@ -135,6 +135,29 @@ follows:
codespark.ui.view.acls/code when the application was run will
also have
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-56600443
I think there's a very unlikely race in your code: it's possible, if things
are messed up just right, that the reader thread might try to read a log file
that is being
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-56601784
Jenkins, retest this please.
Is there any way to access `unit-tests.log` from jenkins?
---
If your project is set up for it, you can reply to this email and have
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-56604168
Having everything in the same file is ok. I think the trick in this case is
to convince the child processes launched by Yarn to not use the common log4j
configuration
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2311#discussion_r17946116
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -91,7 +94,11 @@ private[spark] class ApplicationMaster(args
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-56694970
I'll merge with master and see if I can reproduce the failure...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-56696661
Yep, fails locally too after the merge. Let me look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-56709844
I found the problem - it was caused by a recent PR that basically broke
yarn-cluster mode...
---
If your project is set up for it, you can reply to this email and have
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2520#issuecomment-56711425
LGTM. I don't really understand why you need to tell sbt again where the
sources are (after all, sbt does build the yarn code properly), but then I'm
not an sbt expert
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998434
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster egspark
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998489
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster egspark
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998530
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster egspark
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998542
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster egspark
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998857
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -48,8 +50,10 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998933
--- Diff:
core/src/main/scala/org/apache/spark/deploy/MergedPropertyMap.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17999062
--- Diff:
core/src/main/scala/org/apache/spark/deploy/MergedPropertyMap.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998809
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -48,8 +50,10 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging
1 - 100 of 11074 matches
Mail list logo
