On 8/6/2013 10:59 AM, Erik Gahlin wrote:
Please review this change.
An exception from JConsole plug-in should not affect other tabs.
http://monaco.us.oracle.com/detail.jsf?cr=6696970
Added a plug-in proxy that handles RE. If debug mode is enabled
exceptions are written to System.err. Tested
On 7/23/2013 5:54 PM, David Holmes wrote:
On 23/07/2013 7:53 PM, Daniel Fuchs wrote:
On 7/23/13 11:45 AM, David Holmes wrote:
On 23/07/2013 7:24 PM, Jaroslav Bachorik wrote:
The result is that the offender is j.u.l.LogManager$Cleaner
thread. I
am attaching the profiler snapshot (can be
On 7/24/2013 2:09 PM, Daniel Fuchs wrote:
On 7/24/13 8:01 AM, Mandy Chung wrote:
I am catching up on this thread
The thread count counts Java threads that are not hidden. I believe
all VM internal threads are hidden from external API. This test runs
in othervm mode and AFAICT
On 7/24/2013 4:50 PM, shanliang wrote:
So we have 2 kinds of issues here:
1) the test related, like Thread state checking, we can fix them in
the test
2) MBean.getThreadCount() issue, we can create a bug to trace it (add
your test case to the bug), and add a workaround (sleep or call 2
Changeset: 858c75eb83b5
Author:mchung
Date: 2013-07-08 14:05 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/858c75eb83b5
8014890: (ref) Reference queues may return more entries than expected
Summary: When enqueuing references check whether the j.l.r.Reference has
already
On 7/10/2013 4:33 PM, Jaroslav Bachorik wrote:
The change looks reasonable. In the class spec for MXBean, suggest to
rename
interface ThisIsNotMXBean{}
to something more explicit
interface NonPublicInterfaceNotMXBean{}
Since this was a part of the CCC review which was approved I am
Looks good.
Mandy
On Jul 10, 2013, at 5:10 PM, Jaroslav Bachorik jaroslav.bacho...@oracle.com
wrote:
Please, review this simple fix.
http://cr.openjdk.java.net/~jbachorik/8019826/webrev.00
Firstly, the patch removes a conditional early exit which checks for a
build 52 of an unspecified
Changeset: cf7202b32a34
Author:mchung
Date: 2013-07-02 15:58 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf7202b32a34
8007035: deprecate public void SecurityManager.checkMemberAccess(Class?
clazz, int which)
Reviewed-by: jrose, alanb, dfuchs
!
Changeset: 986793409b2b
Author:bpb
Date: 2013-06-05 21:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/986793409b2b
7032154: Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDecimal
Summary: Performance improvements for double/float - String and decimal/hex
Changeset: f5f54e493a64
Author:bpb
Date: 2013-06-06 16:45 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5f54e493a64
8016117: New sun.misc.FDBigInteger class as part of 7032154
Reviewed-by: martin, iris
Contributed-by: Sergey Kuksenko sergey.kukse...@oracle.com, Brian
Changeset: bd84bad9ee99
Author:jdn
Date: 2013-06-04 15:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd84bad9ee99
8014097: add doPrivileged methods with limited privilege scope
Reviewed-by: mchung
! src/share/classes/java/security/AccessControlContext.java
!
On 5/31/2013 5:59 AM, Nils Loodin wrote:
Simple fix to not show negative CPU usage in JConsole:
http://cr.openjdk.java.net/~nloodin/6526682/webrev.00/
Looks okay.
Mandy
Regards,
Nils Loodin
Good catch. Looks good. There are other j.l.management tests that
force GC to happen and I'm not sure if any of them requires similar
fix. Might be worth to check if any of them has similar assumption.
Mandy
On 5/28/13 1:11 AM, Staffan Larsen wrote:
Please review the following fix:
the indentation on lines 458-459)
Thumbs up!
FYI: Mandy Chung is the person to ping if/when you have a more
complicated jconsole fix...
Dan
On 5/27/13 8:34 AM, Nils Loodin wrote:
Could you please chime in? :)
/Nisse
On 05/24/2013 06:33 PM, Staffan Larsen wrote:
Looks good
Changeset: 5e8959ab64af
Author:mchung
Date: 2013-05-16 15:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e8959ab64af
4487672: (proxy) Proxy constructor should check for null argument
Reviewed-by: alanb, lancea
! src/share/classes/java/lang/reflect/Proxy.java
!
On 5/13/13 1:50 PM, Staffan Larsen wrote:
Shouldn't the link be to the oracle site that the sun site redirects to:
http://docs.oracle.com/javase/7/docs/technotes/guides/management/jconsole.html
Can you take it further to construct the link with the release version of the
JRE:
On 5/6/13 8:17 AM, Staffan Larsen wrote:
webrev: http://cr.openjdk.java.net/~sla/7148492/webrev.00/
Looks good. It's good to run ResetPeakMemoryUsage with all different
collectors. There are several shell tests in the
test/java/lang/management/MemoryMXBean that can simply be replaced by
MBean server. Many smaller fixes have also been done based
on provided feedback.
http://cr.openjdk.java.net/~fparain/7150256/webrev.07/
Thanks,
Fred
On 24/04/2013 22:07, Mandy Chung wrote:
Hi Frederic,
I reviewed the jdk webrev that is looking good. I reviewed
On 5/3/2013 11:19 AM, Daniel Fuchs wrote:
Hi,
On 5/3/13 8:02 PM, Mandy Chung wrote:
2. Investigate what DiagnosticCommandImpl.getAttributes and
setAttributes should do per DynamicMBean spec. The current
implementation throws UOE which seem to be okay. It's good to confirm
what is specified
of DynamicMBean.setAttributes() is
void. Does it mean that in our case, setAttributes()
should simply be a no-op method?
Fred
On 03/05/2013 20:19, Daniel Fuchs wrote:
Hi,
On 5/3/13 8:02 PM, Mandy Chung wrote:
2. Investigate what DiagnosticCommandImpl.getAttributes and
setAttributes should do per
Changeset: 4a82d2b86c75
Author:mchung
Date: 2013-04-30 15:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a82d2b86c75
8013531: Provide a utility class in com.sun.tools.classfile to find
field/method references
Reviewed-by: alanb
!
Changeset: 57648bad3287
Author:mchung
Date: 2013-04-30 15:43 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/57648bad3287
8013531: Provide a utility class in com.sun.tools.classfile to find
field/method references
Reviewed-by: alanb
!
On 4/29/13 7:09 AM, Staffan Larsen wrote:
You are right. I was just being lazy.
Update webrev: http://cr.openjdk.java.net/~sla/8003671/webrev.01/
This change looks fine to me.
Mandy
Thanks,
/Staffan
On 29 apr 2013, at 15:43, Rickard Bäckmanrickard.back...@oracle.com wrote:
Actually,
Changeset: 5e7ae178b24d
Author:plevart
Date: 2013-04-26 16:09 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e7ae178b24d
7123493: (proxy) Proxy.getProxyClass doesn't scale under high load
Reviewed-by: mchung
! src/share/classes/java/lang/reflect/Proxy.java
+
Hi Frederic,
I reviewed the jdk webrev that is looking good. I reviewed
com.sun.management.DiagnosticCommandMBean spec almost half a year ago.
Reviewing it now with a fresh memory has some benefit that I have a few
comments on the spec.
java.lang.management.PlatformManagedObject is
Changeset: e8f1dc6d0c0c
Author:jgish
Date: 2013-04-19 16:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8f1dc6d0c0c
8010939: Deadlock in LogManager
Summary: re-order locks to avoid deadlock
Reviewed-by: mchung
! src/share/classes/java/util/logging/LogManager.java
+
This fix adds GetSafepointSyncTime.java test in the ProblemList.txt
until 8010897 is resolved. It has been failing intermittently on macosx-x64.
diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++ b/test/ProblemList.txt
@@ -144,6 +144,9 @@
# jdk_management
Changeset: 32c3a580812b
Author:mchung
Date: 2013-04-18 11:14 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/32c3a580812b
8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in
ProblemList.txt
Reviewed-by: lancea, alanb
! test/ProblemList.txt
Changeset: 3b81fac25d26
Author:mchung
Date: 2013-04-18 13:02 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b81fac25d26
8011934: sun.misc.PerfCounter calls Perf.createLong with incorrect parameters
Reviewed-by: mchung
Contributed-by: Yasumasa Suenaga y...@ysfactory.dip.jp
Changeset: 3e4a0fddeb00
Author:jgish
Date: 2013-04-18 16:33 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e4a0fddeb00
8012005: LogManager needs test to ensure stack trace is not being done to find
bundle
Reviewed-by: mchung
+
Changeset: 73e3b474125e
Author:mchung
Date: 2013-04-17 12:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/73e3b474125e
8004260: dynamic proxy class should have the same Java language access as the
proxy interfaces
Reviewed-by: alanb, jrose, jdn
!
Changeset: da6addef956e
Author:mchung
Date: 2013-04-16 21:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da6addef956e
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
Reviewed-by: jrose, alanb, twisti
! make/java/java/FILES_c.gmk
!
Changeset: 222a72df2f42
Author:mchung
Date: 2013-04-16 22:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/222a72df2f42
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
Reviewed-by: jrose, alanb, twisti, sundar
!
Hi Yasumasa,
I'm adding core-libs and bcc serviceability-dev to move this thread to
core-libs for sun.misc.PerfCounter discussion.
On 4/9/2013 4:50 AM, Yasu wrote:
Hi,
I'm trying to create entry from Java program to hsperfdata through
sun.misc.PerfCounter .
First of all,
Changeset: b62a76763bf3
Author:mchung
Date: 2013-04-05 10:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b62a76763bf3
8011380: FX dependency on PlatformLogger broken by 8010309
Reviewed-by: alanb
! src/share/classes/java/util/logging/LoggingProxyImpl.java
!
Changeset: e433ed08b733
Author:mchung
Date: 2013-03-28 13:14 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e433ed08b733
8010309: Improve PlatformLogger.isLoggable performance by direct mapping from
an integer to Level
Reviewed-by: mchung
Contributed-by:
Changeset: 5e383a73386a
Author:mchung
Date: 2013-03-25 17:19 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e383a73386a
8007703: Remove com.sun.servicetag API
Reviewed-by: dholmes, alanb, erikj
! make/com/sun/Makefile
! make/common/Release.gmk
! makefiles/CopyFiles.gmk
!
Changeset: 335d2156222e
Author:mchung
Date: 2013-03-25 18:14 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/335d2156222e
8010787: changeset for 8007703 is missing the deleted files
Reviewed-by: dholmes, alanb, erikj
- make/com/sun/servicetag/Makefile
-
Changeset: ccd9f53377c4
Author:mchung
Date: 2013-03-20 09:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ccd9f53377c4
8006104: Improve tests to test .useParentHandlers property set in the logging
configuration
Reviewed-by: alanb
!
Changeset: fd3fdaff0257
Author:mchung
Date: 2013-03-14 10:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fd3fdaff0257
8005428: Update jdeps to read the same profile information as by javac
Reviewed-by: alanb
! make/netbeans/langtools/nbproject/project.xml
!
Changeset: 94335b6ffb32
Author:jgish
Date: 2013-03-13 11:24 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94335b6ffb32
8002070: Remove the stack search for a resource bundle for Logger to use
Summary: The fragile, vulnerable, stack crawling has been eliminated from
On 2/21/2013 10:46 AM, Alan Bateman wrote:
Joe Darcy recently added @jdk.Supported [1] to make it possible to
identify JDK-specific APIs.
I'd like to add this to a number of APIs in the com.sun namespace to
make it obvious these are supported.
It's nice to be able to mark what is
Changeset: 88286a36bb34
Author:mchung
Date: 2013-02-14 09:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/88286a36bb34
8006225: tools/jdeps/Basic.java failes with AssertionError
Reviewed-by: alanb
+ src/share/classes/com/sun/tools/jdeps/Analyzer.java
!
Changeset: 1405ad6afb1e
Author:bharadwaj
Date: 2013-02-14 11:09 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1405ad6afb1e
8007736: VerifyError for use of static method in interface
Reviewed-by: mchung
! src/share/native/common/check_code.c
+
On 2/8/2013 12:08 AM, Erik Helin wrote:
New webrev located at:
http://cr.openjdk.java.net/~ehelin/8004172/jdk/webrev.05/
Thumbs up.
Mandy
On 2/7/2013 4:36 AM, Erik Helin wrote:
Hi Mandy,
thanks for the review! See comments inline.
On 02/05/2013 09:14 PM, Mandy Chung wrote:
Looks good. Minor nits:
gcCapacityOutput1.awk - should the last column in L7 be removed?
I don't think so, jmap -gccause outputs the GC cause
Hi Erik,
On 2/4/13 8:01 AM, Erik Helin wrote:
There have been some updates to the hotspot code based on feedback from
the hotspot-gc-dev mailing list. The only change to the JDK code is that
the namespace is back to sun.gc :)
New webrevs:
-
-January/007957.html
On 2/5/13 12:14 PM, Mandy Chung wrote:
Hi Erik,
On 2/4/13 8:01 AM, Erik Helin wrote:
There have been some updates to the hotspot code based on feedback from
the hotspot-gc-dev mailing list. The only change to the JDK code is that
the namespace is back to sun.gc :)
New webrevs
Changeset: a09a37cff333
Author:mchung
Date: 2013-01-31 14:29 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a09a37cff333
6355704: (fmt) %f formatting of BigDecimals is incorrect
Reviewed-by: darcy
Contributed-by: brian.burkhal...@oracle.com
!
Hi Jon,
On 1/4/2013 2:41 PM, Jon Masamitsu wrote:
8004172: Remove display of permanent generation counters from jstat
options
This change removes from the jstat options the display of
permanent generation counters. It also removes entirely the
gcpermcapacity option.
Changeset: 4c8b37f159f9
Author:mchung
Date: 2013-01-09 16:58 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c8b37f159f9
7103957: NegativeArraySizeException while initializing class IntegerCache
Reviewed-by: darcy, mchung
Contributed-by: brian.burkhal...@oracle.com
!
Changeset: c37401e77c80
Author:mchung
Date: 2012-12-28 22:20 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/c37401e77c80
8003562: Provide a CLI tool to analyze class dependencies
Reviewed-by: jjg, alanb, ulfzibis, erikj
! common/bin/compare_exceptions.sh.incl
Changeset: 0c244701188e
Author:mchung
Date: 2012-12-28 22:25 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0c244701188e
8003562: Provide a CLI tool to analyze class dependencies
Reviewed-by: jjg, alanb, ulfzibis, erikj
! make/build.properties
!
Hi Frederic,
It's good to see the management interface for diagnostic commands is back.
On 12/17/12 6:58 AM, Frederic Parain wrote:
http://cr.openjdk.java.net/~fparain/7150256/webrev.01/
Please send your makefiles change to build-dev and build-infra for
review to ensure necessary change is
Changeset: ef537bcc825a
Author:mchung
Date: 2012-12-17 15:19 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ef537bcc825a
8005137: Rename DocLint.call to DocLint.init which overrides Plugin.init
Reviewed-by: darcy, jjh
!
Looks good to me.
I didn't know about this file and so I was interested in finding out
more. This file classfile_constants.h doesn't look like a header file
exported from the hotspot repo (I couldn't find it). It's used by hprof
and the old verifier
Changeset: cac1bfaceaaa
Author:mchung
Date: 2012-12-10 15:15 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cac1bfaceaaa
4819681: Typo in
http://java.sun.com/j2se/1.4.1/docs/api/java/util/logging/LogManager.html
Summary: Simple capitalization typo in LogManager()
Changeset: 09bef1e118e3
Author:mchung
Date: 2012-11-28 10:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09bef1e118e3
8003851: MethodHandleNatives dependency on java.sql.DriverManager
Reviewed-by: alanb, dholmes
!
Changeset: 6f20caa6e1e9
Author:bchristi
Date: 2012-11-16 17:01 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f20caa6e1e9
7178922: (props) re-visit how os.name is determined on Mac
Reviewed-by: alanb, mchung, skovatch, serb
!
Changeset: 6156b9235758
Author:mchung
Date: 2012-10-17 12:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6156b9235758
8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false
Reviewed-by: alanb, ohair
! make/common/internal/Defs-jaxws.gmk
It's good to clean this up and the change looks fine in general.A
couple of minor comments:
jdk_management - Might be good to include java/lang/management tests in
this target in case someone only runs one target to verify that area.
On the other hands, they are currently covered by
On 10/8/2012 11:12 AM, Alan Bateman wrote:
On 08/10/2012 18:44, Mandy Chung wrote:
It's good to clean this up and the change looks fine in general.A
couple of minor comments:
jdk_management - Might be good to include java/lang/management tests
in this target in case someone only runs
On 9/19/2012 2:01 AM, Alan Bateman wrote:
On 18/09/2012 23:05, Mandy Chung wrote:
Eamonn,
I filed a RFE that the serviceability team can follow up your
suggestion:
7199353: Allow ConstructorProperties annotation from any package
Alan - I modified the fix to throw InternalError instead
the code one has to write to achieve the same effect by defining
from(CompositeData) is nasty.
(Although I have reviewed this change, I would rather not be mentioned
in the Reviewed-by field.)
Éamonn
On 14 September 2012 06:46, Alan Batemanalan.bate...@oracle.com wrote:
On 14/09/2012 06:25, Mandy
Changeset: 045a0962b430
Author:mchung
Date: 2012-09-18 15:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/045a0962b430
7198070: Eliminate static dependency from JMX to
java.beans.ConstructorProperties
Reviewed-by: alanb
!
Changeset: 22d7a9f73a59
Author:mchung
Date: 2012-09-14 09:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/22d7a9f73a59
7193302: Remove ConstructorProperties annotation from
java.lang.management.LockInfo
Reviewed-by: alanb, sla, egahlin
!
This is to eliminate the static dependency from JMX to
java.beans.ConstructorProperties. Similar work has been
done in the past [1] and this fix will allow JMX to be used
without the presence of java.beans.
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7198070/webrev.00/
All
Hi Eamonn,
Thanks for the review and the information.
On 9/13/2012 9:48 AM, Eamonn McManus wrote:
If at all possible, it would be better to split out
ConstructorProperties into a separable dependency so that JMX could
depend on just that. The idea that a profile with JMX but not
JavaBeans is
On 9/13/2012 2:59 PM, Eamonn McManus wrote:
If at all possible, it would be better to split out
ConstructorProperties into a separable dependency so that JMX could
depend on just that. The idea that a profile with JMX but not
JavaBeans is almost but not quite exactly like a profile with both
On 9/12/2012 3:55 AM, Alan Bateman wrote:
Mandy - one other thing is
com.sun.jmx.mbeanserver.DefaultMXBeanMappingFactory.CompositeBuilderViaConstructor,
I think that will need to be changed to used reflection in order to
eliminate the static dependency completely.
I meant to file a
On 9/12/2012 1:33 AM, Alan Bateman wrote:
This looks good to me. A minor point but LockInfo should have an
@since 1.8 to make it clear that the from( CompositeData) is new. Also
as LazyCompositeData is serializable then you may wish to add a
serialVersionUID to LockInfoCompositeData too (I see
The @java.beans.ConstructorProperties annotation on j.l.m.LockInfo
causes an undesirable dependency on java.beans at compile
time and runtime.
As java.beans is tightly coupled with the client API (awt, swing,
java2d, etc), anyone using java.lang.management (management module)
would cause all the
Mikael,
On 9/6/2012 8:40 AM, Mikael Gerdin wrote:
On 2012-09-06 17:05, Jon Masamitsu wrote:
Mikael,
Does the code in CollectionUsageThreshold.java
happen to work if perm is the last memory pool
in the list and the test
139 if (result.size() == numMemoryPools) {
140
On 8/30/2012 6:55 AM, Dmitry Samersoff wrote:
Hi Everybody.
Please review the fix.
com.sun.management.VMOption.toString() returns ...(read-only) if
writable is true and ...(read-write) otherwise.
http://cr.openjdk.java.net/~dsamersoff/7194597/webrev.01/
Thumbs up.
Mandy
On 8/23/2012 6:27 PM, David Holmes wrote:
Another way to simplify this would be to add a new overload of
Class.forName():
public static Class? forName(String name, boolean initialize)
That way the loader argument could be dropped completely from a number
of the use-cases.
Paul and Remi
On 8/24/2012 3:44 PM, David Holmes wrote:
My other query with these changes is whether we are certain that using
the specified loader rather than the boot loader will always be correct.
Yes I'm to my best knowledge but I'm looking to the reviewers to tell me
otherwise :)
The class being
This change is to bring the jdk modularization changes from jigsaw repo [1]
to jdk8. This allows the jdk modularization changes to be exposed for
testing as early as possible and minimize the amount of changes carried
in the jigsaw repo that helps sync up jigsaw with jdk8/jdk9.
Webrev at:
On 8/23/2012 11:58 AM, Alan Bateman wrote:
On 23/08/2012 18:43, Mandy Chung wrote:
This change is to bring the jdk modularization changes from jigsaw
repo [1]
to jdk8. This allows the jdk modularization changes to be exposed for
testing as early as possible and minimize the amount of changes
On 8/23/2012 12:48 PM, serguei.spit...@oracle.com wrote:
Mandy,
It looks good.
Thanks.
Just a question below.
|| *src/share/classes/java/lang/management/ManagementFactory.java*
596 String intfName = mxbeanInterface.getName();
599 is not an instance of +
Chung wrote:
On 8/23/2012 11:58 AM, Alan Bateman wrote:
On 23/08/2012 18:43, Mandy Chung wrote:
This change is to bring the jdk modularization changes from jigsaw
repo [1]
to jdk8. This allows the jdk modularization changes to be exposed for
testing as early as possible and minimize the amount
Alan,
Looks good to me. It's good to add a test to cover these methods
(thanks). You might want to add the case when SecurityManager is
enabled. Your change doesn't affect the permission check and I'm fine
with what you have.
Mandy
On 8/18/2012 3:35 AM, Alan Bateman wrote:
I need a
On 8/18/2012 2:14 PM, Alan Bateman wrote:
On 18/08/2012 21:05, Alan Bateman wrote:
Thanks for looking at this. Tests using a security manager would
require a bit more work and slightly beyond the scope of the changes
but let me see if I find time before pushing this change.
I've updated the
Erik,
Tested in JPRT with -testset core -onlytests '.*jdk_tools2.*' on all
platforms,
Good. It didn't realize the previous webrev was not verified with
JPRT. It's always a good practice to run through shell test fix with
JPRT and sometimes you will find surprises :)
On 6/8/2012 12:59 PM, Erik Gahlin wrote:
I ran it on the JPRT Stockholm queue and it doesn't have Macs (so I
excluded that platform, it was after all a Java fix) and of course it
was the only platform it failed on it.
I see - thanks and I'm glad that you caught that.
Murphy's law ;)
Oh,
Looks good. Sorry for not catching the test issue during the review for
7017818.
Mandy
On 5/30/2012 4:40 AM, Erik Gahlin wrote:
Hi,
Could you please review 7172176, which is a test fix for 7017818 -
JConsoleResources.java cannot be handled by translation team.
Webrev:
calls.
- Changed CONNECTION_LOST back to CONNECTION_LOST1 and kept message
keys as is since they should work with the property files sent away.
Erik
Mandy Chung skrev 2012-05-22 23:49:
Erik,
I approve what you have - please go through and fix the formatting
nits. I inlined my comment below
Erik,
I approve what you have - please go through and fix the formatting
nits. I inlined my comment below and you can follow up them later if
needed.
On 5/22/2012 12:40 PM, Erik Gahlin wrote:
Thanks for reviewing,
I got a lot of unused import warnings from the IDE when I changed the
PM, Mandy Chung wrote:
7164376 Replace use of sun.security.action.LoadLibraryAction
with direct call of System.loadLibrary
Webrev:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7164376/webrev.00/
This change is required for jdk modularization. High level summary:
it replaces the use
Changeset: 46e0bd218fcc
Author:mchung
Date: 2012-05-01 19:45 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46e0bd218fcc
7164376: Replace use of sun.security.action.LoadLibraryAction with
System.loadLibrary
Reviewed-by: alanb, mullan, prr
!
/classes/sun/management/FileSystemImpl.java
src/windows/classes/sun/management/FileSystemImpl.java
- line-break coding style is different from all others; probably
better to be consistent
--Sean
On 04/26/2012 02:49 PM, Mandy Chung wrote:
7164376 Replace use
On 04/23/2012 02:36 PM, David Holmes wrote:
Except of course that Properties is a Hashtable and synchronizes on
'this' for all public methods. So locking the properties object in the
client code will guarantee exclusive access to it.
David, thanks for looking at this closer. I missed that
Nicolas,
Thanks for reporting the problem. I am curious if you have collected
any profiling data that shows
sun.util.logging.PlatformLogger.redirectPlatformLoggers() is the cause
of the performance degradation. This redirection is done as part of the
logging initialization before JFrame
On 4/11/2012 12:36 AM, Deven You wrote:
Hi core-libs-devs,
I am not sure if sun.management.Agent belongs to jmx-dev mailing list,
if so please anyone tell me.
serviceability-dev (cc'ed) is the mailing list for this patch.
This issue is that the
reviewed it and I think it looks OK. I tried looking at the code
in MacosxOperatingSystem.c relative to the Linux version, but I think
it is easily possible to miss something subtle here.
You might try a direct ping to Mandy Chung since MM was her area.
You might also try a direct ping to Mike
On 1/13/2012 3:26 AM, Dmitry Samersoff wrote:
Why is it not relevant any more? Hmm this code is
a bit confusing. The sun.management.snmp.AdaptorBootstrap class
exists but the snmp runtime classes may not since they are
in the closed source. The CNFE is from other snmp class but
not
On 1/10/2012 4:35 PM, Kurchi Hazra wrote:
Updated webrev with all the above changes incorporated:
http://cr.openjdk.java.net/~khazra/7117570/webrev.04/
GarbageCollectorImpl.java
L76: nit - needs a space between for and (
SnmpNamedListTableCache.java
L215: I assume the unchecked
Kurchi,
Thanks for following up this cleanup build warnings work. I went
through all files including the snmp ones. You mentioned in your
initial review request that you used the serialver tool to
generate all the serial version UIDs and that's good. This change
looks okay. Some minor
On 12/12/2011 6:31 AM, Frederic Parain wrote:
http://cr.openjdk.java.net/~fparain/7104647/webrev.jdk.03/
The jdk change looks okay to me.
Mandy
On 12/7/2011 1:30 PM, Frederic Parain wrote:
The execute method doesn't throw any exception other than
IAE. What happens if the specified command execution fails
in the target VM? If no exception is thrown, how does the
caller detect if the command succeeds or not and handle it
gracefully?
On 12/7/2011 2:04 PM, Mandy Chung wrote:
On 12/7/2011 1:30 PM, Frederic Parain wrote:
The execute method doesn't throw any exception other than
IAE. What happens if the specified command execution fails
in the target VM? If no exception is thrown, how does the
caller detect if the command
501 - 600 of 703 matches
Mail list logo
