Re: [sigrok-devel] LA2016 bug fixes - libusb issues on windows, RAW_IO policy

Replying to my own email to close this out... This problem was solved by using appropriately sized usb transfer buffer, with this commit: https://github.com/sigrokproject/libsigrok/commit/e847645b7be832c1d62d1ad2312e3a3d4de467ce The PV nightly builds for linux and windows are working now for

Re: [sigrok-devel] LA2016 bug fixes - libusb issues on windows, RAW_IO policy

Hello, Replying to my own email here. It looks like libusb folks have discussed enabling RAW_IO but have so far decided not to (Jan2021), as it seemingly adds some complexity to the driver operation: https://github.com/libusb/libusb/issues/490 Furthermore, some quotes from here: https://do

[sigrok-devel] LA2016 bug fixes - libusb issues on windows, RAW_IO policy

Hello, I made some changes to the Kingst LA2016 logic analyser driver which were pulled in the last few days. https://github.com/sigrokproject/libsigrok/pull/131 I have tested the nightly build of PulseView for Linux and both the LA2016 and LA1016 are working, which is good. However, the W

Re: [sigrok-devel] LA2016 bug fixes

On 2021-04-05 15:54, Kevin Grant wrote: Hello Gerhard, The Kingst LA2016 driver needs some changes, as I summarised here: https://sourceforge.net/p/sigrok/mailman/message/37249530/ Following on from that, here are a couple of pull requests. (1) sigrok utils firmware extraction The current f

[sigrok-devel] LA2016 bug fixes

Hello Helge, I built the latest libsigrok from the official git repo and tried it with pulseview on linux. It does not work for me. There is never any data to upload, even without triggers enabled. After applying fixes from my PR [1] I made these simple tests. I used the default signals from

Re: [sigrok-devel] LA2016 bug fixes

On 2021-04-06 09:40, Helge Kruse wrote: Am 05.04.2021 um 16:54 schrieb Kevin Grant: I have tested all this with LA2016 and LA1016 in PulseView on linux. Sampling, edge/level triggering all work now. Perhaps others here can verify that. https://github.com/sigrokproject/libsigrok/pull/131

[sigrok-devel] LA2016 bug fixes

Hello Gerhard, The Kingst LA2016 driver needs some changes, as I summarised here: https://sourceforge.net/p/sigrok/mailman/message/37249530/ Following on from that, here are a couple of pull requests. (1) sigrok utils firmware extraction The current firmware extraction script fails, probably

Re: [sigrok-devel] LA2016 bug fixes

Am 25.03.2021 um 16:40 schrieb Gerhard Sittig: >> Yes, the basic operation is fundamentally broken. The implementation >> uses a construct of packed structs to layout USB reports. The packed >> attribute is suppressed for some reasons in the MXE cross compile >> configuration for the whole libsigro

Re: [sigrok-devel] LA2016 bug fixes

Hello Gerhard, Thanks for your recent feedback on my PR, which I will summarise as 'more information needed'. Here is the status of the LA2016 driver as I see it; Recent Changes: * Wiki updated (by me) with additional technical information. * Portability issues fixed by Helge in his PR you

Re: [sigrok-devel] LA2016 bug fixes

On Thu, 2021-03-11 at 08:26 +0100, Helge Kruse wrote: > > Am 10.03.2021 um 14:15 schrieb Kevin Grant: > > > > Hello Gerhard, > > > > On 2021-03-08 18:25, Gerhard Sittig wrote: > > > >> Is the basic operation fundamentally broken, or are just not all > >> of the product's features available while th

Re: [sigrok-devel] LA2016 bug fixes

On Sun, 2021-03-14 at 18:58 +0100, Helge Kruse wrote: > > Am 14.03.2021 um 12:50 schrieb Kevin Grant: > > > > I submitted a PR for the sigrok-utils LA2016 firmware > > extraction script > > > > https://github.com/sigrokproject/sigrok-util/pull/6/files > >

Re: [sigrok-devel] LA2016 bug fixes

Hello, The PR below has been tested by myself and Helge K. Can this be accepted? Regards, Kevin On 2021-03-14 11:50, Kevin Grant wrote: I submitted a PR for the sigrok-utils LA2016 firmware extraction script https://github.com/sigrokproject/sigrok-util/pull/6/files It works for me but if

Re: [sigrok-devel] LA2016 bug fixes

On Sun, 2021-01-24 at 19:15 +0100, Helge Kruse wrote: > > Hi, > > I have recently fixed driver bugs for the Kingst LA2016 driver. I have > created a pull request for you to merge. > > https://github.com/sigrokproject/libsigrok/pull/112 These USB transfer layout fixes just went mainline in commits

Re: [sigrok-devel] LA2016 bug fixes

Am 14.03.2021 um 12:50 schrieb Kevin Grant: > > I submitted a PR for the sigrok-utils LA2016 firmware extraction script > > https://github.com/sigrokproject/sigrok-util/pull/6/files > > > It works for me but if someone else could verify th

Re: [sigrok-devel] LA2016 bug fixes

I submitted a PR for the sigrok-utils LA2016 firmware extraction script https://github.com/sigrokproject/sigrok-util/pull/6/files It works for me but if someone else could verify then it would help get it accepted. (Note that it includes changes from the other outstanding PR for sigrok-utils

Re: [sigrok-devel] LA2016 bug fixes

Hello Gerhard, hello Kevin, comments are in-line. Best regards, Helge Am 10.03.2021 um 14:15 schrieb Kevin Grant: > > Hello Gerhard, > > On 2021-03-08 18:25, Gerhard Sittig wrote: > >> Is the basic operation fundamentally broken, or are just not all >> of the product's features available while t

Re: [sigrok-devel] LA2016 bug fixes

Hello Gerhard, On 2021-03-08 18:25, Gerhard Sittig wrote: Is the basic operation fundamentally broken, or are just not all of the product's features available while the device _can_ be used to get captures and inspect or process the waveforms? In the former case I'd agree to "not supported", in

Re: [sigrok-devel] LA2016 bug fixes

On Sun, 2021-03-07 at 11:31 +, Kevin Grant wrote: > > Hello, > > I edited the Sigrok wiki in the last few days to add additional > information about the LA2016 logic analyser. > > https://sigrok.org/wiki/Kingst_LA2016 > > I also marked the device as unsupported (being worked on) because > the d

[sigrok-devel] LA2016 bug fixes

Hello, I edited the Sigrok wiki in the last few days to add additional information about the LA2016 logic analyser. https://sigrok.org/wiki/Kingst_LA2016 I also marked the device as unsupported (being worked on) because the driver has problems, not just on windows (as Helge K. pointed out) b

Re: [sigrok-devel] LA2016 bug fixes

On 2021-02-02 20:13, Kevin Grant wrote: On 2021-02-02 19:20, Helge Kruse wrote: Am 25.01.2021 um 19:43 schrieb Gerhard Sittig: Can you fixup the issues in that series? I hope, I did so. Who else had a look at these changes, or even tested it for proper operation? I have tested it with Windows

Re: [sigrok-devel] LA2016 bug fixes

On 2021-02-02 19:20, Helge Kruse wrote: Am 25.01.2021 um 19:43 schrieb Gerhard Sittig: Can you fixup the issues in that series? I hope, I did so. Who else had a look at these changes, or even tested it for proper operation? I have tested it with Windows and Linux. Unfortunately I don't h

Re: [sigrok-devel] LA2016 bug fixes

Am 25.01.2021 um 19:43 schrieb Gerhard Sittig: > Can you fixup the issues in that series? I hope, I did so. > Who else had a look at these changes, or even tested it for > proper operation? I have tested it with Windows and Linux. Unfortunately I don't have a list of mailing list members with t

Re: [sigrok-devel] LA2016 bug fixes

Am 26.01.2021 um 09:53 schrieb Kevin Grant: > > On 2021-01-26 07:48, Helge Kruse wrote: > >> Am 25.01.2021 um 19:43 schrieb Gerhard Sittig: >>> On Sun, 2021-01-24 at 19:15 +0100, Helge Kruse wrote: I have recently fixed driver bugs for the Kingst LA2016 driver. I have created a pull reque

Re: [sigrok-devel] LA2016 bug fixes

On 2021-01-26 07:48, Helge Kruse wrote: Am 25.01.2021 um 19:43 schrieb Gerhard Sittig: On Sun, 2021-01-24 at 19:15 +0100, Helge Kruse wrote: I have recently fixed driver bugs for the Kingst LA2016 driver. I have created a pull request for you to merge. https://github.com/sigrokproject/libsigr

Re: [sigrok-devel] LA2016 bug fixes

Am 25.01.2021 um 19:43 schrieb Gerhard Sittig: > On Sun, 2021-01-24 at 19:15 +0100, Helge Kruse wrote: >> I have recently fixed driver bugs for the Kingst LA2016 driver. >> I have created a pull request for you to merge. >> >> https://github.com/sigrokproject/libsigrok/pull/112 > Can you fixup the

Re: [sigrok-devel] LA2016 bug fixes

On Sun, 2021-01-24 at 19:15 +0100, Helge Kruse wrote: > > I have recently fixed driver bugs for the Kingst LA2016 driver. > I have created a pull request for you to merge. > > https://github.com/sigrokproject/libsigrok/pull/112 Can you fixup the issues in that series? Bring the commit messages in

[sigrok-devel] LA2016 bug fixes

Hi, I have recently fixed driver bugs for the Kingst LA2016 driver. I have created a pull request for you to merge. https://github.com/sigrokproject/libsigrok/pull/112 Best regards, Helge ___ sigrok-devel mailing list sigrok-devel@lists.sourceforge.