[
https://issues.apache.org/jira/browse/SOLR-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12753840#action_12753840
]
Henri Biestro commented on SOLR-1167:
-
Just a thought; wouldn'it be possible to use
[
https://issues.apache.org/jira/browse/SOLR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12709483#action_12709483
]
Henri Biestro commented on SOLR-1154:
-
{quote}
BTW the root of the problem is that there
[
https://issues.apache.org/jira/browse/SOLR-735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-735:
---
Fix Version/s: (was: 1.3.1)
1.4
CoreContainer.unload should remove all aliases
[
https://issues.apache.org/jira/browse/SOLR-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-731:
---
Fix Version/s: (was: 1.3.1)
1.4
CoreDescriptor.getCoreContainer should not be
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-725:
---
Fix Version/s: (was: 1.3.1)
1.4
CoreContainer/CoreDescriptor/SolrCore
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-725:
---
Attachment: solr-725.patch
updated for trunk 720487
CoreContainer/CoreDescriptor/SolrCore cleansing
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-725:
---
Fix Version/s: 1.3.1
CoreContainer/CoreDescriptor/SolrCore cleansing
[
https://issues.apache.org/jira/browse/SOLR-735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-735:
---
Fix Version/s: 1.3.1
CoreContainer.unload should remove all aliases of a core
[
https://issues.apache.org/jira/browse/SOLR-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-731:
---
Fix Version/s: 1.3.1
CoreDescriptor.getCoreContainer should not be public
[
https://issues.apache.org/jira/browse/SOLR-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12627419#action_12627419
]
Henri Biestro commented on SOLR-745:
Part of it might be in 'getAdminHandler()' which
[
https://issues.apache.org/jira/browse/SOLR-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12627419#action_12627419
]
henrib edited comment on SOLR-745 at 9/1/08 3:02 AM:
Part of it
[
https://issues.apache.org/jira/browse/SOLR-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-745:
---
Attachment: solr-745.patch
Seems like this fixes it.
CoreAdminHandler in bad state after UNLOADing
[
https://issues.apache.org/jira/browse/SOLR-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12627502#action_12627502
]
henrib edited comment on SOLR-745 at 9/1/08 3:21 PM:
The uploaded
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626993#action_12626993
]
Henri Biestro commented on SOLR-725:
Paul
Would it be fair to say that you fear the
[
https://issues.apache.org/jira/browse/SOLR-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12627035#action_12627035
]
Henri Biestro commented on SOLR-731:
The issue is about having public access from CD to
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-725:
---
Description:
These 3 classes and the name vs alias handling are somewhat confusing.
The recent
[
https://issues.apache.org/jira/browse/SOLR-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626520#action_12626520
]
Henri Biestro commented on SOLR-734:
It should not be possible to build a SolrCore with a
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-725:
---
Attachment: solr-725.patch
added remaining operations and their mappings in CoreAdminRequest;
added
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626522#action_12626522
]
henrib edited comment on SOLR-725 at 8/28/08 4:30 AM:
-
added
CoreContainer.unload should remove all aliases of a core
Key: SOLR-735
URL: https://issues.apache.org/jira/browse/SOLR-735
Project: Solr
Issue Type: Bug
Affects Versions: 1.3
[
https://issues.apache.org/jira/browse/SOLR-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626540#action_12626540
]
Henri Biestro commented on SOLR-734:
Seen the thread as
SolrCore.getSolrCore() may create a SolrCore without a CoreContainer
Key: SOLR-736
URL: https://issues.apache.org/jira/browse/SOLR-736
Project: Solr
Issue Type: Bug
[
https://issues.apache.org/jira/browse/SOLR-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-736:
---
Description:
The method is deprecated but one can still initialize start working this way.
Potential
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626112#action_12626112
]
Henri Biestro commented on SOLR-725:
Paul-
We are not removing any of these methods but
[
https://issues.apache.org/jira/browse/SOLR-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-731:
---
Description:
For the very same reasons that CoreDescriptor.getCoreProperties did not need to
be
[
https://issues.apache.org/jira/browse/SOLR-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-731:
---
Description:
For the very same reasons that CoreDescriptor.getCoreProperties did not need to
be
CoreDescriptor.getCoreContainer should not be public
Key: SOLR-731
URL: https://issues.apache.org/jira/browse/SOLR-731
Project: Solr
Issue Type: Bug
Affects Versions: 1.3
[
https://issues.apache.org/jira/browse/SOLR-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626178#action_12626178
]
Henri Biestro commented on SOLR-723:
The other simpler approach is just to state that the
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626188#action_12626188
]
Henri Biestro commented on SOLR-725:
The rename with null can only occur if the core
[
https://issues.apache.org/jira/browse/SOLR-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-731:
---
Attachment: solr-731.patch
A patch that fixes this issue.
As a strawman feature, this completely
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626209#action_12626209
]
Henri Biestro commented on SOLR-725:
bq. A rename with null is a bad usecase . We should
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626209#action_12626209
]
henrib edited comment on SOLR-725 at 8/27/08 10:51 AM:
--
bq. A
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626219#action_12626219
]
Henri Biestro commented on SOLR-725:
Paul,
The core always has a name; if you use that
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-725:
---
Attachment: solr-725.patch
updated to include part of solr-731 changes (aka
[
https://issues.apache.org/jira/browse/SOLR-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625719#action_12625719
]
henrib edited comment on SOLR-723 at 8/26/08 6:06 AM:
-
Yonik's
[
https://issues.apache.org/jira/browse/SOLR-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625719#action_12625719
]
Henri Biestro commented on SOLR-723:
Yonik's comment in solr-725 makes an analogy between
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625805#action_12625805
]
Henri Biestro commented on SOLR-725:
Shalin -
We decref the counter appropriately
CoreContainer.reload should make core aliases point to reloaded core
Key: SOLR-722
URL: https://issues.apache.org/jira/browse/SOLR-722
Project: Solr
Issue Type: Bug
CoreDescriptor.{get,set}CoreExpressions should probably not be public (but
package private)
---
Key: SOLR-724
URL: https://issues.apache.org/jira/browse/SOLR-724
CoreContainer/CoreDescriptor/SolrCore cleansing
---
Key: SOLR-725
URL: https://issues.apache.org/jira/browse/SOLR-725
Project: Solr
Issue Type: Improvement
Affects Versions: 1.3
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-725:
---
Attachment: solr-725.patch
The patch solves the 3 issues this relates to.
The SolrCore handles its
[
https://issues.apache.org/jira/browse/SOLR-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-724:
---
Summary: CoreDescriptor.{get,set}CoreProperties should probably not be
public (but package private)
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625304#action_12625304
]
Henri Biestro commented on SOLR-725:
About being inconsistent, this is what this issue
[
https://issues.apache.org/jira/browse/SOLR-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625305#action_12625305
]
Henri Biestro commented on SOLR-724:
I'm confused about when the 'what-if' rule can apply
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625317#action_12625317
]
Henri Biestro commented on SOLR-725:
bq. What we do is after we make the necessary
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625347#action_12625347
]
Henri Biestro commented on SOLR-725:
bq . This does not look like a useful way of using
[
https://issues.apache.org/jira/browse/SOLR-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625346#action_12625346
]
Henri Biestro commented on SOLR-724:
When a method is public, it also has to be
[
https://issues.apache.org/jira/browse/SOLR-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625377#action_12625377
]
Henri Biestro commented on SOLR-724:
Obviously different :-)
In my mind, these are
[
https://issues.apache.org/jira/browse/SOLR-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625541#action_12625541
]
Henri Biestro commented on SOLR-725:
Otis, this does not hold releasing 1.3; I'm glad
[
https://issues.apache.org/jira/browse/SOLR-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro closed SOLR-715.
--
Resolution: Incomplete
Not proper scope, will reformulate
CoreDescriptor should fully describe what is
[
https://issues.apache.org/jira/browse/SOLR-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625028#action_12625028
]
Henri Biestro commented on SOLR-716:
bq.SolrResourceLoader keeps a reference to the
[
https://issues.apache.org/jira/browse/SOLR-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625028#action_12625028
]
henrib edited comment on SOLR-716 at 8/23/08 12:19 AM:
--
Setting
[
https://issues.apache.org/jira/browse/SOLR-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625028#action_12625028
]
henrib edited comment on SOLR-716 at 8/23/08 12:22 AM:
--
[
https://issues.apache.org/jira/browse/SOLR-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-716:
---
Attachment: solr-716.patch
property expressions in solr.xml preserved during solr.xml persistence.
[
https://issues.apache.org/jira/browse/SOLR-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625040#action_12625040
]
henrib edited comment on SOLR-716 at 8/23/08 2:45 AM:
-
property
[
https://issues.apache.org/jira/browse/SOLR-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-716:
---
Attachment: solr-716.patch
Might be post-commit but this will give a base to solr-646.
Fixed all
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-646:
---
Attachment: solr-646.patch
Updated to be based on SOLR-716 commit. Thanks Shalin.
Some improvement
[
https://issues.apache.org/jira/browse/SOLR-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625099#action_12625099
]
Henri Biestro commented on SOLR-712:
Amit,
I reused your good idea and added an entity
[
https://issues.apache.org/jira/browse/SOLR-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625099#action_12625099
]
henrib edited comment on SOLR-712 at 8/23/08 12:33 PM:
--
Amit,
I
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-646:
---
Description:
This patch refers to 'generalized configuration properties' as specified by
Persisting solr.xml through SolrJ does not handle relative pathes correctly
---
Key: SOLR-719
URL: https://issues.apache.org/jira/browse/SOLR-719
Project: Solr
Issue
Persistence does not write the expected XML
---
Key: SOLR-720
URL: https://issues.apache.org/jira/browse/SOLR-720
Project: Solr
Issue Type: Bug
Affects Versions: 1.4
Reporter: Henri
[
https://issues.apache.org/jira/browse/SOLR-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-720:
---
Affects Version/s: (was: 1.4)
1.3
Persistence does not write the expected
[
https://issues.apache.org/jira/browse/SOLR-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-719:
---
Affects Version/s: (was: 1.4)
1.3
Persisting solr.xml through SolrJ does
DirectSolrConnection is broken - missing CoreContainer initialization
-
Key: SOLR-721
URL: https://issues.apache.org/jira/browse/SOLR-721
Project: Solr
Issue Type: Bug
[
https://issues.apache.org/jira/browse/SOLR-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-721:
---
Description:
It might be initialized in such a way that no core container is created.
Adding the
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624813#action_12624813
]
Henri Biestro commented on SOLR-646:
Given that:
1 - I've wasted too much time of too
CoreContainer.Load does not handle correctly multiple aliases
-
Key: SOLR-714
URL: https://issues.apache.org/jira/browse/SOLR-714
Project: Solr
Issue Type: Bug
Affects
CoreDescriptor should fully describe what is necessary to create/re-create a
SolrCore
-
Key: SOLR-715
URL: https://issues.apache.org/jira/browse/SOLR-715
Project:
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-646:
---
Attachment: solr-646.patch
New stripped down version since there was indeed a leaner way to achieve
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-646:
---
Description:
This patch refers to 'generalized configuration properties' as specified by
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624369#action_12624369
]
henrib edited comment on SOLR-646 at 8/21/08 7:15 AM:
-
New leaner
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-646:
---
Description:
This patch refers to 'generalized configuration properties' as specified by
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624369#action_12624369
]
henrib edited comment on SOLR-646 at 8/21/08 7:19 AM:
-
New leaner
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624369#action_12624369
]
henrib edited comment on SOLR-646 at 8/21/08 7:27 AM:
-
New leaner
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624369#action_12624369
]
henrib edited comment on SOLR-646 at 8/21/08 7:43 AM:
-
New leaner
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-646:
---
Description:
This patch refers to 'generalized configuration properties' as specified by
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624450#action_12624450
]
henrib edited comment on SOLR-646 at 8/21/08 11:56 AM:
--
The
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624450#action_12624450
]
Henri Biestro commented on SOLR-646:
The ant-ish syntax is certainly more common; I'll
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624467#action_12624467
]
Henri Biestro commented on SOLR-646:
0 - I *do* use today an include mechanism of some
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624467#action_12624467
]
henrib edited comment on SOLR-646 at 8/21/08 1:15 PM:
-
0 - I *do*
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624467#action_12624467
]
henrib edited comment on SOLR-646 at 8/21/08 1:18 PM:
-
0 - I *do*
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624467#action_12624467
]
henrib edited comment on SOLR-646 at 8/21/08 2:06 PM:
-
0 - I *do*
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-646:
---
Attachment: solr-646.patch
Modified property definition syntax to follow ant's.
Renamed test class.
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-646:
---
Description:
This patch refers to 'generalized configuration properties' as specified by
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-646:
---
Description:
This patch refers to 'generalized configuration properties' as specified by
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624485#action_12624485
]
henrib edited comment on SOLR-646 at 8/21/08 2:40 PM:
-
Modified
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624114#action_12624114
]
Henri Biestro commented on SOLR-646:
Not sure this is my place to comment since I'm no
[
https://issues.apache.org/jira/browse/SOLR-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12623745#action_12623745
]
Henri Biestro commented on SOLR-710:
There should be a comment in the log file stating
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-646:
---
Attachment: solr-646.patch
Refactored following HossMan recommendations.
This still includes the
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12623204#action_12623204
]
Henri Biestro commented on SOLR-647:
Small err that would affect reload() in
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12623029#action_12623029
]
Henri Biestro commented on SOLR-646:
Thanks HossMan for the review;
I've overhauled the
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12623029#action_12623029
]
henrib edited comment on SOLR-646 at 8/15/08 5:43 PM:
-
Thanks
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-647:
---
Attachment: solr-647.patch
My apologies to all for cluttering the issue.
New simplified version
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-647:
---
Attachment: solr-647.patch
Based on Ryan's comment, simplified the patch to strictly focus on the
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622583#action_12622583
]
Henri Biestro commented on SOLR-647:
About the SolrCore.open() close():
If we were to do
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622583#action_12622583
]
henrib edited comment on SOLR-647 at 8/14/08 8:46 AM:
-
About the
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622592#action_12622592
]
Henri Biestro commented on SOLR-647:
Yonik;
About the close(), you're right: the refcount
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-647:
---
Attachment: solr-647.patch
updated to reflect Yonik's last suggestion.
fixed test attempting to close
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-647:
---
Attachment: solr-647.patch
bq. Yes, if cores obtained through other methods need to be open for some
1 - 100 of 211 matches
Mail list logo
