Re: Request go ahead for structural changes in CVS

2001-03-18 Thread Robert Leland
Vincent Massol wrote: I'd like to have the go ahead for making the changes to the struts directory I think it is OK to commit those changes as long as they are tested and the distribution builds. Namely, I'd like to commit the following changes that I have locally on my computer (step

Re: [VOTE] NEW COMMITTER - Martin Cooper

2001-06-04 Thread Robert Leland
Ted Husted wrote: Martin Cooper has submitted several useful patches to Struts, has been +1, Firmly agreed! Robert Leland [EMAIL PROTECTED] 804 N. Kenmore Street +01-703-525-3580 Arlington VA 22201

Re: I would like to offer myself to help with documentation

2001-06-16 Thread Robert Leland
as with the documentation. In the CVS repository doc/uml/sequence-diagram-action.gif This was generated by Gerry Chike. This does a good job showing the sequence of steps struts goes through for login. Maybe this could be used in the documentation ? -- Robert Leland [EMAIL PROTECTED] 804 N. Kenmore

[Struts Cactus 1.2 - 1.3]

2002-10-10 Thread Robert Leland
I have changed the default build.properties file to require, cactus 1.3 as opposed to 1.2. I ran the unit tests and all looked ok. By using cactus 1.3 the new required API's exist, along with the depreciated ones. This will give the contrib code comitters a chance to make the small changes

RE: Ok, who broke the build?

2002-10-12 Thread Robert Leland
Eddie Bush Screamed: Just wanted to throw out an FYI - I don't have time to dig into it right now. Eddie it works for me, after doing a CVS get a clean copy, no sticky. Do you have recient versions of the commons ? -Rob -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional

Re:[PATCH] handle maps in logic:empty/logic:notEmpty

2002-10-12 Thread Robert Leland
Robert Rasmussen [EMAIL PROTECTED] Small patch related to logic:empty for your consideration. The intent of Robert, best place to put this is in Buzilla: http://nagoya.apache.org/bugzilla/ If you don't have an account it only takes a minute to fill out the no-nonsense form. -Rob -- To

RE:Constructing Binary Distribution

2002-10-16 Thread Robert Leland
Anyone else having trouble running the dist target? Mine is failing on the struts-el stuff (not compile error, but ant task errors due to path settings and such), and I am working through it, but wondering if I missed an email somewhere ?!?!?!? It's a bug. I emailed the list but David

Re: [VOTE] David Graham as Struts Committer

2002-10-16 Thread Robert Leland
+1, Sorry Eddie, David got more votes but that doesn't mean we like him any better than you. ;-) ! -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]

Re: Moving/deprecated of StrutsValidator StrutsValidatorUtilPropertyMessageResources.java

2002-10-18 Thread Robert Leland
I wasn't suggesting that was the way it had be. Doing that would have *all* validator-related things living under o.a.s.v though. I really was agreeing with you, that it --could-- be beneficial. I didn't feel strongly one way or the other. It is possible that when Java Server Faces comes that

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/util PropertyMessageResources.java

2002-10-18 Thread Robert Leland
Demonstration: (This is my text graphic of a HashMap ;) This would make good documentation :-) ! -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/util PropertyMessageResources.java

2002-10-18 Thread Robert Leland
That correct, they need to be there as well. James, this is getting to be alot of work, you must be bucking for comitter :-D ! Under what circumstances will addIt after the while loop be false ? I'll buy you a copy of Teds Book if you can provide just one case. If you can't then you'll own

RE: cvs commit: jakarta-struts/src/share/org/apache/struts/util PropertyMessageResources.java

2002-10-18 Thread Robert Leland
I didn’t mean inherited in the sense of the Java Language. Ok, I understand now. At the same time, please take the time to look at this code: boolean addIt = false; while (true) { if (message != null) { if (addIt) messages.put(originalKey, message); return (message); } addIt = true;

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/util PropertyMessageResources.java

2002-10-18 Thread Robert Leland
Should I make a new section about Understanding i18n with Struts? I'll do it. Although is that more of a framework developers documentation? Your right, maybe it belongs in the main class description, in the JavaDoc. James Mitchell Software Engineer/Struts Evangelist

Re: Validator 1.0 Release and bug 10868

2002-10-18 Thread Robert Leland
Joe Germuska wrote: The problem being that Struts hasn't really switched over to commons-resources yet. That would end up touching almost every class! Who wants to take that on when the masses are clamoring at the gates for a 1.1 final release! If the API's are very similar then I could

Re: Moving/deprecated of StrutsValidator StrutsValidatorUtilPropertyMessageResources.java

2002-10-18 Thread Robert Leland
Robert Leland wrote: +1 except I think we should lose the 'Struts' part of the class names. We know it's Struts, right? It's in a o.a.s package in the Struts jar file... ;-) So we'd have: I agree we should remove 'Struts' and or 'Validator' from the names o.a.s.validator.Validator +1

Moving/deprecated of StrutsValidator StrutsValidatorUtil

2002-10-18 Thread Robert Leland
It seems like StrutsValidatorUtil StrutsValidator really belong in o.a.s.validator so I propose to deprecated o.a.s.util.StrutsValidator o.a.s.util.StrutsValidatorUtil and copy them to o.a.s.validator.StrutsValidator o.a.s.validator.StrutsValidatorUtil Only the

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/util PropertyMessageResources.java

2002-10-18 Thread Robert Leland
That is true, but it is needed with each iteration in order to satisfy the logic. Could you please add those line back in? I believe we were talking past each other ! addIt was never taken out of the while loop, just --after-- the loop when addIt was always true. -Rob -- To unsubscribe,

Re: Moving/deprecated of StrutsValidator StrutsValidatorUtilPropertyMessageResources.java

2002-10-18 Thread Robert Leland
Robert Leland wrote: Eddie spoke and it was so: Only the o.a.s.t.html.JavascriptValidatorTag uses the StrutsValidatorUtil, other than the o.a.s.validator. classes We could move that too and update the TLD, couldn't we? ... if we're moving ... (maybe put it in o.a.s.v.t.html? It might

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/util PropertyMessageResources.java

2002-10-18 Thread Robert Leland
Robert Leland wrote: addIt = true; -Set to true. if (underscore 0) break; } If a break happens, addIt has already been set to true, and is not needed. I mean to say it is not required --after-- the while loop. -Rob -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe

Re: DO NOT REPLY [Bug 11950] - Missing script in generatedjavascipt

2002-10-21 Thread Robert Leland
James Homes wrote: I just checked the latest nightly build and the //-- is showing up on the Register and Logon pages of the example app in IE. This is a problem. I am using IE 6.0,Mozilla 1.1, NS 4.08, and didn't see the // --. I also looked at the html generated and saw paired 'html

Re: Nightly binary distributions broken?

2002-10-28 Thread Robert Leland
Moral of the story -- please be sure that an ant dist runs successfully before checking in changes to the XML source documents, so that you've ensured all the XSLT transformations are successful. I also run Cooktop, on the Windows platform, to edit/display/validate the XML using XSLT. It's

Re: DO NOT REPLY [Bug 14054] - Rename Application components

2002-10-30 Thread Robert Leland
+1 on your proposed approach, including not doing the deprecated thing for stuff that was added after 1.1b2. Craig Bugzilla, Please :-) ! -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org

Re: DO NOT REPLY [Bug 14054] - Rename Application components

2002-10-30 Thread Robert Leland
So, this is a long-winded case of asking why can't we do this? The method public ApplicationConfig ActionConfig.getApplicationConfig() though this is only used 4 times in struts itself, it is public. Which means we assume that others extending struts may rely on it. So to remain

Whats up with CVS ?

2002-11-01 Thread Robert Leland
When I updated CVS for Struts and Commons from Work today all my files were replaced. Earlier when I updated CVS from Home this morning, every thing seemed to be working OK. It looks like a router went down right as I was doing a commit, the archive was updated by my local copy's version wasn't

Re: DO NOT REPLY [Bug 14054] - Rename Application components toModule

2002-11-04 Thread Robert Leland
Subject: Re: DO NOT REPLY [Bug 14054] - Rename Application components to Module From: David Graham [EMAIL PROTECTED] Date: 2002-11-04 18:04:41 [Download message RAW] +1 on the ModuleConfig interface (Struts needs more of these). I'm not sure about StandardModuleConfigImpl though.

Re: [Vote] Modify classloading in RequestUtils

2002-11-07 Thread Robert Leland
See comments enclosed James Mitchell wrote: Not sure if you caught the thread on the users list, or the bug recently posted by Kjeld Froberg: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14332 Here's the proposed code change: RequestUtils.java

Re: [Vote] Modify classloading in RequestUtils

2002-11-07 Thread Robert Leland
David Graham wrote: Do people still use Tomcat 3.2? It's not like they have to pay to upgrade to 4.1.12. Maybe this isn't such a big deal. I agree that support for TC 3.2 isn't a big deal since we still have Struts 1.0.2 which does run on TC 3.2 right ? I have experience with SOME deployed

Re: javadoc Weird state of org/apache/struts/util/AppException.java

2002-11-08 Thread Robert Leland
David Graham wrote: Yes, I removed all the empty lines because it made the file very long. I'm not sure why it would show up as a single line though with ^M. That character normally shows up from windows systems right? I used Eclipse to make the changes and it shows up fine in my editor.

Re: Choosing a nightly build for Da Book

2002-11-08 Thread Robert Leland
James Turner wrote: Hi all, We're finishing up the CD-ROM for the our Struts Book, and I want to put a recent nightly build in addition to the 1.1b2 build. Can anyone recommend a fairly stable recent nightly build that would be a good candidate (i.e., not crashing all over the place,

Tools in Struts [was: Re: Struts At ApacheCon 2002]

2002-11-20 Thread Robert Leland
James Holmes wrote: Struts Console too. -james --- Emmanuel Boudrant [EMAIL PROTECTED] wrote: I think it is time to start packaging tools and generators with Struts to help the developer Thats a really good initiative Easy Struts will be volunteer ;) -emmanuel Would the source

[Nightly] Documentation

2002-11-20 Thread Robert Leland
Next time the Nightly documentation is updated, I'd like to request that the JavaDoc also be updated. From what I can tell it hasn't been updated for at least a month or so. I have read the directions for updating the web site, but don't knoe if I myself have access to do it ? -Rob -- To

RE: Struts logo

2002-11-25 Thread Robert Leland
I suggested a previous logo back in July but there wasn't any feedback, every body must have been on vacation. Take a look at the original post it contains some very interesting links to the types of the logo's I had in mind. http://marc.theaimsgroup.com/?l=struts-userm=102779133515796w=3 -Rob

Re: Avoid code reformating !

2002-12-16 Thread Robert Leland
David Graham wrote: With all due respect Cedric, that code did not follow the java standard coding guidelines so it was a candidate for reformatting. Under the Jakarta rules code must meet those guidelines unless specified differently for the project. AFAIK Struts has no specific rules so it

Re: Struts Coding Standard

2003-01-06 Thread Robert Leland
I suggested before having the code automatically formatted when a checkin or checkout happens. This could be done in 2 places: 1) The Jakarta script that checks to see if a user has access to one of the Jakarta projects. 2)CVS provides hooks/calls to be made before or after any check out, or

Re: Beta 3 PlugIn interface change

2003-01-06 Thread Robert Leland
David Morris wrote: One problem I had with Beta 3 is related to a change to the PlugIn (http://cvs.apache.org/viewcvs/jakarta-struts/src/share/org/apache/struts/action/PlugIn.java.diff?r1=texttr1=1.6r2=texttr2=1.7diff_format=l) that forces an update to any class that implements Plugin. Looking

Re: Struts Coding Standard

2003-01-06 Thread Robert Leland
David Graham wrote: Couldn't you do it just on check-in? It seems like it would take forever to check out the project if it's always formatting the code. Yes, it could be done just for check-in. Then we would run into the problem of doing cvs diffs would not be too usefull if The version

Re: Struts Coding Standard

2003-01-07 Thread Robert Leland
Martin Cooper wrote: In any case, I'd prefer to separate the discussion of a set of coding conventions from the discussion on whether or not to automate them around the checkout/checkin process. +1, I'll table the auto discussion for now. My only pet peeves on formatting is no spaces between

Re: Struts Coding Standard

2003-01-07 Thread Robert Leland
David Graham wrote: Member variables should be at the top if for no other reason than that's where people expect them to be. It's one of those acquired tastes. Like I said it's not on my list of must haves, and that's ok! When I first saw variables at the bottom of a class I cursed, and

Re: A plea for closure

2003-01-17 Thread Robert Leland
James Turner wrote: I'm the new fish in the pond here, but I wanted to put in my +1 for sticking a fork in the puppy, 'cause it's done. +1 Leave the Resources as is. Delay any major changes to TagLibs until 1.2. Fix any bugs remaining in the Controller/Module awareness of struts. (I'll MAKE

Re: compiling 1.1 beta 3 problems

2003-01-22 Thread Robert Leland
Pablo Casado wrote: Hi, What version of commons logging should I be using? Download the latest nightly binary build and use those jars to build your patch against. -Rob -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]

Re: 1.1 Cleanup Questions

2003-01-31 Thread Robert Leland
David Graham wrote: Can o.a.s.util.IteratorAdaptor be deprecated and replaced with a call to the commons-collections' IteratorUtils.asIterator(Enumeration) method? This class is only used in 3 places. +0, since I was the one to contribute this originally anyway. Dave -Rob

Re: ModuleConfigImpl holds reference to factory

2003-02-05 Thread Robert Leland
On Tue, 4 Feb 2003, David Graham wrote: Date: Tue, 04 Feb 2003 20:05:27 -0700 From: David Graham [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: ModuleConfigImpl holds reference to factory ModuleConfigImpl implements Serializable but the

No Struts nightly build

2003-02-05 Thread Robert Leland
I apologize if this has been brought up reciently... The Nightly Struts builds directory is empty http://jakarta.apache.org/builds/jakarta-struts/nightly/ Is this a bad link, know problem, or to simply to force people to use 1.1b3 ? ;-) ! -Rob

Re: Cactus Test Failures?

2003-02-07 Thread Robert Leland
So basically you want to get those values from a property file? I'll see if I can replicate your changes since I don't have a diff. -Rob James Mitchell wrote: Ok, couple of things: After careful digging I think I've discovered the problem(s). 1. getServerPort in MockHttpServletRequest is

Re: New Tests

2003-02-12 Thread Robert Leland
Martin Cooper wrote: I prefer this second approach, because then we're testing the real behaviour of the tags in a real container. Using a mock approach makes me nervous because of the intricacies of tag lifecycles, and I wouldn't feel as confident that the tags would work in the real world just

Re: New Tests

2003-02-12 Thread Robert Leland
David Graham wrote: Ideally, tests shouldn't rely on other components that could be broken because then you don't know why the test failed. I don't understand what you mean by other components that could be broken. snip Simple tests are better than complicated ones. How you ordered the

Re: New Tests

2003-02-12 Thread Robert Leland
James Mitchell wrote: - Original Message - From: Robert Leland [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent: Wednesday, February 12, 2003 2:00 PM Subject: Re: New Tests Martin Cooper wrote: I prefer this second approach, because then we're testing the real

Re: New Tests

2003-02-12 Thread Robert Leland
Ignore that last email I haven't finished working out a digester example yet. -Rob - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: New Tests

2003-02-12 Thread Robert Leland
James Mitchell wrote: - Original Message - From: Robert Leland [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent: Wednesday, February 12, 2003 2:00 PM Subject: Re: New Tests Martin Cooper wrote: I prefer this second approach, because then we're testing

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/htmlMessagesTag.java

2003-02-14 Thread Robert Leland
[EMAIL PROTECTED] wrote: /** + * Commons Logging instance. + * @since Struts 1.1 + */ +protected static Log log = LogFactory.getLog(MessagesTag.class); By sharing thge logger errors will look like they are coming from MessageTag instead of any derived class.

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/htmlMessagesTag.java

2003-02-14 Thread Robert Leland
David Graham wrote: Sorry, I don't follow what you're saying. Are you talking about the log variable being protected, using the wrong class in getLog(), using the wrong message key? Close. When I derive a class class NewMessageTag extends Messagetag { setMessage(String message) {

Re: RC1 release and Commons Logging 1.0.2

2003-02-24 Thread Robert Leland
Gary Ashley wrote: Otherwise, I'd ask that an important criteria in posting future releases be considered. There should not be any dependencies upon nightly builds. Two of my customers will not allow me to use nightly builds for fear of bugs, and this prevents me from using either beta3 or RC1.

Re: RC1 release and Commons Logging 1.0.2

2003-02-24 Thread Robert Leland
Also, this message would have better been posted on the struts-user list. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: RC1 release and Commons Logging 1.0.2

2003-02-24 Thread Robert Leland
I am moving this over to the struts-user list where it belongs. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: David Graham, 1.1 RC1 MVC

2003-02-25 Thread Robert Leland
+1 Ted Husted wrote: While *we all* put a lot of time and effort into getting 1.1 ready for its first release candidate, it seems to me that David Graham really came through for us over the last few weeks (months, even). As a token of our appreciation, I'd like to nominate David for a Most

Re: Dependent Packages in Struts 1.1

2003-02-25 Thread Robert Leland
Martin Cooper wrote: Craig R. McClanahan [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] As the topic comes up regularly, it strikes me that we haven't had any formal discussions or decisions on what versions of our dependent packages to include in Struts 1.1 final. Most of them are

Re: compiling and building struts

2003-03-10 Thread Robert Leland
asatrasala wrote: Hello, Is there any one place I can download all the dependent jars necessary for compiling struts Yes download a nightly build and use the included commons-* jars. -Rob - To unsubscribe, e-mail: [EMAIL

[Vote ?] deprecate ActionErrors

2003-08-10 Thread Robert Leland
No, and here is why. -Rob -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web Application Development 804 N. Kenmore Street +01-703-525-3580 Arlington VA 22201

Re: UML Diagrams (o.a.s.actions)

2003-08-12 Thread Robert Leland
from a commercial vendor. -Rob Steve - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Robert Leland [EMAIL PROTECTED

Re: When is the next release?

2003-08-14 Thread Robert Leland
there is not a bread crumb trail to follow and it will cost use more work answering questions on the users list than if we document it to start with. That way when they don't read the release notes we can cut and paste the URL to the release notes. Robert Leland [EMAIL PROTECTED

Re: Parameter/Mapping/ConfigDispatchAction (Was RE: Addition of twonew actions)

2003-08-14 Thread Robert Leland
Steve Raeburn wrote: I *think* we agreed to add this action. Pick a name. [ ] ParameterDispatchAction [X] MappingDispatchAction [ ] ConfigDispatchAction -Rob -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web Application

Re: Resource Bundle Prototyping

2003-08-14 Thread Robert Leland
adam kramer wrote: On Wed, 6 Aug 2003, Joe Germuska wrote: I'm pretty sure this was an explicit design intention, although the main reason may have been to make backwards compatibility more manageable (or maybe not -- I can't cite any place where this was discussed; I just have vague

Re: When is the next release?

2003-08-14 Thread Robert Leland
anyway. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web

Re: cvs commit: jakarta-struts/doc volunteers.xml

2003-08-14 Thread Robert Leland
: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web Application Development 804 N. Kenmore Street +01-703-525-3580 Arlington VA 22201

Re: When is the next release?

2003-08-14 Thread Robert Leland
. Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web

Re: [PATCH] for bug nr. 21408

2003-08-14 Thread Robert Leland
) { - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts

Re: Building contrib packages WAS Re: cvs commit: jakarta-struts/contrib/tag-docbuild.xml

2003-08-14 Thread Robert Leland
PROTECTED] -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web Application Development 804 N. Kenmore Street +01-703-525-3580 Arlington VA 22201

Re: cvs commit: jakarta-struts/web/example/WEB-INF struts-config-registration.xmlstruts-config.xml

2003-08-14 Thread Robert Leland
a 'display-name' 'description' element defined. Who Knew. So I will be changing that. -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web Application Development 804 N. Kenmore Street +01-703-525-3580 Arlington VA 22201

Re: Decomposing RequestProcessor -- Some Code To Play With

2003-08-14 Thread Robert Leland
be so revolutionary, and painful. It may be that your page flow could be just the ticket. However if you would like to contribute to the chaining directly that would be great ! -Rob -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE

Re: ActionForwards, et al (was SuccessAction)

2003-08-14 Thread Robert Leland
:30 am for me when the checkin occured and I was just trying to get it compiled quickly. -Rob -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web Application Development 804 N. Kenmore Street +01-703-525-3580 Arlington VA

Re: cvs commit: jakarta-struts/doc/resources extensions.xml

2003-08-14 Thread Robert Leland
# causes Buzilla to create a hyper link to the report. -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web Application Development 804 N. Kenmore Street +01-703-525-3580 Arlington VA 22201

Re: [Vote ?] deprecate ActionErrors

2003-08-14 Thread Robert Leland
David Graham wrote: --- Robert Leland [EMAIL PROTECTED] wrote: I believe at one time we were going to deprecate ActionErrors since it is really a shell over ActionMessages. We could still keep the error tag, just make it use ActionMessages directly. It would be nice to get rid of it but I

Re: cvs commit: jakarta-struts/doc/resources extensions.xml

2003-08-14 Thread Robert Leland
the typical notation is PR# . As long as you commit from the top level, you'll pick up the CVS template, which provides the spaces for you to enter bug number and submitter. -- Martin Cooper Sounds like I should also use the command line version of CVS, to make life easier. -- Robert Leland

Re: Wildcard-matched actions (again)

2003-08-14 Thread Robert Leland
, e-mail: [EMAIL PROTECTED] -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web Application Development 804 N. Kenmore Street +01-703-525-3580 Arlington VA 22201

Re: [Vote ?] deprecate ActionErrors

2003-08-14 Thread Robert Leland
David Graham wrote: --- Robert Leland [EMAIL PROTECTED] wrote: David Graham wrote: --- Robert Leland [EMAIL PROTECTED] wrote: I believe at one time we were going to deprecate ActionErrors since it is really a shell over ActionMessages. We could still keep the error tag, just make

Re: Wildcard-matched actions (again)

2003-08-14 Thread Robert Leland
should be able to be turned off. In fact once struts configuration is frozen then it should be able to detect whether it needs to search for wild card matches or not. -Rob -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web

Re: Building contrib packages WAS Re: cvs commit: jakarta-struts/contrib/tag-docbuild.xml

2003-08-14 Thread Robert Leland
] -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web Application Development 804 N. Kenmore Street +01-703-525-3580 Arlington VA 22201

Re: parameter vs. set-property (was Re: Flexible form support)

2003-08-16 Thread Robert Leland
-u old new. I also like to use 'diff -u 5 old new' just to be sure. -Rob -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web Application Development 804 N. Kenmore Street +01-703-525-3580 Arlington VA 22201

Re: parameter vs. set-property (was Re: Flexible form support)

2003-08-16 Thread Robert Leland
Sgarlata Matt wrote: Robert Leland wrote: Sgarlata Matt wrote: What do you think? Would this be a reasonable enhancement request? Can I post it in BugZilla with patches? Since you have talked about it on the struts-user group, and it looks like the existing system makes your life harder

Re: design - tags with errors

2003-08-17 Thread Robert Leland
! (Pointing me to a tag with the kind of preferred error handling that I should emulate would be useful.) Paul Sundling - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Robert

Re: design - tags with errors

2003-08-18 Thread Robert Leland
exception.because.it.does.not.exist/ following html and bunch of stuff... So when I get a blank page, I just have to comment out the include to see the errors. Sorry for the false alarm. Paul Thanks for the offer of a patch ! -- Robert Leland [EMAIL PROTECTED

Re: Tags more extensible (was: Suggestions for Calendar Popup taglib?)

2003-08-18 Thread Robert Leland
- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Robert Leland [EMAIL PROTECTED] -- Java, J2EE, Struts, Web Application Development 804 N. Kenmore Street +01-703-525-3580 Arlington VA 22201

Re: [OT] I didn't realize we had a celebrity

2003-08-22 Thread Robert Leland
James Mitchell wrote: Did you guys check out the full page add that Oracle ran in the JDJ? Oh My God I don't get the Attendee Since 2002 though, why he keeps coming back. He hasn't come back yet ! :-/ ! They just wanted a pretty face !!! -Rob

Re: JSTL EL Validator rule: A better requiredif and validatewhenusing JSTL

2003-08-26 Thread Robert Leland
Rick Hightower wrote: What were your thoughts on JSTL EL validator rule? You commented on BSF and OGNL, but not the JSTL EL validator rule, which I actually wrote. The others just seem like a good idea. Sorry, For not commenting on that. I agree that a JSTL EL expression makes sense. For now

Re: Support for non-JSTL tags (was RE: DO NOT REPLY [Bug 21465] - Enhancement of the html:link tag)

2003-08-28 Thread Robert Leland
Steve Raeburn wrote: I'm not singling Vic out for this (honest) but... The standard advice we are now giving everyone is use JSTL, which I wholeheartedly agree with and have said myself. However, I think we need to make sure that we still adequately support non-JSTL solutions and continue to

Re: DO NOT REPLY [Bug 22519] - Allow multiple MessageResourcesfiles to be loaded under one key

2003-08-28 Thread Robert Leland
Craig R. McClanahan wrote: Vic, Please go away. I didn't take this as being negative, just an effort to help Ted. I did get upset when the status was changed to WONTFIX for some items. It --did-- get me to read the Bugzilla request which I see as a positive. There are a number of good patches

Re: [OT] As the Struts world turns [was: Re: DO NOT REPLY [Bug 22519] - Allow multiple MessageResources files to be loaded under one key]

2003-08-28 Thread Robert Leland
James Mitchell wrote: Someone posted a link on another thread that might actually help in situations like this: http://www.originalicons.com/smile Not funny. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

[Fwd: [ANN] Commons-Validator 1.1.0 Alpha released]

2003-08-28 Thread Robert Leland
Commons Validator 1.1.0 Alpha is now available for testing. Please refer to http://jakarta.apache.org/commons/validator/tasks.html that details some of the changes that have taken place since the 1.0.2 release. Downloads: http://jakarta.apache.org/~rleland/ValidatorAlpha/ be sure to update your

Struts web site [was: Re: Conversion of web site docs to XHTML]

2003-09-05 Thread Robert Leland
Steve Raeburn wrote: I have committed the first step in transitioning the web site documentation to valid XHTML. As far as I know we were planning to move over to Maven or forrest. I have been working on Mavenizing items as I can. Instead of doing the stylesheets maybe your efforts could be

Re: Struts web site [was: Re: Conversion of web site docs to XHTML]

2003-09-06 Thread Robert Leland
Robert Leland wrote: Steve Raeburn wrote: I have committed the first step in transitioning the web site documentation to valid XHTML. As far as I know we were planning to move over to Maven or forrest. I have been working on Mavenizing items as I can. Instead of doing the stylesheets maybe

Re: Struts web site [was: Re: Conversion of web site docs to XHTML]

2003-09-06 Thread Robert Leland
site [was: Re: Conversion of web site docs to XHTML] --- Ted Husted [EMAIL PROTECTED] wrote: Robert Leland wrote: Do we want to hold a formal vote/lazy consensus on what doc system we are moving to ? Don already put the Struts SourceForge site on Forrest, so I would lean in that direction

Re: Struts web site [was: Re: Conversion of web site docs to XHTML]

2003-09-06 Thread Robert Leland
Joe Germuska wrote: At 14:23 -0400 9/6/03, Robert Leland wrote: We can always start a struts-2 web site and tweak it until we like what we have, or until it works, which ever comes first ! I also wouldn't want to maintain a seperate look and feel except to move the blasted [powered

Re: Why are ImportAttributeTag and UseAttributeTag final classes?

2003-09-06 Thread Robert Leland
David M. Karr wrote: Is there a good reason for the tiles classes ImportAttributeTag and UseAttributeTag to be final classes? I can't implement tiles-el if those are final classes. +1, for removing final. Since struts is a framework there is no good reason for marking a class as final.

Struts Site + Joe Germuska+ Maven

2003-09-06 Thread Robert Leland
Joe Germuska wrote: At 14:53 -0400 9/6/03, Robert Leland wrote: Thanks, I was hoping you would chime in ! It looks like you used maven for your site, and I prefer your color scheme over the standard... You can set a lot of stuff in project.properties -- it should be in a source distribution

Re: Struts web site [was: Re: Conversion of web site docs to XHTML]

2003-09-07 Thread Robert Leland
Ted Husted wrote: Joe Germuska wrote: It will be some mildly tedious work to move the current doc to xdocs, but nothing too bad, and if they are valid xhtml, it will be much easier. The documentation is all XML now. Steve was just tweaking the XLS. There's a bit of HTML/XHTML in the sample

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java

2003-09-09 Thread Robert Leland
[EMAIL PROTECTED] wrote: David, I thought you were going to back this out ? -Rob dgraham 2003/08/19 16:20:46 Modified:src/share/org/apache/struts/action Action.java Log: Added version of saveMessages() that saves them into the session instead of the request. Revision Changes

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java

2003-09-09 Thread Robert Leland
David Graham wrote: --- Robert Leland [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: David, I thought you were going to back this out ? The conversation was left with me proposing a solution and asking for Martin's thoughts on it. He hasn't responded so I haven't backed it out

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java

2003-09-09 Thread Robert Leland
David Graham wrote: --- Robert Leland [EMAIL PROTECTED] wrote: David Graham wrote: --- Robert Leland [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: David, I thought you were going to back this out ? The conversation was left with me proposing a solution

Saving messages in the session

2003-09-09 Thread Robert Leland
Use Cases: I am not familar with the particular use cases where the ActionMessage needs to hang around in the session. So these suggestions might not fit. Questions: Would managing the life cycle through the struts-config.xml, like the ActionForm work ? or How about a PlugIn that has the

Re: XHTML Web site updates

2003-09-10 Thread Robert Leland
David Graham wrote: Contributors List I think it's important to keep the contributors list on those pages because it's a recognition of volunteers' effort. I agree that it gets in the way so maybe the list should be at the bottom of the page in a smaller +1, absolutely it's through those

  1   2   >