Re: Swing Dev [PATCH] 6179357-related: warnings removal: gtk

To the best of my knowledge, you won't be able to commit. Pavel should act as sponsor and commit the patch on your behalf. To be able commit to a repo on the OpenJDK site you need to have an OpenJDK user id. To get that I think you need to be voted in as a member of a project or group.

Re: Swing Dev Request for review: Bug 100054: Make building the Nimbus look 'n' feel optional

There's public API associated with Nimbus in javax.swing.plaf.nimbus so I don't think many people will want to use that facility and it doesn't seem appropriate to have it in the jdk7 source train. -phil. Andrew John Hughes wrote: HI all, I have a simple patch that allows the building of the

Re: Swing Dev hg: jdk7/swing/jdk: 6822696: Integrating JXLayer component to Swing library

Alex, Mark is correct. They need to have the usual GPL+CP for the source files and GPL for the test. Please file a bug to fix this. -phil. On Aug 15, 2009, at 1:58 PM, Mark Wielaard wrote: Hi, On Mon, 2009-08-10 at 12:53 +, alexander.potoch...@sun.com wrote: Changeset: 8e65977e4969

Re: Swing Dev Fixing font sizes in GTKLookAndFeel

There's two public API changes in here and you can get away without either of them. So I believe you wouldn't need the changes in SunFontManager, FontUIResource, or Font.java Eg in PangoFonts you can write something like : Font f = new Font(family, style, ((int)dsize+0.5)); f =

Re: Swing Dev jdk6 and jdk7: wrong class cast in sun.print.IPPPrintService (in Solaris classes)

Why did you send this to the Swing list? Its about printing which is handled by 2D. Please re-send it there : 2d-...@openjdk.java.net, as I don't want to cross-post this. -phil. On 11/15/2010 6:40 AM, Nico R. wrote: Hello! In sun.print.IPPPrintService.getIPPConnection(URL), there is a bug

Re: Swing Dev Swind Dev [7u6] Review request for 6836089: Swing HTML parser can't properly decode codepoints outside the Unicode Plane 0 into a surrogate pair

I don't understand why you call Character.toChars() if you've just determined you don't need to ? ie what was wrong with data = ( n 16 == 0) ? {mapNumericReference((char) n)} : Character.toChars(n); ? In the case of an invalid supplementary pair, maybe it would be safer to return { ' '

Re: Swing Dev Swind Dev [7u6] Review request for 6836089: Swing HTML parser can't properly decode codepoints outside the Unicode Plane 0 into a surrogate pair

or surrogate pair entirely to Character class... Regards, - Vlad On 6/26/2012 9:49 PM, Phil Race wrote: I don't understand why you call Character.toChars() if you've just determined you don't need to ? ie what was wrong with data = ( n 16 == 0) ? {mapNumericReference((char) n

Re: Swing Dev Swind Dev [7] Review request for 6836089: Swing HTML parser can't properly decode codepoints outside the Unicode Plane 0 into a surrogate pair

: Hello, could you please review a new version? Please find webrev here: http://cr.openjdk.java.net/~vkarnauk/6836089/webrev.04/ Regards, - Vlad On 6/29/2012 2:09 AM, Phil Race wrote: That would work but I think its cleaner to just move it all into mapNumericReference as below. -phil. diff

Re: Swing Dev Swing and imageio-related types that are candidates to be FunctionalInterfaces in JDK 8

Joe, The imageio and print classes belong to 2D, not Swing. Please re-direct to 2d-dev -phil. On 2/5/13 2:41 PM, Joe Darcy wrote: Hello, As part of Project Lambda, a FunctionalInterface annotation type was added to the platform to mark interfaces that are intended to be used in lambda

Re: Swing Dev Swing and imageio-related types that are candidates to be FunctionalInterfaces in JDK 8

Joe, Note that Swing is a single threaded API. You can't update the UI from any thread other than the EDT. Where any automatic usage of processing in parallel from additional threads is performed by the lambda implementation it will violate that requirement. So you should be circumspect in

Re: Swing Dev AWT Dev Approved: [8] Request for review: 7194902 and 7181403

Sergey (B), I assume you updated the test with the bug ID ? That's the normal convention as a test uncovers a regression to indicate which test to run to verify the fix. In this case the failing test is in closed so I can't see it here to verify you did this I know we have a backlog of such

Re: Swing Dev AWT Dev [8] Review request for CR 7145406 - [macosx] Migrate Apple tests from macosx-port to 7u

Konstantin, First I am puzzled by the decision to send this to AWT and Swing lists. There are a couple of Swing tests and a large number of AWT tests but it seems to be also a very large number of 2D/graphics tests PLUS a large scattering in other areas such as - hotspot/managment - jndi -

Re: Swing Dev JDK 9 RFR of JDK-8035692 : Fix serial lint warnings in mac-specific code

Looks OK to me -phil. On 3/10/14 2:14 PM, Joe Darcy wrote: *ping* Any other comments on this changeset? Thanks, -Joe On 03/05/2014 01:19 PM, Alan Bateman wrote: On 05/03/2014 20:30, Joe Darcy wrote: Hello, Please review this webrev which addresses serial warnings in mac-specific code:

Swing Dev RFR: 8016451 : scary messages from Nimbus PainterGenerator during JDK build

http://cr.openjdk.java.net/~prr/8016451/ https://bugs.openjdk.java.net/browse/JDK-8016451 This eliminates the 20 or so messages like this [Error] encoded value was less than 0: encode(-8.326673E-17, 5.0, 11.0, 16.0) I know these messages vex many people. These messages seem to be warnings at

Re: Swing Dev JDK 9 RFR of 8044698: Fix finally lint warnings in javax.swing

Looks ok to me .. -phil. On 6/3/2014 10:53 AM, Joe Darcy wrote: Hello, Please review this change to fix 8044698: Fix finally lint warnings in javax.swing http://cr.openjdk.java.net/~darcy/8044698.0/ The finally javac lint warning issues a warning when a finally block always

Re: Swing Dev AWT Dev [9] Review request for JDK-8039383: NPE when changing Windows Theme

ahem, this is a bad fix. It has broken all non-windows builds because shared code is now referencing WToolkit and ThemeReader. Please back out this fix ASAP .. -phil. On 6/6/2014 7:03 AM, Anthony Petrov wrote: You're welcome. -- best regards, Anthony On 6/6/2014 5:58 PM, Alexey Ivanov

Re: Swing Dev AWT Dev [9] Review request for JDK-8039383: NPE when changing Windows Theme

I filed P1 bug https://bugs.openjdk.java.net/browse/JDK-8046239 You really should at least build on other platforms and you can use JPRT for that .. Testing would be good too .. -phil. On 6/6/2014 10:48 AM, Phil Race wrote: ahem, this is a bad fix. It has broken all non-windows builds

Re: Swing Dev AWT Dev [9] Review request for JDK-8039383: NPE when changing Windows Theme

in another thread? I am really sorry about build failure. I won't make it happen again. Thanks, Alexey. On 06.06.2014 21:54, Phil Race wrote: I filed P1 bug https://bugs.openjdk.java.net/browse/JDK-8046239 You really should at least build on other platforms and you can use JPRT for that .. Testing

Re: Swing Dev AWT Dev [9] Review request for JDK-8039383: NPE when changing Windows Theme

I filed https://bugs.openjdk.java.net/browse/JDK-8046391 -phil. On 6/9/2014 2:38 PM, Phil Race wrote: Hi, So the repo now builds but when I run SwingSet2 on Windows and select the Win LF and try to bring up JFileChooser the whole app hangs. Looks like the same deadlock/hang that we saw

Re: Swing Dev JDK 9 RFR of JDK-8046271: Fix overrides lint warnings in Apple laf code

Seems reasonable to me. -phil. On 6/6/2014 4:42 PM, Joe Darcy wrote: Hello, One of the classes in the Apple laf code commits the classic mistake of override equals without also overriding hashCode. Please review my addition of a hashCode method: diff -r 717cad3f30fe

Re: Swing Dev RFR: 8046485: Add missing @since tag under javax.swing.*

.. I suppose its likely that after 1.2 people were more diligent in adding these tags. Assuming the answer is yes, then I'm OK. If no, then I'm OK too although at least then we'd know you still had to do those packages .. -phil. On 6/18/2014 11:11 AM, Henry Jen wrote: On 06/18/2014 10:44 AM, Phil

Re: Swing Dev [9] Review Request: 8047025 Fix raw and unchecked lint warnings in generated nimbus files

Looks ok to me. The simplest way to test nimbus is to run the swingset2.jar demo, and select Nimbus from the LF drop down menu, then go through the various tabs in the demo. That should exercise all the commonly used elements of Nimbus. Note that SwingSet2 is in the 'closed' sources so if you

Re: Swing Dev Review Request for 8042284: Add block tags for @return and @param to swing plaf classes

http://sqeweb.us.oracle.com/coretools/ssides/webrevs/8042284/8042284.4/src/share/classes/javax/swing/plaf/ComponentUI.java.sdiff.html You didn't do anything about the (many) uses of codeFOO/code like this :- * Returns codetrue/code if the specified ix,y/i location is 231 * contained

Re: Swing Dev Review request for JDK-8050924 fix doclint missing tags in a few javax.swing.plaf.basic classes

http://cr.openjdk.java.net/~ssides/8050924/8050924.00/src/share/classes/javax/swing/plaf/basic/BasicInternalFrameUI.java.sdiff.html new empty line 187 seems superfluous. Please delete before pushing Otherwise seems fine. -phil. On 07/28/2014 01:14 PM, Steve Sides wrote: Hello, Could you

Re: Swing Dev JDK 9 RFR of JDK-8055059: JDK9b22 public API exposes package private classes

I don't know this package very well but it seems like it was a bit of a messed up design from the beginning if it exposed methods which had a vector of opaque types meant only for internal use. How would an application ever be able to call them or subclass them? Amusingly perhaps the javadoc

Re: Swing Dev [9] Review Request: 8055326 Fix typos in client-related packages

approved. -phil. On 9/10/2014 5:11 AM, Sergey Bylokhov wrote: Hi, Phil. It seems both changes are unnecessary: http://cr.openjdk.java.net/~serb/8055326/webrev.01 On 21.08.2014 22:04, Phil Race wrote: Was the additional spce on the 2nd line intended here ? --- old/src/java.desktop/share

Re: Swing Dev [9] Review Request: 6329748 Invalid/old variable name - newModel in setModel method in JTable class

looks ok to me -phil. On 9/23/2014 10:59 AM, Sergey Bylokhov wrote: Hello. Any volunteers? On 18.08.2014 18:18, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk 9. Bug description: Long long time ago all our JTable.set*model methods used newModel as a parameter. Since

Re: Swing Dev [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8066621: Suppress deprecation warnings in java.desktop module

Hi, You did not provide a direct reference to the set of warnings that were generated. fortunately I found it here :- https://bugs.openjdk.java.net/browse/JDK-8066622 A couple of things I find 'unfortunate' are 1) In order to avoid a deprecation warning on one call/line of a 100 line method,

Re: Swing Dev [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8066621: Suppress deprecation warnings in java.desktop module

On 12/12/14 5:35 PM, joe darcy wrote: Hi Phil, On 12/12/2014 12:46 PM, Phil Race wrote: Hi, You did not provide a direct reference to the set of warnings that were generated. fortunately I found it here :- https://bugs.openjdk.java.net/browse/JDK-8066622 Each Suppress deprecations

Re: Swing Dev [9] Review Request: 8067657 Dead/outdated links in Javadoc of package java.beans

Looks good to me. Are there other references to these top-level URLs in the doc? I'd like to think we are just doing the same as everyone else. -phil. On 12/23/2014 11:32 AM, Sergey Bylokhov wrote: Hello. Please review the small documentation fix for jdk 9. Bug:

Re: Swing Dev AWT Dev [9] Review Request: JDK-8071532 Fix for java/awt/print/PrinterJob/ImagePrinting/NullClipARGB.java fails with PrinterException: No print service found

#1 this is being reviewed on the wrong list printing should be reviewed on 2d-dev and the bug cat should be client/2d #2 I see you prepared the webrev against 9/dev. It should be 9/client. #3 In general I think that its questionable to make this change. Granted other tests do this but there is

Re: Swing Dev JDK 9 RFR of JDK-8055059: JDK9b22 public API exposes package private classes, take 2

+1 -phil. On 1/12/2015 1:13 AM, Sergey Bylokhov wrote: Hi, Joe. The fix looks good. On 10.01.2015 3:23, Joseph D. Darcy wrote: Hello, The previously proposed fix for JDK-8055059: JDK9b22 public API exposes package private classes was rejected during code review:

Swing Dev Request for comment: merging the openjdk client groups ?

consequence worth calling out. Whether to proceed with the idea will depend in part on the feedback to the proposal which we are soliciting here. So is this something we should pursue ? -Phil Race.

Re: Swing Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

Looks fine (I just looked at the getFontPeer() this time around. Pls remember to do a CCC before pushing this ! -phil. On 03/05/2015 04:51 AM, Sergey Bylokhov wrote: The new version of the fix: http://cr.openjdk.java.net/~serb/8074028/webrev.06 Font.getPeer() was renamed to Font.getFontPeer().

Re: Swing Dev [OpenJDK 2D-Dev] AWT Dev [9] Review Request: 8074668 [macosx] Mac 10.10: Application run with splash screen has focus issues

+1 .. I was pondering the exact same approach so I am OK with this as it leaves the useful code in place and disables the problematic part. There was a test added for the hi-res splash. Perhaps you should add an @ignore for now ? -phil. On 3/11/15 6:46 PM, Sergey Bylokhov wrote: 11.03.15

Re: Swing Dev AWT Dev RfR JDK-8055831 Open Source Java Access Bridge

AWTEventMonitor.java has a bunch of deprecated methods. If you don't have time now (I expect you don't) then it can be revisited later. Open sourcing is different than binary compatibility. The change jdk/make/copy/Copy-java.gmk suggests that accessbridge is the only reason the closed version of

Re: Swing Dev AWT Dev RfR JDK-8055831 Open Source Java Access Bridge

On 3/25/2015 10:58 AM, Pete Brunet wrote: Thanks Phil, On 3/25/15 11:26 AM, Phil Race wrote: AWTEventMonitor.java has a bunch of deprecated methods. If you don't have time now (I expect you don't) then it can be revisited later. Open sourcing is different than binary compatibility. These were

Re: Swing Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

Looks good to me. I like some of the clean up like : -if (getPeer() == null) { +if (!isDisplayable()) { which is the same as we've told other folks to do .. I was initially surprised at just using the field peer as it might be null, but getPeer() just returned peer anyway, so

Re: Swing Dev customizing LFs in JDK9

My understanding is that the Aqua LF classes are already inaccessible if there's a SecurityManager so its not a completely new thing. Whilst there may be ways around the JDK9 restrictions, what internal Aqua APIs do you need to customise ? And how do you deliver those customisations ? We are

Re: Swing Dev customizing LFs in JDK9

been out for quite a while now and Java is still using Mavericks rendering on Yosemite. Alan On May 15, 2015, at 12:49 PM, Phil Race philip.r...@oracle.com mailto:philip.r...@oracle.com wrote: My understanding is that the Aqua LF classes are already inaccessible if there's a SecurityManager

Re: Swing Dev [9] Review request for 8051548 JColorChooser should have a way to disable transparency controls

210 211 void setColorTransparencySelectionEnabled(boolean b) { 212 spinners[model.getCount() - 1].setVisible(b); 213 colorChanged(); 214 } do you want to check if there's a state change here before firing the events ? Other than that it looks OK to me. -phil.

Re: Swing Dev AWT Dev internal API usage: sun.awt.AppContext

Alan, AppContext was devised to support applets running in browsers where the JDK internal classes were shared so were in need of a way to provide a key that was unique to each running applet. Note that the 'advertisement' is comments on the internal source code. Unless your LF is installed on

Re: Swing Dev [OpenJDK 2D-Dev] RFR: JDK-8076468 Add @modules to tests in jdk_desktop test group

I guess I was expecting to see only tests that use internal API updated but we do have some that do not being updated. grep @modules jdk.patch | grep -v sun | more | wc 119 4553341 + * @modules java.datatransfer + * @modules java.compiler + * @modules java.desktop And this simple

Swing Dev RFR: 8081231: JDK9 client build broken on Windows

https://bugs.openjdk.java.net/browse/JDK-8081231 ShellFolder2 only gets a definition of DASSERT if DEBUG is defined. Proposed fix :- diff --git a/src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp b/src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp ---

Re: Swing Dev AWT Dev RFR: 8081231: JDK9 client build broken on Windows

, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8081231 ShellFolder2 only gets a definition of DASSERT if DEBUG is defined. Proposed fix :- diff --git a/src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp b/src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp

Re: Swing Dev JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

too. I would prefer that we not label tests just based on grep output. -phil. On 8/20/2015 11:44 AM, joe darcy wrote: Hi Phil, On 8/20/2015 11:14 AM, Phil Race wrote: Joe, How is this keyword interpreted and used ? From the TEST.ROOT file in the jdk/test directory: # The randomness keyword

Re: Swing Dev JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

Joe, How is this keyword interpreted and used ? How did you select the tests below to be so marked ? I might ask more once I understand the answers to these but looking at just one of these - MTGraphicsAccessTest.java - there is no such thing a spurious failure of this test. If you ever see a

Re: Review request for JDK-8030099 Memory usage of java process increases after pressing start button in test window

It is arguably most important to run this with the *default* collector. If that changes to G1 (I think it is at least temporarily so changed in JDK 9) then we will never see problems in the case people end up using. But you obviously also want to test the case that shows the bug. So I would

Re: [9] Review Request for 8081722: Provide public API for file hierarchy provided by sun.awt.shell.ShellFolder

We should specify what happens if you pass in to get(String) a) null b) an unrecognised name. Would it make sense to define string constants on FileSystemView as otherwise people have to spell these exactly right without compiler help ? Also I expect (hope!) that we do not assert any

Re: Review request for JDK-8030099 Memory usage of java process increases after pressing start button in test window

/~rchamyal/8030099/webrev.02/ The test case has been updated as per review comments. Added tests for both Parallel and default collector. Regards, Rajeev Chamyal -Original Message- From: Phil Race Sent: 30 October 2015 01:10 To: Rajeev Chamyal Cc: Sergey Bylokhov; Alexander Scherbatiy; swing-dev

Re: Swing Dev [9] Review Request for 8098835: [PIT] Endless loop in JEditorPane

Looks like this has been approved. Can it be pushed now ? It needs some kind of noreg- keyword on the bug. -phil. On 07/08/2015 12:29 PM, Sergey Bylokhov wrote: Looks fine. On 17.06.15 15:21, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 6/16/2015 8:27

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

I don't remember or know how Swing resolves this but the measurement ones are not reliable since they do not take a Graphics context, so you cannot measure the string properly. You need a FontRenderContext to measure. So as it stands these APIs do not appear suitable to be made public as they

Re: RFR: [9] [JDK-8081491] The case print incomplete.

become rMax = table.getRowCount(); Now we will try to access one past the end of the row count -phil. Regards Prasanta On 9/29/2015 4:03 AM, Phil Race wrote: Sorry to be nit-picky but TablePrintable.java seems to have gained some new empty lines and lost other lines that make the 'diff' look much larger t

Re: RFR: [9] [JDK-8081491] The case print incomplete.

Sorry to be nit-picky but TablePrintable.java seems to have gained some new empty lines and lost other lines that make the 'diff' look much larger than it really is. Also a couple in BasicTableUI have the same. I also see this comment seems to be invalidated by the change in some cases and it

Re: RFR: 8136783: Run blessed-modifier-order script on java.desktop

Let me do that as separate review. There are also demos and tests do this is not the last of it anyway but this is a big one to get out of the way -Phil. > On Sep 19, 2015, at 12:01 PM, Sergey Bylokhov > wrote: > > Hi, Phil. >> >> >> What I am updating here is

RFR: 8136783: Run blessed-modifier-order script on java.desktop

http://cr.openjdk.java.net/~prr/8136783/ https://bugs.openjdk.java.net/browse/JDK-8136783 The idea here is to have our sources follow the recommended order fom the JLS which is further documented here https://docs.oracle.com/javase/8/docs/api/java/lang/reflect/Modifier.html#toString-int- For

RFR: 8137059: Run blessed-modifier-order script on client demos and misc. sources

https://bugs.openjdk.java.net/browse/JDK-8137059 http://cr.openjdk.java.net/~prr/8137059/ This is a follow-up to https://bugs.openjdk.java.net/browse/JDK-8136783 This new change cleans up the demos and one additional JDK source file. -phil.

Re: [9] Review Request for 8081722: Provide public API for file hierarchy provided by sun.awt.shell.ShellFolder

I think this version looks OK. Don't forget it needs a CCC .. -phil. On 11/24/2015 02:01 AM, Semyon Sadetsky wrote: On 11/2/2015 11:09 PM, Sergey Bylokhov wrote: On 29.10.15 21:30, Phil Race wrote: We should specify what happens if you pass in to get(String) a) null b) an unrecognised name

Re: RfR JDK-8056925 Add jaccessinspector and jaccesswalker to the bin directory

On 11/20/2015 09:24 AM, Pete Brunet wrote: Please review: http://cr.openjdk.java.net/~ptbrunet/JDK-8056925/webrev.00/ 42 char *printError(char *msg) { 43 LPVOID lpMsgBuf = NULL; 44 static char retbuf[256]; 45 46 if (msg != NULL) { 47 strncpy((char *)retbuf, msg,

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

Approved -phil. On 05/24/2016 05:27 AM, Rajeev Chamyal wrote: Hello Phil, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.07/ Changes: Updated the Javadoc. Added the following note: * This method is intended to be used only by PopupFactory sub-classes.

Re: [9] Review request for 8156217 Selected text is shifted on HiDPI display

I applied this and it is *much* better but there still seem to be some tiny quirks. When I drag the mouse to select text down and then up again, as I pass the original mouse click point vertically, repaint seem to jiggle vertically by a pixel. Perhaps a rounding issue in the repaint code's

Re: [9] Review request for 8142966 Wrong cursor position in text components on HiDPI display

This looks reasonable except I am not sure when gc would be null here :- 1062 private static FontRenderContext getFRCProperty(JComponent c) { 1063 if (c != null) { 1064 1065 GraphicsConfiguration gc = c.getGraphicsConfiguration(); 1066 AffineTransform tx =

Re: [9] Review request for 8151015: JTextArea.insert() does not behave as expected with invalid position

content (see AbstractDocument#getLength() for example). The updated webrev: http://cr.openjdk.java.net/~ssadetsky/8151015/webrev.01/ This webrev passes open and closed javax/swing/text/**/* tests. Also bug4496801.java test is moved to open. --Semyon On 3/29/2016 10:24 PM, Phil Race wrote

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

59 * Some times it is required to select several check box menu items from a button 60 * group. In this case it is useful that clicking on one check box menu item 61 * does not close the menu. Such behavior can be controlled by the Look and Feel 62 * property named {@code

Re: [OpenJDK 2D-Dev] RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

It should have been reviewed on 2d as well - I only just saw this. But how I noticed is that as I am syncing jdk9/dev into jdk9/client I saw hundreds (!) of client tests had been updated in the wrong forest. Client test changes and other client changes go into 9/client unless there is a very good

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

On 06/27/2016 04:42 AM, Semyon Sadetsky wrote: I left the suggested phrase as: "* Note: some {@code L}s may ignore this property. All built-in L inherit this behaviour." "L" produces compilation error because the "&" is a prefix for special symbols codes. You need to replace it with ""

Fwd: JEP 283: Enable GTK 3 on Linux

This JEP also touches substantially on Swing (& AWT) Discussion thread here : http://mail.openjdk.java.net/pipermail/openjfx-dev/2016-February/018703.html -phil. Original Message Subject:JEP 283: Enable GTK 3 on Linux Date: Thu, 18 Feb 2016 17:41:48 -0800 (PST)

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

There is a lot to read here. I think I need to patch and try it but first ... Two high level questions : 1) Have you verified that this behaves properly (or no worse than currently) with -Djava.awt.headless=true since Swing components are supposed to be able to draw off-screen in headless mode

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

d for OEL 7 (GTK 3.8). Each minor GTK version may have some appearance changes. On 3/15/2016 10:39 PM, Phil Race wrote: There is a lot to read here. I think I need to patch and try it but first ... Two high level questions : 1) Have you verified that this behaves properly (or no wors

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

: On 3/17/2016 10:57 PM, Phil Race wrote: I ran your changes (which included my fix) through jprt and all Solaris platforms failed as follows :- jdk/src/java.desktop/unix/native/libawt_xawt/awt/sun_awt_X11_GtkFileDialogPeer.c", line 37: error: typedef redeclared: GtkWindow (E_TYPEDEF_REDECLARE

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

which are necessary for the taskbar module are added to gtk_interface: g_object_unref(), g_list_append(), g_list_free(), g_list_free_full(). --Semyon On 4/5/2016 8:54 PM, Phil Race wrote: Could you point me to what was updated ? -phil. On 04/05/2016 10:04 AM, Semyon Sadetsky wrote: The fix

Re: RfR, JDK-8145228 , Java Access Bridge, getAccessibleStatesStringFromContext doesn't wrap the call to getAccessibleRole

+1. -phil. On 02/29/2016 12:35 PM, Pete Brunet wrote: Please review this change which runs code on the EDT like it should have. http://cr.openjdk.java.net/~ptbrunet/JDK-8145228/webrev.00/

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

k/src/java.desktop/unix/native/libawt_xawt/awt/sun_awt_X11_GtkFileDialogPeer.c -phil. On 03/17/2016 09:42 AM, Phil Race wrote: This reminded me I had not yet tried the build myself. When I did I not get the error that Sergey did but I got this as well :- jdk9-client/jdk/src/java.desktop/unix/n

Re: [9] Review request for 8146301: Enter key does not work in a deserialized JFileChooser

The fix looks fine to me and I agree the OS X problem is a distinct one. -phil. On 03/21/2016 11:05 AM, Semyon Sadetsky wrote: On 3/21/2016 8:09 PM, Sergey Bylokhov wrote: On 21.03.16 19:46, Semyon Sadetsky wrote: yes. This a generic code issue. It is failed on OSX even after the fix,

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

Another webrev where you have to slip past 40_ files to get to the two that really matter :-) I would have put SwingUtilities2.java and TextUIDrawing.java as the first files. Some of what I have to say here is more along the lines of things to think about rather than things that are wrong ..

Re: RfR JDK-8153149, Uninitialised memory in WinAccessBridge.cpp:1128

You say its a simple fix but I need you to confirm if i have it right What I see is that pkg is a pointer to part of "buffer" but the contents of that buffer are not initialised so the field rVMID is garbage. So you should not use it. So far so good. But then a reader must ask himself 1) where

Re: RfR: JDK-8153153, Format string argument mismatch in jaccesswalker.cpp:545

All bugs should have an evaluation. Period. -phil. On 04/04/2016 06:33 AM, Pete Brunet wrote: Hi Phil, As far as I know this doesn't need an evaluation. It's just a printf arg mismatch so a 64 bit pointer only gets printed as a 32 bit value, i.e. %X was used where %p should have been used.

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

ese methods were hidden. I am not sure we express this goal successfully or not. On 31.03.16 22:23, Phil Race wrote: Maybe the test to pass in that case is whether the default implementation is going to be satisfactory for 90% of uses. If they are frequently over-ridden it would not

Re: RfR: JDK-8153153, Format string argument mismatch in jaccesswalker.cpp:545

The bug is now evaluated and jPRT is happy so "+1" -phil. On 04/04/2016 03:00 PM, Pete Brunet wrote: Evaluation added. Is the patch OK? https://bugs.openjdk.java.net/browse/JDK-8153153 http://cr.openjdk.java.net/~ptbrunet/JDK-8153153/webrev.00/ Pete On 4/4/16 12:10 PM, Phil

Re: [9] Review request for 8151015: JTextArea.insert() does not behave as expected with invalid position

There is actually a test for the previous bug - called bug4496801.java, but it is in closed. I suggest it be opened as part of this fix. Also run any (all) related Swing regression tests that might cover this area. I am a little nervous that since the original fix was 13 years ago that some

RFR 8154213: clean up uses of boxed primitive constructors in the java.desktop module

Bug: https://bugs.openjdk.java.net/browse/JDK-8154213 Webrev: http://cr.openjdk.java.net/~prr/8154213/ https://bugs.openjdk.java.net/browse/JDK-8145468 has caused the following constructors usages to be deprecated : new Long(long) and new Integer(String) new Integer(int) and new Integer(String)

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

On 04/26/2016 01:39 PM, Sergey Bylokhov wrote: On 26.04.16 23:31, Alexander Scherbatiy wrote: Now it is possible that width1 is not equal to width2. Absolutely true. And it is something Swing needs to handle. Even more, it is not will be possible to rely on the fact that width of number

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

ed. Changing what happens in the font system is not an option since it will break many applications - even if it were the right thing to do - which it is not. -phil. On 4/26/16, 4:49 PM, Sergey Bylokhov wrote: On 27.04.16 1:50, Phil Race wrote: Glyphs are always rasterised in device space so

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

implementaion BasicTextUIDrawing class are added - font metrics argument description is updated On 31/03/16 23:23, Phil Race wrote: Another webrev where you have to slip past 40_ files to get to the two that really matter :-) I would have put SwingUtilities2.java and TextUIDrawing.java as the first

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

you drafted also mis-spells Yield as Yeild in at least two places) -phil. On 05/11/2016 04:20 AM, Semyon Sadetsky wrote: On 5/11/2016 12:17 AM, Phil Race wrote: On 04/22/2016 01:11 AM, Semyon Sadetsky wrote: Forget to attach the link: http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.01

Re: [9] Review request for 8156128: Tests for [AWT/Swing] Conditional support for GTK 3 on Linux

Linux and Solaris just verifying that neither of the flag values (well, of 2 and 3) prevents GTK LaF initialization. Here we don't try to find which version of the library is actually loaded. Please see: http://cr.openjdk.java.net/~yan/8156128/webrev.01/ Thanks, -yan On 05/05/2016 08:26 PM, Phil

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

e: On 4/19/2016 10:41 PM, Phil Race wrote: On 04/19/2016 11:05 AM, Semyon Sadetsky wrote: On 4/19/2016 7:47 PM, Phil Race wrote: Hi, You are deprecating shouldYieldFocus(JComponent) and yet this class directly uses it. Is this deprecation really the right thing to do ? Why is this not cor

Re: [9] Review request for 8136366 Add a public API to create a L without installation

, Alexandr. On 4/4/2016 11:17 PM, Phil Race wrote: +1 -phil. On 04/01/2016 08:19 AM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8136366/webrev.01 The UnsupportedLookAndFeelException is thrown from

Re: [9] Review request for 8136366 Add a public API to create a L without installation

And at the same time the method iterates over the list of the installed L which can be changed by the user. No it does not. The user can only change the list returned by getLAFState() .. this is iterating over the immutable initial list. That is how I read it. -phil. On 17.05.16 19:10, Phil Race wrote

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

Sergey Bylokhov wrote: On 27.04.16 1:50, Phil Race wrote: Glyphs are always rasterised in device space so it does mean device space. I don't argue with it, the question is how to round. The identity transform therefore happens to always return a user space advance is that is an integer, but it

Re: [9] Review request for 8156128: Tests for [AWT/Swing] Conditional support for GTK 3 on Linux

30 # @requires os.family == "linux" That and the test is very linux centric. Does it need to run on Solaris too ? Whilst that may only have gtk2 (not sure about S12) we should still test. -phil. On 05/05/2016 07:23 AM, Yuri Nesterenko wrote: Colleagues, could you please review the tests

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

On 05/06/2016 04:33 PM, Volker Simonis wrote: Hi Phil, Thanks for looking at this problem. On Saturday, May 7, 2016, Phil Race <philip.r...@oracle.com <mailto:philip.r...@oracle.com>> wrote: Hi, I've confirmed that what was pushed was v5 and it should really have be

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

Hi, I've confirmed that what was pushed was v5 and it should really have been v6. I can't say unequivocally that it would have built on AIX but 1) It does not use RTLD_NOLOAD anywhere 2) all calls to dlopen include RTLD_LAZY. Here is the delta - the patch that makes v5 into v6 and although it

Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

Which seems to imply the _AccessibleState subclass has been obsolete since 1.5 Although when these tools were unbundled it perhaps could not assume 1.5. The rest of the changes look fine and it is a lot simpler than the v0 .. -phil. On 04/19/2016 08:54 AM, Pete Brunet wrote: Thanks for

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

Hi, You are deprecating shouldYieldFocus(JComponent) and yet this class directly uses it. Is this deprecation really the right thing to do ? The new over-loaded shouldYieldFocus() is perhaps not much more than a utility. And the doc says "calls verify(input)" which seems odd since you do

Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

oh one nit picky thing - can we get rid of the wild card imports ? -phil. On 04/19/2016 10:21 AM, Phil Race wrote: Which seems to imply the _AccessibleState subclass has been obsolete since 1.5 Although when these tools were unbundled it perhaps could not assume 1.5. The rest of the changes

Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

+1 -phil. On 04/19/2016 12:05 PM, Pete Brunet wrote: New patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8076554/webrev.03/ Changes: - removed _AccessibleState - removed wildcard imports. Is this ready to push? Pete On 4/19/16 12:26 PM, Phil Race wrote: oh one nit picky thing - can we get

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

On 04/19/2016 11:05 AM, Semyon Sadetsky wrote: On 4/19/2016 7:47 PM, Phil Race wrote: Hi, You are deprecating shouldYieldFocus(JComponent) and yet this class directly uses it. Is this deprecation really the right thing to do ? Why is this not correct? There are plenty examples in JDK

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

The key word here is SWING - I looked at the JComponent code and it returns true if either source or target is not a JComponent, without ever getting near the call to shouldYieldFocus(). -phil. On 04/19/2016 12:41 PM, Phil Race wrote: On 04/19/2016 11:05 AM, Semyon Sadetsky wrote: On 4/19/2016 7:47

Re: [9] Review request for 8160986 Bad rendering of Swing UI controls with Metal L on HiDPI display

Since I noticed it right away, I am sure lots of others will soon enough. -phil. On 07/25/2016 02:19 PM, Sergey Bylokhov wrote: On 07.07.16 22:00, Phil Race wrote: the screenshot here bears that out .. ie left/right do not look to be any better. http://cr.openjdk.java.net/~alexsch/8160986

  1   2   3   4   5   >