Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-08-01 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Aug 01, 2015 at 03:27:23PM +1000, Jonathan Liu wrote: Hi, On 2/06/2015 8:27 PM, Dimitri John Ledkov wrote: On 1 June 2015 at 19:12, David Herrmann dh.herrm...@gmail.com wrote: Hi As of today we've disabled git-push to fd.o. The official development git repository is now at github

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-07-31 Thread Jonathan Liu
Hi, On 2/06/2015 8:27 PM, Dimitri John Ledkov wrote: On 1 June 2015 at 19:12, David Herrmann dh.herrm...@gmail.com wrote: Hi As of today we've disabled git-push to fd.o. The official development git repository is now at github [1]. The old repository will still be back-synced, but we had to

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-07-22 Thread Lennart Poettering
On Sat, 18.07.15 19:06, Marc Haber (mh+systemd-de...@zugschlus.de) wrote: On Tue, Jun 09, 2015 at 01:02:43PM +0200, Lennart Poettering wrote: On Mon, 01.06.15 22:43, Michael Biebl (mbi...@gmail.com) wrote: 2015-06-01 20:12 GMT+02:00 David Herrmann dh.herrm...@gmail.com: Hi As

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-07-18 Thread Marc Haber
On Tue, Jun 09, 2015 at 01:02:43PM +0200, Lennart Poettering wrote: On Mon, 01.06.15 22:43, Michael Biebl (mbi...@gmail.com) wrote: 2015-06-01 20:12 GMT+02:00 David Herrmann dh.herrm...@gmail.com: Hi As of today we've disabled git-push to fd.o. The official development git

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-12 Thread Ronny Chevalier
On Fri, Jun 12, 2015 at 5:30 AM, Filipe Brandenburger filbran...@google.com wrote: On Thu, Jun 11, 2015 at 12:31 PM, Ronny Chevalier chevalier.ro...@gmail.com wrote: On Thu, Jun 11, 2015 at 6:31 PM, Filipe Brandenburger filbran...@google.com wrote: Another downside of adding comments to the

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-11 Thread Filipe Brandenburger
On Wed, Jun 10, 2015 at 9:52 AM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 10.06.15 08:25, Filipe Brandenburger (filbran...@google.com) wrote: On Wed, Jun 10, 2015 at 6:31 AM, Alban Crequy al...@endocode.com wrote: FWIW it only loses the comments if people comment on individual

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-11 Thread Ronny Chevalier
On Thu, Jun 11, 2015 at 6:31 PM, Filipe Brandenburger filbran...@google.com wrote: On Wed, Jun 10, 2015 at 9:52 AM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 10.06.15 08:25, Filipe Brandenburger (filbran...@google.com) wrote: On Wed, Jun 10, 2015 at 6:31 AM, Alban Crequy

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-11 Thread Lucas De Marchi
On Tue, Jun 9, 2015 at 7:01 PM, Lennart Poettering lenn...@poettering.net wrote: Well, but it's really weird... If you start out with a patch things are tracked as PR. If you start out without a patch things are tracked as an issue. And they have quite different workflows, as PRs cannot be

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-11 Thread Filipe Brandenburger
On Thu, Jun 11, 2015 at 12:31 PM, Ronny Chevalier chevalier.ro...@gmail.com wrote: On Thu, Jun 11, 2015 at 6:31 PM, Filipe Brandenburger filbran...@google.com wrote: Another downside of adding comments to the commits is that e-mail notifications are not sent for them (I just noticed that

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Lennart Poettering
On Wed, 10.06.15 06:44, Martin Pitt (martin.p...@ubuntu.com) wrote: Filipe Brandenburger [2015-06-09 12:55 -0700]: I think a more productive advice would be for reviewers to avoid using line comments for anything that is wanted for posterity and instead only use them to say typo or comment

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Martin Jansa
On Wed, Jun 10, 2015 at 12:01:18AM +0200, Lennart Poettering wrote: On Tue, 09.06.15 14:54, Filipe Brandenburger (filbran...@google.com) wrote: On Tue, Jun 9, 2015 at 2:37 PM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 09.06.15 13:04, Filipe Brandenburger

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Andrei Borzenkov
On Wed, Jun 10, 2015 at 3:35 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 10.06.15 14:04, Martin Jansa (martin.ja...@gmail.com) wrote: WHat really surprises me about the whole discussion is that we cannot be the first ones running into this. Given the success of github this

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Lennart Poettering
On Wed, 10.06.15 14:04, Martin Jansa (martin.ja...@gmail.com) wrote: WHat really surprises me about the whole discussion is that we cannot be the first ones running into this. Given the success of github this must be a common issue. And if it is, then either github is actually prety bad,

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Alban Crequy
On Tue, Jun 9, 2015 at 11:37 PM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 09.06.15 13:04, Filipe Brandenburger (filbran...@google.com) wrote: On Tue, Jun 9, 2015 at 12:59 PM, Lennart Poettering lenn...@poettering.net wrote: [...] so we comment and ask for a new PR, and close

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Jóhann B. Guðmundsson
On 06/10/2015 03:09 PM, Lennart Poettering wrote: On Wed, 10.06.15 14:53, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: WHat really surprises me about the whole discussion is that we cannot be the first ones running into this. Given the success of github this must be a common issue. And

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Lennart Poettering
On Wed, 10.06.15 16:20, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Without proper infrastructure ( or at least the wills to acquire such ) how can you ( or any of us for that matter ) with a straight face advocate for consolidation and call systemd the modern building block of an OS (

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Filipe Brandenburger
On Wed, Jun 10, 2015 at 5:04 AM, Martin Jansa martin.ja...@gmail.com wrote: If you want good review tool, why not use gerrit? +1 for Gerrit as a code review tool. It's not perfect, but from all of them that I've used it seems to get the most right: - Review *commits* and not PRs (tends to

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Lennart Poettering
B1;4002;0cOn Wed, 10.06.15 08:25, Filipe Brandenburger (filbran...@google.com) wrote: On Wed, Jun 10, 2015 at 6:31 AM, Alban Crequy al...@endocode.com wrote: Instead, just reuse the same PR and use `git push -f` to ship new versions of the commits to the same branch... Yes it's awful but

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Mihamina Rakotomandimby
On 06/10/2015 05:53 PM, Jóhann B. Guðmundsson wrote: On 06/10/2015 12:35 PM, Lennart Poettering wrote: On Wed, 10.06.15 14:04, Martin Jansa (martin.ja...@gmail.com) wrote: WHat really surprises me about the whole discussion is that we cannot be the first ones running into this. Given the

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Greg KH
On Wed, Jun 10, 2015 at 05:38:30PM +, Jóhann B. Guðmundsson wrote: On 06/10/2015 04:35 PM, Lennart Poettering wrote: On Wed, 10.06.15 16:20, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Without proper infrastructure ( or at least the wills to acquire such ) how can you ( or

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Greg KH
On Wed, Jun 10, 2015 at 07:04:17PM +, Jóhann B. Guðmundsson wrote: On 06/10/2015 05:46 PM, Greg KH wrote: There's also no real need for it, I don't understand why you keep insisting there is given how well things have been working so far. I do understand and am aware of the complication

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Lennart Poettering
On Wed, 10.06.15 17:38, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Without proper infrastructure ( or at least the wills to acquire such ) how can you ( or any of us for that matter ) with a straight face advocate for consolidation and call systemd the modern building block of an OS

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Greg KH
On Wed, Jun 10, 2015 at 05:38:30PM +, Jóhann B. Guðmundsson wrote: On 06/10/2015 04:35 PM, Lennart Poettering wrote: On Wed, 10.06.15 16:20, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Without proper infrastructure ( or at least the wills to acquire such ) how can you ( or

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Greg KH
On Wed, Jun 10, 2015 at 05:38:30PM +, Jóhann B. Guðmundsson wrote: On 06/10/2015 04:35 PM, Lennart Poettering wrote: On Wed, 10.06.15 16:20, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Without proper infrastructure ( or at least the wills to acquire such ) how can you ( or

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Jóhann B. Guðmundsson
On 06/10/2015 05:46 PM, Greg KH wrote: There's also no real need for it, I don't understand why you keep insisting there is given how well things have been working so far. I do understand and am aware of the complication ( legal and otherwise social aspect of it etc ) involved with bringing

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Jóhann B. Guðmundsson
On 06/10/2015 04:35 PM, Lennart Poettering wrote: On Wed, 10.06.15 16:20, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Without proper infrastructure ( or at least the wills to acquire such ) how can you ( or any of us for that matter ) with a straight face advocate for consolidation

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Jóhann B. Guðmundsson
On 06/10/2015 07:36 PM, Greg KH wrote: On Wed, Jun 10, 2015 at 07:04:17PM +, Jóhann B. Guðmundsson wrote: On 06/10/2015 05:46 PM, Greg KH wrote: There's also no real need for it, I don't understand why you keep insisting there is given how well things have been working so far. I do

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Greg KH
On Thu, Jun 11, 2015 at 02:01:06AM +, Jóhann B. Guðmundsson wrote: On 06/10/2015 07:36 PM, Greg KH wrote: On Wed, Jun 10, 2015 at 07:04:17PM +, Jóhann B. Guðmundsson wrote: On 06/10/2015 05:46 PM, Greg KH wrote: There's also no real need for it, I don't understand why you keep

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Lennart Poettering
On Wed, 10.06.15 14:53, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: WHat really surprises me about the whole discussion is that we cannot be the first ones running into this. Given the success of github this must be a common issue. And if it is, then either github is actually prety bad,

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Filipe Brandenburger
On Wed, Jun 10, 2015 at 6:31 AM, Alban Crequy al...@endocode.com wrote: Instead, just reuse the same PR and use `git push -f` to ship new versions of the commits to the same branch... Yes it's awful but unfortunately that's how GitHub works... Yeah, it is awful, and loses all the comments, as

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Jóhann B. Guðmundsson
On 06/09/2015 11:02 AM, Lennart Poettering wrote: On Mon, 01.06.15 22:43, Michael Biebl (mbi...@gmail.com) wrote: 2015-06-01 20:12 GMT+02:00 David Herrmann dh.herrm...@gmail.com: Hi As of today we've disabled git-push to fd.o. The official development git repository is now at github [1].

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Mihamina Rakotomandimby
On 06/09/2015 02:30 PM, Jóhann B. Guðmundsson wrote: As of today we've disabled git-push to fd.o. The official development git repository is now at github [1]. What about the bug tracker? Will it remain at fdo's bugzilla. I have to admit I'm not a huge fan of github's bug tracker. I am not

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Lennart Poettering
On Mon, 01.06.15 22:43, Michael Biebl (mbi...@gmail.com) wrote: 2015-06-01 20:12 GMT+02:00 David Herrmann dh.herrm...@gmail.com: Hi As of today we've disabled git-push to fd.o. The official development git repository is now at github [1]. What about the bug tracker? Will it remain at

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Camilo Aguilar
Oh please Jira no, it is too much and the user friendliness is highly arguable. On Tue, Jun 9, 2015 at 8:46 AM Jóhann B. Guðmundsson johan...@gmail.com wrote: On 06/09/2015 11:57 AM, Mihamina Rakotomandimby wrote: On 06/09/2015 02:30 PM, Jóhann B. Guðmundsson wrote: As of today we've

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Jóhann B. Guðmundsson
On 06/09/2015 06:42 PM, David Timothy Strauss wrote: Let's just try the GitHub tracker. I like how it associates issues with pull requests and supports auto-linking for commit IDs, user names, and other issue numbers. Is there any serious use case for systemd upstream it doesn't support?

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Jóhann B. Guðmundsson
On 06/09/2015 06:53 PM, Camilo Aguilar wrote: Oh please Jira no, it is too much and the user friendliness is highly arguable. Please do not top post and compared to bugzilla and the lack of proper oversight github and other issue tracker provide it's much better. JBG

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread David Timothy Strauss
Let's just try the GitHub tracker. I like how it associates issues with pull requests and supports auto-linking for commit IDs, user names, and other issue numbers. Is there any serious use case for systemd upstream it doesn't support? ___ systemd-devel

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Lennart Poettering
On Tue, 09.06.15 11:30, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: I would like to see us move and migrated the bugs to jira ( which is without doubt the best and friendliest bug tracker I have found ) which integrates nicely with github as well as move the community wiki to confluence

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Filipe Brandenburger
Moving from #88 to this thread: On Tue, Jun 9, 2015 at 12:41 PM, Lennart Poettering lenn...@poettering.net wrote: So I think updating the PR (by force-pushing) is really nasty, and we shouldn't do it. Instead, please push a new PR, mention that it obsoletes the old one. (of course, I wished

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Lennart Poettering
On Wed, 03.06.15 10:39, Krzesimir Nowak (krzesi...@endocode.com) wrote: Hi, I see that some patches from mailing list were imported as issues to github.com (like this one - https://github.com/systemd/systemd/pull/16). There's a problem with that - I can't update the PR anymore with followup

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Camilo Aguilar
Usually, when a PR needs fixing, it is done in the same PR, and there may be need to rebase so that commit history is not polluted, hence git push -f On Tue, Jun 9, 2015 at 3:59 PM Lennart Poettering lenn...@poettering.net wrote: On Tue, 09.06.15 18:42, David Timothy Strauss

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Filipe Brandenburger
On Tue, Jun 9, 2015 at 12:59 PM, Lennart Poettering lenn...@poettering.net wrote: [...] so we comment and ask for a new PR, and close the old one. See my previous comment, I think this cure is worse than the disease :-) Instead, just reuse the same PR and use `git push -f` to ship new versions

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Lennart Poettering
On Tue, 09.06.15 18:42, David Timothy Strauss (da...@davidstrauss.net) wrote: Let's just try the GitHub tracker. I like how it associates issues with pull requests and supports auto-linking for commit IDs, user names, and other issue numbers. Is there any serious use case for systemd upstream

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Jóhann B. Guðmundsson
On 06/09/2015 07:50 PM, Lennart Poettering wrote: On Tue, 09.06.15 11:30, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: I would like to see us move and migrated the bugs to jira ( which is without doubt the best and friendliest bug tracker I have found ) which integrates nicely with

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Jóhann B. Guðmundsson
On 06/09/2015 06:42 PM, David Timothy Strauss wrote: Let's just try the GitHub tracker. I like how it associates issues with pull requests and supports auto-linking for commit IDs, user names, and other issue numbers. Is there any serious use case for systemd upstream it doesn't support? I

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Jóhann B. Guðmundsson
On 06/09/2015 09:34 PM, Lennart Poettering wrote: On Tue, 09.06.15 19:19, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 06/09/2015 06:42 PM, David Timothy Strauss wrote: Let's just try the GitHub tracker. I like how it associates issues with pull requests and supports auto-linking

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Jóhann B. Guðmundsson
On 06/09/2015 09:44 PM, Lennart Poettering wrote: On Tue, 09.06.15 21:11, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: We need to do proper QA to properly support and backup our downstream consumers ( distributions, embedded and otherwise) and that means tagging bugs by distributions,

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Lennart Poettering
On Tue, 09.06.15 12:55, Filipe Brandenburger (filbran...@google.com) wrote: Moving from #88 to this thread: On Tue, Jun 9, 2015 at 12:41 PM, Lennart Poettering lenn...@poettering.net wrote: So I think updating the PR (by force-pushing) is really nasty, and we shouldn't do it. Instead,

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Lennart Poettering
On Tue, 09.06.15 21:11, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: We need to do proper QA to properly support and backup our downstream consumers ( distributions, embedded and otherwise) and that means tagging bugs by distributions, vendors, releases. I'd be very careful with

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Filipe Brandenburger
On Tue, Jun 9, 2015 at 2:37 PM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 09.06.15 13:04, Filipe Brandenburger (filbran...@google.com) wrote: On Tue, Jun 9, 2015 at 12:59 PM, Lennart Poettering lenn...@poettering.net wrote: [...] so we comment and ask for a new PR, and close

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Lennart Poettering
On Tue, 09.06.15 14:54, Filipe Brandenburger (filbran...@google.com) wrote: On Tue, Jun 9, 2015 at 2:37 PM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 09.06.15 13:04, Filipe Brandenburger (filbran...@google.com) wrote: On Tue, Jun 9, 2015 at 12:59 PM, Lennart Poettering

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Lennart Poettering
On Tue, 09.06.15 19:19, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 06/09/2015 06:42 PM, David Timothy Strauss wrote: Let's just try the GitHub tracker. I like how it associates issues with pull requests and supports auto-linking for commit IDs, user names, and other issue numbers.

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Lennart Poettering
On Tue, 09.06.15 13:04, Filipe Brandenburger (filbran...@google.com) wrote: On Tue, Jun 9, 2015 at 12:59 PM, Lennart Poettering lenn...@poettering.net wrote: [...] so we comment and ask for a new PR, and close the old one. See my previous comment, I think this cure is worse than the

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Jóhann B. Guðmundsson
On 06/09/2015 11:57 AM, Mihamina Rakotomandimby wrote: On 06/09/2015 02:30 PM, Jóhann B. Guðmundsson wrote: As of today we've disabled git-push to fd.o. The official development git repository is now at github [1]. What about the bug tracker? Will it remain at fdo's bugzilla. I have to

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Mihamina Rakotomandimby
On 06/09/2015 10:50 PM, Lennart Poettering wrote: I would like to see us move and migrated the bugs to jira ( which is without doubt the best and friendliest bug tracker I have found ) which integrates nicely with github as well as move the community wiki to confluence to strengthen

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Martin Pitt
Filipe Brandenburger [2015-06-09 12:55 -0700]: I think a more productive advice would be for reviewers to avoid using line comments for anything that is wanted for posterity and instead only use them to say typo or comment here or to point out what exactly in the code the comment on the main

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-05 Thread David Herrmann
Hi On Wed, Jun 3, 2015 at 7:48 PM, Lucas De Marchi lucas.de.mar...@gmail.com wrote: Of course this is a non-issue for several projects in github which don't have proper commit review. It's not the case of systemd and it seems it's even the reason why you are moving to github. So I'm just

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-05 Thread Lucas De Marchi
On Fri, Jun 5, 2015 at 7:02 AM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Wed, Jun 3, 2015 at 7:48 PM, Lucas De Marchi lucas.de.mar...@gmail.com wrote: Of course this is a non-issue for several projects in github which don't have proper commit review. It's not the case of systemd

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-03 Thread Martin Pitt
Hello Krzesimir, Krzesimir Nowak [2015-06-03 10:39 +0200]: I see that some patches from mailing list were imported as issues to github.com (like this one - https://github.com/systemd/systemd/pull/16). There's a problem with that - I can't update the PR anymore with followup fixes and whatnot.

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-03 Thread Krzesimir Nowak
On Mon, Jun 1, 2015 at 8:12 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi As of today we've disabled git-push to fd.o. The official development git repository is now at github [1]. The old repository will still be back-synced, but we had to disable push-access to avoid getting

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-03 Thread Filipe Brandenburger
Hi, On Tue, Jun 2, 2015 at 7:58 AM, Dimitri John Ledkov dimitri.j.led...@intel.com wrote: And I think this is _good_, because the submitter's commit ids will be preserved (together with the signed gpg commits) [...] This, signed gpg commits, is actually the first reasonable argument I see for

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-03 Thread Colin Guthrie
Abdó Roig-Maranges wrote on 02/06/15 17:03: Daniel Mack writes: On 06/02/2015 04:34 PM, Martin Pitt wrote: Merging manually is quite a bit of work, as you have to add a new remote every time, fetch that, and pull from it. But it does keep a cleaner git log history. Btw, Harald pointed

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-03 Thread Suckow, Thomas J
On 6/3/15, 7:14 AM, Filipe Brandenburger filbran...@google.com wrote: I think, though, in general, the GitHub way of focusing on PRs and not commits tends to generate poorer git commits and git histories in general. I too often see broken PRs being ammended with second or third commits to fix

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-03 Thread David Timothy Strauss
On Tue, Jun 2, 2015 at 5:03 PM Kay Sievers k...@vrfy.org wrote: Could you please check your old repos at: https://github.com/systemd and move or delete them if they are no longer needed. One of them at least has a comment like This is old. Actual repo is on my davidstrauss account. Will

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-03 Thread Kay Sievers
On Wed, Jun 3, 2015 at 7:06 PM, David Timothy Strauss da...@davidstrauss.net wrote: On Tue, Jun 2, 2015 at 5:03 PM Kay Sievers k...@vrfy.org wrote: Could you please check your old repos at: https://github.com/systemd and move or delete them if they are no longer needed. One of them at

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-03 Thread Lucas De Marchi
On Tue, Jun 2, 2015 at 11:53 AM, Kay Sievers k...@vrfy.org wrote: On Tue, Jun 2, 2015 at 4:34 PM, Martin Pitt martin.p...@ubuntu.com wrote: David Herrmann [2015-06-02 13:06 +0200]: Our preferred way to send future patches is the github way. This means sending pull-requests to the github repo.

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Umut Tezduyar Lindskog
On Mon, Jun 1, 2015 at 8:12 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi As of today we've disabled git-push to fd.o. The official development git repository is now at github [1]. The old repository will still be back-synced, but we had to disable push-access to avoid getting

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Michael Marineau
On Tue, Jun 2, 2015 at 6:31 AM, Daniel Mack dan...@zonque.org wrote: On 06/02/2015 02:19 PM, Jason A. Donenfeld wrote: On Tue, Jun 2, 2015 at 1:06 PM, David Herrmann dh.herrm...@gmail.com wrote: Regarding the final github address: David Strauss kindly offered the 'systemd' user to us. Hence,

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Ronny Chevalier
On Tue, Jun 2, 2015 at 1:06 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Mon, Jun 1, 2015 at 8:12 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi As of today we've disabled git-push to fd.o. The official development git repository is now at github [1]. The old repository will

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Suckow, Thomas J
On 6/2/15, 2:05 PM, Stefan Tatschner rumpels...@sevenbyte.org wrote: On Tue, 2015-06-02 at 14:49 +, Zbigniew Jędrzejewski-Szmek wrote: Merging manually is quite a bit of work, as you have to add a new remote every time, fetch that, and pull from it. But it does keep a cleaner git log

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread David Timothy Strauss
Looks like everything's in place now at the new github.com/systemd/systemd home. I've halted the Jenkins CI from pushing to that repository (which was formerly the mirror updated whenever CI passed). I'll probably update CI to merely push a branch like master-passing so there's still a way to get

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Kay Sievers
On Wed, Jun 3, 2015 at 1:51 AM, David Timothy Strauss da...@davidstrauss.net wrote: Looks like everything's in place now at the new github.com/systemd/systemd home. I've halted the Jenkins CI from pushing to that repository (which was formerly the mirror updated whenever CI passed). I'll

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Stefan Tatschner
On Tue, 2015-06-02 at 14:49 +, Zbigniew Jędrzejewski-Szmek wrote: Merging manually is quite a bit of work, as you have to add a new remote every time, fetch that, and pull from it. But it does keep a cleaner git log history. I'd very much prefer to keep current look of the git tree,

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Dimitri John Ledkov
On 1 June 2015 at 19:12, David Herrmann dh.herrm...@gmail.com wrote: Hi As of today we've disabled git-push to fd.o. The official development git repository is now at github [1]. The old repository will still be back-synced, but we had to disable push-access to avoid getting out-of-sync with

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread David Herrmann
Hi On Mon, Jun 1, 2015 at 8:12 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi As of today we've disabled git-push to fd.o. The official development git repository is now at github [1]. The old repository will still be back-synced, but we had to disable push-access to avoid getting

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Jóhann B. Guðmundsson
On 06/02/2015 11:48 AM, Dimitri John Ledkov wrote: On 2 June 2015 at 12:34, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 06/02/2015 11:06 AM, David Herrmann wrote: Regarding the final github address: David Strauss kindly offered the 'systemd' user to us. Hence, we hope to move the

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jun 02, 2015 at 04:03:59PM +0200, David Herrmann wrote: Hi On Tue, Jun 2, 2015 at 3:58 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Jun 02, 2015 at 03:31:19PM +0200, Daniel Mack wrote: On 06/02/2015 02:19 PM, Jason A. Donenfeld wrote: On Tue, Jun 2, 2015 at

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Martin Pitt
David Herrmann [2015-06-02 13:06 +0200]: Our preferred way to send future patches is the github way. This means sending pull-requests to the github repo. Furthermore, all feature patches should go through pull-requests and should get reviewed pre-commit. This applies to everyone. Exceptions

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jun 02, 2015 at 04:34:03PM +0200, Martin Pitt wrote: David Herrmann [2015-06-02 13:06 +0200]: Our preferred way to send future patches is the github way. This means sending pull-requests to the github repo. Furthermore, all feature patches should go through pull-requests and should

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jun 02, 2015 at 03:31:19PM +0200, Daniel Mack wrote: On 06/02/2015 02:19 PM, Jason A. Donenfeld wrote: On Tue, Jun 2, 2015 at 1:06 PM, David Herrmann dh.herrm...@gmail.com wrote: Regarding the final github address: David Strauss kindly offered the 'systemd' user to us. Hence, we

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Dimitri John Ledkov
On 2 June 2015 at 12:34, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 06/02/2015 11:06 AM, David Herrmann wrote: Regarding the final github address: David Strauss kindly offered the 'systemd' user to us. Hence, we hope to move the repository to github.com/systemd/systemd this week.

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread David Herrmann
Hi On Tue, Jun 2, 2015 at 3:58 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Jun 02, 2015 at 03:31:19PM +0200, Daniel Mack wrote: On 06/02/2015 02:19 PM, Jason A. Donenfeld wrote: On Tue, Jun 2, 2015 at 1:06 PM, David Herrmann dh.herrm...@gmail.com wrote: Regarding the

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Daniel Mack
On 06/02/2015 02:19 PM, Jason A. Donenfeld wrote: On Tue, Jun 2, 2015 at 1:06 PM, David Herrmann dh.herrm...@gmail.com wrote: Regarding the final github address: David Strauss kindly offered the 'systemd' user to us. Hence, we hope to move the repository to github.com/systemd/systemd this

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Jason A. Donenfeld
On Tue, Jun 2, 2015 at 1:06 PM, David Herrmann dh.herrm...@gmail.com wrote: Regarding the final github address: David Strauss kindly offered the 'systemd' user to us. Hence, we hope to move the repository to github.com/systemd/systemd this week. Sorry for the confusion, I hope we can settle

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Dimitri John Ledkov
On 2 June 2015 at 15:34, Martin Pitt martin.p...@ubuntu.com wrote: David Herrmann [2015-06-02 13:06 +0200]: Our preferred way to send future patches is the github way. This means sending pull-requests to the github repo. Furthermore, all feature patches should go through pull-requests and

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Daniel P. Berrange
On Tue, Jun 02, 2015 at 04:34:03PM +0200, Martin Pitt wrote: David Herrmann [2015-06-02 13:06 +0200]: Our preferred way to send future patches is the github way. This means sending pull-requests to the github repo. Furthermore, all feature patches should go through pull-requests and should

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Kay Sievers
On Tue, Jun 2, 2015 at 4:34 PM, Martin Pitt martin.p...@ubuntu.com wrote: David Herrmann [2015-06-02 13:06 +0200]: Our preferred way to send future patches is the github way. This means sending pull-requests to the github repo. Furthermore, all feature patches should go through pull-requests

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Dimitri John Ledkov
On 2 June 2015 at 15:56, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Jun 02, 2015 at 04:34:03PM +0200, Martin Pitt wrote: David Herrmann [2015-06-02 13:06 +0200]: Our preferred way to send future patches is the github way. This means sending pull-requests to the github repo.

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Dimitri John Ledkov
On 2 June 2015 at 15:49, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Jun 02, 2015 at 04:34:03PM +0200, Martin Pitt wrote: David Herrmann [2015-06-02 13:06 +0200]: Our preferred way to send future patches is the github way. This means sending pull-requests to the github repo.

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Abdó Roig-Maranges
Daniel Mack writes: On 06/02/2015 04:34 PM, Martin Pitt wrote: Merging manually is quite a bit of work, as you have to add a new remote every time, fetch that, and pull from it. But it does keep a cleaner git log history. Btw, Harald pointed me to this simple alias that makes checking out

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Martin Pitt
Dimitri John Ledkov [2015-06-02 15:58 +0100]: And I think this is _good_, because the submitter's commit ids will be preserved (together with the signed gpg commits) and the maintainers are discouraged to fix-up and/or adjust commits upon rebase / git-am. Instead fix-ups from reviewer should

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-01 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jun 01, 2015 at 08:12:37PM +0200, David Herrmann wrote: [1] https://github.com/systemd-devs/systemd Is there a particular reason not to use the existing https://github.com/systemd/systemd ? Zbyszek ___ systemd-devel mailing list

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-01 Thread Ronny Chevalier
On Mon, Jun 1, 2015 at 8:12 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi As of today we've disabled git-push to fd.o. The official development git repository is now at github [1]. The old repository will still be back-synced, but we had to disable push-access to avoid getting

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-01 Thread David Timothy Strauss
On Mon, Jun 1, 2015 at 11:20 AM Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Mon, Jun 01, 2015 at 08:12:37PM +0200, David Herrmann wrote: [1] https://github.com/systemd-devs/systemd Is there a particular reason not to use the existing https://github.com/systemd/systemd ? No

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-01 Thread Michael Biebl
2015-06-01 20:12 GMT+02:00 David Herrmann dh.herrm...@gmail.com: Hi As of today we've disabled git-push to fd.o. The official development git repository is now at github [1]. What about the bug tracker? Will it remain at fdo's bugzilla. I have to admit I'm not a huge fan of github's bug

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-01 Thread Martin Pitt
Hey David, David Herrmann [2015-06-01 20:12 +0200]: As of today we've disabled git-push to fd.o. The official development git repository is now at github [1]. Can you copy the committer list from fd.o? Right now it seems the only person that can actually push to systemd-devs/systemd is you