Re: [patch] Add error handling in usr.bin/time/time.c

Hi, Nan Xiao wrote on Fri, Apr 20, 2018 at 05:28:01PM +0800: > FYI, thanks! No. Read the manual page and /sys/kern/kern_time.c : With a valid clock id and a valid address, this function cannot fail, so you are just adding dead code. Worse, you are making future auditors wonder what the heck i

Re: start splitting kern.9 up

Hi David, David Gwynne wrote on Thu, Apr 19, 2018 at 10:19:44AM +1000: > like a small handful of man pages, kern.9 puts prototypes in places > other than the SYNOPSIS section. of these, it is probably the most > straightforward to fix. kern.9 documents a bunch of different apis > provided by "lib

Re: Should rm(1) -Pf change file permission?

Hi Gregoire, Gregoire Jadi wrote on Tue, Apr 17, 2018 at 11:44:41AM +0200: > Ingo Schwarze writes: >> Feedback is welcome both on the general idea and on the specific >> implementation. The result of that feeback was "we don't want it, the whole idea of changing this i

Re: autoconf.9 consistency

Hi David, David Gwynne wrote on Tue, Apr 03, 2018 at 02:01:33PM +1000: > i landed on this manpage and got confused cos it looked different > to the rest of them. Note that the style of having multiple synopses in multiple sections of a page is used in more than one page - though admittedly in fe

Re: plug a memory leak in diff(1)

Hi, Theo Buehler wrote on Mon, Apr 02, 2018 at 08:32:43PM +0200: > On Mon, Apr 02, 2018 at 07:41:55PM +0200, Stefan Sperling wrote: >> Line buffers allocated in preadline() were never freed. > They are freed in ignoreline(). What a beautiful case of obfuscation. How symmetrical. Both the mall

Re: Should rm(1) -Pf change file permission?

Hi, Gregoire Jadi wrote on Fri, Mar 30, 2018 at 06:07:42PM +0200: > While working on a port of keyringer, I observed the following behavior > of rm(1) with the -P option: if the file does not have write permission, > the file is removed without being overwritten. > > This is not the same behavio

Re: expr: Fix integer overflows

Hi Tobias, Tobias Stoeckmann wrote on Sat, Mar 31, 2018 at 01:28:19PM +0200: > I actually ended up in expr(1) after seeing that the test(1) and ksh(1) > debate could be continued here. While expr(1) is int64_t, expressions > in ksh(1) are of type long, i.e. 32/64 bit depending on architecture. >

Re: manpage text width

Hi Paul, Paul Irofti wrote on Fri, Mar 30, 2018 at 11:23:54AM +0300: > Ingo Schwarze wrote: >> * Nowadays, i guess that terminals narrower than 80 columns >>have become seriously rare, so there is not very widespread >>benefit for that case. > Maybe that was tr

Re: expr: Fix integer overflows

Hi Tobias, Tobias Stoeckmann wrote on Fri, Mar 30, 2018 at 05:39:11PM +0200: > Our expr implementation supports 64 bit integers, but does not check > for overflows during parsing and arithmetical operations. Even though - as discussed previously for test(1) - behaviour is undefined by POSIX outs

Re: manpage text width

Hi Paul, Theo de Raadt wrote on Thu, Mar 29, 2018 at 04:17:14PM -0600: > piroft@ wrote: >> Is there any reason why manpage text does not resize nicely >> with <80 columns xterms? I want to avoid excessive magic. By the way, actually, the default width is 78, not 80. By tradition. >> Is it beca

Re: cut: Fix segmentation fault

Hi Tobias, Tobias Stoeckmann wrote on Tue, Mar 27, 2018 at 11:51:29PM +0200: > On Tue, Mar 27, 2018 at 11:47:27PM +0200, Ingo Schwarze wrote: >> See inline for one optional suggestion. >>> if (!stop || !start) >>> errx(1, "[-bcf] l

Re: cut: Fix segmentation fault

Hi Tobias, Tobias Stoeckmann wrote on Tue, Mar 27, 2018 at 01:30:03PM +0200: > This patch fixes an out of boundary write in cut: > > $ cut -c 2147483648 - > Segmentation fault (core dumped) > > The supplied number can be parsed by strtol, but the result is casted > into a signed int, therefore

Re: test(1): Fix integer overflows

Hi Tobias, Tobias Stoeckmann wrote on Tue, Mar 27, 2018 at 07:37:32PM +0200: > While at it, -t has a proper 0-INT_MAX limitation now as well. Looks correct. > Please note that we have overflows in pdksh's builtin test as well. > If bin/test is refactored, I'll try to unify both implementations

Re: test(1): Fix integer overflows

Hi Tobias, one quick remark regarding POSIX: The relevant text is http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html section 12.1 Utility Argument Syntax, number 6. Together with http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html we have the followin

Re: [patch] 62.html

Hi, Thomas Alexander Frederiksen wrote on Fri, Mar 16, 2018 at 02:20:54PM +0100: > Same as the rejected patch for the temporary 63.html, but this time > for a relevant page. Committed, thanks. Ingo > --- 62.html.orig 2018-03-16 14:17:49.0 +0100 > +++ 62.html 2018-03-16 14:18:0

Re: add lld manual page

Hi Jonathan, Jonathan Gray wrote on Thu, Mar 01, 2018 at 10:03:25PM +1100: > There are other pages, ie gcc.1 gcov.1 aren't present on arm64. > > We don't install gcc3/gcc4 manual pages in architecture specific > directories currently. Or llvm manual pages on architectures > that don't build llv

Re: add lld manual page

Hi, Jonathan Gray wrote on Thu, Mar 01, 2018 at 07:28:45PM +1100: > The binary is installed on all architectures that build llvm as > /usr/bin/ld.lld and is also installed as /usr/bin/ld on arm64. > > With ld.1 from binutils and ld.lld.1 with ld in .Nm 'man ld' will pick > the binutils page but

Re: More useful: something like doasedit

Hi, Felix Maschek wrote on Wed, Feb 28, 2018 at 08:24:19PM +0100: > How would you prevent that something like 'doas vi /etc/fstab' (which > will run as root) doesn't offer the user to enter a root shell within vi > (by typing '.sh')? The sudo(8) utility has become able, over the decades, to do

Re: openssl.1 diff

Hi, Holger Mikolon wrote on Tue, Feb 27, 2018 at 11:04:10PM +0100: > jmc@ wrote: >> i wonder whether we could more simply just use the date format [YY]YY, >> explain the 2050 cutoff, and forget about mentioning asn.1 time >> structures. >> >> or do you think there is a practical reason why the u

Re: [patch] sigaction.2 fix spacing

Hi Edgar, Edgar Pettijohn wrote on Mon, Feb 26, 2018 at 08:19:30PM -0600: > Index: sigaction.2 > === > RCS file: /cvs/src/lib/libc/sys/sigaction.2,v > retrieving revision 1.74 > diff -u -p -u -r1.74 sigaction.2 > --- sigaction.22

Re: [PATCH] www/books.html - SSH Mastery, 2nd Edition has now been released

Hi, Raf Czlonka wrote on Thu, Feb 15, 2018 at 05:26:44AM +: > An update of the "SSH Mastery" book entry to its 2nd edition. > > While there, I moved its subtitle up, where it belongs, and swapped > ISBN 10 and 13 to keep it consistent with other books. > > I had also taken the liberty to up

Re: Fix for vi(1) manpage Visual command

Hi Christian and Claudio, Christian Weisgerber wrote on Thu, Feb 08, 2018 at 09:49:21PM -: > On 2018-02-07, Claudio Jeker wrote: >> On Wed, Feb 07, 2018 at 07:28:42PM +0100, Ingo Schwarze wrote: >>> while trying to fix the documentation of screen splitting in the vi(1) &g

Re: Fix for vi(1) manpage Visual command

Hi, while trying to fix the documentation of screen splitting in the vi(1) manual page, jmc@ suggested to stop documenting it at all. I like the idea because splitting is useless and confusing and the already excessively large documentation profits from simplification. Rationale: 1. vi screen

Re: daily(8): don't fail silently if backup disk is unavailable

Hi Theo, Theo Buehler wrote on Mon, Feb 05, 2018 at 12:13:31PM +1300: > After a power failure, my apu2 booted, but its sdmmc controller didn't > attach properly. A few days later I was wondering why I didn't get the > usual dump output from the backup of the root filesystem in my daily > mails. >

Re: Fix for vi(1) manpage Visual command

Hi Jason, Jason McIntyre wrote on Sat, Feb 03, 2018 at 08:52:16PM +: > hmm. not that i entirely agree with this sentiment but fair enough, > i will look at updating the USD docs. Thanks. Don't waste your time on that until after commit, of course. > a good way to do it without adding verbi

Re: Fix for vi(1) manpage Visual command

Hi Jason, Jason McIntyre wrote on Sat, Feb 03, 2018 at 07:23:59PM +: > On Sat, Feb 03, 2018 at 08:10:14PM +0100, Ingo Schwarze wrote: >> Jason McIntyre wrote on Sat, Feb 03, 2018 at 05:41:01PM +: >>> can of worms, there's still stuff like :exusage >> I t

Re: Fix for vi(1) manpage Visual command

Hi Jason, Jason McIntyre wrote on Sat, Feb 03, 2018 at 05:41:01PM +: > personally i still think it would be simpler to only list these commands > once, but note which subset can take a capital letter (and what that > means). I seems you are right, amybe i should believe you the first time yo

Re: sleep(1): better error messages

Hi Scott, Scott Cheloha wrote on Sat, Feb 03, 2018 at 10:08:46AM -0600: > This adds strtonum(3)-style error messages to sleep(1). They're > more informative than the usage statement and they're idiomatic > for numeric input. > > Exiting with EINVAL is really unusual. It went into r1.9. Unless

Re: Fix for vi(1) manpage Visual command

Hi Jason, hi Anthony, Jason McIntyre wrote on Sat, Feb 03, 2018 at 02:52:26PM +: > ok, but it does not currently say that. hence the original post: > [Vi]i[sual] > that seems an obvious mistake, as noted in the original post. That section of the manual is full of lies in multiple respe

Re: sysctl(3) or sysctl(2)?

Hi, Theo de Raadt wrote on Thu, Jan 11, 2018 at 08:48:32PM -0700: > Anthony Coulter wrote: >> /usr/src/lib/libc/gen/sysctl.3 >> Should it actually be in section 2? > It used to be wrapped in an odd way. > The manual page could now be renamed, We rarely do that, though. There are many edge case

Re: ksh: unused param in print_expansions()

Hi, Michael W. Bombardieri wrote on Thu, Jan 11, 2018 at 05:37:29PM +0800: > The local function print_expansions() is a wrapper for > x_print_expansions(). Going back to revision 1.1 of vi.c > reveals the command parameter wasn't used then either. Yes, this patch looks correct and works, and i f

Re: Bug in dd's args.c, invalid check for error

Hi, Bulat Musin wrote on Tue, Jan 02, 2018 at 09:47:39PM +0300: > /bin/dd/args.c r1.28 > get_off(char *val) > > num = strtoll(val, &expr, 0); > if (num == LLONG_MAX) /* Overflow. */ > err(1, "%s", oper); > > Incorrect checking of overflow. > Firstly,

Re: uniq: add -i option

Hi Theo, Theo Buehler wrote on Thu, Dec 21, 2017 at 11:57:12PM +0100: > Ingo Schwarze wrote: >> So i really don't feel like adding a BUGS section, but instead i >> think documenting that -i is intended as an ASCII-only feature is >> the way to go. > Yes, sounds rea

Re: uniq: add -i option

Hi Theo, Theo Buehler wrote on Thu, Dec 21, 2017 at 11:06:02AM +0100: > On Thu, Dec 21, 2017 at 01:50:37AM -0800, Claus Assmann wrote: >> On Fri, Dec 15, 2017, Todd C. Miller wrote: >>> On Fri, 15 Dec 2017 03:41:25 -0800, Claus Assmann wrote: I use uniq for some log file analysis and it cont

Re: wprintf.3: fix synopsis

Hi, kshe wrote on Thu, Nov 30, 2017 at 11:56:13PM +: > This adds a missing parameter name and makes whitespace more consistent > in the synopsis of wprintf(3). As a bonus, also link to this manual > from plain printf(3). Committed with tweaks, thanks. Ingo > Index: printf.3 > ==

Re: ksh(1): kill the "version" function

Hi Jeremie, Jeremie Courreges-Anglas wrote on Sun, Nov 26, 2017 at 07:27:37PM +0100: > Here's a diff to remove that function. OK schwarze@. > If people want to keep and > document it I would not object, but I don't really see the point. Indeed. It is part of a specific interactive module, so

Re: faster printf

Hi Theo, Theo de Raadt wrote on Fri, Nov 17, 2017 at 11:59:47AM -0700: > how should this work and what would be the best direction The following two aspects provide no clear guidance what is better: 1. Both printing invalid bytes (in particular to terminals) and losing information that was

Re: faster printf

Hi Theo, Theo de Raadt wrote on Fri, Nov 17, 2017 at 10:43:10AM -0700: > Ingo Schwarze wrote: >> I don't think, though, that the commit message should advertise >> this as a performance improvement. It should be called an intentional >> change of behaviour, now using t

Re: faster printf

Ingo Schwarze wrote on Fri, Nov 17, 2017 at 03:07:48PM +0100: [ regarding cases where this may matter in practice ] > (2) Programs legitimately calling *printf() with a variable format > string in any non-POSIX locale, even if it's just UTF-8. Whoa. I just realized ther

Re: faster printf

Hi Theo, Quick answer, more later: Theo de Raadt wrote on Thu, Nov 16, 2017 at 09:52:39AM -0700: > Todd Miller wrote: >> Also, POSIX isn't explicit as to whether that restriction applies >> to the format string or just the arguments to %lc and %ls conversions. >> >> What it does say is: >> >>

Re: faster printf

Hi Todd, Todd C. Miller wrote on Tue, Nov 14, 2017 at 09:09:13AM -0700: > On Tue, 14 Nov 2017 09:26:47 +0100, Theo Buehler wrote: >> If we only support UTF-8 and ASCII, we do not need complicated multibyte >> decoding to recognize a '%' in the format string. >> >> In his commit message, enh clai

Re: faster printf

Hi Theo, it's bad that i slacked on this, causing people to spend so much effort, but i failed to make up my mind at first. I think now i see clearly. Theo Buehler wrote on Tue, Nov 14, 2017 at 09:26:47AM +0100: > There is a simplification and optimization for __vfprintf() > from android pointed

Re: README patch

Hi, Andras Farkas wrote on Mon, Nov 13, 2017 at 06:21:26PM -0500: > On Mon, Nov 13, 2017 at 8:16 AM, Sebastian Benoit wrote: >> http://ftp.openbsd.org/pub/OpenBSD/6.2/README > Much more minor, It is now known that that file is outdated in a number of respects. However, it is not subject to ve

Re: mandoc warning tweak

Hi Jeremie, Jeremie Courreges-Anglas wrote on Fri, Nov 10, 2017 at 07:18:54PM +0100: > I hit this while reviewing a recent diff: > > ritchie /usr/src/usr.sbin/ospf6d$ mandoc -Tlint ospf6d.conf.5 > mandoc: ospf6d.conf.5:211:5: STYLE: typo in section name: \ > Sh AREAS instead of CAV

Re: README patch

Hi, Jason McIntyre wrote on Thu, Nov 09, 2017 at 07:26:32PM +: > On Wed, Nov 08, 2017 at 08:14:24PM -0600, Edgar Pettijohn wrote: >> --- README.orig 2017-11-08 20:11:47.091955000 -0600 >> +++ README 2017-11-08 20:12:19.787639000 -0600 >> @@ -49,8 +49,8 @@ >> >> No major funding or cos

Re: [patch] Remove superfluous seek_filesize() from less

Hi, On Sat, Sep 16, 2017 at 10:53:47PM +0200, Jesper Wallin wrote: > I was reading through the code for less/filename.c and noticed that the > calling for seek_filesize() in filesize() is superfluous? A wild guess > is that it's remains from when BAD_LSEEK was removed? There is more that is use

Re: rm exits 0

Hi, Jason McIntyre wrote on Fri, Oct 27, 2017 at 11:51:25AM +0100: > On Fri, Oct 27, 2017 at 11:42:30AM +0200, Jan Stary wrote: >> "rm exits 0" does not seem right (though I'm not a native speaker). > well it is clear, so i don;t see a problem. virtually every man page > with an EXIT STATUS sect

Re: dd: exit nonzero on receipt of SIGINT

Hi, Scott Cheloha wrote on Mon, Oct 23, 2017 at 09:01:04PM -0500: > Per this bit from POSIX on dd(1): >> For SIGINT, the dd utility shall interrupt its current processing, >> write status information to standard error, and exit as though >> terminated by SIGINT. It shall take the standard actio

Re: man pages for OpenBSD 6.2

Hi, Raf Czlonka wrote on Mon, Oct 16, 2017 at 08:04:00AM +0100: > Manual pages for OpenBSD 6.2 are not yet available on > https://man.openbsd.org/ > > I thought I'd mention it in case this has slipped your attention :^) Oh my... I ought to know by now that i have a job to do twice each year...

Re: [PATCH] innovations.html - use singular nop instead of plural nops

Hi Raf, Raf Czlonka wrote on Wed, Oct 11, 2017 at 01:20:15AM +0100: > As per the subject - nops sequences -> nop sequences. Done, thanks. Ingo > Index: innovations.html > === > RCS file: /cvs/www/innovations.html,v > retrieving

Re: [patch] hostname.if5 additional info on point to point addressing

Hi Tom, it is still completely unclear what you are even trying to talk about. The patch is certainly not acceptable, it is vague, highly confusing, and fails to state what it is all about. If what you are trying to document is the so-called "IP unnumbered" hack: That is an abomination brewed b

Re: document tar -vv

Hi Todd, Todd C. Miller wrote on Mon, Oct 09, 2017 at 09:35:44AM -0600: > On Mon, 09 Oct 2017 17:27:46 +0200, Ingo Schwarze wrote: >> Given that tar(1) is not even specified by POSIX, i don't see >> how documenting it might do harm. The option was introduced >> here:

document tar -vv

Hi, Philippe Meunier wrote on Mon, Oct 09, 2017 at 08:03:12AM -0400: > leo_...@volny.cz wrote: >> % tar cvvf - > On a related note, it would be nice if tar(1)'s man page indicated > that the -v option can be specified more than once to get extra > information. Until seeing this discussion threa

Re: typo in nl_langinfo.3

Hi Sebastien, Sebastien Marie wrote on Wed, Oct 04, 2017 at 01:31:12PM +0200: > There is a typo in nl_langinfo.3 man page: nl_langinfo -> nl_langinfo_l > for the locale_t version. Committed to -current after unlock. Thanks, Ingo > Index: nl_langinfo.3 > =

Re: typo in nl_langinfo.3

Hi, Sebastien Marie wrote on Wed, Oct 04, 2017 at 01:31:12PM +0200: > There is a typo in nl_langinfo.3 man page: nl_langinfo -> nl_langinfo_l > for the locale_t version. Please remind me if i forget to commit that within a few days after unlock. Right now, i think we are beyond the point in the

Re: vscsi.4, wsdisplay.4: add missing Dv tags to ioctl constants

Hi Scott, Scott Cheloha wrote on Mon, Sep 11, 2017 at 11:57:13PM -0500: > Constants without the Dv styling stick out quite a bit in a browser. > This patch adds them to the ioctl constants in vscsi.4 and the two > lone constants without them in wsdisplay.4. > > I also noticed that wsdisplay.4 is

Re: Open /dev/mem file failed when running as a root priviledge

Hi, moving from misc@ to tech@ because you found a documentation bug. Any OKs for the patch below? Ingo Nan Xiao wrote on Tue, Sep 12, 2017 at 08:58:25AM +0800: > I want to run dmidecode (https://github.com/mirror/dmidecode) on > OpenBSD 6.1, but executing it will report following errors: >

Re: [PATCH] pwd_mkdb.8 - fix wording

Hi Raf, Raf Czlonka wrote on Sat, Sep 09, 2017 at 10:03:03PM +0100: > I guess the two could be simplified further and combined into one Done, and i also fixed various other aspects while there. Yours, Ingo

Re: strtok_r(3): mention standards

Hi Jeremie, Jeremie Courreges-Anglas wrote on Mon, Aug 28, 2017 at 02:29:18PM +0200: > Also, mandoc -Tlint warns: > mandoc: strtok.3:90:2: STYLE: useless macro: Tn > s/Tn/Li/ ? No. The messages printed by mandoc -Tlint are terse, but the mandoc(1) manual is intended to provide enough detail t

Re: time(1): perror(3) -> err(3) and friends

Hi, Scott Cheloha wrote on Sun, Aug 20, 2017 at 05:17:55PM -0500: > Few weeks bump. Committed, thanks for the reminder. Ingo > Any feedback on this fabulous Scott Cheloha/ingo@ collaboration? > > Slightly re-tweaked patch below; while here: > > kill(getpid(), sig) -> raise(sig) > > I

Re: setvbuf.3: document possible allocation failure

Hi, Scott Cheloha wrote on Fri, Jul 28, 2017 at 08:33:16PM -0500: > Unlikely to happen during normal use, but setvbuf(3) can fail > to allocate your buffer: > > /* prog.c */ > #include > > int > main(int argc, char *argv[]) > { > if (setvbuf(stdout,

Re: [patch] Add -z and -Z to apmd for automatic suspend/hibernate

Whoa, and i promptly sent the wrong example. Here is the working one: schwarze@isnote $ cat /etc/sensorsd.conf hw.sensors.acpiac0.indicator0:low=1:command=/etc/sensorsd/acpiac %2 %3 %4 schwarze@isnote $ cat /etc/sensorsd/acpiac #!/bin/sh export XAUTHORITY=/home/schwarze/.Xauthority lo

Re: [patch] Add -z and -Z to apmd for automatic suspend/hibernate

Hi Ted, Ted Unangst wrote on Tue, Aug 15, 2017 at 07:42:39PM -0400: > Jesper Wallin wrote: >> On Sun, Aug 13, 2017 at 09:52:22AM +0200, Martijn van Duren wrote: >>> I've also been bitten by this a couple of times, but you can also solve >>> this via the sensorsd framework, which is how I've done

Re: sysctl machdep.lidaction=suspend

Hi Martin, Martin Natano wrote on Sat, Jul 29, 2017 at 08:45:05PM +0200: > On Sat, Jul 29, 2017 at 02:19:50PM +0200, Martin Natano wrote: >> On Sat, Jul 29, 2017 at 02:03:22PM +0200, Mark Kettenis wrote: >>> I don't think we want to add string parsing like this in the kernel. >>> Maybe the sysctl

Re: printf(3) return value on ENOMEM

Hi Theo, Theo de Raadt wrote on Wed, Jul 26, 2017 at 11:27:03PM -0600: > Ted Unangst wrote: >> returning -1 to indicate error, ignoring the possibility of short >> output, seems like the option that results in less damage. as an >> application author, it's the only behavior i can reasonably code

Re: printf(3) return value on ENOMEM

Hi Ted, Ted Unangst wrote on Thu, Jul 27, 2017 at 01:08:24AM -0400: > Ingo Schwarze wrote: >> So i say in all cases above, return -1, set ENOMEM, and it doesn't >> matter much whether anything is printed, except that asprintf(3) >> must of course free(3) any allocated m

Re: printf(3) return value on ENOMEM

Hi Theo, Theo de Raadt wrote on Wed, Jul 26, 2017 at 08:07:53AM -0600: > Ingo Schwarze wrote: >> The current behaviour of our implementation is to return the number >> of characters printed *and* set errno = ENOMEM. > I expect it should not set errno. As a general rule, errn

Re: printf(3) return value on ENOMEM

Hi, now we have conflicting and incomplete opinions. What should "prefix %.500f postfix", 1.0 and "%s %.500f %s", "prefix", 1.0, "postfix" do if the %f fails with ENOMEM? Currently, 1. [f]printf(..., "prefix %.500f postfix", 1.0) prints nothing, returns 7, sets ENOMEM

printf(3) return value on ENOMEM

Hi, what should printf(3) return on %e/%f/%g/%a malloc(3) failure? Neither POSIX nor our manual page seem fully conclusive. POSIX says: The fprintf() and printf() functions may fail if: [ENOMEM] Insufficient storage space is available. RETURN VALUE Upon successful completion, the fprin

Re: newsyslog: simplify mail sending

Hi Jeremie, Jeremie Courreges-Anglas wrote on Sat, Jul 22, 2017 at 09:27:29PM +0200: > I have nothing against asprintf(3), but the openmail function looks > needlessly complicated. > > ok? Looks like a nice simplification, works for me, and looks good to code inspection, so OK schwarze@. Yours

Re: make: clarify an error string

Hi Marc, Marc Espie wrote on Mon, Jul 24, 2017 at 01:02:12PM +0200: > On Mon, Jul 24, 2017 at 10:43:03AM +0200, Marc Espie wrote: >> On Mon, Jul 24, 2017 at 03:15:32PM +0800, Michael W. Bombardieri wrote: >>> In make(1), do_run_command() has a sanity check for a null command string. >>> The error

Re: make netstart a variable

Hi, Gregory Edigarov wrote on Mon, Jul 24, 2017 at 01:22:55PM +0300: > personally, I prefer using my short script, over the stock > /etc/netstart, so why not let everybody use what they prefer? Hell no. This is directly contrary to project goals. KISS. No useless knobs. That said, OpenBSD is

Re: [patch] Remove binc from vi(1)

Hi Martijn, On 06/22/17 21:32, Martijn van Duren wrote: > Attached a patch to remove the binc function from vi > and replace it with recallocarray. In principle, the memory handling in vi is very ugly, and getting it into a more standard form seems desirable - but likely to cause quite some work

Re: getdelim(3): perror -> err in example

Hi Jeremie, Jeremie Courreges-Anglas wrote on Sun, Jul 23, 2017 at 12:43:14AM +0200: > getline(3) and perror(3) are in posix, but fgetln(3) and err(3) come > from 4.4BSD (according to their manpage). We should probably keep the > example code posix-compliant. Paul Janzen asked me the same quest

Re: time(1): perror(3) -> err(3) and friends

Hi, Scott Cheloha wrote on Thu, Jul 13, 2017 at 07:30:26PM -0500: > We currently use a mix of perror(3) and err(3). > > In one case you can merge perror + exit into err, which is nice. > > The warns, though, are not equivalent (you get a "time: " prefix), > so maybe this is too risky. > > Putt

Re: time(1): make global flags local

Hi, Scott Cheloha wrote on Thu, Jul 13, 2017 at 07:14:08PM -0500: > The flags don't need to be global, and there are more obvious > ways to zero a variable. > > While here, order the stack structures and variables by size. Committed with tweaks. Ingo > Index: usr.bin/time/time.c > =

Re: style.9: discourage (void)ing unused return values

Hi Scott, Scott Cheloha wrote on Sat, Jul 22, 2017 at 11:27:17AM -0500: > Okay, going back and rereading, it appears he meant specifically to not > (void) stuff like printf or fprintf, e.g. > > (void)fprintf(stderr, "usage: prog [args]\n"); /* don't do this */ Even on printf(3), (void) m

Re: time(1): kill some lint-era voids, switch to getprogname(3)

Hi Scott, Scott Cheloha wrote on Thu, Jul 13, 2017 at 07:37:46PM -0500: > The (void) casts are going out of style. While here, > switch from __progname to getprogname(3) Committed. Ingo > Index: usr.bin/time/time.c > === > RCS

Re: style.9: discourage (void)ing unused return values

Hi Mark, Mark Kettenis wrote on Sat, Jul 22, 2017 at 04:11:03PM +0200: > int foo(void) __attribute__((warn_unused_result)); > > I think it would be good if you started using that > in our system headers for some functions. Sounds worth considering, ... > clang allows one to suppress the warni

Re: style.9: discourage (void)ing unused return values

Hi Scott, Scott Cheloha wrote on Fri, Jul 21, 2017 at 05:03:11PM -0500: > Per encouragement from deraadt@, Not sure what exactly he said, but i'm quite sure you misunderstood him. I have both removed and added (void) casts in the past. Removed from functions like close(3) where they are usuall

Re: Document hostctl commands for XenServer

Hi Mike, Mike Belopuhov wrote on Fri, Jul 21, 2017 at 07:08:06PM +0200: > Thanks for the detailed respose, I share your outlook and in > this case it is better to keep this stuff in the userland since > we actually can do it just fine. Fair enough! > I will however add some text to the > hostct

Re: Document hostctl commands for XenServer

Hi Mike, Mike Belopuhov wrote on Fri, Jul 21, 2017 at 03:14:08PM +0200: > Together with Maxim Khitrov we have figured out what needs to > be set for XenServer If XenServer were free software, i would say that the OpenBSD operating system should detect whether it is running under XenServer and th

Re: Remove accents from fortunes

Hi, Ted Unangst wrote on Tue, Jul 11, 2017 at 09:41:36AM -0400: > and it always sucks to lose information if somebody went to the > trouble of recording the necessary accents already. So here is a patch that makes putting UTF-8 characters into fortune/datfiles safe. Of course, we cannot protect

Re: Remove accents from fortunes

Hi Stuart, Stuart Henderson wrote on Tue, Jul 11, 2017 at 03:52:26PM +0100: > On 2017/07/11 16:19, Ingo Schwarze wrote: >> This decade feels like a strange point in time for degrading fortune >> and calendar files by replacing UTF-8 characters with ASCII >> transcriptio

Re: Remove accents from fortunes

Hi, Anthony J. Bentley wrote on Tue, Jul 11, 2017 at 02:58:08AM -0600: > "Ted Unangst" writes: >> do we want to delete them? or replace them with proper utf-8 sequences? > I wouldn't mind doing that. But fortune(6) will happily print UTF-8 to a > non-UTF-8 terminal, which though probably harmles

Re: cwm: remove ssh auto-completion

Hi, Bryan Steele wrote on Mon, Jul 10, 2017 at 09:38:32AM -0400: > This was a feature added last year by nicm@, not touching emacs.c > at all.. edit.c is a helper file containing common utilities for emacs.c and vi.c. So it is also misdocumented. It is only documented for emacs mode, but vi mo

Re: cwm: remove ssh auto-completion

Hi, Bryan Steele wrote on Mon, Jul 10, 2017 at 08:21:19AM -0400: > Instead of relying on the window manager, why not add it to your > shell? > > https://deftly.net/posts/2017-05-01-openbsd-ksh-tab-complete.html > > set -A complete_ssh $(awk '!/\*/ && /^Host /{print $2}' ~/.ssh/config) > > I'

Re: [PATCH] clarify history of htpasswd(1) in its manpage

Hi Raf, Raf Czlonka wrote on Fri, Jul 07, 2017 at 03:30:41AM +0100: > Just gone through htpasswd(1)'s man page and noticed this > in the AUTHORS section: > > Florian Obser implemented htpasswd > from scratch after httpd was removed from OpenBSD base. > > To those not familiar with

Re: [patch] mg: fix overflow on vteeol()

Hi, Hiltjo Posthuma wrote on Sun, Jun 18, 2017 at 03:04:31PM +0200: > mg crashes with certain (unicode) characters and moving the cursor to the > end of the line. Even though i failed to reproduce the crash, even with MALLOC_OPTIONS=S, i see how it may happen. Your analysis looks at the right f

Re: swab: Swap bytes directly, simplify

Hi Klemens, Klemens Nanni wrote on Wed, Jul 05, 2017 at 05:44:42PM +0200: > On Wed, Jul 05, 2017 at 05:27:18PM +0200, Ingo Schwarze wrote: >> No need to fix it because the patch is not likely to go anywhere, >> but once again you mangled the patch such that it won't even ap

Re: swab: Swap bytes directly, simplify

Hi Klemens, Klemens Nanni wrote on Wed, Jul 05, 2017 at 05:02:05PM +0200: > No need for buffers t0, t1 here. Your patch changes behaviour in some cases where the buffers do overlap. For example, if src == dst, right now, the code swaps bytes. With your patch, i'm not sure it is even determinis

Re: file: replace fgetln with getline(3)

Hi Nic, Nicholas Marriott wrote on Sun, Jul 02, 2017 at 08:48:28AM +0100: > Possibly fgetln(3) CAVEATS could benefit from some of what you have > written here, although it is all in the manual already just in several > places. Inspecting the manual page again, i don't think it needs longer text.

Re: file: replace fgetln with getline(3)

Hi, Nicholas Marriott wrote on Sat, Jul 01, 2017 at 09:48:08PM +0100: > Safer how? 1. fgetln(3) returns a char array that is not NUL-terminated. That is prone to buffer overrun bugs in general. getline(3) always returns proper NUL-terminated C strings. 2. The array returned from fget

Re: tweak {event,evtimer,signal}_pending manpage

Hi David, David Gwynne wrote on Tue, Jun 27, 2017 at 11:55:43AM +1000: > the timeval argument is not const. esp since thats how the remaining > time is provided to the caller. Right, event_pending(..., tv) calls timeradd(..., tv), see timeradd(2), so OK schwarze@ FWIW. Yours, Ingo > Index:

Re: [PATCH] rm(1): add -v option for verbosity

Hi, Paul de Weerd wrote on Sun, Jun 25, 2017 at 10:46:15PM +0200: > On Sun, Jun 25, 2017 at 03:12:26PM +0200, Ingo Schwarze wrote: > | If you are really unsure, study the output of > | $ find * > | first, before typing > | $ rm -rf * > | No non-standard option is need

Re: [diffs] libcrypto: minor man page fix & question about odd function types

Hi, Jack Burton wrote on Wed, Jun 21, 2017 at 11:45:38PM +0930: > X509_VERIFY_PARAM_set_flags(3) states that > X509_VERIFY_PARAM_set_flags() and X509_VERIFY_PARAM_clear_flags() > both "return 1 for success or 0 for failure". Which is true. > But both those functions always return 1 In the curr

Re: [PATCH] rm(1): add -v option for verbosity

Hi, Job Snijders wrote on Sun, Jun 25, 2017 at 02:06:16PM +0200: > This patch adds a '-v' option to rm(1) for more verbose output. Do not add new options to standard utilities, unless you can show that they are unusually useful in practice *and* practically every other system out there has them,

Re: mdoc(7): .St for latest POSIX

Hi Jason, Jason McIntyre wrote on Fri, Jun 23, 2017 at 06:24:17PM +0100: > yes, i'm fine with removing it. Good, i'll commit it unless i hear objections. > i hate to say it, but i think it was you who added it! RCS file: /cvs/src/usr.bin/mandoc/st.in,v revision 1.17 date: 2013/12/30 09:47:43;

Re: mdoc(7): .St for latest POSIX

Hi Jason, Jason McIntyre wrote on Thu, Jun 22, 2017 at 02:07:51PM +0100: > so do you want to remove the entry for 1003.1-2013 as well? > none of our man pages use it. The decisive point is that even current groff does not support it, so deleting it is unlikely to break other's pages. OK? Ingo

Re: mdoc(7): .St for latest POSIX

Hi Anthony, Anthony J. Bentley wrote on Thu, Jun 22, 2017 at 12:21:55AM -0600: > ok? NO, definitely NOT OK without a thorough rationale. We do not add definitions just like that. The file st.in has lots of irrelevant definitions already, and i won't let that trend continue. If i remember corr

<    1   2   3   4   5   6   7   8   9   10   >