Re: [tools-discuss] code review: parallelized wsdiff

2010-07-21 Thread Vladimir Kotal
Ali Bahrami wrote: I had almost finished typing a reply very much like the above. elfdump encapsulates a lot of ELF knowledge, and might be harder to replace than it seems on the surface. I'd like to know how long wsdiff takes to run, and how much of It's hard to tell in general. For exa

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-21 Thread Vladimir Kotal
Rod Evans wrote: On 7/21/10 12:45 AM, Vladimir Kotal wrote: Perhaps the wsdiff maintainers have an idea of what would make their life easier? Dunno who is wsdiff maintainer but I think in terms of performance the ultimate solution (although a bit of a overkill) would be to avoid the fork()+e

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-21 Thread Rod Evans
On 7/21/10 12:45 AM, Vladimir Kotal wrote: Perhaps the wsdiff maintainers have an idea of what would make their life easier? Dunno who is wsdiff maintainer but I think in terms of performance the ultimate solution (although a bit of a overkill) would be to avoid the fork()+exec(elfdump) comple

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-21 Thread Rod Evans
On 07/20/10 08:28 AM, Ali Bahrami wrote: We're also open to ideas for elfdump to make it more wsdiff-friendly. I'm guessing that the cost of a single invocation of elfdump isn't the bottleneck when compared to the cost of running it multiple times. Do you have a sense of how bad elfdump's overhe

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-21 Thread Ali Bahrami
On 07/21/10 09:26, Rod Evans wrote: On 7/21/10 12:45 AM, Vladimir Kotal wrote: Perhaps the wsdiff maintainers have an idea of what would make their life easier? Dunno who is wsdiff maintainer but I think in terms of performance the ultimate solution (although a bit of a overkill) would be to

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-21 Thread Vladimir Kotal
Rod Evans wrote: That's a lot of interesting comments. Side note: I think think the dump+elfdump combo is used to provide more robust diff detection (to prevent a case where the actual difference gets lost thanks to an error in elfdump pretty printing functions) and also to push the complex

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-20 Thread Ali Bahrami
James C. McPherson wrote: On 20/07/10 05:28 PM, Shawn Walker wrote: ... There's some code pkg(5) uses for limited elf analysis in the pkg(5) gate that is designed to interface with python: http://src.opensolaris.org/source/xref/pkg/gate/src/modules/elf.c http://src.opensolaris.org/source/xref/p

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-20 Thread Vladimir Kotal
On 07/20/10 09:28 AM, Shawn Walker wrote: There's some code pkg(5) uses for limited elf analysis in the pkg(5) gate that is designed to interface with python: http://src.opensolaris.org/source/xref/pkg/gate/src/modules/elf.c http://src.opensolaris.org/source/xref/pkg/gate/src/modules/elfextra

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-20 Thread James C. McPherson
On 20/07/10 05:28 PM, Shawn Walker wrote: ... There's some code pkg(5) uses for limited elf analysis in the pkg(5) gate that is designed to interface with python: http://src.opensolaris.org/source/xref/pkg/gate/src/modules/elf.c http://src.opensolaris.org/source/xref/pkg/gate/src/modules/elfextr

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-20 Thread Vladimir Kotal
On 07/20/10 06:38 AM, James C. McPherson wrote: I found a library to do it (http://sourceforge.net/projects/python-elf) but it's pre-alpha, GPLv3 and the path to using such a thing under our new overlords is murky. Besides licensing problems there is also a potential problem (albeit smallis

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-20 Thread Shawn Walker
On 07/19/10 09:47 PM, James C. McPherson wrote: On 20/07/10 02:38 PM, James C. McPherson wrote: ... (d) have you had a crack at making the calls to elfdump an internal implementation? You mean there is a Python library which implements the elfdump functionality ? Can you point me to it ? I f

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-19 Thread James C. McPherson
On 20/07/10 02:38 PM, James C. McPherson wrote: ... (d) have you had a crack at making the calls to elfdump an internal implementation? You mean there is a Python library which implements the elfdump functionality ? Can you point me to it ? I found a library to do it (http://sourceforge.net/p

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-19 Thread James C. McPherson
On 20/07/10 01:38 AM, Vladimir Kotal wrote: On 07/16/10 03:06 AM, James C. McPherson wrote: (a) please add timestamps to the wsdiff section in nightly.sh so we know how long it's taking added. Thanks (b) how long does this take on a full debug+nondebug build? Depends on the machine an

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-19 Thread Vladimir Kotal
On 07/16/10 03:06 AM, James C. McPherson wrote: (a) please add timestamps to the wsdiff section in nightly.sh so we know how long it's taking added. (b) how long does this take on a full debug+nondebug build? Depends on the machine and the nature of the changes. The speedup observed dur

Re: [tools-discuss] code review: parallelized wsdiff

2010-07-15 Thread James C. McPherson
On 16/07/10 02:02 AM, Vladimir Kotal wrote: This has been sitting in my workspace for a long time (after doing initial round of code review with Danek and Eric) and it generally works nicely so I'd like to get another chance to finish this. The idea of the changes is simple - convert wsdiff to