lgtm
https://codereview.chromium.org/1185633002/diff/20001/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/1185633002/diff/20001/src/ast.cc#newcode544
src/ast.cc:544: HandleScope scope(isolate);
Please add comment explaining why this can't be moved to the top of the
for()
Committed patchset #1 (id:1)
https://codereview.chromium.org/1183123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/d19410f8e7237240ea870652d32f7147b8873822
Cr-Commit-Position: refs/heads/master@{#29018}
https://codereview.chromium.org/1183123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm
https://codereview.chromium.org/1185703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1187533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/ed977c972ee243b8fe4dc152fc42e0113725014d
Cr-Commit-Position: refs/heads/master@{#29019}
https://codereview.chromium.org/1187533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm
https://codereview.chromium.org/1191433003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1182193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Sven Panne,
Description:
[mjsunit] Remove unsupported flag --turbo-deoptimization from tests.
R=svenpa...@chromium.org
Please review this at https://codereview.chromium.org/1183123002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+18, -43 lines):
Reviewers: Igor Sheludko,
Description:
[mjsunit] regress/regress-crbug-491062 takes too long with --always-opt.
R=ish...@chromium.org
Please review this at https://codereview.chromium.org/1183133002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
Patchset 1 (id:??) landed as
https://crrev.com/2cde7dc82e2845084da949fb3707e7499a30a811
Cr-Commit-Position: refs/heads/master@{#29021}
https://codereview.chromium.org/1183133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
For your description /s/not urgent/non-urgent/.
Also, you say you can post clean up work such as idle-time GC as delayed
work,
however you shouldn't do this as it isn't guaranteed that the browser will
be
idle when the delayed work becomes runnable. What you would need to do is
post a
Reviewers: danno, Sven Panne, Michael Achenbach, martyn.capewell, Jakob,
paul.l..., dusmil.imgtec, akos.palfi,
Message:
This does need a v8-team review on a standlone.gypi (was LGTMed earlier). We
removed the mac related parts and plan to make a followup CL for mac. PTAL
Description:
MIPS64:
Reviewers: arv, rossberg, Michael Starzinger,
Message:
Created Revert of Fix clobbered register when setting this_function
variable.
Description:
Revert of Fix clobbered register when setting this_function variable.
(patchset
#2 id:20001 of https://codereview.chromium.org/1185703002/)
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1184093003/ by machenb...@chromium.org.
The reason for reverting is: [Sheriff] Makes mjsunit/es6/block-const-assign
flaky, e.g.:
http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/4082.
https://codereview.chromium.org/1182303004/diff/1/src/macros.py
File src/macros.py (right):
https://codereview.chromium.org/1182303004/diff/1/src/macros.py#newcode163
src/macros.py:163: # itself (it should really use %GetOwnProperty, but
that would be way slower).
Is this comment still needed?
Hey Sven,
The --turbo-deoptimization flag was removed some time ago (and
deoptimization is
now enabled by default, except for asm.js). Fix the test files to reflect
this
change.
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1183123002/
--
--
v8-dev mailing list
Patchset 2 (id:??) landed as
https://crrev.com/bf2bbc8ba508ccd21edf3c08d2e4192c4764ae91
Cr-Commit-Position: refs/heads/master@{#29020}
https://codereview.chromium.org/1185703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1185703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/1181013007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM (not that this does anything :P)
https://codereview.chromium.org/1180943007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group
non-TF changes LGTM.
https://codereview.chromium.org/1178363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1186713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1186713003/1
https://codereview.chromium.org/1186713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Hey Igor,
Deslowify the regression test. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1183133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
lgtm
https://codereview.chromium.org/1183133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1183133002/1
https://codereview.chromium.org/1183133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Updates:
Status: WontFix
Comment #1 on issue 4186 by jkumme...@chromium.org: V8 Python bindings
https://code.google.com/p/v8/issues/detail?id=4186
I think maintaining Python bindings is out of scope for the core V8 project.
Of course you are free to maintain such bindings yourself,
LGTM. Thanks!
https://codereview.chromium.org/1177033006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1177033006/1
https://codereview.chromium.org/1177033006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #1 (id:1)
https://codereview.chromium.org/1191433003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Committed patchset #1 (id:1)
https://codereview.chromium.org/1183133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: Jakob,
Description:
Fix -Wsign-compare errors in TF tests under GCC 4.9.2
R=jkumme...@chromium.org
LOG=N
BUG=
Please review this at https://codereview.chromium.org/1191433003/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected files (+5, -5 lines):
M
Status: Untriaged
Owner:
New issue 4186 by angelo.d...@gmail.com: V8 Python bindings
https://code.google.com/p/v8/issues/detail?id=4186
Hello,
I am a member of the Honeynet Project and the main developer of Thug, a
Python low-interaction honeyclient aimed at mimicking the behavior of a
On 2015/03/16 09:49:35, commit-bot: I haz the power wrote:
Patchset 1 (id:??) landed as
https://crrev.com/f92c8a36709efb1514846b3bb672c40e4fb4c672
Cr-Commit-Position: refs/heads/master@{#27208}
When removing deprecated functions in future, please add in the description
what
should be used
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1182193004/1
https://codereview.chromium.org/1182193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 1 (id:??) landed as
https://crrev.com/06ac599d1ed7c3f309d74686eefdedfca6decf73
Cr-Commit-Position: refs/heads/master@{#29022}
https://codereview.chromium.org/1184093003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1184093003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1184093003/1
https://codereview.chromium.org/1184093003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/1180943007/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1180943007/diff/1/src/parser.cc#newcode2566
src/parser.cc:2566: if ((FLAG_strong_this || peek() != Token::THIS)
On 2015/06/12 15:01:34, conradw wrote:
Could the peek()
Committed patchset #1 (id:1)
https://codereview.chromium.org/1186713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: rossberg,
Message:
WDYT? Given that the previously-specified private symbols were junked
due to
leaking their keys to proxies, it seems OK to re-appropriate the
name private
internally to mean private-own symbols.
Description:
All private symbols are own symbols
lgtm
https://codereview.chromium.org/1180943007/diff/20001/src/preparser.cc
File src/preparser.cc (right):
https://codereview.chromium.org/1180943007/diff/20001/src/preparser.cc#newcode602
src/preparser.cc:602: if (!FLAG_strong_this) break;
Please add:
// Fall through.
On 2015/06/15 11:44:15, ulan wrote:
On 2015/03/16 09:49:35, commit-bot: I haz the power wrote:
Patchset 1 (id:??) landed as
https://crrev.com/f92c8a36709efb1514846b3bb672c40e4fb4c672
Cr-Commit-Position: refs/heads/master@{#27208}
When removing deprecated functions in future, please add in
Patchset 1 (id:??) landed as
https://crrev.com/9efb230d367b48873a52bd701b90a49276c1cef5
Cr-Commit-Position: refs/heads/master@{#29023}
https://codereview.chromium.org/1191433003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #16 on issue 3340 by rossb...@chromium.org: Expose ES6 Map/Set
through the V8 API
https://code.google.com/p/v8/issues/detail?id=3340
I'd suggest adding the complete set of basic primitives (get, set, has,
delete), but nothing more high-level.
--
You received this message because
lgtm
https://codereview.chromium.org/1183123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1185703002/20001
https://codereview.chromium.org/1185703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1180943007/40001
https://codereview.chromium.org/1180943007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Comment #2 on issue 4186 by angelo.d...@gmail.com: V8 Python bindings
https://code.google.com/p/v8/issues/detail?id=4186
Ok, I thought there could be an interest for the V8 dev team in officially
supporting bindings for different languages in order to increase the
adoption of the engine in
Committed patchset #1 (id:1)
https://codereview.chromium.org/1182193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/a12f11911255806d76c016d8332b9b950759c4f9
Cr-Commit-Position: refs/heads/master@{#29024}
https://codereview.chromium.org/1182193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: Sven Panne,
Description:
[mjsunit] Remove obsolete nosse2 tests.
R=svenpa...@chromium.org
Please review this at https://codereview.chromium.org/1186713003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -883 lines):
D
Hey Sven,
Those tests are useless these days. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1186713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Updates:
Status: Fixed
Comment #4 on issue 4179 by yang...@chromium.org: clear string hash on
serialization
https://code.google.com/p/v8/issues/detail?id=4179
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
Patchset 1 (id:??) landed as
https://crrev.com/e30b351d7b2f8874a314956e61c6aacb94a4c32e
Cr-Commit-Position: refs/heads/master@{#29017}
https://codereview.chromium.org/1186713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1183123002/1
https://codereview.chromium.org/1183123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
LGTM.
https://codereview.chromium.org/1187533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1187533002/40001
https://codereview.chromium.org/1187533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1184723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1191433003/1
https://codereview.chromium.org/1191433003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1181013007/1
https://codereview.chromium.org/1181013007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1184723002/1
https://codereview.chromium.org/1184723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Michael Starzinger,
Description:
[turbofan] Remove context canonicalization hack from generic lowering.
This hack doesn't help currently, since it only applies to asm.js where
we do function context specialization and there we already have a
canonicalized context (and the
Hey Michi,
Removing another (now) useless hack. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1177033006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Try jobs failed on following builders:
v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/3602)
https://codereview.chromium.org/1181013007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Hey Michi,
Some more dehackification; this makes the direct call optimization less
adhoc,
so that it can apply in more situations. Also it should really be part of
typed
lowering, since it's based on types.
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1182193005/
Comment #47 on issue 3956 by bugdro...@chromium.org: Implement strong mode
https://code.google.com/p/v8/issues/detail?id=3956#c47
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/982b46aeb79e2fb8008040f98b6ae3437a1ef5ce
commit
Patchset 3 (id:??) landed as
https://crrev.com/982b46aeb79e2fb8008040f98b6ae3437a1ef5ce
Cr-Commit-Position: refs/heads/master@{#29026}
https://codereview.chromium.org/1180943007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Thanks! Revised code per comments. Had to shift handle thresholds to be
able to
get tests to fail if scopes not present which must be due to changes lower
down.
https://codereview.chromium.org/1185633002/diff/20001/src/ast.cc
File src/ast.cc (right):
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1180943007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/d06591a2a3bc9643aa5785e1f8c01bd820b7c36a
Cr-Commit-Position: refs/heads/master@{#29025}
https://codereview.chromium.org/1177033006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1177033006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Committed patchset #1 (id:1)
https://codereview.chromium.org/1182193005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/6e5b9ffe4c4691570835607a99bc979f0e7cf3fc
Cr-Commit-Position: refs/heads/master@{#29028}
https://codereview.chromium.org/1182193005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1184723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/3938956bdc34b75b6478fa7afd0cae68bedff291
Cr-Commit-Position: refs/heads/master@{#29027}
https://codereview.chromium.org/1184723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
+1, anything else doesn't seem to make sense
https://codereview.chromium.org/1182303004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
LGTM. Love it.
https://codereview.chromium.org/1182193005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1182193005/1
https://codereview.chromium.org/1182193005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Michael Starzinger,
Description:
[turbofan] Remove the TryLowerDirectJSCall hack from generic lowering.
The TryLowerDirectJSCall method tried to lower to a direct JavaScript
function call depending on the type of the receiver, but only if the
target is a cosntant JSFunction. Since
This is ready for review.
https://codereview.chromium.org/1167393005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
LGTM
https://codereview.chromium.org/1167393005/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1167393005/diff/20001/src/parser.cc#newcode1187
src/parser.cc:1187: BlockState block_state(scope_, scope);
Why was this block state added? It does not seem like
For your description /s/not urgent/non-urgent/.
Done.
Also, you say you can post clean up work such as idle-time GC as delayed
work,
however you shouldn't do this as it isn't guaranteed that the browser
will be
idle when the delayed work becomes runnable. What you would need to do is
post
LGTM
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js#newcode138
src/typedarray.js:138: var newIterable = {__proto__: null};
var newIterable = {
__proto__: null,
Reviewers: Benedikt Meurer,
Message:
Dead code is being dead. Feel free to CQ.
Description:
[turbofan] Remove dead code from JSGenericLowering.
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/1186573004/
Base URL:
Reviewers: Hannes Payer,
Description:
Introduce a base pointer field in FixedTypedArrayBase and teach GC about it
BUG=v8:3996
R=hpa...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/1176263004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected
Looks good.
Since this now affects src/heap/*, putting heap owner hpayer@ as reviewer.
I'll
be happy with whatever he recommends.
https://codereview.chromium.org/1155043005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
LGTM, just nits.
https://codereview.chromium.org/1178363002/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1178363002/diff/20001/src/compiler/ast-graph-builder.cc#newcode1355
src/compiler/ast-graph-builder.cc:1355:
+1
Non own private is not useful. (We could always add it back if we ever
needed it.)
On Mon, Jun 15, 2015 at 8:54 AM, verwa...@chromium.org wrote:
+1, anything else doesn't seem to make sense
https://codereview.chromium.org/1182303004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Hello, Danno Titizer.
PTAL.
thanks.
https://codereview.chromium.org/1179763004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group
Committed patchset #1 (id:1)
https://codereview.chromium.org/1180113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/50be4425154a916d54b21b505aa35f77ccf6d8ba
Cr-Commit-Position: refs/heads/master@{#29012}
https://codereview.chromium.org/1180113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Hey Jaro,
This is the performance fix for speedometer. Basically reverts the
previoius
change to use TranslatedState and friends, with some refactoring. Please
take a
look.
Thanks,
Benedikt
https://codereview.chromium.org/1181373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
However, it would be nice to know whether it was GetFunctions or Summarize
that
tanked the benchmarks - my feeling is that Summarize could (and should)
still
use the TranslatedState utility.
Speedometer is too flaky to tell for sure. But it seems like we need both,
because Summarize is used
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1181373003/1
https://codereview.chromium.org/1181373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Status: Available
Owner:
CC: little...@chromium.org, yang...@chromium.org, rossb...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 4188 by ad...@chromium.org: Variable lookup in case expression in
builtin JS fails when it shouldn't
Patchset 1 (id:??) landed as
https://crrev.com/88b0786bc86e20ca7d546451b22171b0cea6dc2d
Cr-Commit-Position: refs/heads/master@{#29035}
https://codereview.chromium.org/1187073008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1187073008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm.
However, it would be nice to know whether it was GetFunctions or Summarize
that
tanked the benchmarks - my feeling is that Summarize could (and should)
still
use the TranslatedState utility.
https://codereview.chromium.org/1181373003/
--
--
v8-dev mailing list
1 - 100 of 201 matches
Mail list logo
