[v8-dev] Re: Issue 4357 in v8: mjsunit/harmony/futex is flaky on win nosnap shared

2015-08-06 Thread codesite-noreply via v8-dev
Comment #6 on issue 4357 by bi...@chromium.org: mjsunit/harmony/futex is flaky on win nosnap shared https://code.google.com/p/v8/issues/detail?id=4357 Yeah, I noticed the same problem after I sent this CL to you. I think I should be using base::TimeTicks::Now instead; it is defined to be

[v8-dev] Re: test262 roll (issue 1268553003 by little...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268553003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268553003/160001 https://codereview.chromium.org/1268553003/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Issue 4163 in v8: Construct on generator functions

2015-08-06 Thread codesite-noreply via v8-dev
Updates: Cc: ad...@chromium.org Comment #5 on issue 4163 by ad...@chromium.org: Construct on generator functions https://code.google.com/p/v8/issues/detail?id=4163 Note that this changed _again_: In the most recent meeting, the conclusion was to throw on [[Construct]] for both

[v8-dev] Re: V8: Add SIMD functions. (issue 1230343003 by bbu...@chromium.org)

2015-08-06 Thread littledan
lgtm https://codereview.chromium.org/1230343003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: V8: Add SIMD functions. (issue 1230343003 by bbu...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 4 (id:??) landed as https://crrev.com/6378f57b30f1141850ef7c260972ae109450b023 Cr-Commit-Position: refs/heads/master@{#30051} https://codereview.chromium.org/1230343003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: V8: Add SIMD functions. (issue 1230343003 by bbu...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #4 (id:180001) https://codereview.chromium.org/1230343003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Issue 4124 in v8: Implement SIMD.js

2015-08-06 Thread codesite-noreply via v8-dev
Comment #32 on issue 4124 by bugdro...@chromium.org: Implement SIMD.js https://code.google.com/p/v8/issues/detail?id=4124#c32 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6378f57b30f1141850ef7c260972ae109450b023 commit

[v8-dev] Re: [es6] Use strict arguments objects for destructured parameters (issue 1278783002 by rossb...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/8364) https://codereview.chromium.org/1278783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] [runtime] Simplify TO_INT32/TO_UINT32 abstract operations. (issue 1275013004 by bmeu...@chromium.org)

2015-08-06 Thread bmeurer
Reviewers: Yang, Message: Hey Yang, This is trivial cleanup. Please take a look. Thanks, Benedikt Description: [runtime] Simplify TO_INT32/TO_UINT32 abstract operations. No need to provide TO_INT32/TO_UINT32 functions for every native context, as they can be implemented in terms of TO_NUMBER

[v8-dev] Re: Issue 4271 in v8: Fatal error in v8::Object::GetInternalField

2015-08-06 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Comment #8 on issue 4271 by ad...@chromium.org: Fatal error in v8::Object::GetInternalField https://code.google.com/p/v8/issues/detail?id=4271 (No comment was entered for this change.) -- You received this message because this project is configured to send all

[v8-dev] Issue 4362 in v8: Minor: String.prototype.repeat supports ''.repeat(any integer)

2015-08-06 Thread codesite-noreply via v8-dev
Status: Available Owner: Labels: Type-Bug Priority-Low Harmony New issue 4362 by little...@chromium.org: Minor: String.prototype.repeat supports ''.repeat(any integer) https://code.google.com/p/v8/issues/detail?id=4362 In the spec, the only range checks for the count argument for repeat

[v8-dev] Re: test262 roll (issue 1268553003 by little...@chromium.org)

2015-08-06 Thread adamk
lgtm https://codereview.chromium.org/1268553003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: V8: Add SIMD functions. (issue 1230343003 by bbu...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230343003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1230343003/180001 https://codereview.chromium.org/1230343003/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] [test] Make test filters platform-independent. (issue 1281453003 by machenb...@chromium.org)

2015-08-06 Thread machenbach
Reviewers: Jakob, Message: PTAL Description: [test] Make test filters platform-independent. Use the same path separator for test cases on the cmd-line on all platforms as in testcase.GetLabel, which is used to report failures. BUG=chromium:511215 LOG=n NOTRY=true Please review this at

[v8-dev] Re: [test] Make test filters platform-independent. (issue 1281453003 by machenb...@chromium.org)

2015-08-06 Thread jkummerow
LGTM!111eleven https://codereview.chromium.org/1281453003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Fix idle step marking after 9d7ebc. (issue 1275573002 by u...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275573002/20001 https://codereview.chromium.org/1275573002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Fix off-by-one in Array.concat's max index check (issue 1278703003 by jkumme...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/087ae1b08aeda52c8add565b2a53e813a477a6ff Cr-Commit-Position: refs/heads/master@{#30040} https://codereview.chromium.org/1278703003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [GC] Fix regression in 517195 (issue 1274983002 by mlippa...@chromium.org)

2015-08-06 Thread mlippautz
https://codereview.chromium.org/1274983002/diff/40001/test/mjsunit/regress/regress-517195.js File test/mjsunit/regress/regress-517195.js (right): https://codereview.chromium.org/1274983002/diff/40001/test/mjsunit/regress/regress-517195.js#newcode5 test/mjsunit/regress/regress-517195.js:5: //

[v8-dev] Re: [GC] Fix regression in 517195 (issue 1274983002 by mlippa...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274983002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274983002/60001 https://codereview.chromium.org/1274983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [GC] Fix regression in 517195 (issue 1274983002 by mlippa...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/8419) https://codereview.chromium.org/1274983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: Issue 1569 in v8: Implement Harmony Modules

2015-08-06 Thread codesite-noreply via v8-dev
Comment #27 on issue 1569 by aneesiqb...@gmail.com: Implement Harmony Modules https://code.google.com/p/v8/issues/detail?id=1569 A friendly bump. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your

[v8-dev] Re: Try turning object-observe test back on in gc-stress (issue 1272193004 by ad...@chromium.org)

2015-08-06 Thread vogelheim
lgtm https://codereview.chromium.org/1272193004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Fix off-by-one in Array.concat's max index check (issue 1278703003 by jkumme...@chromium.org)

2015-08-06 Thread jkummerow
Reviewers: Yang, Description: Fix off-by-one in Array.concat's max index check The maximum valid index is strictly smaller than the maximum valid length. BUG=chromium:516592 LOG=y R=yang...@chromium.org Please review this at https://codereview.chromium.org/1278703003/ Base URL:

[v8-dev] Re: Fix off-by-one in Array.concat's max index check (issue 1278703003 by jkumme...@chromium.org)

2015-08-06 Thread yangguo
On 2015/08/06 09:06:04, Jakob wrote: lgtm https://codereview.chromium.org/1278703003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] Re: Fix off-by-one in Array.concat's max index check (issue 1278703003 by jkumme...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278703003/1 https://codereview.chromium.org/1278703003/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [GC] Fix regression in 517195 (issue 1274983002 by mlippa...@chromium.org)

2015-08-06 Thread hpayer
https://codereview.chromium.org/1274983002/diff/40001/test/mjsunit/regress/regress-517195.js File test/mjsunit/regress/regress-517195.js (right): https://codereview.chromium.org/1274983002/diff/40001/test/mjsunit/regress/regress-517195.js#newcode5 test/mjsunit/regress/regress-517195.js:5: //

[v8-dev] Re: Fix Array.prototype.concat for arguments object with getter. (issue 1270403002 by yang...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270403002/40001 https://codereview.chromium.org/1270403002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Fix idle step marking after 9d7ebc. (issue 1275573002 by u...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/da97af0d016aa69b78551de6b953f0624e8d6792 Cr-Commit-Position: refs/heads/master@{#30041} https://codereview.chromium.org/1275573002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Fix idle step marking after 9d7ebc. (issue 1275573002 by u...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1275573002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Fix Array.prototype.concat for arguments object with getter. (issue 1270403002 by yang...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #3 (id:40001) https://codereview.chromium.org/1270403002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Fix Array.prototype.concat for arguments object with getter. (issue 1270403002 by yang...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/2e0d55a5b9a31296956d029896e6d47a8c1605c9 Cr-Commit-Position: refs/heads/master@{#30042} https://codereview.chromium.org/1270403002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [GC] Fix regression in 517195 (issue 1274983002 by mlippa...@chromium.org)

2015-08-06 Thread mlippautz
PTAL Switched to hand-knitted cctest since JS test ran oom on a win bot. https://codereview.chromium.org/1274983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] Re: [GC] Fix regression in 517195 (issue 1274983002 by mlippa...@chromium.org)

2015-08-06 Thread hpayer
https://codereview.chromium.org/1274983002/diff/20001/test/mjsunit/regress/regress-517195.js File test/mjsunit/regress/regress-517195.js (right): https://codereview.chromium.org/1274983002/diff/20001/test/mjsunit/regress/regress-517195.js#newcode7 test/mjsunit/regress/regress-517195.js:7: //

[v8-dev] Re: [GC] Fix regression in 517195 (issue 1274983002 by mlippa...@chromium.org)

2015-08-06 Thread mlippautz
https://codereview.chromium.org/1274983002/diff/20001/test/mjsunit/regress/regress-517195.js File test/mjsunit/regress/regress-517195.js (right): https://codereview.chromium.org/1274983002/diff/20001/test/mjsunit/regress/regress-517195.js#newcode7 test/mjsunit/regress/regress-517195.js:7: //

[v8-dev] Re: Fix off-by-one in Array.concat's max index check (issue 1278703003 by jkumme...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1278703003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

Re: [v8-dev] Re: Ensure `String.prototype.normalize.length` is `0` (issue 1274653002 by math...@qiwi.be)

2015-08-06 Thread 'Andreas Rossberg' via v8-dev
On 5 August 2015 at 22:18, Adam Klein ad...@chromium.org wrote: On Wed, Aug 5, 2015 at 7:23 AM, rossb...@chromium.org wrote: https://codereview.chromium.org/1274653002/diff/1/src/i18n.js File src/i18n.js (right): https://codereview.chromium.org/1274653002/diff/1/src/i18n.js#newcode2019

[v8-dev] Re: [GC] Fix regression in 517195 (issue 1274983002 by mlippa...@chromium.org)

2015-08-06 Thread hpayer
LGTM https://codereview.chromium.org/1274983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [es6] Use strict arguments objects for destructured parameters (issue 1278783002 by rossb...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278783002/20001 https://codereview.chromium.org/1278783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: test262 roll (issue 1268553003 by little...@chromium.org)

2015-08-06 Thread littledan
Reviewers: adamk, Description: Update to latest test262 from 2015-07-31 Please review this at https://codereview.chromium.org/1268553003/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+347, -166 lines): M test/test262-es6/test262-es6.status M

[v8-dev] Re: Update V8 DEPS. (issue 1276153002 by v8-autor...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276153002/1 https://codereview.chromium.org/1276153002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Update V8 DEPS. (issue 1276153002 by v8-autor...@chromium.org)

2015-08-06 Thread v8-autor...@chromium.org via codereview.chromium.org
Reviewers: Michael Achenbach, Description: Update V8 DEPS. Rolling v8/third_party/icu to bbb24c53b4f46025e87a5973c39fa722c8757595 TBR=machenb...@chromium.org Please review this at https://codereview.chromium.org/1276153002/ Base URL: https://chromium.googlesource.com/v8/v8@master Affected

[v8-dev] Re: [turbofan] Stand-alone deferred block splitting. (issue 1271703002 by mtro...@chromium.org)

2015-08-06 Thread 'Jaroslav Sevcik' via v8-dev
Here is the CL that adds stack/interrupt checks to loops: https://codereview.chromium.org/1273353002 Below are the perf numbers fox x64 Embenchen. As you can see, at the moment we would pay 10%, depending on benchmark (mem-ops being especially bad because it is just a tight loop). We hope that

[v8-dev] Re: Make sure that memory reducer makes progress in incremental marking (issue 1274633003 by u...@chromium.org)

2015-08-06 Thread hpayer
On 2015/08/06 13:09:01, ulan wrote: PTAL Lgtm https://codereview.chromium.org/1274633003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from

[v8-dev] Re: Update V8 DEPS. (issue 1276153002 by v8-autor...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1276153002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Update V8 DEPS. (issue 1276153002 by v8-autor...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/7668fcda2fc4172df4bb4d02c0a1deb3e5d6f0ea Cr-Commit-Position: refs/heads/master@{#30054} https://codereview.chromium.org/1276153002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Rename extras exports to extras binding (issue 1275683002 by dome...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275683002/1 https://codereview.chromium.org/1275683002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Rename extras exports to extras binding (issue 1275683002 by dome...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/2dff84e66fd3c26a08aa214ee9a8d8d7cccb396c Cr-Commit-Position: refs/heads/master@{#30053} https://codereview.chromium.org/1275683002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Rename extras exports to extras binding (issue 1275683002 by dome...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1275683002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: test262 roll (issue 1268553003 by little...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #9 (id:160001) https://codereview.chromium.org/1268553003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: test262 roll (issue 1268553003 by little...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 9 (id:??) landed as https://crrev.com/722ad6923887d367f14588f5ccd6697b8684bd28 Cr-Commit-Position: refs/heads/master@{#30052} https://codereview.chromium.org/1268553003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [turbofan] Debug-time helpers for regalloc data structures (issue 1280483002 by mtro...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280483002/1 https://codereview.chromium.org/1280483002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Issue 4357 in v8: mjsunit/harmony/futex is flaky on win nosnap shared

2015-08-06 Thread codesite-noreply via v8-dev
Updates: Cc: bmeu...@chromium.org mvstan...@chromium.org ja...@chromium.org Comment #5 on issue 4357 by machenb...@chromium.org: mjsunit/harmony/futex is flaky on win nosnap shared https://code.google.com/p/v8/issues/detail?id=4357 It's unfortunately not fixed yet, see

[v8-dev] Re: Fix Array.prototype.concat for arguments object with getter. (issue 1270403002 by yang...@chromium.org)

2015-08-06 Thread yangguo
Done. Please re-review. https://codereview.chromium.org/1270403002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Sample allocation rate in memory reducer. (issue 1280623002 by u...@chromium.org)

2015-08-06 Thread ulan
Reviewers: Hannes Payer, Message: PTAL Description: Sample allocation rate in memory reducer. Otherwise, if there is no GC and no idle notification, memory reducer will use old allocation rate. BUG=chromium:515873 Please review this at https://codereview.chromium.org/1280623002/ Base URL:

[v8-dev] Re: [test] Make test filters platform-independent. (issue 1281453003 by machenb...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281453003/1 https://codereview.chromium.org/1281453003/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Helpful checks.cc file is being helpful. (issue 1276843004 by mstarzin...@chromium.org)

2015-08-06 Thread mstarzinger
Reviewers: titzer, Description: Helpful checks.cc file is being helpful. R=tit...@chromium.org Please review this at https://codereview.chromium.org/1276843004/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+0, -11 lines): M BUILD.gn D src/checks.cc M

[v8-dev] Make sure that memory reducer makes progress in incremental marking (issue 1274633003 by u...@chromium.org)

2015-08-06 Thread ulan
Reviewers: Hannes Payer, Message: PTAL Description: Make sure that memory reducer makes progress in incremental marking even if there are no idle notifications. BUG=chromium:515873 LOG=NO Please review this at https://codereview.chromium.org/1274633003/ Base URL:

[v8-dev] Re: When allocation rate is low and we are close to the new space limit, we should perform a scavenge d… (issue 1272573006 by hpa...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1272573006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: When allocation rate is low and we are close to the new space limit, we should perform a scavenge d… (issue 1272573006 by hpa...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/9df592c1c5fe43746b567c36212d343427f09f39 Cr-Commit-Position: refs/heads/master@{#30044} https://codereview.chromium.org/1272573006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Fix stale entries in optimized code map. (issue 1277873002 by mstarzin...@chromium.org)

2015-08-06 Thread hpayer
Cool! lgtm https://codereview.chromium.org/1277873002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1277873002/diff/1/src/objects.cc#newcode9521 src/objects.cc:9521: new_code_map = isolate-factory()-NewFixedArray(kInitialLength, TENURED); Good!

[v8-dev] Re: [test] Make test filters platform-independent. (issue 1281453003 by machenb...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1281453003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: [test] Make test filters platform-independent. (issue 1281453003 by machenb...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/7ce3afa0df92cad3c1ecc6ff350250f97fbc9d70 Cr-Commit-Position: refs/heads/master@{#30045} https://codereview.chromium.org/1281453003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Helpful checks.cc file is being helpful. (issue 1276843004 by mstarzin...@chromium.org)

2015-08-06 Thread titzer
On 2015/08/06 12:56:06, Michael Starzinger wrote: LGTM. I guess this is where CheckEqualsHelper used to live. https://codereview.chromium.org/1276843004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: When allocation rate is low and we are close to the new space limit, we should perform a scavenge d… (issue 1272573006 by hpa...@chromium.org)

2015-08-06 Thread ulan
lgtm https://codereview.chromium.org/1272573006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Issue 4352 in v8: Chromium will fail if enabling v8 profilier or vtune profiler.

2015-08-06 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Labels: -Merge-Approved-4.5 Comment #4 on issue 4352 by habl...@chromium.org: Chromium will fail if enabling v8 profilier or vtune profiler. https://code.google.com/p/v8/issues/detail?id=4352 (No comment was entered for this change.) -- You received

[v8-dev] Re: Sample allocation rate in memory reducer. (issue 1280623002 by u...@chromium.org)

2015-08-06 Thread hpayer
lgtm https://codereview.chromium.org/1280623002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [turbofan] Stand-alone deferred block splitting. (issue 1271703002 by mtro...@chromium.org)

2015-08-06 Thread jarin
I think I understand now how the spilling works, but it is very subtle. Once you add explanatory comments, it will be good to go. What are the performance numbers? https://codereview.chromium.org/1271703002/diff/80001/src/compiler/register-allocator.cc File src/compiler/register-allocator.cc

[v8-dev] Re: [test] Return variant and random seed on failures. (issue 1276853002 by machenb...@chromium.org)

2015-08-06 Thread machenbach
Reviewers: Jakob, Message: PTAL Description: [test] Return variant and random seed on failures. BUG=chromium:511215 LOG=n Please review this at https://codereview.chromium.org/1276853002/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+23, -13 lines): M

[v8-dev] Re: Sample allocation rate in memory reducer. (issue 1280623002 by u...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4734) https://codereview.chromium.org/1280623002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev ---

[v8-dev] Re: Helpful checks.cc file is being helpful. (issue 1276843004 by mstarzin...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276843004/1 https://codereview.chromium.org/1276843004/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [GC] Fix regression in 517195 (issue 1274983002 by mlippa...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274983002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274983002/80001 https://codereview.chromium.org/1274983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Fix stale entries in optimized code map. (issue 1277873002 by mstarzin...@chromium.org)

2015-08-06 Thread mstarzinger
Reviewers: Hannes Payer, Description: Fix stale entries in optimized code map. This fixes a corner-case where entending an optimized code map left stale entries in the abandoned copy. This can cause havoc not only in the heap verifier but also in the GC, because stale entries have not been

[v8-dev] When allocation rate is low and we are close to the new space limit, we should perform a scavenge d… (issue 1272573006 by hpa...@chromium.org)

2015-08-06 Thread hpayer
Reviewers: ulan, Description: When allocation rate is low and we are close to the new space limit, we should perform a scavenge during idle time. BUG=chromium:517395 LOG=n Please review this at https://codereview.chromium.org/1272573006/ Base URL:

[v8-dev] Re: When allocation rate is low and we are close to the new space limit, we should perform a scavenge d… (issue 1272573006 by hpa...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272573006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272573006/20001 https://codereview.chromium.org/1272573006/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [GC] Fix regression in 517195 (issue 1274983002 by mlippa...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #5 (id:80001) https://codereview.chromium.org/1274983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: [GC] Fix regression in 517195 (issue 1274983002 by mlippa...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 5 (id:??) landed as https://crrev.com/d2bd9517fefabf0d739f29b4ab61f26e88bddb0b Cr-Commit-Position: refs/heads/master@{#30043} https://codereview.chromium.org/1274983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Sample allocation rate in memory reducer. (issue 1280623002 by u...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280623002/1 https://codereview.chromium.org/1280623002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: V8: Add SIMD functions. (issue 1230343003 by bbu...@chromium.org)

2015-08-06 Thread bbudge
The failures are because I forgot to remove a hack in heap.cc that requests twice the amount of memory for the name table. PTAL https://codereview.chromium.org/1230343003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message

[v8-dev] Re: Issue 4285 in v8: Sloppy function in block

2015-08-06 Thread codesite-noreply via v8-dev
Comment #4 on issue 4285 by ad...@chromium.org: Sloppy function in block https://code.google.com/p/v8/issues/detail?id=4285 Andreas, do you happen to know why we think the spec is actually web compatible enough? It changes behavior for simple cases like: function foo() { bar(); {

[v8-dev] Re: Issue 4285 in v8: Sloppy function in block

2015-08-06 Thread codesite-noreply via v8-dev
Comment #6 on issue 4285 by rossb...@chromium.org: Sloppy function in block https://code.google.com/p/v8/issues/detail?id=4285 Yes, there were many rounds of discussion and experiments (by Microsoft) trying to narrow down what the interesection semantics is. In the end, Brian and Allen were

[v8-dev] Re: [es6] Use strict arguments objects for destructured parameters (issue 1278783002 by rossb...@chromium.org)

2015-08-06 Thread adamk
On 2015/08/06 18:56:29, rossberg wrote: On 2015/08/06 17:12:43, adamk wrote: Can you add some tests with arrow functions? Want to make sure that's covered, as some of the logic upstream is different (though should all flow through the same place). That's funny: I actually had tests for

[v8-dev] Re: [es6] Use strict arguments objects for destructured parameters (issue 1278783002 by rossb...@chromium.org)

2015-08-06 Thread adamk
Can you add some tests with arrow functions? Want to make sure that's covered, as some of the logic upstream is different (though should all flow through the same place). https://codereview.chromium.org/1278783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Issue 3943 in v8: New objects should be created with the prototype/map of the original constructor

2015-08-06 Thread codesite-noreply via v8-dev
Updates: Owner: ad...@chromium.org Labels: Area-Language Comment #2 on issue 3943 by ad...@chromium.org: New objects should be created with the prototype/map of the original constructor https://code.google.com/p/v8/issues/detail?id=3943 (No comment was entered for this

[v8-dev] [turbofan] Remove architecture-specific linkage files and LinkageTraits. Use macro-assembler-define… (issue 1272883003 by tit...@chromium.org)

2015-08-06 Thread tit...@chromium.org via codereview.chromium.org
Reviewers: Michael Starzinger, Description: [turbofan] Remove architecture-specific linkage files and LinkageTraits. Use macro-assembler-defined constants. R=mstarzin...@chromium.org BUG= Please review this at https://codereview.chromium.org/1272883003/ Base URL:

[v8-dev] Re: Issue 3990 in v8: PrepareStep in debugger listener fails if the listener calls frameMirror.allScopes

2015-08-06 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Cc: ad...@chromium.org Comment #4 on issue 3990 by ad...@chromium.org: PrepareStep in debugger listener fails if the listener calls frameMirror.allScopes https://code.google.com/p/v8/issues/detail?id=3990 Assuming the attached CL fixed this. -- You

[v8-dev] Re: Issue 4359 in v8: Crash in v8::internal::MemoryChunk::IsEvacuationCandidate on arm64 in mjsunit/strong/load-proxy.js

2015-08-06 Thread codesite-noreply via v8-dev
Updates: Status: Started Comment #2 on issue 4359 by mlippa...@chromium.org: Crash in v8::internal::MemoryChunk::IsEvacuationCandidate on arm64 in mjsunit/strong/load-proxy.js https://code.google.com/p/v8/issues/detail?id=4359 Hej Yang, This is just to let you know that I am still

[v8-dev] Re: Issue 4285 in v8: Sloppy function in block

2015-08-06 Thread codesite-noreply via v8-dev
Comment #5 on issue 4285 by ad...@chromium.org: Sloppy function in block https://code.google.com/p/v8/issues/detail?id=4285 Maybe the answer has to do with cross-browser intersection? I see that the above throws under modern Firefox. -- You received this message because this project is

[v8-dev] Re: [es6] Use strict arguments objects for destructured parameters (issue 1278783002 by rossb...@chromium.org)

2015-08-06 Thread adamk
lgtm with added tests, though https://codereview.chromium.org/1278783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: [es6] Use strict arguments objects for destructured parameters (issue 1278783002 by rossb...@chromium.org)

2015-08-06 Thread rossberg
On 2015/08/06 17:12:43, adamk wrote: Can you add some tests with arrow functions? Want to make sure that's covered, as some of the logic upstream is different (though should all flow through the same place). That's funny: I actually had tests for arrow functions, and then spent an hour

[v8-dev] Re: Issue 2930 in v8: Error.prototype.toString uses wrong `this` for getter-access of `message` and `name`

2015-08-06 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Owner: ad...@chromium.org Comment #4 on issue 2930 by ad...@chromium.org: Error.prototype.toString uses wrong `this` for getter-access of `message` and `name` https://code.google.com/p/v8/issues/detail?id=2930 This appears to be fixed now:

[v8-dev] Re: Helpful checks.cc file is being helpful. (issue 1276843004 by mstarzin...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1276843004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Helpful checks.cc file is being helpful. (issue 1276843004 by mstarzin...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/325257744f795f8611fd79778a952fdf69b5db64 Cr-Commit-Position: refs/heads/master@{#30046} https://codereview.chromium.org/1276843004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Fix stale entries in optimized code map. (issue 1277873002 by mstarzin...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1277873002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Fix stale entries in optimized code map. (issue 1277873002 by mstarzin...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/d4ac509f3cdcd22523ad2df64ec69d9cda370887 Cr-Commit-Position: refs/heads/master@{#30047} https://codereview.chromium.org/1277873002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Fix stale entries in optimized code map. (issue 1277873002 by mstarzin...@chromium.org)

2015-08-06 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277873002/20001 https://codereview.chromium.org/1277873002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Partially revert https://crrev.com/7e53749df0a10f475404e86ef0ca8df02bb79e7a (issue 1273083002 by u...@chromium.org)

2015-08-06 Thread ulan
Reviewers: Hannes Payer, Message: PTAL Description: Partially revert https://crrev.com/7e53749df0a10f475404e86ef0ca8df02bb79e7a This fixes memory regression caused by not reducing new-space size. BUG=chromium:517468 LOG=NO Please review this at https://codereview.chromium.org/1273083002/

[v8-dev] Re: Fix stale entries in optimized code map. (issue 1277873002 by mstarzin...@chromium.org)

2015-08-06 Thread mstarzinger
https://codereview.chromium.org/1277873002/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/1277873002/diff/1/test/cctest/test-heap.cc#newcode4633 test/cctest/test-heap.cc:4633: // Add the code several times to the optimized code map. This

[v8-dev] Re: V8: Add SIMD functions. (issue 1230343003 by bbu...@chromium.org)

2015-08-06 Thread bbudge
https://codereview.chromium.org/1230343003/diff/140001/src/harmony-simd.js File src/harmony-simd.js (right): https://codereview.chromium.org/1230343003/diff/140001/src/harmony-simd.js#newcode11 src/harmony-simd.js:11: var $bool8x16ToString; On 2015/08/06 00:12:25, Dan Ehrenberg wrote: You're

[v8-dev] [GC] Fix regression in 517195 (issue 1274983002 by mlippa...@chromium.org)

2015-08-06 Thread mlippautz
Reviewers: Hannes Payer, Description: [GC] Fix regression in 517195 We missed a check whether we can actually do incremental marking when starting it on reaching the external allocation limit. BUG=chromium:517195 LOG=N Please review this at https://codereview.chromium.org/1274983002/ Base

[v8-dev] Re: Fix Array.prototype.concat for arguments object with getter. (issue 1270403002 by yang...@chromium.org)

2015-08-06 Thread mstarzinger
LGTM. https://codereview.chromium.org/1270403002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

  1   2   >