ize()
Please keep in mind that you need to convert the arguments from MB to bytes.
Cheers,
Ulan.
On Wed, Feb 10, 2021 at 1:03 PM Marja Hölttä wrote:
> Yes, looks like the comment is out of date and the methods have been
> removed by this commit:
> https://chromium-review.googlesource.com/c/v8/
s dataCopy is stored outside and long
living.
Could you please file a bug at https://bugs.chromium.org/p/v8/issues/list with
steps to reproduce for this minor GC vs major GC issue?
Cheers,
Ulan.
On Tue, Apr 21, 2020 at 3:25 PM Euan Burns wrote:
> I'm trying to understand some garbage collection
he
> last month. Fear not, all changes landed before the Chrome code freeze.
>
> Cheers, Andreas, Dominik, and Ulan
>
>
>
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
> THURSDAY 2020-02-28: API adoption freeze starting
Should this be "THURSDAY 2020-03-05", i.e. today instead of last week?
On Thu, Mar 5, 2020 at 6:46 PM Lutz Vahl wrote:
> Hi,
>
> It is time again. If you have any questions regarding the release, please
> ping this thread.
>
> THURSDAY
.
Cheers,
Ulan.
On Wed, Oct 9, 2019 at 12:35 PM 'Clemens Backes' via v8-dev <
v8-dev@googlegroups.com> wrote:
> Hi Etienne,
>
> I just want to express my excitement about this new API! It looks like
> exactly what we need for WebAssembly compilation (and tier-up). We can
>
ots?
Cheers,
Ulan.
On Mon, Jul 29, 2019 at 7:36 AM Jakob Gruber wrote:
>
>
> On Fri, Jul 26, 2019 at 2:53 AM 'Irina Yatsenko' via v8-dev <
> v8-dev@googlegroups.com> wrote:
>
>> The header comment for v8::internal::*SlotSet::Iterate* says:
>> // Iterate over al
The flag is per isolate
On Thu, Jun 27, 2019 at 12:29 PM Chunhui Li
wrote:
> My question is whether this setting is the limitation of one isolate? Or
> is it a global setting?
>
> On Thu, Jun 27, 2019 at 6:27 PM 'Ulan Degenbaev' via v8-dev <
> v8-dev@googlegroups.com> wrot
Clarification: if 40MB is the expected size of live objects, then you
probably want to have some free space in heap to avoid GC storm.
So --max-semi-space-size=1 --max-old-space-size=80 might be better in that
case.
On Thu, Jun 27, 2019 at 12:21 PM Ulan Degenbaev wrote:
> --max-semi-space-s
--max-semi-space-size=1 --max-old-space-size=37 would keep the heap size at
around 40.
FYI, I am adding a new flag --max-heap-size that will be available in
future versions of V8:
https://chromium-review.googlesource.com/c/v8/v8/+/1679500
On Thu, Jun 27, 2019 at 12:08 PM Jakob Kummerow
wrote:
could get a little more information in between
> memory-infra dumps. Although a timeline with the heap going up and down
> would be much better.
>
> On the V8 side of things, we could improve 'tools/heap-stats' to also
> include heap statistics into the timeline, on top of object st
/v8_isolate_memory_dump_provider.cc?rcl=c16fb58b2bca1bba7248ac509dde60ececf94d63=156
On Tue, Apr 23, 2019 at 12:46 PM Ross McIlroy wrote:
> +Ulan Degenbaev
>
> Hi Pierre,
>
> Have you tried the mem-infra category
> <https://chromium.googlesource.com/chromium/src.git/+/mas
https://codereview.chromium.org/271843005/diff/60001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/271843005/diff/60001/src/heap.cc#newcode5004
src/heap.cc:5004: max_old_generation_size_ = FLAG_max_old_space_size *
MB;
This inadvertently broke the public
lgtm
https://codereview.chromium.org/1323313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Michael, could please take a look at incremental-marking-job.* files?
https://codereview.chromium.org/1265423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev"
Can you add a test using your MockPlatform in cctest/?
There were test for idle tasks. I extended them with delayed tasks.
https://codereview.chromium.org/1265423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
Thank you!
https://codereview.chromium.org/1265423002/diff/140001/src/heap/incremental-marking-job.cc
File src/heap/incremental-marking-job.cc (right):
https://codereview.chromium.org/1265423002/diff/140001/src/heap/incremental-marking-job.cc#newcode27
src/heap/incremental-marking-job.cc:27:
Is it blocking other work or is it purely cleanup?
In the latter case, I would wait until after we ship the disabled left
trimming
in Chrome stable, so that we can revert easily in case of big problems in
the
stable channel.
https://codereview.chromium.org/1305353010/
--
--
v8-dev mailing
lgtm
https://codereview.chromium.org/1311123005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1311123005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1315063007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Thanks!
https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h#newcode843
src/heap/heap.h:843: void FinalizeIncrementalMarkingIfComplete(const
char* comment);
On 2015/09/03
PTAL. The patch set 1 contains the original CL + DCHECK in
incremenal-marking +
regression test.
The patch set 2 contains the actual fix.
https://codereview.chromium.org/1311993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm
https://codereview.chromium.org/1313953008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
On 2015/08/10 13:53:52, Hannes Payer wrote:
Committed patchset #1 (id:1) manually as
6575237d3d0d9a8ef065c488db4ec4d742bc124b (tree was closed).
lgtm, thank for merging!
https://codereview.chromium.org/1284673002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
https://codereview.chromium.org/1277943003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
LGTM, good catch!
https://codereview.chromium.org/1270393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Sample allocation rate in memory reducer.
Otherwise, if there is no GC and no idle notification,
memory reducer will use old allocation rate.
BUG=chromium:515873
Please review this at https://codereview.chromium.org/1280623002/
Base URL:
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Make sure that memory reducer makes progress in incremental marking
even if there are no idle notifications.
BUG=chromium:515873
LOG=NO
Please review this at https://codereview.chromium.org/1274633003/
Base URL:
lgtm
https://codereview.chromium.org/1272573006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
..4647157e8e3443275064997d92c326207fe297cc
100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -4763,7 +4763,13 @@ bool Heap::HasHighFragmentation(intptr_t used,
intptr_t committed) {
void Heap::ReduceNewSpaceSize() {
- if (!FLAG_predictable HasLowAllocationRate()) {
+ // TODO(ulan
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Use conservative estimate for GC speed instead of bailing out when computing
mutator utilization.
This makes GC heuristics more robust for small applications that trigger
scavenges but do not trigger full GC.
BUG=
Please review this at
Reviewers: Hannes Payer,
Message:
PTAL
https://codereview.chromium.org/1265423002/diff/40001/src/heap/gc-idle-time-handler.h
File src/heap/gc-idle-time-handler.h (left):
https://codereview.chromium.org/1265423002/diff/40001/src/heap/gc-idle-time-handler.h#oldcode76
Hannes, adding you as reviewer too, since there were conflicts.
https://codereview.chromium.org/1268423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Thanks!
https://codereview.chromium.org/1265423002/diff/40001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1265423002/diff/40001/src/heap/gc-idle-time-handler.cc#newcode249
src/heap/gc-idle-time-handler.cc:249: if
Reviewers: Hannes Payer,
Message:
ptal
Description:
Fix idle step marking after 9d7ebc.
Idle notification should force marking to make progress.
BUG=
Please review this at https://codereview.chromium.org/1275573002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected
lgtm
https://codereview.chromium.org/1265983006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Are the function bodies copied verbatim without any changes?
https://codereview.chromium.org/1264993002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
rubber-stamp lgtm
https://codereview.chromium.org/1264993002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
On 2015/07/31 15:28:42, ulan wrote:
PTAL
In local testing I observed that memory reducer can time long time to
kick in
because it doesn't use the current allocation rate.
Abandoning this CL since it can cause too aggressive GCs.
https://codereview.chromium.org/1268933003/
--
--
v8-dev
Added TODO and added a check for last GC time.
https://codereview.chromium.org/1263373002/diff/1/src/heap/memory-reducer.cc
File src/heap/memory-reducer.cc (right):
https://codereview.chromium.org/1263373002/diff/1/src/heap/memory-reducer.cc#newcode98
src/heap/memory-reducer.cc:98:
Reviewers: Hannes Payer,
Message:
ptal
Description:
Revert d5419b for regressing v8.top_25_smooth benchmark.
BUG=chromium:516425
LOG=NO
Please review this at https://codereview.chromium.org/1271973002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -9
lgtm
https://codereview.chromium.org/1273483002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
..750827968dcd757edff47ece2ed0948930aa688f
100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -1806,6 +1806,10 @@ class Heap {
// last GC.
bool old_gen_exhausted_;
+ // Indicates that memory usage is more important than latency.
+ // TODO(ulan): Merge it with memory reducer once chromium:490559 is
fixed
lgtm
https://codereview.chromium.org/1273483002/diff/1/src/heap/incremental-marking.h
File src/heap/incremental-marking.h (right):
https://codereview.chromium.org/1273483002/diff/1/src/heap/incremental-marking.h#newcode31
src/heap/incremental-marking.h:31: CompletionAction complete_action_ =
lgtm
https://codereview.chromium.org/1266793003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm!
https://codereview.chromium.org/1259613006/diff/60001/src/heap/incremental-marking.cc
File src/heap/incremental-marking.cc (right):
https://codereview.chromium.org/1259613006/diff/60001/src/heap/incremental-marking.cc#newcode216
src/heap/incremental-marking.cc:216: Object* obj = *p;
lgtm
https://codereview.chromium.org/1265273002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Grow heap slowly after running memory reducer.
BUG=
Please review this at https://codereview.chromium.org/1261373006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+10, -5 lines):
M src/heap/heap.cc
M
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Perform full GC in background idle notification.
BUG=chromium:515873
LOG=NO
Please review this at https://codereview.chromium.org/1263373002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -8 lines):
M
lgtm with comment:
https://codereview.chromium.org/1270873002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1270873002/diff/1/src/heap/heap.h#newcode2295
src/heap/heap.h:2295: double step_size_in_bytes, double deadline_in_ms,
step_size_in_bytes should be
Reviewers: Hannes Payer,
Message:
PTAL
In local testing I observed that memory reducer can time long time to kick
in
because it doesn't use the current allocation rate.
Description:
Memory reducer should use the current allocation rate instead of the overall
allocation rate.
BUG=
Please
/30 14:28:03, Hannes Payer wrote:
On 2015/07/30 13:20:19, ulan wrote:
This is the main change.
Other lines in this function ensure that state.last_gc_time_ms =
event.time_ms
for mark-compact event or doesn't change.
Can we make the watchdog part a boolean function to increase
readability
Reviewers: Hannes Payer,
Message:
ptal
Description:
Partially revert 5aacee to see its impact on memory histograms.
Original CL: https://crrev.com/5aaceefd9a84327ce6afeaea16557449bf83ce57
BUG=chromium:515721
LOG=NO
Please review this at https://codereview.chromium.org/1264063003/
Base URL:
Reviewers: epertoso, jochen,
Message:
ptal
Description:
Add CancelableIdleTask.
BUG=chromium:490559
LOG=NO
Please review this at https://codereview.chromium.org/1258923010/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+48, -17 lines):
M
Thanks, landing.
https://codereview.chromium.org/1258923010/diff/1/src/cancelable-task.h
File src/cancelable-task.h (right):
https://codereview.chromium.org/1258923010/diff/1/src/cancelable-task.h#newcode57
src/cancelable-task.h:57: // Task overrides.
On 2015/07/30 12:05:30, epertoso wrote:
Reviewers: Hannes Payer,
Message:
ptal
https://codereview.chromium.org/1262363002/diff/1/src/heap/memory-reducer.cc
File src/heap/memory-reducer.cc (right):
https://codereview.chromium.org/1262363002/diff/1/src/heap/memory-reducer.cc#newcode135
src/heap/memory-reducer.cc:135:
lgtm
https://codereview.chromium.org/1268663004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1268663004/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1268663004/diff/1/src/heap/mark-compact.cc#newcode3064
src/heap/mark-compact.cc:3064: if (owner == heap_-lo_space() || owner
== NULL) {
Did you mean
Thanks!
https://codereview.chromium.org/1270493002/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1270493002/diff/1/src/heap/heap.cc#newcode969
src/heap/heap.cc:969: memory_reducer_.NotifyMarkCompact(event);
Please guard just this line with if
Reviewers: Hannes Payer,
Message:
ptal
Description:
Fix idle notification for background tab.
The idle time handler should never return DONE or DO_SCAVENGE for
background tabs. Upon receiving DONE chrome will stop sending idle
notifications.
BUG=chromium:515174
LOG=NO
Please review this at
https://codereview.chromium.org/1269583002/diff/1/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1269583002/diff/1/src/heap/gc-idle-time-handler.cc#newcode205
src/heap/gc-idle-time-handler.cc:205:
lgtm
https://codereview.chromium.org/1263543004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1260953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1255183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1260463002/diff/1/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):
https://codereview.chromium.org/1260463002/diff/1/src/heap/mark-compact.h#newcode329
src/heap/mark-compact.h:329: ObjectSlot Get(intptr_t i) {
Where is it used?
lgtm
https://codereview.chromium.org/1255793003/diff/1/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/1255793003/diff/1/src/debug.cc#newcode1640
src/debug.cc:1640: DCHECK(debug_info_list_ != NULL);
s/NULL/nullptr
https://codereview.chromium.org/1255793003/
--
--
lgtm with comment:
https://codereview.chromium.org/1260463002/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1260463002/diff/20001/test/cctest/test-heap.cc#newcode6030
test/cctest/test-heap.cc:6030:
https://codereview.chromium.org/1254603002/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1254603002/diff/1/src/heap/heap.cc#newcode4824
src/heap/heap.cc:4824: double Heap::MutatorUtilization() {
On 2015/07/24 07:44:22, Hannes Payer wrote:
This function
://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h#newcode25
src/dateparser-inl.h:25: // Accept ES5 ISO 8601 date-time-strings or
legacy
dates compatible
On 2015/07/24 13:56:25, ulan wrote:
Please update this comment to ES6.
Done.
https://codereview.chromium.org/1229903004/diff/60001
One quick note -- I'll address the comments in a bit -- the method is
named
ParseES5DateTime, so should we update that as well?
Yes, let's update it to keep it consistent.
https://codereview.chromium.org/1229903004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm, thanks!
https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h
File src/dateparser-inl.h (right):
https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h#newcode25
src/dateparser-inl.h:25: // Accept ES5 ISO 8601 date-time-strings or
legacy dates
lgtm
https://codereview.chromium.org/1254873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1252713002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Hannes Payer,
Message:
Hannes, ptal. This is just refactoring without any change in behavior.
Description:
Extract function to compute mutator utilization.
This function will be used later instead of HasLowAllocationRate
to decide how many pages to compact.
BUG=chromium:502247
lgtm
https://codereview.chromium.org/1256503004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm, thanks.
https://codereview.chromium.org/1230753004/diff/240001/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/1230753004/diff/240001/src/types.cc#newcode1
src/types.cc:1:
Delete empty line.
https://codereview.chromium.org/1230753004/
--
--
v8-dev mailing list
lgtm
https://codereview.chromium.org/1239383004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/07/21 10:04:35, jbramley wrote:
What's the purpose of it? Will there be future cases where we don't know
the
expected size until after the start of the scope?
The background is in https://code.google.com/p/v8/issues/detail?id=4277
CallCodeSize() depends on the predictable_code_size_
Reviewers: jbramley,
Message:
Hi Jacob, would you mind taking a look?
Description:
ARM: make sure that the expected code size is computed in predictable scope.
BUG=v8:4277
LOG=NO
Please review this at https://codereview.chromium.org/1251443002/
Base URL:
Everything looks good, except:
1) Memory overhead (see comment below).
2) Please add a test that creates bytecode array, checks, and does GC.
https://codereview.chromium.org/1230753004/diff/220001/src/objects.h
File src/objects.h (right):
Stashing in a spare field sounds ideal if possible. I'll have a look, but
do
you
have any candidates?
Logical way would be to share the code field and make it (code | bytecode)
field, which points
1) to code if there is no bytecode
2) to bytecode if there is no code
3) to pair (code,
Reviewers: jochen, aaronlink,
Message:
PTAL
Description:
Declare deleted copy constructor and assignment operator of v8::Global to
take
const parameters.
This is required in order for Globals to be stored in STL containers.
Patch from Aaron Link aaronl...@google.com
BUG=
Please review
lgtm
https://codereview.chromium.org/1227403006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
debugger parts lgtm
https://codereview.chromium.org/1233073005/diff/20001/test/cctest/test-api.cc
File test/cctest/test-api.cc (left):
https://codereview.chromium.org/1233073005/diff/20001/test/cctest/test-api.cc#oldcode20990
test/cctest/test-api.cc:20990:
lgtm
https://codereview.chromium.org/1234833003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1227213003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
looks good
https://codereview.chromium.org/1234833003/diff/20001/src/ia32/assembler-ia32-inl.h
File src/ia32/assembler-ia32-inl.h (right):
https://codereview.chromium.org/1234833003/diff/20001/src/ia32/assembler-ia32-inl.h#newcode78
src/ia32/assembler-ia32-inl.h:78: return;
I think it is
and may be
+ * starved for an arbitrarily long time if no idle time is available.
+ * The definition of foreground is opaque to V8.
+ */
+ virtual void CallIdleOnForegroundThread(Isolate* isolate, IdleTask*
task) {
+// TODO(ulan): Make this function abstract after V8 roll in Chromium
lgtm if mips is fixed.
https://codereview.chromium.org/1232803002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: jochen,
Message:
PTAL
Description:
Correctly handle the case when TimerTask is destroyed with being run.
This is follow-up for a5616e.
BUG=chromium:508584
LOG=NO
Please review this at https://codereview.chromium.org/1234513003/
Base URL:
Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
Fix undefined behavior in InstructionSequence::GetInstructionBlock.
Some implementations of std::lower_bound require weak-strict ordering.
The comparison operator must be assymetric, which doesn't hold for
less_equals.
BUG=
Please
lgtm
https://codereview.chromium.org/1222093007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jochen,
Message:
PTAL
Description:
Disable the pending task if the memory reducer is teared down.
BUG=chromium:508584
LOG=NO
Please review this at https://codereview.chromium.org/1230163002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+24, -5
Thanks, landing
https://codereview.chromium.org/1230163002/diff/20001/src/heap/memory-reducer.cc
File src/heap/memory-reducer.cc (right):
https://codereview.chromium.org/1230163002/diff/20001/src/heap/memory-reducer.cc#newcode183
src/heap/memory-reducer.cc:183: pending_task_ = NULL;
On
lgtm
https://codereview.chromium.org/1215273003/diff/40001/tools/run_perf.py
File tools/run_perf.py (right):
https://codereview.chromium.org/1215273003/diff/40001/tools/run_perf.py#newcode229
tools/run_perf.py:229: def Unchain(iterable):
This function is usually called 'unzip' as it inverts
lgtm
https://codereview.chromium.org/1229673005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
PTAL
https://codereview.chromium.org/1235543005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
looking good.
https://codereview.chromium.org/1222093007/diff/40001/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/1222093007/diff/40001/src/assembler.cc#newcode737
src/assembler.cc:737: if (SetMode(rmode)) return
AdvanceReadDebugBreakSlotData();
Did you mean
lgtm
https://codereview.chromium.org/1227033002/diff/20001/tools/run_perf.py
File tools/run_perf.py (right):
https://codereview.chromium.org/1227033002/diff/20001/tools/run_perf.py#newcode236
tools/run_perf.py:236: res = reduce(lambda r, t: r + t.GetResults(),
measurements, Results())
Nit:
Thanks
https://codereview.chromium.org/1213313004/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1213313004/diff/40001/src/heap/heap.cc#newcode4986
src/heap/heap.cc:4986: }
On 2015/07/07 07:49:34, Hannes Payer wrote:
Let's make this block a method
1 - 100 of 2783 matches
Mail list logo
