Change in vdsm[master]: BZ#844180: Change scsi scan to asynchronous

Ayal Baron has posted comments on this change. Change subject: BZ#844180: Change scsi scan to asynchronous .. Patch Set 9: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: wip - vdsm: improve message when trying to attach import dom...

Ayal Baron has posted comments on this change. Change subject: wip - vdsm: improve message when trying to attach import domain with wrong permissions (#842146) .. Patch Set 1: Looks good to me, but someone else must approve

Change in vdsm[master]: BZ#846323 - Search PV's belonging to the VG in removeVG.

Ayal Baron has posted comments on this change. Change subject: BZ#846323 - Search PV's belonging to the VG in removeVG. .. Patch Set 2: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: BZ829710 Get VMList with oop if necessary

Ayal Baron has posted comments on this change. Change subject: BZ829710 Get VMList with oop if necessary .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6867 To unsubscribe, visit

Change in vdsm[master]: Revert BZ#842631 Use domain proxies instead of actual domai...

Ayal Baron has posted comments on this change. Change subject: Revert BZ#842631 Use domain proxies instead of actual domain references .. Patch Set 1: (1 inline comment) Don't get me wrong, I'm all for this patch, but you

Change in vdsm[master]: Ship the version file with the tarballs

Ayal Baron has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 1: Why is this dependent on the domain monitor patches? -- To view, visit http://gerrit.ovirt.org/7295 To

Change in vdsm[master]: DomainMonitor should use use real domains (no proxy)

Ayal Baron has posted comments on this change. Change subject: DomainMonitor should use use real domains (no proxy) .. Patch Set 1: (1 inline comment) Commit Message Line 3:

Change in vdsm[master]: Related to BZ#843387 - Payload should set volPath or raise.

Ayal Baron has posted comments on this change. Change subject: Related to BZ#843387 - Payload should set volPath or raise. .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6803 To

Change in vdsm[master]: BZ#846323 - Search PV's belonging to the VG in removeVG.

Ayal Baron has posted comments on this change. Change subject: BZ#846323 - Search PV's belonging to the VG in removeVG. .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: Provisional fix: the domain is produced in the monitor threa...

Ayal Baron has posted comments on this change. Change subject: Provisional fix: the domain is produced in the monitor thread. .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7163 To

Change in vdsm[master]: Report hsm tasks in getAllTasksStatuses and getAllTasksInfo

Ayal Baron has posted comments on this change. Change subject: Report hsm tasks in getAllTasksStatuses and getAllTasksInfo .. Patch Set 8: I would prefer that you didn't submit this Doesn't this break engine? 1 scenario that

Change in vdsm[master]: Properly propagate pool timeout in file handler

Ayal Baron has posted comments on this change. Change subject: Properly propagate pool timeout in file handler .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6671 To unsubscribe, visit

Change in vdsm[master]: Add deathSignal options to better peopen

Ayal Baron has posted comments on this change. Change subject: Add deathSignal options to better peopen .. Patch Set 9: Looks good to me, but someone else must approve (4 inline comments)

Change in vdsm[master]: Add missing log object to CrabRPCServer

Ayal Baron has posted comments on this change. Change subject: Add missing log object to CrabRPCServer .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7084 To unsubscribe, visit

Change in vdsm[master]: Check the metadata on domain validation

Ayal Baron has posted comments on this change. Change subject: Check the metadata on domain validation .. Patch Set 1: Looks good to me, approved Note that BZ# should be in commit message when merging. Bug 847328 - VDSM

Change in vdsm[master]: Support the quiesce flag during a live snapshot

Ayal Baron has posted comments on this change. Change subject: Support the quiesce flag during a live snapshot .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit

Change in vdsm[master]: BZ#844656 Respawn the domain monitor when needed

Ayal Baron has posted comments on this change. Change subject: BZ#844656 Respawn the domain monitor when needed .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6787 To unsubscribe, visit

Change in vdsm[master]: BZ#846014 - Fix virtio hotplug disk fail to a VM with IDE di...

Ayal Baron has posted comments on this change. Change subject: BZ#846014 - Fix virtio hotplug disk fail to a VM with IDE disks. .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6970 To

Change in vdsm[master]: BZ#844656 Respawn the domain monitor when needed

Ayal Baron has posted comments on this change. Change subject: BZ#844656 Respawn the domain monitor when needed .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6787 To unsubscribe, visit

Change in vdsm[master]: BZ829710 Get VMList with oop if necessary

Ayal Baron has posted comments on this change. Change subject: BZ829710 Get VMList with oop if necessary .. Patch Set 2: I would prefer that you didn't submit this The oop part should be in the relevant storage domain and not

Change in vdsm[master]: BZ#844656 Respawn the domain monitor when needed

Ayal Baron has posted comments on this change. Change subject: BZ#844656 Respawn the domain monitor when needed .. Patch Set 3: Looks good to me, approved (1 inline comment)

Change in vdsm[master]: BZ#844294 Add requiresMailbox to StorageDomain

Ayal Baron has posted comments on this change. Change subject: BZ#844294 Add requiresMailbox to StorageDomain .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6754 To unsubscribe, visit

Change in vdsm[master]: [WIP] Use 1Mb cluster size for the qcow volumes

Ayal Baron has posted comments on this change. Change subject: [WIP] Use 1Mb cluster size for the qcow volumes .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6677 To unsubscribe, visit

Change in vdsm[master]: [WIP] Use 1Mb cluster size for the qcow volumes

Ayal Baron has posted comments on this change. Change subject: [WIP] Use 1Mb cluster size for the qcow volumes .. Patch Set 1: I would prefer that you didn't submit this After reconsideration it may be preferable to limit this

Change in vdsm[master]: BZ#840386: vms with shared disk will pause...

Ayal Baron has posted comments on this change. Change subject: BZ#840386: vms with shared disk will pause... .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6283 To unsubscribe, visit

Change in vdsm[master]: Add the hostId parameter to reconstructMaster

Ayal Baron has posted comments on this change. Change subject: Add the hostId parameter to reconstructMaster .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6562 To unsubscribe, visit

Change in vdsm[master]: Add missing import config in domainMonitor

Ayal Baron has posted comments on this change. Change subject: Add missing import config in domainMonitor .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6606 To unsubscribe, visit

Change in vdsm[master]: Uniform the block and file volume methods

Ayal Baron has posted comments on this change. Change subject: Uniform the block and file volume methods .. Patch Set 25: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit

Change in vdsm[master]: Unify the volume creation code in volume.create

Ayal Baron has posted comments on this change. Change subject: Unify the volume creation code in volume.create .. Patch Set 26: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3627 To unsubscribe, visit

Change in vdsm[master]: Add the formatConverter for Storage Domain V3

Ayal Baron has posted comments on this change. Change subject: Add the formatConverter for Storage Domain V3 .. Patch Set 19: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3841 To unsubscribe, visit

Change in vdsm[master]: Orthogonal storage repository conversion

Ayal Baron has posted comments on this change. Change subject: Orthogonal storage repository conversion .. Patch Set 36: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3045 To unsubscribe, visit

Change in vdsm[master]: Use domain proxies instead of actual domain references

Ayal Baron has posted comments on this change. Change subject: Use domain proxies instead of actual domain references .. Patch Set 35: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe,

Change in vdsm[master]: Add deathSignal options to better peopen

Ayal Baron has posted comments on this change. Change subject: Add deathSignal options to better peopen .. Patch Set 3: (3 inline comments) Commit Message Line 9: This

Change in vdsm[master]: BZ#842631 Use domain proxies instead of actual domain refere...

Ayal Baron has posted comments on this change. Change subject: BZ#842631 Use domain proxies instead of actual domain references .. Patch Set 36: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3044 To

Change in vdsm[master]: Separate the Volume.share implementation

Ayal Baron has posted comments on this change. Change subject: Separate the Volume.share implementation .. Patch Set 22: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3737 To unsubscribe, visit

Change in vdsm[master]: Remove the unused nocache option

Ayal Baron has posted comments on this change. Change subject: Remove the unused nocache option .. Patch Set 19: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3747 To unsubscribe, visit

Change in vdsm[master]: Uniform the block and file volume methods

Ayal Baron has posted comments on this change. Change subject: Uniform the block and file volume methods .. Patch Set 23: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit

Change in vdsm[master]: Unify the volume creation code in volume.create

Ayal Baron has posted comments on this change. Change subject: Unify the volume creation code in volume.create .. Patch Set 24: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3627 To unsubscribe, visit

Change in vdsm[master]: Add stdin tests to betterPopen

Ayal Baron has posted comments on this change. Change subject: Add stdin tests to betterPopen .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6240 To unsubscribe, visit

Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.

Ayal Baron has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 1: (2 inline comments) Commit

Change in vdsm[master]: Use SANLock lease offset when present

Ayal Baron has posted comments on this change. Change subject: Use SANLock lease offset when present .. Patch Set 6: (1 inline comment) File vdsm/storage/blockVolume.py Line

Change in vdsm[master]: Support the quiesce flag during a live snapshot

Ayal Baron has posted comments on this change. Change subject: Support the quiesce flag during a live snapshot .. Patch Set 3: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: MOM Integration

Ayal Baron has posted comments on this change. Change subject: MOM Integration .. Patch Set 13: I would prefer that you didn't submit this (5 inline comments) Minor issues

Change in vdsm[master]: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf

Ayal Baron has posted comments on this change. Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf .. Patch Set 4: I would prefer that you didn't submit this (3 inline comments)

Change in vdsm[master]: Add the hostId parameter to reconstructMaster

Ayal Baron has posted comments on this change. Change subject: Add the hostId parameter to reconstructMaster .. Patch Set 14: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Separate the Volume.share implementation

Ayal Baron has posted comments on this change. Change subject: Separate the Volume.share implementation .. Patch Set 21: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3737 To

Change in vdsm[master]: Remove the unused nocache option

Ayal Baron has posted comments on this change. Change subject: Remove the unused nocache option .. Patch Set 18: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3747 To unsubscribe, visit

Change in vdsm[master]: Uniform the block and file volume methods

Ayal Baron has posted comments on this change. Change subject: Uniform the block and file volume methods .. Patch Set 22: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit

Change in vdsm[master]: Fix detachStorageDomain for the ISO domains

Ayal Baron has posted comments on this change. Change subject: Fix detachStorageDomain for the ISO domains .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6445 To unsubscribe, visit

Change in vdsm[master]: BZ#834893: vms with shared disk will pause...

Ayal Baron has posted comments on this change. Change subject: BZ#834893: vms with shared disk will pause... .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Add the hostId parameter to reconstructMaster

Ayal Baron has posted comments on this change. Change subject: Add the hostId parameter to reconstructMaster .. Patch Set 13: Not sure why my comments weren't published before. Trying again -- To view, visit

Change in vdsm[master]: Add the hostId parameter to reconstructMaster

Ayal Baron has posted comments on this change. Change subject: Add the hostId parameter to reconstructMaster .. Patch Set 13: (3 inline comments) File vdsm/storage/sp.py

Change in vdsm[master]: BZ#834893: vms with shared disk will pause...

Ayal Baron has posted comments on this change. Change subject: BZ#834893: vms with shared disk will pause... .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6283 To

Change in vdsm[master]: Add the formatConverter for Storage Domain V3

Ayal Baron has posted comments on this change. Change subject: Add the formatConverter for Storage Domain V3 .. Patch Set 17: I would prefer that you didn't submit this (11 inline comments)

Change in vdsm[master]: Unify the volume creation code in volume.create

Ayal Baron has posted comments on this change. Change subject: Unify the volume creation code in volume.create .. Patch Set 22: Looks good to me, but someone else must approve (3 inline comments) Please note inline comments

Change in vdsm[master]: Orthogonal storage repository conversion

Ayal Baron has posted comments on this change. Change subject: Orthogonal storage repository conversion .. Patch Set 33: I would prefer that you didn't submit this (4 inline comments) minor issues

Change in vdsm[master]: Add the hostId parameter to reconstructMaster

Ayal Baron has posted comments on this change. Change subject: Add the hostId parameter to reconstructMaster .. Patch Set 13: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/5068 To

Change in vdsm[master]: send POSIXFS instead of SHAREDFS

Ayal Baron has posted comments on this change. Change subject: send POSIXFS instead of SHAREDFS .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6103 To unsubscribe, visit

Change in vdsm[master]: Related to BZ#833099 - Removing unused exceptions.

Ayal Baron has posted comments on this change. Change subject: Related to BZ#833099 - Removing unused exceptions. .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6085 To unsubscribe, visit

Change in vdsm[master]: Related to BZ#833099 - spmRole is a StoragePool attribute.

Ayal Baron has posted comments on this change. Change subject: Related to BZ#833099 - spmRole is a StoragePool attribute. .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6084 To

Change in vdsm[master]: BZ#833099 - Induce MSD reconstruct when getSpmStatus fail.

Ayal Baron has posted comments on this change. Change subject: BZ#833099 - Induce MSD reconstruct when getSpmStatus fail. .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6083 To

Change in vdsm[master]: Related to BZ#833099 - Removing unused exceptions.

Ayal Baron has posted comments on this change. Change subject: Related to BZ#833099 - Removing unused exceptions. .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6085 To unsubscribe, visit

Change in vdsm[master]: Related to BZ#833099 - spmRole is a StoragePool attribute.

Ayal Baron has posted comments on this change. Change subject: Related to BZ#833099 - spmRole is a StoragePool attribute. .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6084 To

Change in vdsm[master]: BZ#784931 - Fixing race condition in deactivateSD().

Ayal Baron has posted comments on this change. Change subject: BZ#784931 - Fixing race condition in deactivateSD(). .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5677 To unsubscribe,

Change in vdsm[master]: Fix 2nd order exception msg in lvm._initpvs().

Ayal Baron has posted comments on this change. Change subject: Fix 2nd order exception msg in lvm._initpvs(). .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5319 To unsubscribe, visit

Change in vdsm[master]: Remove unnecesary preparePaths.

Ayal Baron has posted comments on this change. Change subject: Remove unnecesary preparePaths. .. Patch Set 1: Do not submit I agree with Federico, this code is needed unless you find a different way to make sure that no

Change in vdsm[master]: Introducing the template activation leak.

Ayal Baron has posted comments on this change. Change subject: Introducing the template activation leak. .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/863 To unsubscribe, visit

Change in vdsm[master]: Related to BZ#784931 - Removing the unused useCache paramete...

Ayal Baron has posted comments on this change. Change subject: Related to BZ#784931 - Removing the unused useCache parameter. .. Patch Set 1: Looks good to me, approved (1 inline comment)

Change in vdsm[master]: Do not acquire leases on shared volumes

Ayal Baron has posted comments on this change. Change subject: Do not acquire leases on shared volumes .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5521 To unsubscribe, visit

Change in vdsm[master]: Add the async kwarg to acquireHostId

Ayal Baron has posted comments on this change. Change subject: Add the async kwarg to acquireHostId .. Patch Set 19: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4392 To unsubscribe, visit

Change in vdsm[master]: Monitor the host id in domainMonitor

Ayal Baron has posted comments on this change. Change subject: Monitor the host id in domainMonitor .. Patch Set 21: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3929 To unsubscribe, visit

Change in vdsm[master]: send POSIXFS instead of SHAREDFS

Ayal Baron has posted comments on this change. Change subject: send POSIXFS instead of SHAREDFS .. Patch Set 1: I would prefer that you didn't submit this all references to SHAREDFS should just be replaced with POSIXFS. No

Change in vdsm[master]: Don't ignore nfs_mount_options in vdsm.conf

Ayal Baron has posted comments on this change. Change subject: Don't ignore nfs_mount_options in vdsm.conf .. Patch Set 2: I would prefer that you didn't submit this I take it back. engine run time per domain configuration

Change in vdsm[master]: BZ#784931 - Fixing raise condition from deactivateSD().

Ayal Baron has posted comments on this change. Change subject: BZ#784931 - Fixing raise condition from deactivateSD(). .. Patch Set 2: I would prefer that you didn't submit this (7 inline comments)

Change in vdsm[master]: BZ#784931 - Fixing raise condition from deactivateSD().

Ayal Baron has posted comments on this change. Change subject: BZ#784931 - Fixing raise condition from deactivateSD(). .. Patch Set 2: (1 inline comment) File

Change in vdsm[master]: Use sparse images for alignmentScanTests

Ayal Baron has posted comments on this change. Change subject: Use sparse images for alignmentScanTests .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5608 To unsubscribe, visit

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Ayal Baron has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 17: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit

Change in vdsm[master]: Make domainMonitor compliant to PEP8

Ayal Baron has posted comments on this change. Change subject: Make domainMonitor compliant to PEP8 .. Patch Set 17: Looks good to me, but someone else must approve Please note previous comment about aligning slots (can be a

Change in vdsm[master]: Remove the traceback from the getVSize warning

Ayal Baron has posted comments on this change. Change subject: Remove the traceback from the getVSize warning .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5294 To unsubscribe, visit

Change in vdsm[master]: Add the async kwarg to acquireHostId

Ayal Baron has posted comments on this change. Change subject: Add the async kwarg to acquireHostId .. Patch Set 13: (1 inline comment) File vdsm/storage/safelease.py Line

Change in vdsm[master]: Monitor the host id in domainMonitor

Ayal Baron has posted comments on this change. Change subject: Monitor the host id in domainMonitor .. Patch Set 15: I would prefer that you didn't submit this (4 inline comments)

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Ayal Baron has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 13: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Ayal Baron has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 13: (1 inline comment) File

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Ayal Baron has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 11: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/2786 To

Change in vdsm[master]: BZ#808874 Skip master validation on repoStat

Ayal Baron has posted comments on this change. Change subject: BZ#808874 Skip master validation on repoStat .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5134 To unsubscribe, visit

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Ayal Baron has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 9: I would prefer that you didn't submit this (4 inline comments)

Change in vdsm[master]: Change storageServer to handle numeric connection values

Ayal Baron has posted comments on this change. Change subject: Change storageServer to handle numeric connection values .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5062 To unsubscribe,

Change in vdsm[master]: Change storageServer to parse some params as strings

Ayal Baron has posted comments on this change. Change subject: Change storageServer to parse some params as strings .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: getDeviceList - passing includePartitioned to HSM

Ayal Baron has posted comments on this change. Change subject: getDeviceList - passing includePartitioned to HSM .. Patch Set 3: I would prefer that you didn't submit this (3 inline comments)

Change in vdsm[master]: Change oop to be a new process instead of a fork

Ayal Baron has posted comments on this change. Change subject: Change oop to be a new process instead of a fork .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4318 To

Change in vdsm[master]: Reuse the stored pool host id on reconstructMaster

Ayal Baron has posted comments on this change. Change subject: Reuse the stored pool host id on reconstructMaster .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: BZ#784931 - Restore SD.validate() semantics.

Ayal Baron has posted comments on this change. Change subject: BZ#784931 - Restore SD.validate() semantics. .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Once commit message is fixed you

Change in vdsm[master]: BZ#788640 - Remove subChainSizeCalc() and getSubChain(). Rem...

Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Remove subChainSizeCalc() and getSubChain(). Remove getAllChildrenList(). .. Patch Set 18: Looks good to me, approved -- To view, visit

Change in vdsm[master]: getAllVolumes() unit test.

Ayal Baron has posted comments on this change. Change subject: getAllVolumes() unit test. .. Patch Set 5: Looks good to me, but someone else must approve even though I don't like the external files. -- To view, visit

Change in vdsm[master]: BZ#788640 - Remove subChainSizeCalc() and getSubChain(). Rem...

Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Remove subChainSizeCalc() and getSubChain(). Remove getAllChildrenList(). .. Patch Set 17: I would prefer that you didn't submit this (1 inline

Change in vdsm[master]: BZ#788640 - Template relink refactored.

Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Template relink refactored. .. Patch Set 15: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3467 To unsubscribe, visit

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Ayal Baron has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 5: Looks good to me, approved (1 inline comment)

Change in vdsm[master]: Use SANLock lease offset when present

Ayal Baron has posted comments on this change. Change subject: Use SANLock lease offset when present .. Patch Set 3: I would prefer that you didn't submit this (9 inline comments)

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 14: Looks good to me, approved I still don't like the fact that _getVolsTree doesn't return a dictionary

Change in vdsm[master]: BZ#788640 - Refactor Pool.deleteImage()

Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Refactor Pool.deleteImage() .. Patch Set 14: Looks good to me, approved (1 inline comment) Please send another patch after this to take care of the if

<    3   4   5   6   7   8   9   10   >