Federico Simoncelli has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 7: Code-Review+1
Nice! This works well with the recent db/ui changes!
--
To view, visit
Federico Simoncelli has uploaded a new change for review.
Change subject: hsm: [wip] protect deleteImage with the spm lock
..
hsm: [wip] protect deleteImage with the spm lock
Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c
Federico Simoncelli has posted comments on this change.
Change subject: hsm: [wip] protect deleteImage with the spm lock
..
Patch Set 1:
(3 comments)
File
Federico Simoncelli has posted comments on this change.
Change subject: hsm: [wip] protect deleteImage with the spm lock
..
Patch Set 1: Verified+1
The SPM locking is used.
--
To view, visit http://gerrit.ovirt.org/19795
To
Federico Simoncelli has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 8:
(1 comment)
File vdsm/vm.py
Line 3318:
Federico Simoncelli has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 8:
(1 comment)
File lib/vdsm/tool/transient.py
Line
Federico Simoncelli has posted comments on this change.
Change subject: vm: shared attribute backward compatibility
..
Patch Set 7: Verified+1
Partially verified. I didn't spot any error on the shared attribute but
migration
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 7:
(7 comments)
File lib/vdsm/tool/transient.py
Line
Federico Simoncelli has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 8:
(1 comment)
File lib/vdsm/tool/transient.py
Line
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
..
Patch Set 6: Code-Review+1
It seems straight forward (and at first sight it seems not to break live
Federico Simoncelli has uploaded a new change for review.
Change subject: sd: use the correct default for LEASE_TIME_SEC
..
sd: use the correct default for LEASE_TIME_SEC
Bug-Url:
Federico Simoncelli has uploaded a new change for review.
Change subject: vm: ignore missing shared attribute
..
vm: ignore missing shared attribute
Change-Id: I4d377635b0687baccc69b203cb3fbe8dbf573169
Signed-off-by: Federico
Federico Simoncelli has uploaded a new change for review.
Change subject: fileVolume: improve size checks in _extendSizeRaw
..
fileVolume: improve size checks in _extendSizeRaw
Change-Id:
Federico Simoncelli has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 7:
(1 comment)
File vdsm/vm.py
Line 3384:
Federico Simoncelli has uploaded a new change for review.
Change subject: blockVolume: round up volume size for createVolume
..
blockVolume: round up volume size for createVolume
The logical volume size granularity used in
Federico Simoncelli has posted comments on this change.
Change subject: Fix parent volume rollback after failure to create snapshot
..
Patch Set 7: Code-Review+1
(1 comment)
Federico Simoncelli has posted comments on this change.
Change subject: glusterSD: BZ 988299: Deduce gluster volume name from domain
metadata
..
Patch Set 1: Code-Review-1
(2 comments)
-1 for visibility
Federico Simoncelli has posted comments on this change.
Change subject: sp: update lease parameters on masterMigrate
..
Patch Set 2: Verified+1
Verified migrating the master from one SD to another.
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: sp: update lease parameters on masterMigrate
..
Patch Set 3: Verified+1
Commit change only.
--
To view, visit http://gerrit.ovirt.org/19176
To
Federico Simoncelli has posted comments on this change.
Change subject: Fix parent volume rollback after failure to create snapshot
..
Patch Set 6: Code-Review+1
(2 comments)
Small nits
Federico Simoncelli has uploaded a new change for review.
Change subject: hsm: fix updateVolumeSize for qcow2 volumes
..
hsm: fix updateVolumeSize for qcow2 volumes
Change-Id: I08aa24277d11595e82c93b979c2c34fcf9d09c38
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/19284
to review the following change.
Change subject: imageSharing: return proper size in httpGetSize
..
imageSharing: return
Federico Simoncelli has submitted this change and it was merged.
Change subject: imageSharing: return proper size in httpGetSize
..
imageSharing: return proper size in httpGetSize
When importing images from OpenStack Glance
Federico Simoncelli has posted comments on this change.
Change subject: imageSharing: return proper size in httpGetSize
..
Patch Set 1: Verified+1 Code-Review+2
Same as master.
--
To view, visit http://gerrit.ovirt.org/19284
Federico Simoncelli has posted comments on this change.
Change subject: Fix parent volume rollback after failure to create snapshot
..
Patch Set 6:
(1 comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 6:
(2 comments)
File vdsm/vm.py
Line 1424:
Federico Simoncelli has uploaded a new change for review.
Change subject: imageSharing: return proper size in httpGetSize
..
imageSharing: return proper size in httpGetSize
When importing images from OpenStack Glance the
Federico Simoncelli has posted comments on this change.
Change subject: imageSharing: return proper size in httpGetSize
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19222
To unsubscribe, visit
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: update lease parameters on masterMigrate
..
sp: update lease parameters on masterMigrate
In this patch:
- update lease parameters on masterMigrate
-
Federico Simoncelli has posted comments on this change.
Change subject: sp: update lease parameters on masterMigrate
..
Patch Set 1:
(1 comment)
File vdsm/storage/sp.py
Federico Simoncelli has posted comments on this change.
Change subject: sp: update lease parameters on masterMigrate
..
Patch Set 2:
(1 comment)
File vdsm/storage/sp.py
Federico Simoncelli has submitted this change and it was merged.
Change subject: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv
..
vdsmd.init: Add service-is-managed in shutdown_conflicting_srv
We should not
Federico Simoncelli has posted comments on this change.
Change subject: lib: add create function to the qemuImg module
..
Patch Set 2: Verified+1
In my current use case it works (backup api). Feel free to merge if you need
Federico Simoncelli has uploaded a new change for review.
Change subject: vdsm-tool: handle missing sanlock pid file
..
vdsm-tool: handle missing sanlock pid file
Change-Id: I711d9b413415ca9372520e6bb25cf6d39ff571a3
Federico Simoncelli has posted comments on this change.
Change subject: vdsm-tool: handle missing sanlock pid file
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19112
To unsubscribe, visit
Federico Simoncelli has uploaded a new change for review.
Change subject: vm: small refactor for _normalizeVdsmImg
..
vm: small refactor for _normalizeVdsmImg
Change-Id: Ie68292eee4b82fbe8527e3960739979cfe117dfa
Signed-off-by:
Federico Simoncelli has uploaded a new change for review.
Change subject: hsm: fix sloppy rebase of one shot prepare
..
hsm: fix sloppy rebase of one shot prepare
A sloppy rebase of c072945 One shot prepare removed the changes
Federico Simoncelli has posted comments on this change.
Change subject: hsm: fix sloppy rebase of one shot prepare
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19049
To unsubscribe, visit
Federico Simoncelli has uploaded a new change for review.
Change subject: vdsm-tool: fix qemu-sanlock configuration
..
vdsm-tool: fix qemu-sanlock configuration
Fixing the logic about qemu-sanlock configuration: if sanlock is
Federico Simoncelli has abandoned this change.
Change subject: Adding more qemuImg commands
..
Abandoned
These changes were slowly introduced by other patches.
--
To view, visit http://gerrit.ovirt.org/2612
To unsubscribe,
Federico Simoncelli has uploaded a new change for review.
Change subject: lib: add create function to the qemuImg module
..
lib: add create function to the qemuImg module
Change-Id: I69522cd6231e511d891815248fab9a15cbc987e5
Federico Simoncelli has posted comments on this change.
Change subject: lib: add create function to the qemuImg module
..
Patch Set 1:
(1 comment)
File lib/vdsm/qemuImg.py
Federico Simoncelli has posted comments on this change.
Change subject: spec: remove shared glusterfs requirements
..
Patch Set 1: Verified+1
verified with:
$ rpm -qRp vdsm-gluster-4.12.0-102.gitde6f9a2.el6_4.noarch.rpm
Federico Simoncelli has posted comments on this change.
Change subject: vm: extend shared property to support locking
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/17714
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: vm: extend shared property to support locking
..
Patch Set 8: Verified+1
No relevant changes.
--
To view, visit http://gerrit.ovirt.org/17714
To
Federico Simoncelli has posted comments on this change.
Change subject: Removing has_systemd from sysv script
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18806
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: storage: kill ongoing operations on exit
..
Patch Set 4: Verified+1
Quickly re-verified.
--
To view, visit http://gerrit.ovirt.org/18074
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: storage: kill ongoing operations on exit
..
Patch Set 5: Verified+1
Minor change
--
To view, visit http://gerrit.ovirt.org/18074
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: storage: kill ongoing operations on exit
..
Patch Set 3: Verified+1
Verified using this patch regularly for more than a week. I also verified that
a
Federico Simoncelli has posted comments on this change.
Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..
Patch Set 3: Code-Review-1
(1 comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..
Patch Set 3: -Code-Review
(1 comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: Add tuneBlockDevIo interface
..
Patch Set 14: Code-Review-1
(3 comments)
File vdsm/vm.py
Line
Federico Simoncelli has posted comments on this change.
Change subject: storage: kill ongoing operations on exit
..
Patch Set 3:
(1 comment)
File lib/vdsm/utils.py
Line
Federico Simoncelli has posted comments on this change.
Change subject: Making setStorageDomainDescription the SPM command
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17198
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: vm: extend shared property to support locking
..
Patch Set 5:
(1 comment)
File vdsm/vm.py
Line 1486:
Federico Simoncelli has posted comments on this change.
Change subject: Add transient disk support
..
Patch Set 2:
(3 comments)
File vdsm/vm.py
Line 1391:
Federico Simoncelli has posted comments on this change.
Change subject: vdsmd: remove reconfigure sanlock on 'reconfigure' verb
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18466
To unsubscribe,
Federico Simoncelli has submitted this change and it was merged.
Change subject: vdsmd: remove reconfigure sanlock on 'reconfigure' verb
..
vdsmd: remove reconfigure sanlock on 'reconfigure' verb
reconfigure sanlock is perform
Federico Simoncelli has posted comments on this change.
Change subject: Fix rollback after failure to create snapshot
..
Patch Set 2: Code-Review-1
(5 comments)
File
Federico Simoncelli has posted comments on this change.
Change subject: Remove redundant check that causes lvm cache to refresh every
volume creation
..
Patch Set 4: Code-Review+2
(1 comment)
Minor comment and waiting for
Federico Simoncelli has posted comments on this change.
Change subject: Removing validate sd from spm verbs which calls ckvg and
refreshes the domain metadata on the spm even though the spm already controls
the changes (i.e. a lot of redundant time is wasted)
Federico Simoncelli has posted comments on this change.
Change subject: Removing validate sd from spm verbs which calls ckvg and
refreshes the domain metadata on the spm even though the spm already controls
the changes (i.e. a lot of redundant time is wasted)
Federico Simoncelli has posted comments on this change.
Change subject: hsm: deleteImage fails because of wrong dictionary use
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17383
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: Removing validate sd from spm verbs which calls ckvg and
refreshes the domain metadata on the spm even though the spm already controls
the changes (i.e. a lot of redundant time is wasted)
Federico Simoncelli has posted comments on this change.
Change subject: Remove redundant check that causes lvm cache to refresh every
volume creation
..
Patch Set 5:
(1 comment)
Federico Simoncelli has uploaded a new change for review.
Change subject: spec: remove shared glusterfs requirements
..
spec: remove shared glusterfs requirements
Since we now require glusterfs in the main package we can now
Federico Simoncelli has posted comments on this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Patch Set 1: Code-Review+2
(1 comment)
Given that the requirements are almost the
Federico Simoncelli has posted comments on this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Patch Set 1: Code-Review+1
Temporarily removing +2 as we're still debating on how
Federico Simoncelli has posted comments on this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Patch Set 1:
(1 comment)
Federico Simoncelli has posted comments on this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17994
To
Federico Simoncelli has posted comments on this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Patch Set 1: Verified+1 Code-Review+2
Same as master
--
To view, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support GlusterFS SD
This
Federico Simoncelli has posted comments on this change.
Change subject: Remove redundant check that causes lvm cache to refresh every
volume creation
..
Patch Set 2:
(1 comment)
Federico Simoncelli has posted comments on this change.
Change subject: Remove redundant check that causes lvm cache to refresh every
volume creation
..
Patch Set 1:
(1 comment)
Federico Simoncelli has posted comments on this change.
Change subject: After exception on _recoverExistingVms thread we should try
again
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17617
To
Federico Simoncelli has submitted this change and it was merged.
Change subject: After exception on _recoverExistingVms thread we should try
again
..
After exception on _recoverExistingVms thread we should try again
Currently
Federico Simoncelli has posted comments on this change.
Change subject: Making setStorageDomainDescription the SPM command
..
Patch Set 4: Code-Review-1
(1 comment)
I dropped an idea to setStorageDomainDescription with
Federico Simoncelli has posted comments on this change.
Change subject: Remove redundant check that causes lvm cache to refresh every
volume creation
..
Patch Set 1:
(1 comment)
Federico Simoncelli has posted comments on this change.
Change subject: One shot prepare.
..
Patch Set 10:
(2 comments)
File vdsm/storage/blockSD.py
Line 1033:
Federico Simoncelli has posted comments on this change.
Change subject: One shot prepare.
..
Patch Set 10:
(1 comment)
File vdsm/clientIF.py
Line 257:
Line 258:
Federico Simoncelli has posted comments on this change.
Change subject: Removing validate sd from spm verbs which calls ckvg and
refreshes the domain metadata on the spm even though the spm already controls
the changes (i.e. a lot of redundant time is wasted)
Federico Simoncelli has posted comments on this change.
Change subject: define.py: remove %s from imageErr
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18230
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: Remove redundant check that causes lvm cache to refresh every
volume creation
..
Patch Set 1: Code-Review-1
Marking for visibility
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: Remove redundant check that causes lvm cache to refresh every
volume creation
..
Patch Set 1:
(3 comments)
Federico Simoncelli has posted comments on this change.
Change subject: Removing validate sd from spm verbs which calls ckvg and
refreshes the domain metadata on the spm even though the spm already controls
the changes (i.e. a lot of redundant time is wasted)
Federico Simoncelli has submitted this change and it was merged.
Change subject: define.py: remove %s from imageErr
..
define.py: remove %s from imageErr
imageErr untypically has an %s in the error message.
To make things
Federico Simoncelli has posted comments on this change.
Change subject: Handling ssl error specifically instead of printing all
stacktrace
..
Patch Set 2: Code-Review-1
(1 comment)
Let's just use the regular log string
Federico Simoncelli has posted comments on this change.
Change subject: Handling ssl error specifically instead of printing all
stacktrace
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17917
To
Federico Simoncelli has posted comments on this change.
Change subject: hsm: deleteImage fails because of wrong dictionary use
..
Patch Set 1: Code-Review-1
(2 comments)
Federico Simoncelli has posted comments on this change.
Change subject: One shot prepare.
..
Patch Set 10: Code-Review-1
(6 comments)
File vdsm/storage/blockSD.py
Line
Federico Simoncelli has posted comments on this change.
Change subject: storage: kill ongoing operations on exit
..
Patch Set 1:
(1 comment)
File lib/vdsm/utils.py
Line
Federico Simoncelli has posted comments on this change.
Change subject: One shot prepare.
..
Patch Set 10:
(1 comment)
File vdsm/clientIF.py
Line 257:
Line 258:
Federico Simoncelli has posted comments on this change.
Change subject: hsm: deleteImage fails because of wrong dictionary use
..
Patch Set 1:
(2 comments)
File
Federico Simoncelli has uploaded a new change for review.
Change subject: storage: kill ongoing operations on exit
..
storage: kill ongoing operations on exit
Some storage operations must be forcibly interrupted when the vdsm
Federico Simoncelli has posted comments on this change.
Change subject: Handling signals interrupts, using pidofproc and prevent lock
over systemd
..
Patch Set 6: Code-Review+2
a comment about a future use of flock is good
Federico Simoncelli has submitted this change and it was merged.
Change subject: Handling signals interrupts, using pidofproc and prevent lock
over systemd
..
Handling signals interrupts, using pidofproc and prevent lock over
Federico Simoncelli has posted comments on this change.
Change subject: image: use successor volume size when merging
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17093
To unsubscribe,
Federico Simoncelli has submitted this change and it was merged.
Change subject: image: use successor volume size when merging
..
image: use successor volume size when merging
Volumes in the same image chain might have
Federico Simoncelli has posted comments on this change.
Change subject: image: use successor volume size when merging
..
Patch Set 1: Verified+1 Code-Review+2
Same as master
--
To view, visit http://gerrit.ovirt.org/18025
To
201 - 300 of 1323 matches
Mail list logo
