Change in vdsm[master]: stomp: broker cleanup

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: broker cleanup
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65681
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I972268a72f51975eb78c6bac926e29ac53178dca
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 22: Code-Review-1

this one should be squeezed with https://gerrit.ovirt.org/#/c/64502

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 13: Code-Review+1

you can split the patch and fix the commit msg. but generally for me this patch 
is fine.

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 14: Code-Review+1

lets monitor the sos paths collection in separate bugzilla and add it after 
splitting the constant module (other bugzilla to monitor. please open the two)

-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: infra tests: added functional test for upgrading vdsm
..


Patch Set 15: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: introduce new client

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpc: introduce new client
..


Patch Set 10:

(3 comments)

https://gerrit.ovirt.org/#/c/64502/10/lib/vdsm/client.py
File lib/vdsm/client.py:

Line 108: ServerError will be raised if the command encountered execution error:
Line 109: 
Line 110: vdsm.client.ServerError: Vdsm request failed
Line 111: (code=4, message=Virtual machine already exists)
Line 112: 
you repeat the errors description twice (here and in the call method). I guess 
that the next update won't update both locations so better to have only one 
description
Line 113: 
Line 114: Please note that if the client isn't a context manager, it should be
Line 115: closed at the end of the run:
Line 116: 


Line 192: '''
Line 193: if args is None:
Line 194: args = {}
Line 195: if timeout is None:
Line 196: timeout = self.default_timeout
why not just have it as default values? like "def call(self, method, args={}, 
timeout=self.default_timeout): "

I didn't understand nir's comment about it. why a modification will effect next 
calls?
Line 197: req = yajsonrpc.JsonRpcRequest(method, args, 
reqId=str(uuid.uuid4()))
Line 198: try:
Line 199: responses = self._client.call(req, timeout=timeout)
Line 200: except EnvironmentError as e:


Line 224: try:
Line 225: self.close()
Line 226: except Exception:
Line 227: if t is None:
Line 228: raise
why is this type check ?


-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: Wait for terminated process

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: utils: Wait for terminated process
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/65324/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 737: try:
Line 738: if proc.poll() is None:
Line 739: logging.debug('Terminating process pid=%d' % proc.pid)
Line 740: proc.kill()
Line 741: proc.wait()
Dan said that he doesn't understand my comment - we invented this context to 
cover proc object in such way that won't leave zombies if the context exists in 
the middle - for safety to avoid depending on the old death signal that we had.

Now, instead of just trying to kill the process and "reap" it, the context 
won't continue until the process exits... at least for me it is not the 
expected behavior. however, we still don't use it so we can change it if that 
way you see more usages for this context
Line 742: except Exception:
Line 743: logging.exception('Failed to kill process %d' % proc.pid)
Line 744: 
Line 745: 


-- 
To view, visit https://gerrit.ovirt.org/65324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida04e2c7ba092efdc2927ed9f460b0098ba2ad94
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Refine TerminationTests names

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: tests: Refine TerminationTests names
..


Patch Set 6:

(4 comments)

https://gerrit.ovirt.org/#/c/65326/6//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2016-10-13 14:32:59 +0300
Line 6: 
Line 7: tests: Refine TerminationTests names
Line 8: 
Line 9: - Al the test are testing termination, there is no need to repeat
s/Al/All
Line 10:   the class name in the test names.
Line 11: - Use the tests names to describe the situation tested; terminating a
Line 12:   running process, or kill failure.
Line 13: - Rename fake_kill to fail, describing what this function is doing.


Line 7: tests: Refine TerminationTests names
Line 8: 
Line 9: - Al the test are testing termination, there is no need to repeat
Line 10:   the class name in the test names.
Line 11: - Use the tests names to describe the situation tested; terminating a
s/names/name
Line 12:   running process, or kill failure.
Line 13: - Rename fake_kill to fail, describing what this function is doing.
Line 14: 
Line 15: Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d


Line 9: - Al the test are testing termination, there is no need to repeat
Line 10:   the class name in the test names.
Line 11: - Use the tests names to describe the situation tested; terminating a
Line 12:   running process, or kill failure.
Line 13: - Rename fake_kill to fail, describing what this function is doing.
Rameing ... describes "better" what this function does
Line 14: 
Line 15: Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d


https://gerrit.ovirt.org/#/c/65326/6/tests/utilsTests.py
File tests/utilsTests.py:

Line 101
Line 102
Line 103
Line 104
Line 105
you asked for this name iirc


-- 
To view, visit https://gerrit.ovirt.org/65326
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: Raise detectable error if termination fail

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: utils: Raise detectable error if termination fail
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/65325/6/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 752: proc.kill()
Line 753: proc.wait()
Line 754: except Exception as e:
Line 755: raise TerminatingFailure(proc.pid, e)
Line 756: 
why not to raise the original exception ?
Line 757: 
Line 758: def get_selinux_enforce_mode():
Line 759: """
Line 760: Returns the SELinux mode as reported by kernel.


-- 
To view, visit https://gerrit.ovirt.org/65325
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cfa5434ce011b9185550884233b5b233026d13c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: Wait for terminated process

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: utils: Wait for terminated process
..


Patch Set 5:

we don't use terminating context anywhere yet anyway, only in execmd itself 
when calling communicate which should be stuck if the process still runs. if 
this context manager waits for the process I wouldn't call it "terminating", it 
just signals the process and wait for it to exit

-- 
To view, visit https://gerrit.ovirt.org/65324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida04e2c7ba092efdc2927ed9f460b0098ba2ad94
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 10: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/59151/10/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 603: """
Line 604: reactor = Reactor()
Line 605: 
Line 606: def start():
Line 607: thread = threading.Thread(target=reactor.process_requests,
> is this a rebase problem? I don't see why this change is wanted/related
this also doesn't change anything. daemon=True is the deafult in out concurrent 
module
Line 608:   name='Client %s:%s' % (host, port))
Line 609: thread.setDaemon(True)
Line 610: thread.start()
Line 611: 


-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: spec: Require ioprocess 0.15.2

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: spec: Require ioprocess 0.15.2
..


spec: Require ioprocess 0.15.2

The first time IOProcess.truncate() or IOProcess.touch() is called,
ioprocess keep the file open and will never close it.

Typically when using with vdsm, ioprocess will keep the
__DIRECT_IO_TEST__ file open on shared storage, since the first thing
vdsm does is touching this file.

Keeping open files on shared storage may prevent activation of a storage
domain after it was deactivated.

This is a 3.6 only patch, 4.0 already requires ioprocess 0.16.1
containing this fix.

Change-Id: Ia1fba8f5bfb84e9ff60478e36a09f1690ca6989a
Bug-Url: https://bugzilla.redhat.com/1370564
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/63038
Reviewed-by: Francesco Romani 
Reviewed-by: Yaniv Bronhaim 
---
M vdsm.spec.in
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Verified; Passed CI tests
  Yaniv Bronhaim: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1fba8f5bfb84e9ff60478e36a09f1690ca6989a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: infra tests: added functional test for upgrading vdsm
..


Patch Set 14:

please trigger check_merged job so we'll see the output - 
jenkins.ovirt.org/job/vdsm_master_check-merged-fc24-x86_64/

-- 
To view, visit https://gerrit.ovirt.org/61186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Allow tox to run all checkers in one shot.

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: build: Allow tox to run all checkers in one shot.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63633
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3efc6e2d6318841892f3cf5bfa27a621922ed025
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 20:

(1 comment)

https://gerrit.ovirt.org/#/c/35181/20/contrib/jsonrpc
File contrib/jsonrpc:

Line 72: from yajsonrpc import stompreactor, JsonRpcRequest, JsonRpcError
Line 73: 
Line 74: 
Line 75: # Suppress unhelpful warnings
Line 76: warnings.simplefilter("ignore", DeprecationWarning)
why do we need that?
Line 77: 
Line 78: 
Line 79: class UsageError(Exception):
Line 80: """ Raised when your hold it in the wrong way """


-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 10: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: spec: Require ioprocess 0.15.2

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: spec: Require ioprocess 0.15.2
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1fba8f5bfb84e9ff60478e36a09f1690ca6989a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: remove capsTests from blacklist

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: py3: remove capsTests from blacklist
..


Patch Set 2: Code-Review+1

good ! thanks

-- 
To view, visit https://gerrit.ovirt.org/64363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49264d5eaa19bb957c69461dfb1cdfe641294037
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sos: collect 'nodectl info' output

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: sos: collect 'nodectl info' output
..


sos: collect 'nodectl info' output

CEE needs a quick and reliable way to determine release information
from a customer's sosreport. nodectl is installed RHV-H by default
and the output of 'nodectl info' provides a nice summary of the
available images and their boot options as well as the current image/layer
in use. If the command doesn't exist it will be ignored by sos report.

Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1372093
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/63775
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M vdsm/sos/vdsm.py.in
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/63775
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vdsm: Do not modify warnings filter in a library
..


vdsm: Do not modify warnings filter in a library

vdsm.vdscli was modifying warnings filter, taking control from the
application importing it. With the old code, there is no way to disable
the warnings - if the application sets a warnings filter, importing
vdscli will override the application filter.

This warnings is highly unwanted, causing user facing warnings each time
you run a vdsClient or hosted-engine command.

This patch removes the wrong filter, returning control to the application
using vdscli. Since warnings are hidden by default, this removes the
unwanted warnings from vdsClient and hosted-engine command line tools.

Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Bug-Url: https://bugzilla.redhat.com/1377069
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/64100
Continuous-Integration: Jenkins CI
Reviewed-by: Simone Tiraboschi 
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/64258
---
M lib/vdsm/vdscli.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.connect

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.connect
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59702
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19b6f25c17e697702ec61eba6b11f256c1df4d83
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: return type fixes for LVMVolumeGroup.getInfo

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: return type fixes for LVMVolumeGroup.getInfo
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59708
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc2b2a3d1e8b4563b24c60601c44e851f2603e6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: return type fixes for StoragePool.getInfo

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: return type fixes for StoragePool.getInfo
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59707
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeadf2323d2a3535a5777d0cc16027cfb9e42f0e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: return type fixes for StoragePool.getSpmStatus

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: return type fixes for StoragePool.getSpmStatus
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59706
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb9fbae250507d4cf02ef9b73eee6403a06cd9d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: return type fixes for Task.getStatus

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: return type fixes for Task.getStatus
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ce3e3ab2e21e5d1f6da6bdf5dc89a3db40e2160
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Remove python-argparse requirement

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Remove python-argparse requirement
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Remove python-argparse requirement

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Remove python-argparse requirement
..


Patch Set 1:

cstratak reached me in irc as python maintainer and asked to remove this 
requirement from our spec now when its part of stdlib. it used to be Provides 
by python2.7 so we it was redundant anyway. but now he wants to remove this 
Provides as he plans to rename it to python2-argparse and this will break our 
build

-- 
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Remove python-argparse requirement

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Remove python-argparse requirement
..

Remove python-argparse requirement

This package has been obsoleted in Fedora because it got in to stdlib.

Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e
Signed-off-by: Yaniv Bronhaim 
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/64162/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index c09b9a9..abe5f7e 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -138,7 +138,6 @@
 Requires: PyYAML
 Requires: python-netaddr
 Requires: python-inotify
-Requires: python-argparse
 Requires: python-cpopen >= 1.4
 Requires: python-ioprocess >= 0.16.1-1
 Requires: python-pthreading >= 0.1.3-3


-- 
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

I wonder if we don't want both the warning and a log print

-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 138
Line 139
Line 140
Line 141
Line 142
> This will show warnings if you run python with warnings enabled.
and if you don't you'll never see it. so for what? you can just write it to 
syslog


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 3:

most developers run "make rpm" directly instead of "make check", as this is 
what we advice to do in [1]. with this patch developers will probably avoid 
running the tests at all

[1]https://www.ovirt.org/develop/developer-guide/vdsm/developers/

-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Mark integration tests

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: tests: Mark integration tests
..


Patch Set 6: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/55730/6//COMMIT_MSG
Commit Message:

Line 9: Mark tests that test the environment and not vdsm code as integration
Line 10: tests. This skip the tests in make check and prevent failures on travis
Line 11: and jenkins.
Line 12: 
Line 13: Integration tests should run separately in a special environment, not
can you elaborate what "special environment" means?
Line 14: during regular make check.
Line 15: 
Line 16: These tests still fail on travis:
Line 17: 


Line 20: 
Line 21: utilsTests.CommandPathTests
Line 22: testExistingNotInPaths  
FAIL
Line 23: 
Line 24: I marked these tests as @brokentest for now, will look into them later.
please separate it from the "mark integration tests" idea
Line 25: 
Line 26: Note: outOutProcessTests fail because ioprocess is not installed in the
Line 27: docker image. This must be fixed in the image.
Line 28: 


Line 23: 
Line 24: I marked these tests as @brokentest for now, will look into them later.
Line 25: 
Line 26: Note: outOutProcessTests fail because ioprocess is not installed in the
Line 27: docker image. This must be fixed in the image.
just add it to contrib/Dockerfile - there is no need to mention it here
Line 28: 
Line 29: Change-Id: I056dc7534bde94a157e750f6699db4fe6a3aff27


-- 
To view, visit https://gerrit.ovirt.org/55730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I056dc7534bde94a157e750f6699db4fe6a3aff27
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 138
Line 139
Line 140
Line 141
Line 142
I don't see any use for leaving the warning here that way. the all idea was to 
make it bold to the users


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG
Commit Message:

Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
> This is wrong usage of warnings, causing user facing regression in any prog
this was supposed to be only in master and the idea was to remove the usages 
and catch them quickly - this is exactly what we have here which is good - lets 
replace the usages and remove the warning from 4.0
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Line 22: Bug-Url: https://bugzilla.redhat.com/1377069


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 142: 
Line 143: 
Line 144: _devel.warning(
Line 145: "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please 
use "
Line 146: "vdsm.jsonrpcvdscli")
> Please remove this change from the patch, as devel logger is not good solut
I really don't understand your expectation. I suggest to keep it and focus on 
the areas that imports vdscli. for 4.0 please remove this warning at all, leave 
it only on master and we'll move forward with replacing usages. in 4.1 we will 
remove vdscli at all
Line 147: 
Line 148: 
Line 149: if __name__ == '__main__':
Line 150: print('connecting to %s:%s ssl %s ts %s' % (


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64099/2/client/vdsClient.py
File client/vdsClient.py:

Line 28: import re
Line 29: import shlex
Line 30: import socket
Line 31: import pprint as pp
Line 32: import logging
> Not in this patch, this should be backported to 4.0, only minimal changes h
In 4.0 I prefer that you will remove the warning usage in vdscli at all. 
Although, as I mentioned before, Dan requested for that
Line 33: 
Line 34: from six.moves import xmlrpc_client
Line 35: 
Line 36: # Must configure logging before importing vdsm modules, some modules 
may log


-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cache: Add caching decorator with invalidation

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: cache: Add caching decorator with invalidation
..


Patch Set 6: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/34709
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dd8fb29d94286e3e3a3e29b8218501cbdc5c018
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vitor de Lima 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cache: Add caching decorator with invalidation

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: cache: Add caching decorator with invalidation
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/34709/6/lib/vdsm/cache.py
File lib/vdsm/cache.py:

Line 1: #
Line 2: # Copyright 2014 Red Hat, Inc.
2016 - and please move this module to infra package
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


-- 
To view, visit https://gerrit.ovirt.org/34709
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dd8fb29d94286e3e3a3e29b8218501cbdc5c018
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vitor de Lima 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG
Commit Message:

Line 13: 
Line 14: This warnings is highly unwanted, causing user facing warnings each 
time
Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
s/remove/removes
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77


Line 14: This warnings is highly unwanted, causing user facing warnings each 
time
Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
s/hare/are s/remove/removes
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Line 22: Bug-Url: https://bugzilla.redhat.com/1377069


Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
Maintainers' conflict? Dan wanted it that way exactly. I guess this warning has 
a purpose and the purpose was achieved. I susgest to focus about removing the 
usages and with that also the warning will disappear
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Line 22: Bug-Url: https://bugzilla.redhat.com/1377069


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
..


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/64099/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: vdsClient: Configure logging before imports
Line 8: 
Line 9: Because vdscli logs devel warning on import, we get this unwanted
Line 10: error from the logging module:
please rebase over https://gerrit.ovirt.org/#/c/62209/ if its part of it
Line 11: 
Line 12:No handlers could be found for logger "devel"
Line 13: 
Line 14: Configuring logging avoids this error.


https://gerrit.ovirt.org/#/c/64099/2/client/vdsClient.py
File client/vdsClient.py:

Line 28: import re
Line 29: import shlex
Line 30: import socket
Line 31: import pprint as pp
Line 32: import logging
> Since imports are not sorted, we cannot add logging in the correct place.
please sort it and rebase
Line 33: 
Line 34: from six.moves import xmlrpc_client
Line 35: 
Line 36: # Must configure logging before importing vdsm modules, some modules 
may log


-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: functional tests: fix supervdsmServer test

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: functional tests: fix supervdsmServer test
..


Patch Set 19: Code-Review+1

amazing. much simpler

-- 
To view, visit https://gerrit.ovirt.org/61902
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: build: Remove python 3 test run

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: build: Remove python 3 test run
..


Patch Set 1:

please verify.

-- 
To view, visit https://gerrit.ovirt.org/61189
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6723272a95b407e3fa9ad8e12f595d0b8f0d6a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63765/1/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 131: self.collectExtOutput("/sbin/fdisk -l")
Line 132: self.collectExtOutput("/usr/bin/iostat")
Line 133: self.collectExtOutput("/sbin/iscsiadm -m node")
Line 134: self.collectExtOutput("/sbin/iscsiadm -m session")
Line 135: self.collectExtOutput("/usr/sbin/nodectl info")
I don't have /usr/sbin/nodectl over my f24 and centos7 .. should we run it only 
over rhv-h?
Line 136: 
Line 137: with closing(_connectToVdsm()) as cli:
Line 138: self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")
Line 139: self.addObjectAsFile(cli.getVdsStats(), "getVdsStats")


-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 15: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3:

Yes Nir, I really don't understand your concern, we remove here the status 
field to avoid overriding for that key. returning a list means that the value 
of vmList key is a list. all return vals are dicts and those patches don't 
change it.

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: logUtils: add devel_warn function

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: lib: logUtils: add devel_warn function
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62209/2/lib/vdsm/logUtils.py
File lib/vdsm/logUtils.py:

Line 254: _devlog = logging.getLogger('devel')
Line 255: 
Line 256: 
Line 257: def devel_warn(message):
Line 258: if config.getboolean('devel', 'python_warnings_enable'):
> This is very ugly we should kill this option instead.
i guess we shouldn't want this config value if we don't use the broken python 
warning module anymore


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: vdscli: switch to the new devel_warn helper

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: lib: vdscli: switch to the new devel_warn helper
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/62211/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 139: 
Line 140: 
Line 141: devel_warn
Line 142: "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please 
use "
Line 143: "vdsm.jsonrpcvdscli")
> We don't need this warning, adding a comment that the module is deprecated 
Dan requested for that, and I agree that it helps to notice when vdscli is 
being used.
Line 144: 
Line 145: 
Line 146: if __name__ == '__main__':
Line 147: print('connecting to %s:%s ssl %s ts %s' % (


-- 
To view, visit https://gerrit.ovirt.org/62211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1189097826e79290cb996657ccf34a7c2b611ee0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/62628/5/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 57
Line 58
Line 59
Line 60
Line 61
how is this removal related to the use of dump-volume-chains?


Line 126: self.collectExtOutput("/usr/bin/iostat")
Line 127: self.collectExtOutput("/sbin/iscsiadm -m node")
Line 128: self.collectExtOutput("/sbin/iscsiadm -m session")
Line 129: 
Line 130: with closing(jsonrpcvdscli.connect()) as cli:
this change can be done in different patch
Line 131: self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")
Line 132: self.addObjectAsFile(cli.getVdsStats(), "getVdsStats")
Line 133: self.addObjectAsFile(cli.getAllVmStats(), "getAllVmStats")
Line 134: self.addObjectAsFile(cli.list(), "list")


-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/62324/14/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:

Line 121: 
Line 122: 
Line 123: def _get_volume_info(server, vol_uuid, img_uuid, sd_uuid, sp_uuid):
Line 124: res = _call_server(
Line 125: server.getVolumeInfo, vol_uuid, sp_uuid, sd_uuid, img_uuid)
why do you change this line? please mention it in the commit msg .
Line 126: return res['info']
Line 127: 
Line 128: 
Line 129: def _get_volumes_chains(server, sd_uuid):


-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: change getConnectedStoragePoolsList result key
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix Host.getVMList command result

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: fix Host.getVMList command result
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix Host.getVMList command result

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: fix Host.getVMList command result
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Adding build-artifacts-manual.sh script

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62559
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70ed044ff9c8bc89c75e6c5e3669373468fadc1c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Adding build-artifacts-manual.sh script

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Adding build-artifacts-manual.sh script
..


Adding build-artifacts-manual.sh script

Adding build-artifacts-manual.sh script and related
packages and repos files.
build-artifacts-manual.sh is used for creating rpms from an
existing tarball. It assumes that the tarball already exists
in the projects directory and builds srpms and rpms, and moves
the files to exported_artifacts directory.
See more info here: https://gerrit.ovirt.org/#/c/62811/

Change-Id: I70ed044ff9c8bc89c75e6c5e3669373468fadc1c
Signed-off-by: Sharon Naftaly 
Reviewed-on: https://gerrit.ovirt.org/62559
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
---
A automation/build-artifacts-manual.packages.el7
A automation/build-artifacts-manual.packages.fc23
A automation/build-artifacts-manual.repos.el7
A automation/build-artifacts-manual.repos.fc23
A automation/build-artifacts-manual.sh
5 files changed, 40 insertions(+), 0 deletions(-)

Approvals:
  Sharon Naftaly: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/62559
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I70ed044ff9c8bc89c75e6c5e3669373468fadc1c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: mom: create the socket under tmpdir

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: tests: mom: create the socket under tmpdir
..


tests: mom: create the socket under tmpdir

Some tests may fail under automation if Vdsm
is built and its test are run under a too nested
directory.
This because the absolute path of the UNIX domain
socket becomes too long.

To fix this, we create the socket under a temporary
directory.
This also makes cleanup a little easier.

Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/63129
Continuous-Integration: Jenkins CI
Tested-by: Sharon Naftaly 
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Irit Goihman 
Reviewed-by: Martin Sivák 
Reviewed-by: Eyal Edri 
---
M tests/momTests.py
1 file changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, but someone else must approve
  Sharon Naftaly: Verified
  Eyal Edri: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63129
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: after_vm_destroy.py: migrate to jsonrpcvdscli

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62383
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f3fa6479dde2c4a1298d0ae167d888d9f7e020a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix Host.getVMList command result

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: fix Host.getVMList command result
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/62773/4/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 331: 
Line 332: rc, out, err = commands.execCmd([_restoreconCommandPath.cmd,
Line 333: '-Rv', mountPoint])
Line 334: if rc:
Line 335: raise ge.GlusterHostFailedToRunRestorecon(mountPoint, rc, 
out, err)
> this is not possible with gluster. We don't maintain the bricks list in vds
Isn't there a way to scan for the brick list ?
Line 336: 


-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: static: move man

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: static: move man
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62549/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-08-18 15:36:21 +0200
Line 4: Commit: Martin Polednik 
Line 5: CommitDate: 2016-09-06 13:09:06 +0200
Line 6: 
Line 7: static: move man
please give better description here :) and explain why do you do this move
Line 8: 
Line 9: Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490


-- 
To view, visit https://gerrit.ovirt.org/62549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 4:

(4 comments)

https://gerrit.ovirt.org/#/c/62773/4/lib/vdsm/gluster/exception.py
File lib/vdsm/gluster/exception.py:

Line 481: 
Line 482: class GlusterHostFailedToSetSelinuxContext(GlusterHostException):
Line 483: code = 4420
Line 484: 
Line 485: def __init__(self, brickMountPoint=None, rc=0, out=(), err=()):
why having default None? the print will be redundant when its None
Line 486: self.rc = rc
Line 487: self.out = out
Line 488: self.err = err
Line 489: self.message = "Failed to set selinux context on the brick : 
%s" \


https://gerrit.ovirt.org/#/c/62773/4/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 57: _semanageCommandPath = utils.CommandPath("semanage",
Line 58:  "/sbin/semanage",
Line 59:  "/usr/sbin/semanage",)
Line 60: _restoreconCommandPath = utils.CommandPath("restorecon",
Line 61:"/sbin/restorecon",
in gluster/api.py you use selinux.restorecon . why here you don't use the 
selinux package?
Line 62:"/usr/sbin/restorecon",)
Line 63: 
Line 64: # All size are in MiB unless otherwise specified
Line 65: DEFAULT_CHUNK_SIZE_KB = 256


Line 58:  "/sbin/semanage",
Line 59:  "/usr/sbin/semanage",)
Line 60: _restoreconCommandPath = utils.CommandPath("restorecon",
Line 61:"/sbin/restorecon",
Line 62:"/usr/sbin/restorecon",)
we also have RESTORECON_PATH - maybe you can fix RESTORECON_PATH's paths and 
use it?
Line 63: 
Line 64: # All size are in MiB unless otherwise specified
Line 65: DEFAULT_CHUNK_SIZE_KB = 256
Line 66: DEFAULT_METADATA_SIZE_KB = 16777216


Line 331: 
Line 332: rc, out, err = commands.execCmd([_restoreconCommandPath.cmd,
Line 333: '-Rv', mountPoint])
Line 334: if rc:
Line 335: raise ge.GlusterHostFailedToRunRestorecon(mountPoint, rc, 
out, err)
maybe this should be part of vdsm-tool configure sebool 
(configurators/sebool.py) ? if selinux was disabled when this function was 
called but later turned to enabled - nothing will set the context. in vdsm 
documentation we should ask users to run vdsm-tool configure after changing 
selinux state
Line 336: 


-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: jsonvdscli: change hostname default
..


jsonvdscli: change hostname default

We want to mitigate dns lookups due to potential issues with
connectivity or dns servers.


Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Signed-off-by: Piotr Kliczewski 
Bug-Url: https://bugzilla.redhat.com/1358530
Reviewed-on: https://gerrit.ovirt.org/63308
Reviewed-by: Irit Goihman 
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Tested-by: Irit Goihman 
---
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/vdscli.py
M tests/vdsClientTests.py
3 files changed, 4 insertions(+), 7 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 1: Code-Review+2

please verify

-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: draft: spec modification to pass koji build

[ybronhei]

Yaniv Bronhaim has abandoned this change.

Change subject: draft: spec modification to pass koji build
..


Abandoned

not relevant

-- 
To view, visit https://gerrit.ovirt.org/63265
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie4dd839ace307fea0c7449cee173b9a26170ac0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: added VM cont verb

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: added VM cont verb
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f740c83517850251f2ed3f6fd64c87a263e404f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: v2v: filter out Xen VMs with block storage

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: v2v: filter out Xen VMs with block storage
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63133
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: v2v: filter out Xen VMs with block storage

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: v2v: filter out Xen VMs with block storage
..


v2v: filter out Xen VMs with block storage

virt-v2v is not support importing Xen VMs with block storage domain.
No need to return these VMs via get_external_vms verb

Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Bug-Url: https://bugzilla.redhat.com/1365411
Signed-off-by: Shahar Havivi 
Reviewed-on: https://gerrit.ovirt.org/62368
Reviewed-by: Tomas Golembiovsky 
Tested-by: Shahar Havivi 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/63133
Reviewed-by: Nir Soffer 
Reviewed-by: Yaniv Bronhaim 
---
M lib/vdsm/v2v.py
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Shahar Havivi: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Tomas Golembiovsky: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63133
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: functional tests: fix supervdsmServer test

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: functional tests: fix supervdsmServer test
..


Patch Set 16:

(1 comment)

https://gerrit.ovirt.org/#/c/61902/16//COMMIT_MSG
Commit Message:

Line 9: supervdsmServer dropPrivileges function is switching root user to
Line 10: a non privileged user but not switching the user back to root. It 
causes
Line 11: other tests which require root user to fail.
Line 12: it's not possible to switch to root from non privileged user so
Line 13: every test is done in a seprate process so the user won't be changed
> It is possible to switch to root from non-privilege user, but you have to u
- we don't need that, you can change the commit msg

- although I thought you aim to elimate the usage of our own test utils, but as 
we already have those tools in our tree using @forked might be cool
Line 14: 
Line 15: Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b


-- 
To view, visit https://gerrit.ovirt.org/61902
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: functional tests: fix supervdsmServer test

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: functional tests: fix supervdsmServer test
..


Patch Set 16: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61902
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Vdsm supports only x86, ppc and ppc64

[ybronhei]

Yaniv Bronhaim has abandoned this change.

Change subject: Vdsm supports only x86, ppc and ppc64
..


Abandoned

not needed.

-- 
To view, visit https://gerrit.ovirt.org/62465
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic6f7a7d9aac6033b60fe592749bab2613b62466a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: stomp: make sure that stomp connection is active before send...

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: make sure that stomp connection is active before sending 
messages
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f6881d7966fa47031d027740633ca83c834387f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: mom: create the socket under tmpdir

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: tests: mom: create the socket under tmpdir
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62779
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Using %{?_smp_mflags} for make calls

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Using %{?_smp_mflags} for make calls
..


Patch Set 4:

we saw the comment. thanks

-- 
To view, visit https://gerrit.ovirt.org/62163
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I290734e0ac4db6d6891428a9c149d631f5b705f8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: draft: spec modification to pass koji build

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: draft: spec modification to pass koji build
..


Patch Set 1:

(1 comment)

I stop the work on that till storage group helps with the /rhev issue. they can 
run and fix the tests in koji as well.

btw, if someone wants to proceed with the process - 
http://koji.fedoraproject.org/koji/taskinfo?taskID=15498934 the build works , 
so this is the direction, only trigger after having the src.rpm and tar with 
this patch

and I forgot the link - [1] 
https://askubuntu.com/questions/505506/how-to-get-bash-or-ssh-into-a-running-container-in-background-mode

https://gerrit.ovirt.org/#/c/63265/1/configure.ac
File configure.ac:

Line 247: AC_SUBST([vdsmbackupdir], ['${vdsmlogdir}/backup'])
Line 248: AC_SUBST([vdsmexecdir], ['${libexecdir}/vdsm'])
Line 249: AC_SUBST([vdsmhooksdir], ['${vdsmexecdir}/hooks'])
Line 250: AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm'])
Line 251: AC_SUBST([vdsmrepo], ['/var/run/vdsm/storage/repo'])
> This is not possible, not only because of migrations, this also require cha
Man, please give options here at least... it doesn't help only to say that its 
wrong. Im trying to save the ack that we've got from fedora guys, and you 
resist to help with a ticket. So.. I'm listening.
Line 252: AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm'])
Line 253: AC_SUBST([vdsmnetinfodir], ['${vdsmpylibdir}/network/netinfo'])
Line 254: AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool'])
Line 255: AC_SUBST([configuratorsdir], ['${vdsmtooldir}/configurators'])


-- 
To view, visit https://gerrit.ovirt.org/63265
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4dd839ace307fea0c7449cee173b9a26170ac0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: draft: spec modification to pass koji build

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: draft: spec modification to pass koji build
..

draft: spec modification to pass koji build

* Until figure issue [1] we cancel noarch for 2 sub-packages.
* make tests fail in koji
* replacing /rhev usage - migration won't work

Change-Id: Ie4dd839ace307fea0c7449cee173b9a26170ac0f
Signed-off-by: Yaniv Bronhaim 
---
M configure.ac
M vdsm.spec.in
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/63265/1

diff --git a/configure.ac b/configure.ac
index 5756499..726b533 100644
--- a/configure.ac
+++ b/configure.ac
@@ -248,7 +248,7 @@
 AC_SUBST([vdsmexecdir], ['${libexecdir}/vdsm'])
 AC_SUBST([vdsmhooksdir], ['${vdsmexecdir}/hooks'])
 AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm'])
-AC_SUBST([vdsmrepo], ['/rhev/data-center'])
+AC_SUBST([vdsmrepo], ['/var/run/vdsm/storage/repo'])
 AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm'])
 AC_SUBST([vdsmnetinfodir], ['${vdsmpylibdir}/network/netinfo'])
 AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool'])
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 53434e6..ddae430 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -326,7 +326,7 @@
 %package python
 Summary:VDSM python libraries
 Requires:   %{name}-api = %{version}-%{release}
-BuildArch:  noarch
+# BuildArch:  noarch
 Requires:   python-cpopen >= 1.4
 Requires:   m2crypto
 Requires:   python-ioprocess >= 0.16.1-1
@@ -668,7 +668,7 @@
 
 %package hook-fcoe
 Summary:Hook to enable FCoE support
-BuildArch:  noarch
+# BuildArch:  noarch
 Requires:   %{name} = %{version}-%{release}
 Requires:   fcoe-utils
 
@@ -783,7 +783,7 @@
  %{buildroot}%{_sysconfdir}/libvirt/hooks/qemu
 
 %check
-make tests
+# make tests
 
 %pre
 # Force standard locale behavior (English)


-- 
To view, visit https://gerrit.ovirt.org/63265
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4dd839ace307fea0c7449cee173b9a26170ac0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Fix makefile - move config.log to right location

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Fix makefile - move config.log to right location
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: stomp: improve message id handling during response send

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: improve message id handling during response send
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49185
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21102b03245da7906d5618ba9e0f9811e8864c34
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: certificates: remove config.read call

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: certificates: remove config.read call
..


certificates: remove config.read call

config.read(file) loads a new configuration to 'config' based on the
file it reads. This call causes a bug and incosistency of vdsm 
configuration since it overrides the right configuration.
config should be built from files in pre configured paths (drop-in
dirs) with priority determined by configuration file names.


Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1368115
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/62885
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/62941
---
M lib/vdsm/tool/configurators/certificates.py
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: Obsolete actual vdsm-infra packages

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: spec: Obsolete actual vdsm-infra packages
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63215
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3a832fa02f0538ac9a22dfabfd291928ca4db7b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: Obsolete actual vdsm-infra packages

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: spec: Obsolete actual vdsm-infra packages
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63215
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3a832fa02f0538ac9a22dfabfd291928ca4db7b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Fix makefile - move config.log to right location

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Fix makefile - move config.log to right location
..

Fix makefile - move config.log to right location

Probably by mistake config.log was declared in wrong location and caused
failure in rpmbuild run

Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80
Signed-off-by: Yaniv Bronhaim 
---
M vdsm_hooks/checkips/Makefile.am
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/63221/1

diff --git a/vdsm_hooks/checkips/Makefile.am b/vdsm_hooks/checkips/Makefile.am
index 4b25acd..9d2c014 100644
--- a/vdsm_hooks/checkips/Makefile.am
+++ b/vdsm_hooks/checkips/Makefile.am
@@ -27,9 +27,10 @@
 
 nodist_noinst_DATA = \
vdsm-checkips.service \
-   config.log
+   $(NULL)
 
 CLEANFILES = \
+   config.log \
$(nodist_noinst_DATA)
 
 EXTRA_DIST = \


-- 
To view, visit https://gerrit.ovirt.org/63221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: certificates: remove config.read call

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: certificates: remove config.read call
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Using %{?_smp_mflags} for make calls

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Using %{?_smp_mflags} for make calls
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62163/2/vdsm.spec.in
File vdsm.spec.in:

Line 743: %endif
Line 744: --with-qemu-kvm='@QEMU_KVM_PKG@' \
Line 745: --with-qemu-img='@QEMU_IMG_PKG@'
Line 746: 
Line 747: make %{?_smp_mflags}
> How does it fail exactly? (`make -j4 rpm' works fine on my system.)
this works, but change the spec with the above flag and then run make rpm. when 
rpmbuild run the %build part it fails around the checkips script
Line 748: # Setting software_version and software_revision in dsaversion.py
Line 749: baserelease=`echo "%{release}" | sed 
's/\([0-9]\+\(\.[0-9]\+\)\?\).*/\1/'`
Line 750: baseversion=`echo "%{version}" | sed 
's/\([0-9]\+\(\.[0-9]\+\)\?\).*/\1/'`
Line 751: rawversion=%{version}-%{release}


-- 
To view, visit https://gerrit.ovirt.org/62163
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I290734e0ac4db6d6891428a9c149d631f5b705f8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: remove bond0 hack

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: automation: remove bond0 hack
..


automation: remove bond0 hack

`echo -bond0 > /sys/class/net/bonding_masters` is causing
check-merged job to fail since bond0 doesn't exist.
bond0 used to be added implicitly when bonding kernel module
was loaded but there are merged patches that solve this issue.

Change-Id: I7b5ff287058bd9f4063d9eda6921a690645a3c5f
Label: ovirt-4.0-only
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/62889
Reviewed-by: Yaniv Bronhaim 
Continuous-Integration: Yaniv Bronhaim 
Reviewed-by: Edward Haas 
---
M automation/deploy.sh
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
  Irit Goihman: Verified
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/62889
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b5ff287058bd9f4063d9eda6921a690645a3c5f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: remove bond0 hack

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: automation: remove bond0 hack
..


Patch Set 1: Code-Review+2 Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/62889
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b5ff287058bd9f4063d9eda6921a690645a3c5f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: certificates: remove config.read call

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: certificates: remove config.read call
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62885
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org