Douglas Schilling Landgraf has posted comments on this change.
Change subject: Ship the version file with the tarballs
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#833425 Change cpu topology source to /sys.
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Check if libvirtd.upstart is present before copying
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has abandoned this change.
Change subject: vdsmd.init: remove validation to reload config
..
Patch Set 1: Abandoned
http://gerrit.ovirt.org/#/c/7375/ replaces this patch.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#849542 bootstrap: set system time as soon as possible
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: Adding hostname as Require
..
vdsm.spec: Adding hostname as Require
vdsm-gencerts.sh requires hostname
Change-Id:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Adding hostname as Require
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7385
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Ship the version file with the tarballs
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: use python scripts from ovirtnode
..
Patch Set 3: (2 inline comments)
I need to execute new tests, ASAP I will update here.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#848843 Check if libvirtd.upstart is present before copying
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script
..
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: use python scripts from ovirtnode
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/7074
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
..
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
..
Patch Set 9: (1 inline comment)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: tc: add to PEP8_WHITELIST
..
Patch Set 1: I would prefer that you didn't submit this
Dan, not sure if this happened with you as well (with a clean
Douglas Schilling Landgraf has posted comments on this change.
Change subject: make vdsm/libvirtvm.py PEP 8 clean
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6561
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Check if libvirtd.upstart is present before copying
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configNet: grant proper selinux context to ifcfg-*
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: survive missing ntpq
..
Patch Set 1: I would prefer that you didn't submit this
The vdsm.spec requires ntp, which provides ntpq. Any
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: survive missing ntpq
..
Patch Set 1: Looks good to me, but someone else must approve
Hi,
I see the point and agree with your comments.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: survive missing ntpq
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7597
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: node id: consider bonding MAC addresses as well
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Check if libvirtd.upstart is present before copying
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/7375
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#833425 Change cpu topology source to /sys.
..
Patch Set 13:
I still prefer the libvirt approach. We already depend of libvirt, why not use
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Remove superfluous macros in the specfile
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Remove superfluous macros in the specfile
..
Patch Set 1:
I meant, 1) I have tested installed vdsm by rpm. 2) I have executed make
install inside
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: sync utils.getHostUUID() with deployUtil.getHostID()
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: add is_libvirtd_run method and improve comments.
..
Patch Set 2: (1 inline comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 7: (1 inline comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: add is_libvirtd_run method and improve comments.
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: changed upstart_libvirt function name
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 7: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/7487
To
Douglas Schilling Landgraf has abandoned this change.
Change subject: nfs-check: check if temp dir exists
..
Patch Set 4: Abandoned
--
To view, visit http://gerrit.ovirt.org/3167
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 7: (1 inline comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Trigger reboot automatically after upgrade
..
Patch Set 2:
I have just changed the call to use the full argument.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd: set nwfilter on ovirt-node
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7821
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd: set nwfilter on ovirt-node
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7821
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine.py: fix nodeCleanup() call
..
Patch Set 4: (1 inline comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Trigger reboot automatically after upgrade
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7778
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add the autotools support in the spec file
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine.py: fail if Password doesn't match
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7917
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine.py: fail if Password doesn't match
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/7917
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine.py: fail if Password doesn't match
..
Patch Set 3: (1 inline comment)
About:
One more thought; do we have to worry about how
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm-reg-setup: get hostname with gethostname()
..
vdsm-reg-setup: get hostname with gethostname()
Currently, if Node users use TUI to replace the
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg-setup: get hostname with gethostname()
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7939
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Replace 'ovirt Engine' string with @ENGINENAME@
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine.py: fail if Password doesn't match
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/7917
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: setNetworking(): return bridge status
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6875
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: setNetworking(): return bridge status
..
Patch Set 2: I would prefer that you didn't submit this
new patch will come with WARN not FAIL
--
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: setNetworking(): return bridge status
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6875
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: add is_libvirtd_run method and improve comments.
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in: Requires: python-libguestfs
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#856167 - Verify downloaded CA certificate
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#856167 - Parse correctly the management_server parameter
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#856167 - Verify downloaded CA certificate
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 1: (1 inline comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8029
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#856167 - Parse correctly the management_server parameter
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded SSH public key
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded CA certificate
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Logging shouldn't reach the terminal console
..
Patch Set 1: I would prefer that you didn't submit this
Following federico -1... to avoid showing
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#856167 - Store engine CA cert in enginecacert.pem
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 3: (2 inline comments)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 3: (1 inline comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8029
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: stressCheckTest fails because it passes the rlimit
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec.in: use locale LC_ALL
..
vdsm.spec.in: use locale LC_ALL
During VDSM instalation, we verify if SELinux booleans are
enabled with return
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in: use locale LC_ALL
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8068
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/8029
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 4: (1 inline comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Validate downloaded CA certificate
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8021
Douglas Schilling Landgraf has posted comments on this change.
Change subject: add and use hypervisor autodetection in bootstrap.
..
Patch Set 4: I would prefer that you didn't submit this
Looking the current comments, new
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in: use locale LC_ALL=C
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8068
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add input parameter to _logExec
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8095
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 3: (2 inline comments)
Hi Fernando, IMO, you could split your patch. Also, fell free to add your name
into
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Validate downloaded CA certificate
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8021
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Validate downloaded SSH public key
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8018
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 4: Looks good to me, but someone else must approve
+1 Based on mailing list
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd: await for libvirt with systemd, too.
..
Patch Set 1:
Hi Dan, looks correct your change but it doesn't resolve the
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsmd.init: verify if libvirt socket file exists
..
vdsmd.init: verify if libvirt socket file exists
Currently, VDSM init script checks if libvirt
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.init: verify if libvirt socket file exists
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd: await for libvirt with systemd, too.
..
Patch Set 2: Verified
Dan, your patch + http://gerrit.ovirt.org/#/c/8175/ make vdsm work again
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8039
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.init: verify if libvirt socket file exists
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.init: verify if libvirt socket file exists
..
Patch Set 2:
Hi Dan, your comment make sense, thanks for this catch! New patch available for
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.init: verify if libvirt socket file exists
..
Patch Set 2: (1 inline comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.init: verify if libvirt socket file exists
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.init: verify if libvirt socket file exists
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8037
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8037
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Support for the new polkit rules
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8213
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add load_needed_modules.py to gitignore
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine.py: fix nodeCleanup() call
..
Patch Set 4: (1 inline comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Use 'yum clean expire-cache' instead of 'yum clean all'
..
Patch Set 1: Looks good to me, but someone else must approve
Doron/Dan might have
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Include vds_name parameter for node registration
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: Use virsh to check if libvirt is up
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: setup: configure selinux for sanlock on nfs
..
Patch Set 1: I would prefer that you didn't submit this
-1 since I have a question: Should'n we add
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: Use virsh to check if libvirt is up
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
Alright guys, that's ok. From
1 - 100 of 1676 matches
Mail list logo
