Re: [Warzone-dev] Commit guidelines are in effect

2008-08-24 Thread Per Inge Mathisen
On Mon, Aug 25, 2008 at 5:03 AM, bugs buggy <[EMAIL PROTECTED]> wrote: > About these guidelines, take this: > > " Patches as a rule go into the patch tracker. Give a quick run down of what > it does and what it changes." > > Does it matter which tracker? No. But if the tracker doesn't email the li

Re: [Warzone-dev] [Warzone-commits] r5865 - in /trunk: lib/framework/debug.h src/intdisplay.c src/map.c src/move.c

2008-08-24 Thread Per Inge Mathisen
On Mon, Aug 25, 2008 at 2:29 AM, Giel van Schijndel <[EMAIL PROTECTED]> wrote: > Hmm, the "program defefensively" I've learned to know means "try to > *detect* and handle every/most errors" it doesn't mean recovering from > them. That's just a terminology issue though, so don't interpret that > las

Re: [Warzone-dev] [Warzone-commits] r5865 - in /trunk: lib/framework/debug.h src/intdisplay.c src/map.c src/move.c

2008-08-24 Thread Per Inge Mathisen
On Mon, Aug 25, 2008 at 2:41 AM, Giel van Schijndel <[EMAIL PROTECTED]> wrote: > Then lets discuss it now. Unfortunately I'm not too good at estimating > what kind of changes you would like to discuss before committing and > which not. Then try to err on the side of caution. >> So my most pertine

Re: [Warzone-dev] Commit guidelines are in effect

2008-08-24 Thread bugs buggy
On 8/24/08, Per Inge Mathisen <[EMAIL PROTECTED]> wrote: > > See http://wiki.wz2100.net/Commit_guidelines About these guidelines, take this: " Patches as a rule go into the patch tracker. Give a quick run down of what it does and what it changes." Does it matter which tracker? The Trac tracker

Re: [Warzone-dev] [Warzone-commits] r5865 - in /trunk: lib/framework/debug.h src/intdisplay.c src/map.c src/move.c

2008-08-24 Thread Giel van Schijndel
Per Inge Mathisen schreef: > This is the kind of change that I would love to have been able to > discuss before it was committed. There was no reason to hurry it > though. Then lets discuss it now. Unfortunately I'm not too good at estimating what kind of changes you would like to discuss before c

Re: [Warzone-dev] [Warzone-commits] r5865 - in /trunk: lib/framework/debug.h src/intdisplay.c src/map.c src/move.c

2008-08-24 Thread Giel van Schijndel
Dennis Schridde schreef: > Am Sonntag, 24. August 2008 23:12:18 schrieb Dennis Schridde: >> Am Sonntag, 24. August 2008 22:55:48 schrieb Per Inge Mathisen: >>> On Sun, Aug 24, 2008 at 5:42 PM, Giel van Schijndel <[EMAIL PROTECTED]> >>> wrote: * Change an ASSERT that checks calloc's return va

Re: [Warzone-dev] [Warzone-commits] r5865 - in /trunk: lib/framework/debug.h src/intdisplay.c src/map.c src/move.c

2008-08-24 Thread Dennis Schridde
Am Sonntag, 24. August 2008 23:12:18 schrieb Dennis Schridde: > Am Sonntag, 24. August 2008 22:55:48 schrieb Per Inge Mathisen: > > On Sun, Aug 24, 2008 at 5:42 PM, Giel van Schijndel <[EMAIL PROTECTED]> > > wrote: > > > * Change an ASSERT that checks calloc's return value into an if() > > > bloc

Re: [Warzone-dev] [Warzone-commits] r5865 - in /trunk: lib/framework/debug.h src/intdisplay.c src/map.c src/move.c

2008-08-24 Thread Per Inge Mathisen
On Sun, Aug 24, 2008 at 11:12 PM, Dennis Schridde <[EMAIL PROTECTED]> wrote: > Aside of that I think we could add a out-of-memory "handler", or some more > generic way of handling the most common errors. > Why? So we can inform the user in a nicer manner than "application X was > terminated in an u

Re: [Warzone-dev] [Warzone-commits] r5865 - in /trunk: lib/framework/debug.h src/intdisplay.c src/map.c src/move.c

2008-08-24 Thread Dennis Schridde
Am Sonntag, 24. August 2008 22:55:48 schrieb Per Inge Mathisen: > On Sun, Aug 24, 2008 at 5:42 PM, Giel van Schijndel <[EMAIL PROTECTED]> wrote: > > * Change an ASSERT that checks calloc's return value into an if() block > > (we can also run out of memory on non-debug builds...) > > I am also rath

Re: [Warzone-dev] [Warzone-commits] r5865 - in /trunk: lib/framework/debug.h src/intdisplay.c src/map.c src/move.c

2008-08-24 Thread Per Inge Mathisen
On Sun, Aug 24, 2008 at 5:42 PM, Giel van Schijndel <[EMAIL PROTECTED]> wrote: > * Change an ASSERT that checks calloc's return value into an if() block (we > can also run out of memory on non-debug builds...) I am also rather mystified by this. When we fail to allocate memory and do not handle

Re: [Warzone-dev] [Warzone-commits] r5865 - in /trunk: lib/framework/debug.h src/intdisplay.c src/map.c src/move.c

2008-08-24 Thread Per Inge Mathisen
On Sun, Aug 24, 2008 at 5:42 PM, Giel van Schijndel <[EMAIL PROTECTED]> wrote: > Author: muggenhor > Date: Sun Aug 24 17:42:59 2008 > New Revision: 5865 > > URL: http://svn.gna.org/viewcvs/warzone?rev=5865&view=rev > Log: > * Split ASSERT out into ASSERT_HELPER: > * ASSERT_HELPER can be used by d

[Warzone-dev] Commit guidelines are in effect

2008-08-24 Thread Per Inge Mathisen
See http://wiki.wz2100.net/Commit_guidelines ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev

Re: [Warzone-dev] [Warzone-commits] r5864 - in /branches/2.1: ./ src/display.c src/droid.c src/init.c src/mission.c

2008-08-24 Thread Per Inge Mathisen
On Sun, Aug 24, 2008 at 4:55 PM, Giel van Schijndel <[EMAIL PROTECTED]> wrote: > Author: muggenhor > Date: Sun Aug 24 16:55:50 2008 > New Revision: 5864 > > URL: http://svn.gna.org/viewcvs/warzone?rev=5864&view=rev > Log: > Merged revision r5861 into the 2.1 branch via svnmerge from trunk > > .

Re: [Warzone-dev] Trunk On OS X

2008-08-24 Thread Tim Baumgartner
Ari Johnson wrote: > On Sat, Aug 23, 2008 at 2:50 PM, Freddie Witherden > <[EMAIL PROTECTED]> wrote: >> Hi all, >> >> I have just got around to compiling off trunk on OS X 10.5. This >> required two changes: >> • Updating the QuesoGLC version to trunk r832; >> • Changing the include path for GLC