Re: [webkit-dev] Patch process - let's make it better

2009-07-15 Thread Adam Treat
On Friday 10 July 2009 06:55:59 pm Maciej Stachowiak wrote: * Phase 1 * A) Make it really easy to submit a patch. Eric's bugzilla-tool is close to being there. I'm going to help him refine this tool to the point that submitting a patch has only one step - a single command will make the

Re: [webkit-dev] Patch process - let's make it better

2009-07-15 Thread Ojan Vafai
On Wed, Jul 15, 2009 at 1:14 PM, Adam Treat tr...@kde.org wrote: http://www.webkit.org/pending-review The page above already lists the review queue sorted by date. Over the last few days the queue has numbered in the 100's. A significant fraction (50%+) are older than a week. I could

Re: [webkit-dev] Patch process - let's make it better

2009-07-15 Thread Maciej Stachowiak
I'll try to get bugs filed for any part of the plan that isn't done by tomorrow, and I'll tag them with a keyword so we can track progress. On Jul 15, 2009, at 1:14 PM, Adam Treat wrote: On Friday 10 July 2009 06:55:59 pm Maciej Stachowiak wrote: * Phase 1 * A) Make it really easy to

Re: [webkit-dev] Patch process - let's make it better

2009-07-15 Thread David Kilzer
On Saturday, July 11, 2009 11:55:36 AM, Maciej Stachowiak wrote: On Jul 11, 2009, at 9:39 AM, Darin Adler wrote: On Jul 10, 2009, at 4:23 PM, Maciej Stachowiak wrote: Perhaps we should make update-webkit (or some new wrapper type tool) run resolve-ChangeLogs automatically. Dave

Re: [webkit-dev] Patch process - let's make it better

2009-07-15 Thread Maciej Stachowiak
On Jul 15, 2009, at 4:13 PM, David Kilzer wrote: On Saturday, July 11, 2009 11:55:36 AM, Maciej Stachowiak wrote: On Jul 11, 2009, at 9:39 AM, Darin Adler wrote: On Jul 10, 2009, at 4:23 PM, Maciej Stachowiak wrote: Perhaps we should make update-webkit (or some new wrapper type tool)

Re: [webkit-dev] Patch process - let's make it better

2009-07-13 Thread Maciej Stachowiak
Hi Luke, I think your webkit-dev emails are becoming disruptive. Sending profanity-laced walls of text is not an appropriate use of this list. Please find a way to communicate without annoying the rest of the list, or I will ask the list administrators to censor you from the mailing list

Re: [webkit-dev] Patch process - let's make it better

2009-07-13 Thread Ariya Hidayat
I think your webkit-dev emails are becoming disruptive. Sending profanity-laced walls of text is not an appropriate use of this list. Please find a way to communicate without annoying the rest of the list, or I will ask the list administrators to censor you from the mailing list for the

Re: [webkit-dev] Patch process - let's make it better

2009-07-13 Thread Luke Kenneth Casson Leighton
On 7/13/09, Maciej Stachowiak m...@apple.com wrote: Hi Luke, hi maciej, I think your webkit-dev emails are becoming disruptive. whilst at the same time apologising for being disruptive, i'd like to ask you why you consider that to be a bad thing. Sending profanity-laced walls of text

Re: [webkit-dev] Patch process - let's make it better

2009-07-13 Thread Luke Kenneth Casson Leighton
I concur with Maciej. Luke, in some other culture your posts are already considered derogatory and insulting. dear ariya, i apologise for that. i invite you to consider this, especially in light of the subject being discussed: if there was not a deep seated problem with the way that

Re: [webkit-dev] Patch process - let's make it better

2009-07-13 Thread Luke Kenneth Casson Leighton
On 7/13/09, Luke Kenneth Casson Leighton luke.leigh...@googlemail.com wrote: I concur with Maciej. Luke, in some other culture your posts are already considered derogatory and insulting. also - (i apologise for not thinking of this earlier) - it's worth emphasising that early on

Re: [webkit-dev] Patch process - let's make it better

2009-07-13 Thread Luke Kenneth Casson Leighton
On 7/13/09, Maciej Stachowiak m...@apple.com wrote: Hi Luke, I think your webkit-dev emails are becoming disruptive. Sending profanity-laced [apologised and explained already] walls of text maciej, i thought i'd best pick up on this one and nip it in the bud, even though i've replied

Re: [webkit-dev] Patch process - let's make it better

2009-07-13 Thread Holger Freyther
On Monday 13 July 2009 13:47:13 Luke Kenneth Casson Leighton wrote: On 7/13/09, Luke Kenneth Casson Leighton luke.leigh...@googlemail.com wrote: I concur with Maciej. Luke, in some other culture your posts are already considered derogatory and insulting. also - (i apologise

Re: [webkit-dev] Patch process - let's make it better

2009-07-12 Thread Luke Kenneth Casson Leighton
Hi everyone, One common topic for discussion has been how to make our process around patch submission better. As the project grows, it's becoming more important for this process to work really smoothly, and we are seeing some breakdowns. well, this is interesting - some good timing on

Re: [webkit-dev] Patch process - let's make it better

2009-07-11 Thread Darin Adler
On Jul 10, 2009, at 4:23 PM, Maciej Stachowiak wrote: Perhaps we should make update-webkit (or some new wrapper type tool) run resolve-ChangeLogs automatically. Dave Kilzer had the same idea when he created resolve-ChangeLogs, so update-webkit does run resolve-ChangeLogs automatically. See

Re: [webkit-dev] Patch process - let's make it better

2009-07-11 Thread Maciej Stachowiak
On Jul 11, 2009, at 9:39 AM, Darin Adler wrote: On Jul 10, 2009, at 4:23 PM, Maciej Stachowiak wrote: Perhaps we should make update-webkit (or some new wrapper type tool) run resolve-ChangeLogs automatically. Dave Kilzer had the same idea when he created resolve-ChangeLogs, so

Re: [webkit-dev] Patch process - let's make it better

2009-07-10 Thread Chris Marrin
On Jul 10, 2009, at 3:55 PM, Maciej Stachowiak wrote: Hi everyone, One common topic for discussion has been how to make our process around patch submission better. As the project grows, it's becoming more important for this process to work really smoothly, and we are seeing some

Re: [webkit-dev] Patch process - let's make it better

2009-07-10 Thread Mark Rowe
On 2009-07-10, at 16:17, Chris Marrin wrote: On Jul 10, 2009, at 3:55 PM, Maciej Stachowiak wrote: Hi everyone, One common topic for discussion has been how to make our process around patch submission better. As the project grows, it's becoming more important for this process to work

Re: [webkit-dev] Patch process - let's make it better

2009-07-10 Thread Dan Bernstein
On Jul 10, 2009, at 4:17 PM, Chris Marrin wrote: The annoying part is the fact that I ALWAYS get conflicts in at least one Changelog file when I try to check in. I have to fix these by hand, do svn resolved, and try to check in again. No you don’t. You can just use

Re: [webkit-dev] Patch process - let's make it better

2009-07-10 Thread Maciej Stachowiak
On Jul 10, 2009, at 4:17 PM, Chris Marrin wrote: On Jul 10, 2009, at 3:55 PM, Maciej Stachowiak wrote: Hi everyone, One common topic for discussion has been how to make our process around patch submission better. As the project grows, it's becoming more important for this process to

Re: [webkit-dev] Patch process - let's make it better

2009-07-10 Thread Jan Michael Alonzo
Hi Maciej === Action Plan === * Phase 1 * snip C) Improve the way we get attention from reviewers. I think we should do three things here: C.1) Split review queues, based on our emerging [Bracket] convention for patches needing specialized review. If we find more areas of

Re: [webkit-dev] Patch process - let's make it better

2009-07-10 Thread Maciej Stachowiak
On Jul 10, 2009, at 4:41 PM, Jan Michael Alonzo wrote: Hi Maciej === Action Plan === * Phase 1 * snip C) Improve the way we get attention from reviewers. I think we should do three things here: C.1) Split review queues, based on our emerging [Bracket] convention for patches needing

Re: [webkit-dev] Patch process - let's make it better

2009-07-10 Thread David Kilzer
On Friday, July 10, 2009 3:55:59 PM, Maciej Stachowiak wrote: A) Make it really easy to submit a patch. Eric's bugzilla-tool is close to being there. I'm going to help him refine this tool to the point that submitting a patch has only one step - a single command will make the patch, file

Re: [webkit-dev] Patch process - let's make it better

2009-07-10 Thread Brent Fulgham
The resolve-ChangeLogs script will fix it for you automatically. Perhaps we should make update-webkit (or some new wrapper type tool) run resolve-ChangeLogs automatically. It's embarassing for me to admit, but I've been part of the WebKit project for nearly a year and didn't know about