Re: [Wicket-develop] Model change in 2.0

2006-09-14 Thread Martijn Dashorst
The outcome of this statement is unclear... Should the IWrapModel go? It is still there (woogle is down, so I can't search the irc logs, to find if there was a conclusion) Martijn On 6/22/06, Igor Vaynberg [EMAIL PROTECTED] wrote: johan, you are back? my gut tells me we should start with

Re: [Wicket-develop] Model change in 2.0

2006-09-14 Thread Johan Compagner
i don't think we can remove it completely. At specific points i have to know if the modeli have now in the componet is a wrap model so that i can do things or call the getNestedModel()that method getNestedModel() can be removed from IModel if it where me and added to IWrapModel johanOn 9/15/06,

Re: [Wicket-develop] Model change in 2.0

2006-09-14 Thread Martijn Dashorst
Perhaps I'm suffering from late night drowziness, but if I look at ResourceModel, I don't see the need for wrapping the object. The assignment is purely for getting the component. I think a better interface name would be INeedMyComponentModel. So resourcemodel.wrapOnAssignment(Component

Re: [Wicket-develop] Model change in 2.0

2006-09-14 Thread Johan Compagner
what would happen if you share that model over more then one component?(like you do with compoundmodel by default, i agree with resource on assigment is it maybe a bit different but doesn't have to be)johan On 9/15/06, Martijn Dashorst [EMAIL PROTECTED] wrote: Perhaps I'm suffering from late night

Re: [Wicket-develop] Model change in 2.0

2006-06-22 Thread Martijn Dashorst
+1 for 2.0 less is more. Martijn On 6/21/06, Eelco Hillenius [EMAIL PROTECTED] wrote: If we can can rid of it, all the better. I don't think the semantics are great, and they are covered through other means now. If we remove getNestedModel, we should also remove

Re: [Wicket-develop] Model change in 2.0

2006-06-22 Thread Matej Knopp
I also think we should get rid of getNestedModel and IWrapModel. Anyone objects? -Matej Martijn Dashorst wrote: +1 for 2.0 less is more. Martijn On 6/21/06, Eelco Hillenius [EMAIL PROTECTED] wrote: If we can can rid of it, all the better. I don't think the semantics are great, and

Re: [Wicket-develop] Model change in 2.0

2006-06-22 Thread Matej Knopp
public interface IInheritableModelT extends IModelT { C IModelC wrapOnInhertance(ComponentC component); } But maybe it makes sense to have a Marker interface for inherited models. -Matej Eelco Hillenius wrote: getNestedModel was what we plussed on, right? I'm not sure how you can do

Re: [Wicket-develop] Model change in 2.0

2006-06-22 Thread Matej Knopp
Btw., ICompoundModel is no longer used, is it? Matej Knopp wrote: public interface IInheritableModelT extends IModelT { C IModelC wrapOnInhertance(ComponentC component); } But maybe it makes sense to have a Marker interface for inherited models. -Matej Eelco Hillenius wrote:

Re: [Wicket-develop] Model change in 2.0

2006-06-22 Thread Johan Compagner
no compound is inheritableAnd i still don't know if that should really returns a IWrapModel thing or just a IModelThe question is do we really need to know if it is a wrap model in some cases.Don't know. johanOn 6/22/06, Matej Knopp [EMAIL PROTECTED] wrote: Btw., ICompoundModel is no longer used,

Re: [Wicket-develop] Model change in 2.0

2006-06-22 Thread Igor Vaynberg
johan, you are back?my gut tells me we should start with IModel and then if we run into a situation that realy really requires us to know about the wrapper we should introduce iwrapmodel back.-Igor On 6/22/06, Johan Compagner [EMAIL PROTECTED] wrote: no compound is inheritableAnd i still don't

Re: [Wicket-develop] Model change in 2.0

2006-06-21 Thread Matej Knopp
Sorry, I meant getNestedModel of course (as there's no such thing as getWrappedModel). Matej Knopp wrote: Hi, I'm going through the big model change in 2.0 and I noticed that now we have IWrapModel, but IModel still contains getWrappedModel(). Wouldn't it be cleaner if the

Re: [Wicket-develop] Model change in 2.0

2006-06-21 Thread Matej Knopp
I'm looking bit deeper and it seems that the semantics of IWrapModel is slightly different than I though, so just silently ignore the question :) Matej Knopp wrote: Sorry, I meant getNestedModel of course (as there's no such thing as getWrappedModel). Matej Knopp wrote: Hi, I'm going

Re: [Wicket-develop] Model change in 2.0

2006-06-21 Thread Eelco Hillenius
If we can can rid of it, all the better. I don't think the semantics are great, and they are covered through other means now. If we remove getNestedModel, we should also remove wicket.Component#sameRootModel(wicket.Component) and wicket.Component#sameRootModel(IModel) and update the documentation.