[Wikitech-l] IIS Test Environment (Short URLs)
I've finished Nginx and Lighttpd support for the short URL building tool (http://shorturls.redwerks.org/) and I also have unfinished support for thumbnail handlers on the alpha (http://shorturls.jade.redwerks.org/). I am wondering if anyone has spare resources they can use to give me a temporary test environment for IIS with administrator privileges. Essentially I want to setup IIS, install MediaWiki on it, and then configure short urls on it determining the best way to do it as I have done for both Nginx and Lighttpd. Then after that implement support for it into the short URL builder and then re-configure the server and wiki to make sure the config works. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Images in wikipedia
When using wikipedia and clicking on an image it opens up on a new page. Wouldn't it be nice if it just scaled-up on the same page using JS. Is there an extension there for this? and if yes why not implemented on wikipedia? -- With Regards Nischay Nahata B.tech 3rd year Department of Information Technology NITK,Surathkal irc-nick nischayn22 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Images in wikipedia
În data de 27 februarie 2012, 11:06, nischay nahata nischay...@gmail.com a scris: When using wikipedia and clicking on an image it opens up on a new page. Wouldn't it be nice if it just scaled-up on the same page using JS. Is there an extension there for this? and if yes why not implemented on wikipedia? There used to be a user script for that. I have a modified version at http://ro.wikipedia.org/w/index.php?title=Utilizator:Strainu/picture_popups.js if you're interested in the code. I can't seem to find the original version and I haven't used the script in a long time, so there are no guarantees it still works. Strainu ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r105809]: New comment added, and revision status changed
Hashar changed the status of MediaWiki.r105809 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105809#c31501 Old Status: ok New Status: resolved Commit summary for MediaWiki.r105809: Update wfArrayToCGI and wfCgiToArray: - 'foo' = '' now outputs foo= instead of the key being omitted - 'foo' = null and 'foo' = false now omit the key instead of outputting foo= - Added a test to make sure that 'foo' = true outputs foo=1 - Fixed a php notice caused when passing a =value-less bit like qwerty to wfCgiToArray by treating it like php and extracting it as 'qwerty' = '' - Updated tests Hashar's comment: Caused Bug 34736 - empty limit on special pages causes navigation issues Fixed by r112474 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112474]: New comment added
Hashar posted a comment on MediaWiki.r112474.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112474#c31502
Commit summary for MediaWiki.r112474:
(bug 34736) empty limit on special pages causes navigation issues
On special pages, the older link showed a limit='' query parameter which
made the page show nothing ('' is evalued to a limit of 0 articles).
The cause is r105809 which changed the way we interprets parameters in
wfArrayToCGI() and wfCGIToArray(). Previously, An empty string value would skip
the key, after r105809, we need to use null.
Hashar's comment:
Tagging for 1.19 since that is a regression :-]
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112478]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112478 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112478 Old status: new New status: ok Commit summary for MediaWiki.r112478: Update tags. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112446]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112446 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112446 Old status: new New status: ok Commit summary for MediaWiki.r112446: Follow-up r112445. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112445]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112445 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112445 Old status: new New status: ok Commit summary for MediaWiki.r112445: Remove out- from Shapado groups. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112436]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112436 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112436 Old status: new New status: ok Commit summary for MediaWiki.r112436: Use local context ( $this-msg() ) instead of global method wfMessage() per IAlex. Follows-up r112433. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Images in wikipedia
On Mon, Feb 27, 2012 at 3:39 PM, Strainu strain...@gmail.com wrote: There used to be a user script for that. I have a modified version at http://ro.wikipedia.org/w/index.php?title=Utilizator:Strainu/picture_popups.js if you're interested in the code. I can't seem to find the original version and I haven't used the script in a long time, so there are no guarantees it still works. Strainu I am not looking for any code. But want to know why is it not implemented in en.wikipedia.org? -- With Regards Nischay Nahata B.tech 3rd year Department of Information Technology NITK,Surathkal ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112389]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112389 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112389 Old status: new New status: ok Commit summary for MediaWiki.r112389: Update tags. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112390]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112390 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112390 Old status: new New status: ok Commit summary for MediaWiki.r112390: Follow-up r112389: replace spaces by underscores. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112391]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112391 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112391 Old status: new New status: ok Commit summary for MediaWiki.r112391: Update tags. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112479]: New comment added, and revision status changed
Siebrand changed the status of MediaWiki.r112479 to fixme and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112479#c31503
Old Status: new
New Status: fixme
Commit summary for MediaWiki.r112479:
Combine getLanguageNames and getTranslatedLanguageNames into one function which
is much easier and more logical to use. Does not contain any actual changes yet
in what the function does.
* Reduces the overly long code in r107002, and reduces code for {{#language:}}
* Fixes the language list in Special:Translate which contained languages that
gave invalid code when selecting
Siebrand's comment:
Translate needs to remain compatible with the latest stable, which is 1.18.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112479]: New comment added, and revision status changed
SPQRobin changed the status of MediaWiki.r112479 to new and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112479#c31504
Old Status: fixme
New Status: new
Commit summary for MediaWiki.r112479:
Combine getLanguageNames and getTranslatedLanguageNames into one function which
is much easier and more logical to use. Does not contain any actual changes yet
in what the function does.
* Reduces the overly long code in r107002, and reduces code for {{#language:}}
* Fixes the language list in Special:Translate which contained languages that
gave invalid code when selecting
SPQRobin's comment:
When fetchLanguageNames is not found, it takes LanguageNames::getNames, i.e.
CLDR directly, so it doesn't need to use getTranslatedLanguageNames. (It's even
better this way, because the mentioned problem was present when calling
getTranslatedLanguageNames.)
Confirmed that it works using a 1.18 checkout with trunk Translate.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107002]: New comment added
SPQRobin posted a comment on MediaWiki.r107002. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107002#c31505 Commit summary for MediaWiki.r107002: follow-up to r106912, making change to correct branch this time SPQRobin's comment: Did this in a better way: r112479 (a new hook would've made it even messier) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] IIS Test Environment (Short URLs)
On 02/27/2012 03:38 AM, Daniel Friesen wrote: I've finished Nginx and Lighttpd support for the short URL building tool (http://shorturls.redwerks.org/) and I also have unfinished support for thumbnail handlers on the alpha (http://shorturls.jade.redwerks.org/). I am wondering if anyone has spare resources they can use to give me a temporary test environment for IIS with administrator privileges. Essentially I want to setup IIS, install MediaWiki on it, and then configure short urls on it determining the best way to do it as I have done for both Nginx and Lighttpd. Then after that implement support for it into the short URL builder and then re-configure the server and wiki to make sure the config works. I have a couple of contacts at Microsoft who might be able to help you out. Contacting them. Grace, Doug, can you get this MediaWiki developer a test environment with IIS? -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111087]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111087 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111087 Old status: new New status: ok Commit summary for MediaWiki.r111087: IncubatorTest: Redirect $redlink=1 back to the normal page also for sister projects InfoPage: a better title for unrecognised languages: put unknown code after the title instead of using it as parameter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111821]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111821 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111821 Old status: new New status: resolved Commit summary for MediaWiki.r111821: Use numbered variables. Follows-up r111272. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111825]: New comment added
Nikerabbit posted a comment on MediaWiki.r111825. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111825#c31506 Commit summary for MediaWiki.r111825: Follow-up r111272, r111821: *facepalm* Nikerabbit's comment: It used to be $traArray[$i], now it is $defArray[$i]. Was that intentional change? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111272]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111272 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111272 Old status: new New status: resolved Commit summary for MediaWiki.r111272: * Move hard coded styles in MessageWebImporter to CSS. * Break long line. * Bump version. * Update an unanswered @todo. * Add MessageGroups::getAllMessageGroups() as a replacement of MessageGroups::getGroups() * Update MessageGroups::getAllMessageGroups() to reduce code duplication in export.php and sync-group.php. Added two optional parameters: ** $groups: Get an array of groups for an array of group IDs. ** $groupPrefix: Get an array of groups with a given prefix. * Exit export.php if no valid group IDs are given. * i18n for two hard coded strings. * Add FIXME for missing i18n. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111725]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111725 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111725 Old status: new New status: resolved Commit summary for MediaWiki.r111725: Qunit test cases for the grammar support in mw.jqueryMsg added in r111646 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] IIS Test Environment (Short URLs)
I have a iis server aivable that is currently not in use. You could use that if it can be europe based, 2012/2/27, Sumana Harihareswara suma...@wikimedia.org: On 02/27/2012 03:38 AM, Daniel Friesen wrote: I've finished Nginx and Lighttpd support for the short URL building tool (http://shorturls.redwerks.org/) and I also have unfinished support for thumbnail handlers on the alpha (http://shorturls.jade.redwerks.org/). I am wondering if anyone has spare resources they can use to give me a temporary test environment for IIS with administrator privileges. Essentially I want to setup IIS, install MediaWiki on it, and then configure short urls on it determining the best way to do it as I have done for both Nginx and Lighttpd. Then after that implement support for it into the short URL builder and then re-configure the server and wiki to make sure the config works. I have a couple of contacts at Microsoft who might be able to help you out. Contacting them. Grace, Doug, can you get this MediaWiki developer a test environment with IIS? -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Verzonden vanaf mijn mobiele apparaat Kind regards, Huib Laurens WickedWay.nl Webhosting the wicked way. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111867]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r111867 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111867#c31507 Old Status: new New Status: resolved Commit summary for MediaWiki.r111867: * Some refactoring for parseGettextData() * Remove remaining pre 1.18 compat. Nikerabbit's comment: Good enough for now. I'd combine the four output parameters passed by reference into one parameter. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108938]: New comment added
SPQRobin posted a comment on MediaWiki.r108938. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108938#c31508 Commit summary for MediaWiki.r108938: (Bug 33553) Babel AutoCreate should not be able to create categories it is not allowed to create (protected titles) SPQRobin's comment: Now that it's in 1.19wmf1 (and actually deployed on most wikis), it doesn't need to be in 1.18wmf1 anymore, so it's okay. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112479]: New comment added
Siebrand posted a comment on MediaWiki.r112479.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112479#c31509
Commit summary for MediaWiki.r112479:
Combine getLanguageNames and getTranslatedLanguageNames into one function which
is much easier and more logical to use. Does not contain any actual changes yet
in what the function does.
* Reduces the overly long code in r107002, and reduces code for {{#language:}}
* Fixes the language list in Special:Translate which contained languages that
gave invalid code when selecting
Siebrand's comment:
Thanks, Robin.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111995]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111995 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111995 Old status: new New status: ok Commit summary for MediaWiki.r111995: Make the input method rules of Narayam testable. Remove some of the tests added in r111990 since they need to be rewritten in ext.narayam.rules.tests.js using keypress simulation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112341]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112341 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112341 Old status: new New status: ok Commit summary for MediaWiki.r112341: Reverting r110725 - doesn't seem to be relevant anymore. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Asking for a mysql test: patch submitted: authentication on Wikipedia via user_name OR user_email
Le 23 févr. 2012 à 02:01, phoebe ayers a écrit : On Wed, Feb 22, 2012 at 4:24 AM, Nicolas Brouard brou...@ined.fr wrote: Thank you for your support. I just submitted a complete patch entitled Can't authenticate using my mother language username (UNICODE) when I only have (a public) access to Wikipedia with an ASCII (english) keyboard in about 20 languages on https://bugzilla.wikimedia.org/show_bug.cgi?id=34590 People supporting this idea, please for it. Cool! See also: https://bugzilla.wikimedia.org/show_bug.cgi?id=28085, a bug I submitted ages ago based on feedback I've gotten talking to users who only occasionally edited. The idea is that that remembering a username can be a barrier to casual editing (a few tries to remember a username that you don't use much and you might just give up) -- and being able to log in with an email address might help make things smoother Thank you for pointing me on your older bug that I didn't find on Bugzilla before I submitted this current bug. The aim was different but the solution to be found is the same. I haven't seen a proposed patch neither by yourself nor anyone else, am I wrong? Concerning the patch submitted, and in order to have an idea of the pertinence of it for other MediaWikis sites than mine and Wikipedia too, I am asking people having access to the standard user database of their wikis to process this next mysql command. The question is how many people are sharing a unique e-mail with several usernames? mysql -u wikiadmin -p wikidb mysql select email_freq, COUNT(email_freq) FROM (select user_email, COUNT(user_email) as email_freq FROM prefix_user WHERE user_email NULL GROUP BY user_email ) AS DISTRIB GROUP BY email_freq; Here is the result on mine: ++---+ | email_freq | COUNT(email_freq) | ++---+ | 1 | 3047 | | 2 |22 | | 3 | 1 | ++---+ On the above example, 22 users have 2 usernames having the same e-mail. 1 have 3, and all the others have an e-mail link to a unique username. I suppressed the number of people having no e-mail authenticated (NULL). The benefit of this patch won't be as good on Wikipedia user table, but I would be happy if you know who I can ask in order to get the results. I was guessing 90% but I am probably pessimistic... -- Nicolas -- phoebe ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [Wikimedia r1346]: New comment added, and revision status changed
Jpostlethwaite changed the status of Wikimedia.r1346 to new and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1346#c31510
Old Status: fixme
New Status: new
Commit summary for Wikimedia.r1346:
Added $effort_id as a parameter to _queue2civicrm_contribution_insert(). See
r1212.
Jpostlethwaite's comment:
If I did is_null(), you could potentially get zeros in the $effort_id:
pre
// $effort_id = 0;
if ( !empty($effort_id)) {
$trxn_id .= ' - ' . (integer) $effort_id;
}
// $trxn_id = 'GLOBALCOLLECT RECURRING-0'
/pre
This would potentially cause bad data if there were some other error that
caused $effort_id to be zero or an empty string as opposed to null.
I could put a line into sanitize $effort_id, but would be even heavier to run.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1359]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1359 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1359 Old status: new New status: ok Commit summary for Wikimedia.r1359: followup r1212 Cleaning up failmail and the control loop that uses it - it has clearly been copied and pasted a couple times from its original incarnation. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111380]: Revision status changed
Hashar changed the status of MediaWiki.r111380 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111380 Old status: new New status: ok Commit summary for MediaWiki.r111380: [mw.debug] Clean up * Instead of inline global variable and lazy-loading, using ResourceLoader (using mw.config and mw.loader) * Can't use OutputPage::addJsConfigVars / OutputPage::addModules because debug is called after those are handled, using ResourceLoader::makeConfigSetScript instead ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100315]: Revision status changed
Hashar changed the status of MediaWiki.r100315 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100315 Old status: new New status: resolved Commit summary for MediaWiki.r100315: * Made ?contribs=user actually show the results for the *user* if 'newbies' was given as the user. * Added a link batch query to newbie contribs paging ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112350]: Revision status changed
Hashar changed the status of MediaWiki.r112350 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112350 Old status: new New status: ok Commit summary for MediaWiki.r112350: r100315: removed now redundant code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110897]: Revision status changed
Hashar changed the status of MediaWiki.r110897 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110897 Old status: new New status: ok Commit summary for MediaWiki.r110897: r96546: Made FeedUtils::formatDiff() use the new LogFormatter class rather than a broken LogPage::actionText() call (the summary tag only had the log action name in it). This change means that log actions in feeds now have the user name in them, unlike 1.18. Also, broke a long code line. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112485]: Revision status changed
SPQRobin changed the status of MediaWiki.r112485 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112485 Old status: new New status: ok Commit summary for MediaWiki.r112485: Add special page aliases. Add some message documentation. Add fixme for large init file. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Images in wikipedia
nischay nahata nischay...@gmail.com writes: I can't seem to find the original version and I haven't used the script in a long time, so there are no guarantees it still works. I am not looking for any code. But want to know why is it not implemented in en.wikipedia.org? If you want some JS like that implemented on en.wikipedia.org, then you should ask for a gadget to be enabled. The place to ask is on [[Wikipedia:Gadget/proposals]] or [[Wikipedia_talk:Gadget]], pages linked from https://en.wikipedia.org/wiki/MediaWiki:Gadgets-definition. Mark. -- Mark A. Hershberger Bugmeister Wikimedia Foundation m...@wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Images in wikipedia
- Original Message -
From: nischay nahata nischay...@gmail.com
When using wikipedia and clicking on an image it opens up on a new
page.
Wouldn't it be nice if it just scaled-up on the same page using JS. Is
there an extension there for this? and if yes why not implemented on
wikipedia?
I'm not sure how well that would work in Opera Mobile on my Evo.
Cheers,
-- jr 'all the world is not {the www,a PC,running Windows,etc}' a
--
Jay R. Ashworth Baylink j...@baylink.com
Designer The Things I Think RFC 2100
Ashworth Associates http://baylink.pitas.com 2000 Land Rover DII
St Petersburg FL USA http://photo.imageinc.us +1 727 647 1274
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112409]: Revision status changed
SPQRobin changed the status of MediaWiki.r112409 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112409 Old status: new New status: ok Commit summary for MediaWiki.r112409: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112411]: Revision status changed
SPQRobin changed the status of MediaWiki.r112411 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112411 Old status: new New status: ok Commit summary for MediaWiki.r112411: Localisation updates for Toolserver i18n messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112423]: Revision status changed
SPQRobin changed the status of MediaWiki.r112423 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112423 Old status: new New status: ok Commit summary for MediaWiki.r112423: Fixes bug 34723: applies the English language to CSS/JS both as a user subpage and a MediaWiki space page, and consequently applies LTR to JS and CSS in the textarea. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1329]: New comment added
Jpostlethwaite posted a comment on Wikimedia.r1329. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1329#c31511 Commit summary for Wikimedia.r1329: Putting in a hard coded fix for issue with selecting only one payment gateway for processing recurring payments in r1212. The lookup now joins the table `civicrm_payment_processor`. Jpostlethwaite's comment: I can do this, but it is a hack. The way I have it set up is the correct way [ unless I made some errors :p ] for the current version of CiviCRM. I agree this is easier: pre AND `civicrm_contribution_recur`.`trxn_id` LIKE 'GLOBALCOLLECT RECURRING%' /pre What is wrong with how it is implemented now? I thought our goal was to make this available to the CiviCRM community. Removing this code would be as step away from that direction. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1329]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1329 to new URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1329 Old status: fixme New status: new Commit summary for Wikimedia.r1329: Putting in a hard coded fix for issue with selecting only one payment gateway for processing recurring payments in r1212. The lookup now joins the table `civicrm_payment_processor`. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112410]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112410 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112410 Old status: new New status: resolved Commit summary for MediaWiki.r112410: (bug 34702) Use localised parentheses in Special:Contributions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112424]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112424 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112424 Old status: new New status: ok Commit summary for MediaWiki.r112424: Follow-up r112410, r112412: Cheaper processing using plain(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112412]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112412 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112412 Old status: new New status: resolved Commit summary for MediaWiki.r112412: Follow-up r112410: (bug 34702) Use localised parentheses for comment, too. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112392]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112392 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112392 Old status: new New status: ok Commit summary for MediaWiki.r112392: Update tags. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112393]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r112393 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112393#c31512 Old Status: new New Status: ok Commit summary for MediaWiki.r112393: Update tags. Nikerabbit's comment: Would it be worthwhile to use website-*.meta_title or does it also filter some good messages? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1334]: New comment added, and revision status changed
Jpostlethwaite changed the status of Wikimedia.r1334 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1334#c31513 Old Status: fixme New Status: new Commit summary for Wikimedia.r1334: Fixes #1246 - Added date and process parameters. Added validation method. Jpostlethwaite's comment: It is a hook, so yes it is intentional. I double checked and it is being run when with: pre drush crg /pre Currently, it is only being used to make sure someone does not input a date in the future. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1336]: New comment added, and revision status changed
Jpostlethwaite changed the status of Wikimedia.r1336 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1336#c31514 Old Status: fixme New Status: new Commit summary for Wikimedia.r1336: Added two methods to query the database for payments: _civicrm_recurring_globalcollect_get_next_sched_contribution() and _civicrm_recurring_globalcollect_get_failure_retry_date(). See r1335. Jpostlethwaite's comment: Why can we not do this? This is the proper way to use the schema? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1336]: New comment added
Jpostlethwaite posted a comment on Wikimedia.r1336.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1336#c31515
Commit summary for Wikimedia.r1336:
Added two methods to query the database for payments:
_civicrm_recurring_globalcollect_get_next_sched_contribution() and
_civicrm_recurring_globalcollect_get_failure_retry_date(). See r1335.
Jpostlethwaite's comment:
The date is formated:
pre
$date = date('Y-m-d', strtotime($date)) . '%';
/pre
So you can only search on days.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1329]: New comment added
Khorn (WMF) posted a comment on Wikimedia.r1329. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1329#c31516 Commit summary for Wikimedia.r1329: Putting in a hard coded fix for issue with selecting only one payment gateway for processing recurring payments in r1212. The lookup now joins the table `civicrm_payment_processor`. Khorn (WMF)'s comment: Ah, okay, let me take a step back. br For a couple different reasons we can go into later (but in a nutshell I believe it's mostly scalability issues and a lack of dev time) we aren't using all the civi features. In particular, the the data Peter mentioned in his first comment, which your queries currently depend on. br While I agree it would be lovely to be able to release this to the civi community, it's definitely not a requirement to get this out the door... Particularly when it won't work for our setup. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1336]: New comment added
Jpostlethwaite posted a comment on Wikimedia.r1336. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1336#c31517 Commit summary for Wikimedia.r1336: Added two methods to query the database for payments: _civicrm_recurring_globalcollect_get_next_sched_contribution() and _civicrm_recurring_globalcollect_get_failure_retry_date(). See r1335. Jpostlethwaite's comment: I will run a few tests with some sample data to see which is better. Here are three possible search patterns: 1. Using LIKE: pre `civicrm_contribution_recur`.`next_sched_contribution` LIKE '2011-12-31%' /pre 2. Using BETWEEN: pre `civicrm_contribution_recur`.`next_sched_contribution` BETWEEN '2012-12-31 00:00:00' AND '2012-12-31 23:59:59' /pre 3. Using greater or less: pre `civicrm_contribution_recur`.`next_sched_contribution` = '2012-12-31 00:00:00' AND `civicrm_contribution_recur`.`next_sched_contribution` = '2012-12-31 23:59:59' /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1336]: New comment added
Jpostlethwaite posted a comment on Wikimedia.r1336. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1336#c31518 Commit summary for Wikimedia.r1336: Added two methods to query the database for payments: _civicrm_recurring_globalcollect_get_next_sched_contribution() and _civicrm_recurring_globalcollect_get_failure_retry_date(). See r1335. Jpostlethwaite's comment: BETWEEN appears twice as fast with a data set of 10,000 records. I will add more records to get some better results to confirm. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112393]: New comment added
Siebrand posted a comment on MediaWiki.r112393. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112393#c31519 Commit summary for MediaWiki.r112393: Update tags. Siebrand's comment: I wish that were possible. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1334]: New comment added, and revision status changed
Khorn (WMF) changed the status of Wikimedia.r1334 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1334#c31520 Old Status: new New Status: ok Commit summary for Wikimedia.r1334: Fixes #1246 - Added date and process parameters. Added validation method. Khorn (WMF)'s comment: Ah, it must be a built-in drush hook, then. Verified. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112437]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112437 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112437 Old status: new New status: ok Commit summary for MediaWiki.r112437: Added @since annotations ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112434]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112434 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112434 Old status: new New status: ok Commit summary for MediaWiki.r112434: Use local context to get messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112447]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112447 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112447 Old status: new New status: ok Commit summary for MediaWiki.r112447: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Technical questions regarding categorisation
Hi there, I'm writing an extension that needs to do the same effect on updating categorisation as editing a page and saving it, but from the PHP code. The article being edit/saved has a parser-function in it which categorises the article. When I manually edit the page and then save it without changing anything, the categorisation is updated by the parser-function and I can see the article listed in that category page. But when I do this same operation from the code, I see the updated category link at the bottom of the article, but the title does not show up in the associated category page unless the categorisation took place via a manual edit/save. To do the edit/save from the PHP I'm doing this: $article-doEdit( $article-fetchContent(), $summary, EDIT_UPDATE ); Does anyone here have any idea what might be different between this approach and manually edit/save? neither one creates a new revision, but the manual process does something more which places the article into the category page properly. Cheers, Aran ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112395]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112395 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112395 Old status: new New status: ok Commit summary for MediaWiki.r112395: * (bug 34528) Don't parse section name in edit section tooltips ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112503]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112503 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112503 Old status: new New status: ok Commit summary for MediaWiki.r112503: They don't want this customised - reported on IRC ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Bugzilla: Adding Huggle and other wiki-related projects
This past Friday, at the request of Michael Movchin, I added a Huggle product to Bugzilla. Michael and Petr Bena are working on a web version of Huggle that can be used if you don't have access to Windows (which, having not used Huggle at all, is where I understand Huggle currently runs). I'd like to add more of these sort of tools to Bugzilla, just as we have a lot of MediaWiki extensions in Bugzilla, since I think this could encourage cross pollination between the WMF projects and people who are interested in things that aren't core to WMF. -- Mark A. Hershberger Bugmeister Wikimedia Foundation m...@wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112474]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112474 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112474
Old status: new
New status: ok
Commit summary for MediaWiki.r112474:
(bug 34736) empty limit on special pages causes navigation issues
On special pages, the older link showed a limit='' query parameter which
made the page show nothing ('' is evalued to a limit of 0 articles).
The cause is r105809 which changed the way we interprets parameters in
wfArrayToCGI() and wfCGIToArray(). Previously, An empty string value would skip
the key, after r105809, we need to use null.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109678]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r109678 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109678
Old status: new
New status: ok
Commit summary for MediaWiki.r109678:
Reinstate r109223 per CR + fixes
* Action/Context stuff is pretty deeply nested everywhere.
* Should be okay now, at last.
* Reverts reverting r109243
* Same as r109223, except adding this:
+ if ( !$context-canUseWikiPage() ) {
+ return 'view';
+ }
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109678]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r109678 to resolved
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109678
Old status: ok
New status: resolved
Commit summary for MediaWiki.r109678:
Reinstate r109223 per CR + fixes
* Action/Context stuff is pretty deeply nested everywhere.
* Should be okay now, at last.
* Reverts reverting r109243
* Same as r109223, except adding this:
+ if ( !$context-canUseWikiPage() ) {
+ return 'view';
+ }
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Bugzilla: Adding Huggle and other wiki-related projects
On Mon, Feb 27, 2012 at 11:03 AM, Mark A. Hershberger m...@wikimedia.orgwrote: This past Friday, at the request of Michael Movchin, I added a Huggle product to Bugzilla. Michael and Petr Bena are working on a web version of Huggle that can be used if you don't have access to Windows (which, having not used Huggle at all, is where I understand Huggle currently runs). I'd like to add more of these sort of tools to Bugzilla, just as we have a lot of MediaWiki extensions in Bugzilla, since I think this could encourage cross pollination between the WMF projects and people who are interested in things that aren't core to WMF. Yay! This is great news. Huggle is used by several of the largest Wikimedia communities (ENWP, PTWP, etc.) for intensive vandalfighting, so it's great to see its issue tracking done in a place more visible to other Wikimedia volunteer and staff developers. Steven ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112458]: Revision status changed
Hashar changed the status of MediaWiki.r112458 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112458 Old status: ok New status: resolved Commit summary for MediaWiki.r112458: [CodeReview/DiffHighlighter] Restore inline wrapper for diff text * Restore inline wrapper for diff text to allow styling of the diff text with the correct inline content width (style for td.ins/td.del styles the entire line rather than just the text) * Use Html::element() consistently in both the top and bottom of formatLine() for the line-numbers. No need to allow raw html in td.linenumbers, and if it does it should be documented and also allowed in other parts of the code. * main change: - Html::Element( 'td', $classAttr, $content ) // $inlineWrapEl is span, ins or del + Html::rawElement( 'td', $classAttr, Html::element( $inlineWrapEl, array() , $content ) ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112460]: New comment added
Hashar posted a comment on MediaWiki.r112460. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112460#c31521 Commit summary for MediaWiki.r112460: Follow-up r112458: html entities were showing up literally on the page. the numbers can be treated as to-be-escaped html but these were not, fixing them to be literal to avoid breakage through Html::element Hashar's comment: I prefer the self descriptive HTML entities there, that will make the code nicer than using some hard to write characters + a comment. Anyway, we move to Gerrit :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112460]: Revision status changed
Hashar changed the status of MediaWiki.r112460 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112460 Old status: new New status: ok Commit summary for MediaWiki.r112460: Follow-up r112458: html entities were showing up literally on the page. the numbers can be treated as to-be-escaped html but these were not, fixing them to be literal to avoid breakage through Html::element ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112510]: Revision status changed
Hashar changed the status of MediaWiki.r112510 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112510 Old status: new New status: ok Commit summary for MediaWiki.r112510: [ext.codereview.styles] Whitespace ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111955]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r111955 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111955 Old status: new New status: ok Commit summary for MediaWiki.r111955: Don't output skinned errors in case of unhandled API exceptions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112512]: Revision status changed
Hashar changed the status of MediaWiki.r112512 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112512 Old status: new New status: ok Commit summary for MediaWiki.r112512: [ext.codereview.styles] follow-up r112511: spaces to tabs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112511]: Revision status changed
Hashar changed the status of MediaWiki.r112511 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112511 Old status: new New status: ok Commit summary for MediaWiki.r112511: [ext.codereview.styles] Make whitespace changes identifiable in CR diffs * (bug 27375) Whitespace changes should be identifiable in CR diffs * Also removing useless text-decoration resets on td.ins. Probably left-over from when the selector/html was ins ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112513]: Revision status changed
Krinkle changed the status of MediaWiki.r112513 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112513 Old status: new New status: ok Commit summary for MediaWiki.r112513: MFT to 1.19wmf1 r112510 r112511 r112512 Special:CodeReview: * (bug 27375) Whitespace changes should be identifiable in CR diffs * Remove text-decoration on td.ins ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112464]: Revision status changed
Krinkle changed the status of MediaWiki.r112464 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112464 Old status: new New status: ok Commit summary for MediaWiki.r112464: MFT r112460 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112456]: New comment added
Reedy posted a comment on MediaWiki.r112456. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112456#c31522 Commit summary for MediaWiki.r112456: Release notes for added feature in r112451 which fixed bug 33952 Reedy's comment: Not much point committing release notes only revisions to 1.19wmf1 ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112344]: New comment added, and revision status changed
F.trott changed the status of MediaWiki.r112344 to reverted and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112344#c31523 Old Status: ok New Status: reverted Commit summary for MediaWiki.r112344: Follow-up to r112224 - removed now-unnecessary helper function SFUtils::getSpecialPage(), replaced with the function it called, SpecialPageFactory::getPage() F.trott's comment: Reverted: SpecialPageFactory does not exist until MW 1.18 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112224]: New comment added, and revision status changed
F.trott changed the status of MediaWiki.r112224 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112224#c31524 Old Status: deferred New Status: resolved Commit summary for MediaWiki.r112224: Removing support for MediaWiki 1.16 - that included removing pre-ResourceLoader Javascript- and CSS-loading code, and removing the entire jQuery and jQuery UI libraries, which are now always retrieved from MediaWiki F.trott's comment: Partly reverted: SpecialPageFactory does not exist until MW 1.18 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110506]: New comment added
Brion VIBBER posted a comment on MediaWiki.r110506. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110506#c31525 Commit summary for MediaWiki.r110506: Changing the message on the big button so it will be clear that it's possible to drag and drop multiple files. Brion VIBBER's comment: Agreed; bug 34667 gives an example of how drag-n-drop goes wrong here if you don't drop in exactly the right place. We should switch this back until the drag-n-drop experience is much nicer, and even then maybe label it differently. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110506]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r110506 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110506 Old status: ok New status: fixme Commit summary for MediaWiki.r110506: Changing the message on the big button so it will be clear that it's possible to drag and drop multiple files. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110506]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r110506 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110506 Old status: fixme New status: reverted Commit summary for MediaWiki.r110506: Changing the message on the big button so it will be clear that it's possible to drag and drop multiple files. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112383]: Revision status changed
Reedy changed the status of MediaWiki.r112383 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112383 Old status: new New status: ok Commit summary for MediaWiki.r112383: Fixed $headers check in streamFile() to use isset() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112397]: Revision status changed
Reedy changed the status of MediaWiki.r112397 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112397 Old status: new New status: ok Commit summary for MediaWiki.r112397: Forgot to commit this file in r112396 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112396]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112396 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112396 Old status: new New status: ok Commit summary for MediaWiki.r112396: * (bug 34246) Display MediaWiki:Whatlinkshere-summary again in Special:Whatlinkshere ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112517]: Revision status changed
Reedy changed the status of MediaWiki.r112517 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112517 Old status: new New status: ok Commit summary for MediaWiki.r112517: Revert r110506: undo change to phrasing on Special:UploadWizard's most important button The big button label was changed from 'Select a media file to donate' to 'Drop media file to donate here' to make it clear that it's possible to drag and drop multiple files. Unfortunately this is probably premature; the drag-n-drop isn't very slickly integrated yet and for instance has no visual indication of whether you're dropping in the right stop. If you get it wrong -- very easy -- then you replace the entire page with just your image in the browser window (bug 34667). Switching it back to the original form. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111335]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r111335 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111335 Old status: new New status: ok Commit summary for MediaWiki.r111335: follow up to r111017, move hook to isAlwatsKnown as per discussion on CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Who can make Gerrit/Labsconsole accounts?
As Ryan mentioned in an email to another list a couple weeks ago: Everyone with access to create svn accounts can also link them to Labs accounts. Feel free to make Labs accounts. Also feel free to add users to the bastion project, and to any other project you are a member of. Unless the user needs/wants Labs access, don't give them bastion or other project access by default, though. It seems to me that the list of people who can make SVN accounts is unclear to the average newbie -- https://meta.wikimedia.org/wiki/System_administrators doesn't have me on it. Is there a better list? How to make a Labs account: https://wikitech.wikimedia.org/view/OpenStack#Wiki_access which I am about to merge into https://labsconsole.wikimedia.org/wiki/Help:Access . -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112397]: New comment added
Reedy posted a comment on MediaWiki.r112397. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112397#c31526 Commit summary for MediaWiki.r112397: Forgot to commit this file in r112396 Reedy's comment: This needs merging as it's a bugfix, whereas r112396 doesn't (as it's only a RELEASE-NOTES change to trunk, and commits to other branches)... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112518]: Revision status changed
Reedy changed the status of MediaWiki.r112518 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112518 Old status: new New status: ok Commit summary for MediaWiki.r112518: fix capitalization, bug 34757 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112518]: New comment added, and revision status changed
Sumanah changed the status of MediaWiki.r112518 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112518#c31527 Old Status: ok New Status: new Commit summary for MediaWiki.r112518: fix capitalization, bug 34757 Sumanah's comment: Per the [https://bugzilla.wikimedia.org/show_bug.cgi?id=34757#c0 description in the bug] shouldn't it be ['StalePagesAlias'] with a capital P? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112518]: New comment added
^demon posted a comment on MediaWiki.r112518. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112518#c31528 Commit summary for MediaWiki.r112518: fix capitalization, bug 34757 ^demon's comment: No. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112518]: New comment added
Sumanah posted a comment on MediaWiki.r112518. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112518#c31529 Commit summary for MediaWiki.r112518: fix capitalization, bug 34757 Sumanah's comment: Never mind, caught my error. Duh. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110045]: New comment added, and revision status changed
Brion VIBBER changed the status of MediaWiki.r110045 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110045#c31530 Old Status: ok New Status: fixme Commit summary for MediaWiki.r110045: sanitize outgoing messages Brion VIBBER's comment: Causes bug 34708 -- usage examples in WikiEditor help are broken! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110045]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r110045 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110045 Old status: fixme New status: reverted Commit summary for MediaWiki.r110045: sanitize outgoing messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1287]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1287 to new URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1287 Old status: fixme New status: new Commit summary for Wikimedia.r1287: Removed tabs from code. Fixed issues with civicrm_recurring_globalcollect_build_url(). Added localhost_test_url to settings. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1278]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1278 to new URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1278 Old status: fixme New status: new Commit summary for Wikimedia.r1278: Code clean up. Disabling debugging and adding more logging for civicrm_recurring_globalcollect module. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1336]: New comment added
Jpostlethwaite posted a comment on Wikimedia.r1336. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1336#c31531 Commit summary for Wikimedia.r1336: Added two methods to query the database for payments: _civicrm_recurring_globalcollect_get_next_sched_contribution() and _civicrm_recurring_globalcollect_get_failure_retry_date(). See r1335. Jpostlethwaite's comment: I created a data set of 600,000 records and tested the three different queries with query caching disabled. There was no difference between queries. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] GSoC'12 Proposal : List of Ideas
Hi, I have created my User page, envisaging the ideas I shared through my last mail - https://en.wikipedia.org/wiki/User:Shivansh13 Please let me know the prospective of the ideas suggested. Regards, -- Shivansh Srivastava | +91-955-243-5407 | http://in.linkedin.com/pub/shivansh-srivastava/17/a50/b18mr.shivansh.srivast...@gmail.com mr.shivansh.srivast...@gmail.comSecretary, BITS Alumni Affairs Division | Web Expert, Newsletter, BITSAA International 3rd Year Undergraduate | B.E. (Hons.) - Electronics Instrumentation BITS-Pilani. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] GSoC'12 Proposal : List of Ideas
On 28.02.2012, 2:14 Shivansh wrote: Hi, I have created my User page, envisaging the ideas I shared through my last mail - https://en.wikipedia.org/wiki/User:Shivansh13 Please let me know the prospective of the ideas suggested. Regards, They should be on mediawiki.org -- Best regards, Max Semenik ([[User:MaxSem]]) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
