[PATCH (v5) xinput 1/1] Add experimental multitouch support from XI 2.1

2011-01-19 Thread Daniel Stone
experimental grab-testing code (the TouchBegin grab, as well as 'thong' and the associated XIAllowTouchEvents), which will be removed from the final revision. For the time being, it's useful for testing. Signed-off-by: Chase Douglas chase.doug...@canonical.com Co-authored-by: Daniel

Re: [PATCH 5/5] input: use a thread for the generation of input events

2011-01-19 Thread Daniel Stone
Hi, On Thu, Dec 16, 2010 at 03:31:40PM -0500, Adam Jackson wrote: If configured, and enabled at runtime, use a separate thread for handling input devices. Use pipes to communicate plug events from main thread to input thread, and to communicate event queue updates from input thread to main

Re: [PATCH] xkb: after making changes to the xkb ctrls, copy them back into kbdfeed.

2011-01-19 Thread Daniel Stone
file a bug): Reviewed-and-regretted-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [PATCH 1/2] mi: Call pScreen-ConstrainCursorHarder from the position update path

2011-01-19 Thread Daniel Stone
with that: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 1/2] mi: Call pScreen-ConstrainCursorHarder from the position update path

2011-01-19 Thread Daniel Stone
On Wed, Jan 19, 2011 at 10:59:21PM -0500, Adam Jackson wrote: On Jan 19, 2011, at 9:27 PM, Daniel Stone wrote: On Wed, Jan 19, 2011 at 12:58:40AM -0500, Adam Jackson wrote: @@ -229,6 +229,10 @@ miPointerSetCursorPosition(DeviceIntPtr pDev, ScreenPtr pScreen, [...] This looks good

Re: [PATCH (v5) xserver 7/8] Input: Add initial multitouch support from Xi 2.1

2011-01-23 Thread Daniel Stone
Hi, On Sun, Jan 23, 2011 at 09:16:09PM +0100, Cyril Brulebois wrote: Daniel Stone dan...@fooishbar.org (19/01/2011): --- a/dix/getevents.c +++ b/dix/getevents.c […] +int +GetTouchEvents(EventList *events, DeviceIntPtr pDev, TouchPointInfoPtr ti, + uint16_t type, uint32_t

Re: input event/mouse detection from evdev/x server

2011-01-28 Thread Daniel Stone
Hi, On Fri, Jan 28, 2011 at 04:56:45PM +, Popescu, CatalinX wrote: I have an issue with the X server, evdev library more precisely. When a mouse (or a compatible device) is detected by the X server, the server does actually detect an event device (/dev/input/eventN) and a mouse device

Re: [PATCH evdev] Export device node as property.

2011-02-06 Thread Daniel Stone
On Wed, Feb 02, 2011 at 03:32:54PM +1000, Peter Hutterer wrote: There is currently no mapping between XI devices and physical devices other than what can be extracted by parsing the Xorg logfile. Add new property Device Node to the driver to export the open device file. The client is

Re: [PATCH evdev] Export device node as property.

2011-02-07 Thread Daniel Stone
Hi, On Tue, Feb 08, 2011 at 08:32:16AM +1000, Peter Hutterer wrote: CC'ing Lennart, he can contribute more details I supposed. On Mon, Feb 07, 2011 at 08:58:22AM +1000, Daniel Stone wrote: On Wed, Feb 02, 2011 at 03:32:54PM +1000, Peter Hutterer wrote: There is currently no mapping

Re: [PATCH xserver] Xi: make XIQueryPointer return the current modifiers/group as documented.

2011-02-08 Thread Daniel Stone
-off-by: Carlos Garnacho carl...@gnome.org Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

[PATCH v6 inputproto 1/1] Multitouch updates for pointer emulation

2011-02-08 Thread Daniel Stone
a/XI2proto.txt b/XI2proto.txt index d079ddb..5ebe59d 100644 --- a/XI2proto.txt +++ b/XI2proto.txt @@ -9,11 +9,11 @@ Daniel Stone dan...@fooishbar.org - Collabora, Ltd. + Collabora, Ltd

Re: [PATCH v6 inputproto 1/1] Multitouch updates for pointer emulation

2011-02-08 Thread Daniel Stone
Hi, On Tue, Feb 08, 2011 at 10:12:19AM -0800, Keith Packard wrote: On Tue, 8 Feb 2011 10:53:19 +, Daniel Stone dan...@fooishbar.org wrote: This means that one touch event may be simultaneously sending touch events through to touch clients, and enqueuing emulated pointer events

Re: [PATCH xserver] Xi: make XIQueryPointer return the current modifiers/group as documented.

2011-02-08 Thread Daniel Stone
Hi, On Tue, Feb 08, 2011 at 10:08:36AM -0800, Keith Packard wrote: On Mon, 7 Feb 2011 18:21:31 +0100, carl...@gnome.org wrote: From: Carlos Garnacho carl...@gnome.org The previous XKB info was being returned instead of the current one, producing inconsistent results between the latest

Re: [PATCH v6 inputproto 1/1] Multitouch updates for pointer emulation

2011-02-08 Thread Daniel Stone
Hi, On Tue, Feb 08, 2011 at 06:24:47PM +, Daniel Stone wrote: If the WM consumes the event and indicates so to the server with Sync{Pointer,Both}, this is treated the same as a client calling XIAllowTouchEvents with XITouchOwnerAccept: the app gets a TouchEnd event indicating

Re: Slightly OT Question

2011-02-09 Thread Daniel Stone
Hi, On Tue, Feb 08, 2011 at 02:04:11PM -0800, Rick Stockton wrote: I was wondering about an idea- and rather than stumble around (for weeks) on my own, I want to ask you WAY SMARTER guys about it: As you already know, I'm planning to bring some decent support for additional mouse buttons

Re: Using XInput 2 to simulate touchevents

2011-02-09 Thread Daniel Stone
On Wed, Feb 09, 2011 at 10:00:07AM +0200, mugunthan wrote: I want to test the touch interface of the device. Can anybody could help me out how to generate the touch events using XInput 2 http://cgit.freedesktop.org/~whot/evtest signature.asc Description: Digital signature

Re: Using XInput 2 to simulate touchevents

2011-02-09 Thread Daniel Stone
Hi, On Wed, Feb 09, 2011 at 02:49:26PM +0200, mugunthan wrote: Thanks a lot for your information. I downloaded the event tester. But it says you can check the output from the device . But I want to generate some events which could be sent to the device. For example I need to generate

Re: Using XInput 2 to simulate touchevents

2011-02-09 Thread Daniel Stone
On Wed, Feb 09, 2011 at 04:30:54PM +0200, mugunthan wrote: I already have the hardware. So I would like to test on that . So I was wondering how to do that. I have no idea what you're actually asking. If you have hardware which you want to test on, then use the hardware. The text file I

Re: Using XInput 2 to simulate touchevents

2011-02-09 Thread Daniel Stone
On Wed, Feb 09, 2011 at 05:17:20PM +0200, mugunthan wrote: I got it ... thanks a lot for your inputs ... I have just one more question when I m running the evtest for a device .like this == [...] === how

Re: [PATCH 2/2] xkb: if the keymap failed to compile, load the default keymap instead.

2011-02-10 Thread Daniel Stone
On Thu, Feb 10, 2011 at 03:34:32PM +1000, Peter Hutterer wrote: We really need symbols, compat and types for a sensible keymap. Try this in your xorg.conf.d snippets for all keyboards: Option XkbLayout us Option XkbVariant nodeadkeys us(nodeadkeys) doesn't exist so xkbcomp

Re: setxkbmap: Refactoring for better style and maintainability?

2011-02-14 Thread Daniel Stone
Hi, On Fri, Feb 11, 2011 at 03:55:16AM +0300, Van de Bugger wrote: Advantages are obvious: better maintainability due to (1) better type control from compiler (because the first argument is of unique type, not widely used faceless int), (2) not using global variables, etc. Who is the

Re: [PATCH 1/4] xkb: Use snprintf to measure string lengths instead of manual strlen math

2011-02-14 Thread Daniel Stone
On Sun, Feb 13, 2011 at 09:36:02PM -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com For the series: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel signature.asc Description: Digital signature

[PATCH 0/6] Various input patches and fixes

2011-02-15 Thread Daniel Stone
Hi, The following series fixes a couple of bugs I found by inspection, and shuffles a few things around in preparation for expanding InternalEvent usage. There's a few more patches in my people.fd.o tree, but I'm going to wait until I've had more time to test them before I push them. Cheers,

[PATCH 1/6] Input: Store passive-activating key in CheckDeviceGrabs

2011-02-15 Thread Daniel Stone
not all callers were doing (I'm looking at you, ComputeFreezes). Just set it in CheckDeviceGrabs instead. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xi/exevents.c |4 +--- dix/events.c | 20 +++- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/Xi

[PATCH 2/6] Input: Don't freeze unrelated devices in DeliverGrabbedEvent

2011-02-15 Thread Daniel Stone
had a non-SyncBoth grab on another unrelated master device. Fix this by completely ignoring devices that aren't our paired device. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix/events.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dix/events.c b/dix

[PATCH 5/6] Input: Reduce use of filter in DeliverEvents

2011-02-15 Thread Daniel Stone
Instead of switching on the event filter to determine delivery, use the event type instead. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix/events.c | 44 +--- 1 files changed, 37 insertions(+), 7 deletions(-) diff --git a/dix/events.c b/dix

[PATCH 3/6] Input: Actually send Xi 1.x DeviceStateNotify events

2011-02-15 Thread Daniel Stone
. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xi/exevents.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Xi/exevents.c b/Xi/exevents.c index 5131167..e10cc3a 100644 --- a/Xi/exevents.c +++ b/Xi/exevents.c @@ -1278,7 +1278,7 @@ DeviceFocusEvent(DeviceIntPtr dev

[PATCH 4/6] Input: Rename EventIsDeliverable return masks

2011-02-15 Thread Daniel Stone
-by: Daniel Stone dan...@fooishbar.org --- dix/events.c| 26 +++--- include/input.h | 11 ++- 2 files changed, 17 insertions(+), 20 deletions(-) diff --git a/dix/events.c b/dix/events.c index 80792ee..2b6f9c0 100644 --- a/dix/events.c +++ b/dix/events.c @@ -2287,8

[PATCH 6/6] Input: Allow EventToCore to return multiple events

2011-02-15 Thread Daniel Stone
Some event types (notably Expose and GraphicsExpose) require multiple events, a la XI 1.x. Bring the EventToCore API in line with EventToXI's and allow it to generate multiple events. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix/eventconvert.c | 37

Re: [PATCH setxkbmap] Eliminate limitations on path length.

2011-02-17 Thread Daniel Stone
On Thu, Feb 17, 2011 at 10:01:37AM -0800, Alan Coopersmith wrote: On 02/17/11 07:25 AM, olafbuddenha...@gmx.net wrote: In short, using dynamic allocation and checking for error returns is actually the *pragmatic* approach. I'd think the pragmatic approach would be to tell anyone putting a

Re: [PATCH setxkbmap] Eliminate limitations on path length.

2011-02-17 Thread Daniel Stone
On Thu, Feb 17, 2011 at 11:28:19PM +0300, Van de Bugger wrote: Thus, I want my keyboard stuff to be located in a place of my choice. Probably, I like very-very-very-long directory and file names, and my names are not in Latin alphabet, so 1024 bytes may actually mean just 512 characters or

Re: [PATCH v2] xkb: Fix a check for MASTER_KEYBOARD

2011-02-20 Thread Daniel Stone
patch would still copy the keymap into the attached master, not the master keyboard. fix this. Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH] dix: a valuator count of 0 is valid (#34510)

2011-02-20 Thread Daniel Stone
-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH] test: write some event → XI1 conversion tests.

2011-02-21 Thread Daniel Stone
On Mon, Feb 21, 2011 at 03:44:31PM +1000, Peter Hutterer wrote: These tests don't test everything, but hey, life is short and I'm trying to have one. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital

[PATCH v2 2/6] Input: Don't freeze unrelated devices in DeliverGrabbedEvent

2011-02-22 Thread Daniel Stone
had a non-SyncBoth grab on another unrelated master device. Fix this by completely ignoring devices that aren't our paired device. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix/events.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/dix/events.c b/dix

Re: [PATCH 2/6] Input: Don't freeze unrelated devices in DeliverGrabbedEvent

2011-02-22 Thread Daniel Stone
On Thu, Feb 17, 2011 at 09:13:07AM +1000, Peter Hutterer wrote: On Tue, Feb 15, 2011 at 08:11:25PM +0100, Simon Thum wrote: On 02/15/2011 12:27 PM, Daniel Stone wrote: --- a/dix/events.c +++ b/dix/events.c @@ -3884,14 +3884,14 @@ DeliverGrabbedEvent(InternalEvent *event

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-24 Thread Daniel Stone
Hi, On Wed, Feb 23, 2011 at 03:46:14PM -0800, Keith Packard wrote: On Wed, 23 Feb 2011 10:16:46 -0800, Aaron Plattner aplatt...@nvidia.com wrote: However, I do need to object strongly to such a major protocol change being made after RC2 of a release cycle. We're supposed to be making only

Re: Spinning in _XReply

2011-02-25 Thread Daniel Stone
On Fri, Feb 25, 2011 at 03:18:37PM +0200, Rami Ylimäki wrote: On 02/25/2011 02:48 PM, Daniel Stone wrote: On Fri, Feb 25, 2011 at 02:08:38PM +0200, Rami Ylimäki wrote: Documentation of C.2.1 XInitExtension from Xlib manual says that the Xlib specific extension number in XExtCodes is connection

Re: [PULL] Server build fixes

2011-02-25 Thread Daniel Stone
On Fri, Feb 25, 2011 at 09:53:00AM -0800, Keith Packard wrote: On Fri, 25 Feb 2011 18:04:56 +0100, Cyril Brulebois k...@debian.org wrote: Keith Packard kei...@keithp.com (25/02/2011): So, I'm a bit confused here -- I do 'make distcheck' to build releases, and it works for me. I'd like to

Re: [PATCH] input: properly align doubles in InitValuatorClassDeviceStruct

2011-02-26 Thread Daniel Stone
On Fri, Feb 25, 2011 at 09:02:20PM -0800, Keith Packard wrote: On Sat, 26 Feb 2011 00:00:39 +0100, Julien Cristau jcris...@debian.org wrote: Some architectures (hi, sparc!) are unhappy with unaligned memory accesses. So make sure the axisVal member of ValuatorClassRec has sizeof(double)

Re: 1.11 release process (was: [PULL] -next branch for 1.11)

2011-03-01 Thread Daniel Stone
On Tue, Mar 01, 2011 at 10:39:15AM -0500, Adam Jackson wrote: On Mon, 2011-02-28 at 21:14 -0800, Keith Packard wrote: Do we need more formal rules for merging code? The RandR 1.4 server code was merged before the protocol and library APIs had seen sufficient review, but we don't have a

Re: 1.11 release process (was: [PULL] -next branch for 1.11)

2011-03-01 Thread Daniel Stone
how to help with that? -- We don't have an official protocol tree maintainer at this point, although Daniel Stone did volunteer to put together another proposal for merging those trees together, and if that happened, maybe we could convince him to run a couple of cycles as release manager. Yeah

Re: 1.11 release process (was: [PULL] -next branch for 1.11)

2011-03-01 Thread Daniel Stone
On Tue, Mar 01, 2011 at 10:08:02AM -0800, Keith Packard wrote: On Tue, 1 Mar 2011 17:52:34 +, Daniel Stone dan...@fooishbar.org wrote: I described my rough plan here: http://lists.freedesktop.org/archives/xorg-devel/2010-September/013145.html Get it started and I'll start pushing RandR

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-02 Thread Daniel Stone
Hi, Sorry about the lateness, have been kind of in a mad rush to finish other work, but should be back on multitouch soon. Hopefully. On Tue, Feb 22, 2011 at 10:06:37AM -0500, Chase Douglas wrote: --- a/XI2.h +++ b/XI2.h @@ -32,6 +32,7 @@ #define Dont_Check 0

Re: [PATCH v6 inputproto 1/1] Multitouch updates for pointer emulation

2011-03-02 Thread Daniel Stone
Hi, On Wed, Mar 02, 2011 at 04:34:30PM +1000, Peter Hutterer wrote: On Tue, Feb 08, 2011 at 10:53:19AM +, Daniel Stone wrote: --- a/XI2.h +++ b/XI2.h @@ -67,6 +67,7 @@ #define XIGrabtypeEnter 2 #define XIGrabtypeFocusIn 3 #define

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-02 Thread Daniel Stone
Hi, On Wed, Mar 02, 2011 at 10:58:08AM +, Daniel Stone wrote: On Tue, Feb 22, 2011 at 10:06:37AM -0500, Chase Douglas wrote: +In order to prevent touch events delivered to one window while pointer events +are implicitly grabbed by another, all touches from indirect devices will end

Re: [PATCH libXi] Add XI2 library-internal array offsets to XIint.h

2011-03-02 Thread Daniel Stone
On Tue, Sep 07, 2010 at 03:33:31PM +1000, Peter Hutterer wrote: These defines are currently defined in XI.h and XI2.h. Their only use is as offset into a library-internal array. Move them to XIint.h so they may be removed from the protocol headers with the next revision. NAK: while you're

Re: [PATCH] dri2: Initialize padding in DRI2GetBuffers reply

2011-03-02 Thread Daniel Stone
Hi, On Wed, Feb 23, 2011 at 07:01:04PM +0200, Pauli wrote: diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c index 4e48e65..725823e 100644 --- a/hw/xfree86/dri2/dri2ext.c +++ b/hw/xfree86/dri2/dri2ext.c @@ -227,11 +227,15 @@ send_buffers_reply(ClientPtr client, DrawablePtr

Re: 1.11 release process (was: [PULL] -next branch for 1.11)

2011-03-02 Thread Daniel Stone
Hi, On Tue, Mar 01, 2011 at 08:44:20AM -0800, Jeremy Huddleston wrote: On Feb 28, 2011, at 22:53, Keith Packard wrote: 2) I think the early rcs might not have been as well tested because they relied on xextproto and randrproto versions that were not released. Perhaps we should ensure that

Re: 1.11 release process

2011-03-02 Thread Daniel Stone
Hi, On Tue, Mar 01, 2011 at 01:30:52PM -0800, Alan Coopersmith wrote: On 03/ 1/11 09:52 AM, Daniel Stone wrote: On Mon, Feb 28, 2011 at 09:14:26PM -0800, Keith Packard wrote: Do we need more formal rules for merging code? The RandR 1.4 server code was merged before the protocol and library

Re: 1.11 release process (was: [PULL] -next branch for 1.11)

2011-03-02 Thread Daniel Stone
Hi, On Tue, Mar 01, 2011 at 10:37:31PM -0800, Dan Nicholson wrote: On Tue, Mar 1, 2011 at 9:52 AM, Daniel Stone dan...@fooishbar.org wrote: Yeah, that got caught up in unexpected holiday and/or moving continents; by the time I'd got to it, I'd missed the feature freeze for 1.10, so just

Re: [PATCH] glx: Remove yet another open coded strdup()

2011-03-02 Thread Daniel Stone
On Tue, Mar 01, 2011 at 04:17:55PM -0500, Adam Jackson wrote: This joke is no longer funny. I like how they even ensured that str_dup(NULL) also didn't do what you want. God. Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel

Re: [PATCH] Unifdef XGLServer

2011-03-02 Thread Daniel Stone
-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH libXi 2/3] Require XI 2 for all XI 2 calls.

2011-03-02 Thread Daniel Stone
On Thu, Sep 09, 2010 at 02:43:02PM +1000, Peter Hutterer wrote: Each XI2 call should check _XiCheckExtInit for XI version 2.0 or higher. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature

Re: [PATCH libXi 3/3] Rename XSetCPtr.c to XISetCPtr.c.

2011-03-02 Thread Daniel Stone
On Thu, Sep 09, 2010 at 02:43:03PM +1000, Peter Hutterer wrote: XISetClientPointer is an XI2.0 call and should be named accordingly. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature

Re: [PATCH] dri2: Initialize padding in DRI2GetBuffers reply

2011-03-02 Thread Daniel Stone
On Wed, Mar 02, 2011 at 01:41:25PM +0200, Pauli Nieminen wrote: On 02/03/11 11:37 +, ext Daniel Stone wrote: On Wed, Feb 23, 2011 at 07:01:04PM +0200, Pauli wrote: diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c index 4e48e65..725823e 100644 --- a/hw/xfree86/dri2

Re: [PATCH v2] dri2: Initialize padding in DRI2GetBuffers reply

2011-03-02 Thread Daniel Stone
) ====by 0x653B3: ProcessInputEvents (xf86Events.c:165) ==== Uninitialised value was created by a stack allocation ====at 0x503FAA0: send_buffers_reply (dri2ext.c:210) Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com Reviewed-by: Daniel Stone dan

Re: [PATCH 2/8] dix: Fix ATOM typedef

2011-03-07 Thread Daniel Stone
On Mon, Mar 07, 2011 at 11:28:12AM -0500, Adam Jackson wrote: unsigned long is needlessly large on LP64. Use unsigned int instead. Could we just use uint32_t? Cheers, Daniel signature.asc Description: Digital signature ___ xorg-devel@lists.x.org:

Re: [PATCH] xfree86: block signals between EnableDevice and first CheckMotion()

2011-03-08 Thread Daniel Stone
position (as seen from the protocol) is valid. Block signals during this window. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel

Re: [PATCH 2/3] dix: Shrink PropertyRec on LP64

2011-03-08 Thread Daniel Stone
that: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/3] dix: Shrink PropertyRec on LP64

2011-03-09 Thread Daniel Stone
On Tue, Mar 08, 2011 at 03:17:09PM -0500, Adam Jackson wrote: On Tue, 2011-03-08 at 19:37 +, Daniel Stone wrote: Being really pedantic again, can't these two be uint8_t or something? You've just grown format from 16 to 32 bytes. :P size pretty much needs to be uint32_t

Re: [PATCH xserver] xkb: Initialize pad bytes sent in replies of geometry requests.

2011-03-09 Thread Daniel Stone
On Wed, Mar 09, 2011 at 03:45:40PM +0200, Rami Ylimäki wrote: Valgrind complains about uninitialized data being written to clients. Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi Signed-off-by: Rami Ylimäki rami.ylim...@vincit.fi Reviewed-by: Daniel Stone dan...@fooishbar.org

Re: [PATCH] [xorg/xserver] mi/misprite: release private record

2011-03-09 Thread Daniel Stone
Hi, On Wed, Mar 09, 2011 at 03:42:14PM +0200, Erkki Seppälä wrote: The record allocated by miSpriteDeviceCursorInitialize was not being released. This patch adds a call to free and resetting the private record to miSpriteDeviceCursorCleanup. Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi

Re: [PATCH 1/1] randr: avoid rrGetScreenResources replying with uninitialized bytes.

2011-03-09 Thread Daniel Stone
: rrGetScreenResources (rrscreen.c:313) Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH] [xorg/xserver] mi/misprite: release private record

2011-03-09 Thread Daniel Stone
Hi, On Wed, Mar 09, 2011 at 04:19:06PM +0200, Erkki Seppala wrote: On 09.03.2011 15:57, Daniel Stone wrote: You could get this automatically by having miSpriteDevPrivatesKey allocate sizeof(miCursorInfoRec), rather than doing the allocation and free separately. Thanks for the feedback

Re: [PATCH v2] [xorg/xserver] mi/misprite: use memory management provided by dixRegisterPrivateKey

2011-03-09 Thread Daniel Stone
. Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg

Re: [PATCH 2/3] panoramiX: convert 0-panoramiXNumScreens loops to macro (v2)

2011-03-09 Thread Daniel Stone
], rather than info[1..n]. Looks like you might just be able to turn this into a FOR_NSCREENS_FORWARD_SKIP though? Other than that, for the series: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel signature.asc Description: Digital signature

Re: [PATCH v2:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-10 Thread Daniel Stone
On Thu, Mar 10, 2011 at 09:34:39AM -0500, Gaetan Nadon wrote: On Thu, 2011-03-10 at 10:47 +0100, Julien Cristau wrote: I think this won't work for gnu/kfreebsd. Maybe use *-gnu for the glibc case, and put it before the *bsd* one? Make that *-gnu* so it can handle linux-gnueabi

Re: [PATCH xserver] xkb: Initialize pad bytes sent in replies of geometry requests.

2011-03-16 Thread Daniel Stone
Hi, On Wed, Mar 16, 2011 at 10:35:22AM +0200, Rami Ylimäki wrote: On 03/16/2011 02:43 AM, Peter Hutterer wrote: -memcpy(wire[2],str,len); -wire+= ((2+len+3)/4)*4; +paddedLen= pad_to_int32(sizeof(len)+len)-sizeof(len); +strncpy(wire[sizeof(len)],str,paddedLen); +wire+=

Re: [PATCH] xkb: Document XkbWriteCountedString.

2011-03-16 Thread Daniel Stone
On Wed, Mar 16, 2011 at 10:35:13AM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] Remove a decnet leftover

2011-03-16 Thread Daniel Stone
On Wed, Mar 16, 2011 at 12:33:55PM -0400, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH] libX11: Add #define XK_SINHALA

2011-03-21 Thread Daniel Stone
On Mon, Mar 21, 2011 at 02:19:45PM +1100, Harshula Jayasuriya wrote: Add #define XK_SINHALA so that the Sinhala keysyms can be used by the lk xkb keymap. Pushed to master, thanks. Cheers, Daniel signature.asc Description: Digital signature ___

Re: [RFC PATCH] Add XI_PROP_ROTATION property to the server's properties.

2011-03-22 Thread Daniel Stone
Hi, Thinking out loud ... On Wed, Mar 23, 2011 at 03:13:55PM +1000, Peter Hutterer wrote: Having rotation support has been a feature requested for a while now. Now we've had two independent implementations happen within quite a short timeframe, one in synaptics, one in evdev (and wacom has had

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-24 Thread Daniel Stone
On Thu, Mar 24, 2011 at 09:20:39AM -0400, Gaetan Nadon wrote: On Wed, 2011-03-23 at 23:29 -0400, Matt Turner wrote: Fixes: http://bugs.gentoo.org/show_bug.cgi?id=360227 Problem is easily seen during compile: -DDFLT_XKB_CONFIG_ROOT='/usr/share/X11/xkb' This is what I get on Ubuntu

Re: [PATCH] dix: remove unused debug code

2011-03-25 Thread Daniel Stone
On Fri, Mar 25, 2011 at 03:42:46PM +0100, Mark Kettenis wrote: Sorry, but what gives you the authority to say this debug code isn't useful? Are you asserting that it's useful? If so, what gives _you_ the authority to say that? Cheers, Daniel, who totally loves nothing more than content-free

Re: [PATCH dix] dix: Added a flat acceleration profile that provides a linear pointer response.

2011-04-05 Thread Daniel Stone
Hi, On Tue, Apr 05, 2011 at 02:07:33PM +0200, Simon Thum wrote: Well, it's an RFC by Peter at the moment, AFAIK not much to read. I'll add a bit to my idea FYC. The concept would probably use pixman and list.h-lists and look something like: So, at the risk of sounding like a bit of an arse

Re: [PATCH dix] dix: Added a flat acceleration profile that provides a linear pointer response.

2011-04-05 Thread Daniel Stone
Hi, On Tue, Apr 05, 2011 at 03:45:58PM +0300, Tiago Vignatti wrote: On 04/05/2011 03:41 PM, ext Daniel Stone wrote: I ask mainly because we already have a very extensively-engineered pointer acceleration architecture, where 90% of the code could probably be removed without more than seven

On complexifigurability (was: Re: [PATCH dix] dix: Added a flat acceleration profile that provides a linear pointer response.)

2011-04-05 Thread Daniel Stone
Hi, On Tue, Apr 05, 2011 at 04:30:38PM +0300, Tiago Vignatti wrote: On 04/05/2011 04:05 PM, ext Daniel Stone wrote: On Tue, Apr 05, 2011 at 03:45:58PM +0300, Tiago Vignatti wrote: and bonus points if we could disable/enable the acceleration architecture in compilation time also. If we get

Re: On complexifigurability

2011-04-05 Thread Daniel Stone
Hi, On Tue, Apr 05, 2011 at 08:21:43PM +0300, Tiago Vignatti wrote: On 04/05/2011 05:51 PM, ext Daniel Stone wrote: Sure, but at some stage there has to be a limit. Every configuration option has a cost: in making the source files larger by putting #ifdefs everywhere - and you could argue we

Re: [RFC PATCH inputproto 0/3] Push 2.1 work into a branch

2011-04-08 Thread Daniel Stone
Hi, On Fri, Apr 08, 2011 at 02:28:10PM +1000, Peter Hutterer wrote: Chase pointed out that we don't have _any_ of the XI 2.1 stuff in the official repos yet. That makes testing harder for everyone and incremental review as well. This patchset is a simple one, just adding a few bumps and a

Re: [RFC PATCH inputproto 0/3] Push 2.1 work into a branch

2011-04-11 Thread Daniel Stone
Hi, On Mon, Apr 11, 2011 at 10:46:52AM +1000, Peter Hutterer wrote: added and pushed. branch inputproto-2.1-devel is now available. You ok to take maintainership of this branch? Sure. Cheers, Daniel signature.asc Description: Digital signature ___

Re: [PATCH] dix: Replace DEBUG_EVENTS + ErrorF with DebugF

2011-04-14 Thread Daniel Stone
Hi, On Thu, Apr 14, 2011 at 05:36:11PM +1000, Peter Hutterer wrote: @@ -1827,33 +1827,25 @@ TryClientEvents (ClientPtr client, DeviceIntPtr dev, xEvent *pEvents, { int type; -#ifdef DEBUG_EVENTS -ErrorF([dix] Event([%d, %d], mask=0x%lx), client=%d%s, +DebugF([dix]

Re: [PULL] Various render changes

2011-04-14 Thread Daniel Stone
On Wed, Apr 13, 2011 at 06:58:36PM -0700, Keith Packard wrote: Also, if REGION_INIT is going to ignore an argument, you should simply remove it from the API. You mean like pScreen? :) Cheers, Daniel signature.asc Description: Digital signature ___

Re: [PATCH] fb: Use an indirect reference to the Screen Pixmap

2011-04-14 Thread Daniel Stone
Hi, On Wed, Mar 23, 2011 at 11:40:40AM +, Chris Wilson wrote: diff --git a/fb/fbscreen.c b/fb/fbscreen.c index 2502efe..392de81 100644 --- a/fb/fbscreen.c +++ b/fb/fbscreen.c @@ -87,7 +87,8 @@ _fbGetWindowPixmap (WindowPtr pWindow) void _fbSetWindowPixmap (WindowPtr pWindow,

Re: [PATCH] dix: replace unneded goto with break.

2011-04-14 Thread Daniel Stone
On Thu, Apr 14, 2011 at 05:35:22PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH libX11] cleanup trivial Indic UTF-8 aliases uppercasing lang. #30112

2011-04-14 Thread Daniel Stone
Hi, On Tue, Apr 12, 2011 at 08:18:38PM +1000, Alistair Leslie-Hughes wrote: From: Jens Petersen peter...@redhat.com Date: Fri, 10 Sep 2010 16:00:52 +1000 Subject: [PATCH] cleanup trivial Indic UTF-8 aliases uppercasing lang Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=30112

Re: [PATCH] Xi: fix valuator alignment in DeepCopyDeviceClasses (#36119)

2011-04-14 Thread Daniel Stone
Hi, On Thu, Apr 14, 2011 at 12:31:00PM +1000, Peter Hutterer wrote: On Tue, Apr 12, 2011 at 09:58:57AM +0100, Daniel Stone wrote: On Tue, Apr 12, 2011 at 11:05:56AM +1000, Peter Hutterer wrote: +/* force alignment with double */ +union align_u { ValuatorClassRec valc; double d

Re: [PATCH 1/4] input: remove GetKeyboardValuatorEvents, this is now unnecessary.

2011-04-15 Thread Daniel Stone
On Fri, Apr 15, 2011 at 12:47:22PM +1000, Peter Hutterer wrote: GetKeyboardValuatorEvents handles NULL valuator masks already, so the GetKeyboardEvents wrapper is not needed. Rename GKVE to GKE. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan

Re: [PATCH 1/5] Xi: return the bad device ID if a passive grab fails with BadDevice.

2011-04-15 Thread Daniel Stone
On Fri, Apr 15, 2011 at 01:20:56PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 2/5] Xi: fix reply swapping function check for XIPassiveGrabDevice

2011-04-15 Thread Daniel Stone
On Fri, Apr 15, 2011 at 01:20:57PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 3/5] Xi: exit with error value if CheckGrabValues failed.

2011-04-15 Thread Daniel Stone
On Fri, Apr 15, 2011 at 01:20:58PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 4/5] Xi: don't swap the status byte in the XIPassiveGrab replies

2011-04-15 Thread Daniel Stone
On Fri, Apr 15, 2011 at 01:20:59PM +1000, Peter Hutterer wrote: Reported-by: Julien Cristau jcris...@debian.org Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org One other thing I noticed here is the confusion between grab status codes (e.g

Re: [PATCH 5/5] test: add some XIPassiveGrab protocol testing.

2011-04-15 Thread Daniel Stone
On Fri, Apr 15, 2011 at 01:21:00PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Daniel Stone dan...@fooishbar.org If I'm completely honest, my eyes started glazing over about 75% of the way through and I've not had a look at the request-wrapping

Re: [PATCH] dix: silence compiler warning

2011-04-18 Thread Daniel Stone
(uint32_t: %PRIu32\n, foo); But it's non-portable, and also seriously ugly. Oh well. Anyway, given that this quashes the warning on the most common development platform: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel signature.asc Description: Digital signature

Re: [PATCH] xfree86: Redact mention of the VideoAdaptor section

2011-04-18 Thread Daniel Stone
-by: Adam Jackson a...@redhat.com Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

Re: [PATCH 20/20] dix: reduce scope of tmp and mult.

2011-04-20 Thread Daniel Stone
. With or without that, for the series: Reviewed-by: Daniel Stone dan...@fooishbar.org I'd also found and written 01/20 independently (it's sitting in another branch) while having a similar 'wtf is all this?' excursion through the pointer code, and had wondered how it worked! Cheers, Daniel

Re: [PATCH] xfree86: add nouveau as the first automatic driver for NVIDIA hardware

2011-04-20 Thread Daniel Stone
, take my R-b for either form: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH] dix: only transform valuators when we need them.

2011-04-21 Thread Daniel Stone
, cursor jumps between the two positions. Introduced in 31737fff08ec19b394837341d5e358ec401f5cd8 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature

Re: [PATCH resend 0/11] remove duplicated includes

2011-04-28 Thread Daniel Stone
On Sun, Apr 24, 2011 at 07:47:58PM -0700, Jeremy Huddleston wrote: Hi Nicolas, I've merged these into my tree (and reviewed the xwin patch which was missing review). They'll be included in my next PULL to keithp (once my clang warning patches are reviewed ... v2 on its way). Damnit, I

Re: [PATCH] Move event filter initializer out of the structure itself

2011-04-28 Thread Daniel Stone
before: 4337008 Xorg File size after:4316568 Xorg Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Daniel Stone dan...@fooishbar.org I've merged this into my tree, thanks. ___ xorg-devel@lists.x.org: X.Org

  1   2   3   4   5   6   7   8   9   10   >