Peter Bacsko created YARN-10018:
---
Summary: container-executor: possible -1 return value of fork() is
not always checked
Key: YARN-10018
URL: https://issues.apache.org/jira/browse/YARN-10018
Project:
[
https://issues.apache.org/jira/browse/YARN-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989781#comment-16989781
]
Peter Bacsko commented on YARN-9868:
Did a rebase, hopefully it's gonna work.
> Validate
[
https://issues.apache.org/jira/browse/YARN-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9868:
---
Attachment: YARN-9868-004.patch
> Validate %primary_group queue in CS queue manager
>
[
https://issues.apache.org/jira/browse/YARN-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989725#comment-16989725
]
Peter Bacsko commented on YARN-9868:
Re-uploaded v3 again to see the checkstyle warning (Jenkins build
[
https://issues.apache.org/jira/browse/YARN-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9868:
---
Attachment: YARN-9868-003.patch
> Validate %primary_group queue in CS queue manager
>
[
https://issues.apache.org/jira/browse/YARN-9920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989720#comment-16989720
]
Peter Bacsko commented on YARN-9920:
[~prabhujoseph] could you pls re-upload the patch? There are some
[
https://issues.apache.org/jira/browse/YARN-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989703#comment-16989703
]
Peter Bacsko commented on YARN-4029:
[~adam.antal] there are a bunch unit test failures. Can you
[
https://issues.apache.org/jira/browse/YARN-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989700#comment-16989700
]
Peter Bacsko commented on YARN-9925:
+1 (non-binding).
> CapacitySchedulerQueueManager allows
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989696#comment-16989696
]
Peter Bacsko commented on YARN-9970:
+1 (non-binding). Checkstyle complains about the method being too
[
https://issues.apache.org/jira/browse/YARN-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985055#comment-16985055
]
Peter Bacsko commented on YARN-9877:
[~adam.antal] is there are way to test this?
[
https://issues.apache.org/jira/browse/YARN-5106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985033#comment-16985033
]
Peter Bacsko edited comment on YARN-5106 at 11/29/19 1:51 PM:
--
Thanks for
[
https://issues.apache.org/jira/browse/YARN-5106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985033#comment-16985033
]
Peter Bacsko edited comment on YARN-5106 at 11/29/19 1:50 PM:
--
Thanks for
[
https://issues.apache.org/jira/browse/YARN-5106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985033#comment-16985033
]
Peter Bacsko edited comment on YARN-5106 at 11/29/19 1:50 PM:
--
Thanks for
[
https://issues.apache.org/jira/browse/YARN-5106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985033#comment-16985033
]
Peter Bacsko commented on YARN-5106:
Thanks for picking up the patch [~adam.antal].
Just minor a
[
https://issues.apache.org/jira/browse/YARN-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984890#comment-16984890
]
Peter Bacsko commented on YARN-9925:
[~prabhujoseph] could you create a follow-up Jira about changing
[
https://issues.apache.org/jira/browse/YARN-9938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984888#comment-16984888
]
Peter Bacsko commented on YARN-9938:
+1 (non-binding)
[~snemeth] please review
> Validate Parent
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984508#comment-16984508
]
Peter Bacsko commented on YARN-9970:
Wow, checkstyle is complaining like crazy. Well, what can we do?
[
https://issues.apache.org/jira/browse/YARN-9938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984500#comment-16984500
]
Peter Bacsko commented on YARN-9938:
# Please address checkstyle issues (if they're addressabble, not
[
https://issues.apache.org/jira/browse/YARN-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984494#comment-16984494
]
Peter Bacsko edited comment on YARN-9866 at 11/28/19 3:29 PM:
--
+1
[
https://issues.apache.org/jira/browse/YARN-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984494#comment-16984494
]
Peter Bacsko commented on YARN-9866:
+1 (non-binding)
> u:user2:%primary_group is not working as
[
https://issues.apache.org/jira/browse/YARN-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984493#comment-16984493
]
Peter Bacsko commented on YARN-9969:
[~snemeth] please check if this is good for commit.
+1
[
https://issues.apache.org/jira/browse/YARN-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984262#comment-16984262
]
Peter Bacsko commented on YARN-9892:
[~maniraj...@gmail.com] yes, feel free to assign this to
[
https://issues.apache.org/jira/browse/YARN-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983530#comment-16983530
]
Peter Bacsko commented on YARN-9925:
I just have a question. I can see what we currently throw
[
https://issues.apache.org/jira/browse/YARN-9938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983493#comment-16983493
]
Peter Bacsko edited comment on YARN-9938 at 11/27/19 1:10 PM:
--
[
https://issues.apache.org/jira/browse/YARN-9938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983493#comment-16983493
]
Peter Bacsko commented on YARN-9938:
[~maniraj...@gmail.com] looks good at first sight. Two comments:
[
https://issues.apache.org/jira/browse/YARN-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983483#comment-16983483
]
Peter Bacsko commented on YARN-9866:
[~maniraj...@gmail.com] just one thing: in the testcase, you
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983450#comment-16983450
]
Peter Bacsko commented on YARN-9970:
1. Please write or generate a proper {{hashCode()}} method for
[
https://issues.apache.org/jira/browse/YARN-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983380#comment-16983380
]
Peter Bacsko commented on YARN-9969:
Thanks [~maniraj...@gmail.com]. Just one final request: I would
[
https://issues.apache.org/jira/browse/YARN-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9899:
---
Attachment: YARN-9899-007.patch
> Migration tool that help to generate CS config based on FS config
[
https://issues.apache.org/jira/browse/YARN-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979065#comment-16979065
]
Peter Bacsko commented on YARN-9899:
[~snemeth] I just tested the patch on a real Hadoop cluster.
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979004#comment-16979004
]
Peter Bacsko commented on YARN-8373:
[~sunilg] don't we need this patch to branch-3.2 also?
> RM
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977527#comment-16977527
]
Peter Bacsko commented on YARN-9011:
[~snemeth] I think we're good to go with branch-3.2 and
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9011:
---
Attachment: YARN-9011-branch-3.1.001.patch
> Race condition during decommissioning
>
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9011:
---
Attachment: YARN-9011-branch-3.2.001.patch
> Race condition during decommissioning
>
[
https://issues.apache.org/jira/browse/YARN-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976599#comment-16976599
]
Peter Bacsko edited comment on YARN-9912 at 11/18/19 2:32 PM:
--
[
https://issues.apache.org/jira/browse/YARN-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976599#comment-16976599
]
Peter Bacsko commented on YARN-9912:
[~maniraj...@gmail.com] the patch cannot apply to trunk because
[
https://issues.apache.org/jira/browse/YARN-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9912:
---
Attachment: YARN-9912-004.patch
> Capacity scheduler: support u:user2:%secondary_group queue mapping
[
https://issues.apache.org/jira/browse/YARN-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9868:
---
Attachment: YARN-9868-003.patch
> Validate %primary_group queue in CS queue manager
>
[
https://issues.apache.org/jira/browse/YARN-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976536#comment-16976536
]
Peter Bacsko commented on YARN-9969:
Thanks for the patch [~maniraj...@gmail.com].
Please correct the
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976389#comment-16976389
]
Peter Bacsko commented on YARN-8373:
Thanks [~wilfreds] now it looks solid. +1 (non-binding) again
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975731#comment-16975731
]
Peter Bacsko commented on YARN-8373:
Just two little things:
1. Javadoc still says "PriorityQueue":
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975730#comment-16975730
]
Peter Bacsko commented on YARN-8373:
Thanks [~wilfreds] for explaining. If that is the case, let's
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975404#comment-16975404
]
Peter Bacsko commented on YARN-8373:
[~wilfreds] I have some concerns regarding the use of
[
https://issues.apache.org/jira/browse/YARN-9362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975172#comment-16975172
]
Peter Bacsko commented on YARN-9362:
+1 (non-binding) from me.
> Code cleanup in
[
https://issues.apache.org/jira/browse/YARN-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9899:
---
Attachment: YARN-9899-006.patch
> Migration tool that help to generate CS config based on FS config
[
https://issues.apache.org/jira/browse/YARN-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974285#comment-16974285
]
Peter Bacsko commented on YARN-9930:
[~cane] what will be your approach? I think the best would be to
[
https://issues.apache.org/jira/browse/YARN-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9912:
---
Summary: Capacity scheduler: support u:user2:%secondary_group queue mapping
(was: Support
[
https://issues.apache.org/jira/browse/YARN-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9912:
---
Component/s: capacityscheduler
capacity scheduler
> Capacity scheduler: support
[
https://issues.apache.org/jira/browse/YARN-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970421#comment-16970421
]
Peter Bacsko commented on YARN-9930:
[~epayne] thanks for explaining - now it's clear. I do agree that
[
https://issues.apache.org/jira/browse/YARN-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969209#comment-16969209
]
Peter Bacsko commented on YARN-9877:
[~adam.antal] to understand the issue better, I have a question:
[
https://issues.apache.org/jira/browse/YARN-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969209#comment-16969209
]
Peter Bacsko edited comment on YARN-9877 at 11/7/19 12:14 PM:
--
[~adam.antal]
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969193#comment-16969193
]
Peter Bacsko commented on YARN-9011:
[~adam.antal] thanks for the comments.
_"[...] renaming
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9011:
---
Attachment: YARN-9011-009.patch
> Race condition during decommissioning
>
[
https://issues.apache.org/jira/browse/YARN-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969028#comment-16969028
]
Peter Bacsko commented on YARN-9930:
[~epayne] [~cane] I'm a bit lost here.
This setting currently
[
https://issues.apache.org/jira/browse/YARN-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967556#comment-16967556
]
Peter Bacsko commented on YARN-9677:
Thanks for the patch [~pingsutw]. Looks like a straightforward
[
https://issues.apache.org/jira/browse/YARN-9362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967545#comment-16967545
]
Peter Bacsko commented on YARN-9362:
Thanks for the patch [~denes.gerencser]. I don't have too much
[
https://issues.apache.org/jira/browse/YARN-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967513#comment-16967513
]
Peter Bacsko commented on YARN-9899:
Fixed a couple of minor things in v5. Also, if args.length == 0,
[
https://issues.apache.org/jira/browse/YARN-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9899:
---
Attachment: YARN-9899-005.patch
> Migration tool that help to generate CS config based on FS config
[
https://issues.apache.org/jira/browse/YARN-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966969#comment-16966969
]
Peter Bacsko commented on YARN-9930:
[~cane] as [~epayne] noted above, this is exactly what FS does
[
https://issues.apache.org/jira/browse/YARN-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9899:
---
Attachment: YARN-9899-004.patch
> Migration tool that help to generate CS config based on FS config
[
https://issues.apache.org/jira/browse/YARN-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964099#comment-16964099
]
Peter Bacsko commented on YARN-9899:
Note: failing tests seems to fail for a reason other than the
[
https://issues.apache.org/jira/browse/YARN-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9899:
---
Attachment: YARN-9899-003.patch
> Migration tool that help to generate CS config based on FS config
[
https://issues.apache.org/jira/browse/YARN-9920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963715#comment-16963715
]
Peter Bacsko edited comment on YARN-9920 at 10/31/19 7:08 AM:
--
Thanks for
[
https://issues.apache.org/jira/browse/YARN-9920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963715#comment-16963715
]
Peter Bacsko commented on YARN-9920:
Thanks for patch [~prabhujoseph], looks pretty good. I have only
[
https://issues.apache.org/jira/browse/YARN-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963082#comment-16963082
]
Peter Bacsko edited comment on YARN-9899 at 10/30/19 2:59 PM:
--
[~snemeth]
[
https://issues.apache.org/jira/browse/YARN-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963082#comment-16963082
]
Peter Bacsko commented on YARN-9899:
[~snemeth] this is the help text that you get with this patch:
[
https://issues.apache.org/jira/browse/YARN-9865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963002#comment-16963002
]
Peter Bacsko commented on YARN-9865:
Patch v4 looks good.
I made a small refactor regarding the
[
https://issues.apache.org/jira/browse/YARN-9865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9865:
---
Attachment: YARN-9865-005.patch
> Capacity scheduler: add support for combined %user +
[
https://issues.apache.org/jira/browse/YARN-9865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962111#comment-16962111
]
Peter Bacsko commented on YARN-9865:
Thanks for the update.
I just realized two things:
1) The two
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961988#comment-16961988
]
Peter Bacsko commented on YARN-9011:
Thanks [~tangzhankun] for the comments - glad we're on the same
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9011:
---
Attachment: YARN-9011-008.patch
> Race condition during decommissioning
>
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961879#comment-16961879
]
Peter Bacsko edited comment on YARN-9011 at 10/29/19 11:10 AM:
---
_"1. Why do
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961897#comment-16961897
]
Peter Bacsko edited comment on YARN-9011 at 10/29/19 11:03 AM:
---
Ok, actually
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961897#comment-16961897
]
Peter Bacsko commented on YARN-9011:
Ok, actually we always call the
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961879#comment-16961879
]
Peter Bacsko edited comment on YARN-9011 at 10/29/19 10:48 AM:
---
_"1. Why do
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961879#comment-16961879
]
Peter Bacsko edited comment on YARN-9011 at 10/29/19 10:48 AM:
---
_"1. Why do
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961879#comment-16961879
]
Peter Bacsko commented on YARN-9011:
_"1. Why do we need a lazy update?"_
Please see details in my
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961133#comment-16961133
]
Peter Bacsko commented on YARN-9011:
Thanks [~snemeth] for the comments - uploaded patch v7 with
[
https://issues.apache.org/jira/browse/YARN-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9011:
---
Attachment: YARN-9011-007.patch
> Race condition during decommissioning
>
[
https://issues.apache.org/jira/browse/YARN-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961000#comment-16961000
]
Peter Bacsko commented on YARN-9891:
Apparently, [~zsiegl] will work on this in YARN-9936.
Closing
[
https://issues.apache.org/jira/browse/YARN-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko resolved YARN-9891.
Resolution: Duplicate
> Capacity scheduler: enhance capacity / maximum-capacity setting
>
[
https://issues.apache.org/jira/browse/YARN-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960973#comment-16960973
]
Peter Bacsko commented on YARN-9868:
Thanks for patch [~maniraj...@gmail.com], unfortunately it no
[
https://issues.apache.org/jira/browse/YARN-9788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960937#comment-16960937
]
Peter Bacsko commented on YARN-9788:
+1 (non-binding)
> Queue Management API - does not support
[
https://issues.apache.org/jira/browse/YARN-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960936#comment-16960936
]
Peter Bacsko commented on YARN-9780:
Latest patch +1 (non-binding).
> SchedulerConf Mutation Api does
[
https://issues.apache.org/jira/browse/YARN-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959719#comment-16959719
]
Peter Bacsko commented on YARN-9930:
To me this looks like a duplicate. [~cane] please check and close
[
https://issues.apache.org/jira/browse/YARN-9865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959662#comment-16959662
]
Peter Bacsko commented on YARN-9865:
[~maniraj...@gmail.com] I agree, this is negligible. Let's skip
[
https://issues.apache.org/jira/browse/YARN-9789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957015#comment-16957015
]
Peter Bacsko commented on YARN-9789:
Patch looks straightforward, +1 non-binding.
> Disable Option
[
https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956995#comment-16956995
]
Peter Bacsko edited comment on YARN-9923 at 10/22/19 12:16 PM:
---
_"NONE
[
https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956995#comment-16956995
]
Peter Bacsko commented on YARN-9923:
_"NONE (default): preserving the current behaviour [...]"_
Even
[
https://issues.apache.org/jira/browse/YARN-9788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956957#comment-16956957
]
Peter Bacsko commented on YARN-9788:
Thanks for the patch [~Prabhu Joseph]. I think the patch looks
[
https://issues.apache.org/jira/browse/YARN-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956941#comment-16956941
]
Peter Bacsko commented on YARN-9780:
[~Prabhu Joseph] I have some minor comments:
#1 Nit: pay
[
https://issues.apache.org/jira/browse/YARN-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956934#comment-16956934
]
Peter Bacsko commented on YARN-9781:
LGTM +1 (non-binding)
> SchedConfCli to get current stored
[
https://issues.apache.org/jira/browse/YARN-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956688#comment-16956688
]
Peter Bacsko edited comment on YARN-9887 at 10/22/19 5:21 AM:
--
[~wangda]
[
https://issues.apache.org/jira/browse/YARN-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956688#comment-16956688
]
Peter Bacsko commented on YARN-9887:
[~wangda] that's correct, but are you saying that we should not
[
https://issues.apache.org/jira/browse/YARN-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956102#comment-16956102
]
Peter Bacsko commented on YARN-9887:
[~epayne] sorry for the delayed answer. Thanks for the info, I'm
[
https://issues.apache.org/jira/browse/YARN-9865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956096#comment-16956096
]
Peter Bacsko commented on YARN-9865:
[~maniraj...@gmail.com] could you please fix the last checkstyle
[
https://issues.apache.org/jira/browse/YARN-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956017#comment-16956017
]
Peter Bacsko commented on YARN-9922:
Findbugs is unrelated, "no tests" is obvious.
pls check [~eyang]
[
https://issues.apache.org/jira/browse/YARN-9699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955926#comment-16955926
]
Peter Bacsko commented on YARN-9699:
Thanks [~eyang], I created YARN-9922 to fix these Javadoc issues.
[
https://issues.apache.org/jira/browse/YARN-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9922:
---
Attachment: YARN-9922-001.patch
> Fix JavaDoc errors introduced by YARN-9699
>
[
https://issues.apache.org/jira/browse/YARN-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9922:
---
Description:
We accidentally introduced some Javadoc errors in YARN-9699:
{code:java}
[ERROR]
1001 - 1100 of 1682 matches
Mail list logo