[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415750#comment-15415750 ] Hudson commented on YARN-5382: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10254 (See

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414251#comment-15414251 ] Jason Lowe commented on YARN-5382: -- +1 for the latest trunk and branch-2.7 patches. I'll commit this

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414129#comment-15414129 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413740#comment-15413740 ] Jason Lowe commented on YARN-5382: -- Scratch that commit, the javadoc error flagged above is related to the

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413725#comment-15413725 ] Jason Lowe commented on YARN-5382: -- +1 for the latest patch. Committing this. > RM does not audit log

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412869#comment-15412869 ] Jian He commented on YARN-5382: --- ah, I missed it.. thanks for catching this ! > RM does not audit log kill

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412709#comment-15412709 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412593#comment-15412593 ] Jason Lowe commented on YARN-5382: -- The auditLogKillEvent method is now being called from the

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411191#comment-15411191 ] Jian He commented on YARN-5382: --- lgtm, [~jlowe], would you like to check? > RM does not audit log kill

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409789#comment-15409789 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409011#comment-15409011 ] Jian He commented on YARN-5382: --- [~vrushalic], looks like you reformatted the whole RMAppImpl java file, and

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406843#comment-15406843 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406600#comment-15406600 ] Vrushali C commented on YARN-5382: -- Will quickly fix the javadoc warnings and one of the findbugs issue.

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405321#comment-15405321 ] Jian He commented on YARN-5382: --- bq. I see only one audit log message when I ran a sleep job and killed it on

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405056#comment-15405056 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404788#comment-15404788 ] Vrushali C commented on YARN-5382: -- So with the last uploaded patch v9 on branch-2.7

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404694#comment-15404694 ] Jason Lowe commented on YARN-5382: -- If we keep the kill success logging in both a transition and in

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404634#comment-15404634 ] Vrushali C commented on YARN-5382: -- Thanks [~jianhe] and [~jlowe]. Apologies, I somehow missed that the

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404090#comment-15404090 ] Jason Lowe commented on YARN-5382: -- bq. Does user expect audit logging both before killing and after

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403426#comment-15403426 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403414#comment-15403414 ] Jian He commented on YARN-5382: --- With this patch, looks like killing a normal running app will cause RM audit

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402851#comment-15402851 ] Vrushali C commented on YARN-5382: -- Thanks [~jlowe] , yes will update the trunk patch with your

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402675#comment-15402675 ] Jason Lowe commented on YARN-5382: -- Thanks for updating the patch! Nit: RMAppKillByClientLogEvent should

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400275#comment-15400275 ] Vrushali C commented on YARN-5382: -- Wondering what I can do to fix the checkstyle warning for {code}

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400262#comment-15400262 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399560#comment-15399560 ] Vrushali C commented on YARN-5382: -- Will fix the checkstyle issues shortly > RM does not audit log kill

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398600#comment-15398600 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398430#comment-15398430 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394699#comment-15394699 ] Jason Lowe commented on YARN-5382: -- Note that if the trunk patch applies as-is to branch-2 (as I suspect

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394696#comment-15394696 ] Vrushali C commented on YARN-5382: -- Thanks [~jlowe]! I will make the changes and upload an updated patch

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394678#comment-15394678 ] Jason Lowe commented on YARN-5382: -- Thanks for the update, Vrushali! I should have said this earlier:

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394338#comment-15394338 ] Vrushali C commented on YARN-5382: -- Thanks [~sunilg]! [~jlowe] Would appreciate your feedback as well..

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393438#comment-15393438 ] Sunil G commented on YARN-5382: --- Yes [~vrushalic]. Thanks for updating the patch. I think the current

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390180#comment-15390180 ] Vrushali C commented on YARN-5382: -- Oh I see. I will update the patch. Thanks [~sunilg] > RM does not

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388954#comment-15388954 ] Sunil G commented on YARN-5382: --- Hi [~vrushalic] Thanks for updating the patch. I think there is a slight

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388915#comment-15388915 ] Vrushali C commented on YARN-5382: -- I see one javadoc warning and a few checkstyle warnings in the patch -

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388688#comment-15388688 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388016#comment-15388016 ] Vrushali C commented on YARN-5382: -- Thanks [~sunilg]! Yes, let me update the code on both of the points

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387522#comment-15387522 ] Sunil G commented on YARN-5382: --- Hi [~vrushalic] Thanks for sharing the patch. Few comments 1.

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387521#comment-15387521 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384758#comment-15384758 ] Vrushali C commented on YARN-5382: -- I see, thanks, sounds good. Will do that. > RM does not audit log

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384722#comment-15384722 ] Jason Lowe commented on YARN-5382: -- bq. Will update the patch to include auditing of killing of active

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384627#comment-15384627 ] Vrushali C commented on YARN-5382: -- Thanks [~jlowe] and [~jianhe]! Will update the patch to include

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384373#comment-15384373 ] Jason Lowe commented on YARN-5382: -- I like the general idea, but I'm not sure a literal move of the audit

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383240#comment-15383240 ] Jian He commented on YARN-5382: --- How about move the audit log in RMApp#AppKilledTransition to avoid

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382769#comment-15382769 ] Jason Lowe commented on YARN-5382: -- Ah, I see. The client is continuing to issue the kill request until

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380264#comment-15380264 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379561#comment-15379561 ] Jason Lowe commented on YARN-5382: -- Thanks for the patch, [~vrushalic]! I don't think we should do a

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379128#comment-15379128 ] Hadoop QA commented on YARN-5382: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378949#comment-15378949 ] Naganarasimha G R commented on YARN-5382: - Thanks for the info missed the mail for 2.7.3 by Vinod !

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378918#comment-15378918 ] Rohith Sharma K S commented on YARN-5382: - [~Naganarasimha Garla] I think Target version 2.7.4

[jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications

[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378606#comment-15378606 ] Vrushali C commented on YARN-5382: -- I think I can add this, will upload a patch shortly > RM does not