[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727783#comment-15727783 ] Hudson commented on YARN-5611: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10958 (See

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653069#comment-15653069 ] Rohith Sharma K S commented on YARN-5611: - thanks Jian and Sunil for thorough review.. :-) >

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652550#comment-15652550 ] Jian He commented on YARN-5611: --- Committed to trunk, branch-2, thanks Rohith ! Thanks Sunil for helping the

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652489#comment-15652489 ] Hudson commented on YARN-5611: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10806 (See

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651830#comment-15651830 ] Hadoop QA commented on YARN-5611: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651252#comment-15651252 ] Sunil G commented on YARN-5611: --- Thanks [~rohithsharma] Patch looks generally fine for me pending jenkins. >

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651054#comment-15651054 ] Hadoop QA commented on YARN-5611: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650567#comment-15650567 ] Sunil G commented on YARN-5611: --- Hi [~rohithsharma], Few more comments: 1. StateStore exception is thrown

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649663#comment-15649663 ] Sunil G commented on YARN-5611: --- Thanks [~rohithsharma]. I think RMContainer is mostly kept as read-only. I

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649568#comment-15649568 ] Rohith Sharma K S commented on YARN-5611: - bq.

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649540#comment-15649540 ] Rohith Sharma K S commented on YARN-5611: - [~sunilg] bq 1.

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649497#comment-15649497 ] Bibin A Chundatt commented on YARN-5611: Thank you [~rohithsharma] for patch Few Minor comments #

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648958#comment-15648958 ] Hadoop QA commented on YARN-5611: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648602#comment-15648602 ] Sunil G commented on YARN-5611: --- Thanks [~rohithsharma] for the patch.. *Few more comments.* 1.

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647732#comment-15647732 ] Hadoop QA commented on YARN-5611: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15638126#comment-15638126 ] Jian He commented on YARN-5611: --- Currently, the patch is taking a lock on the applicationId when updating

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637350#comment-15637350 ] Hadoop QA commented on YARN-5611: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635311#comment-15635311 ] Rohith Sharma K S commented on YARN-5611: - bq. 1. ApplicationUpdateTimeoutMapProto ->

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633911#comment-15633911 ] Sunil G commented on YARN-5611: --- Thanks [~rohithsharma] for the patch. Few comments 1.

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630958#comment-15630958 ] Jian He commented on YARN-5611: --- - can you add comments about the type of the timeout value ? {code} /**

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629646#comment-15629646 ] Hadoop QA commented on YARN-5611: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623498#comment-15623498 ] Jian He commented on YARN-5611: --- - What is the reason to involve RMAppImpl state-machine to update the

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608854#comment-15608854 ] Hadoop QA commented on YARN-5611: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601420#comment-15601420 ] Varun Vasudev commented on YARN-5611: - Instead of using long as part of the API and expecting clients

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15599256#comment-15599256 ] Rohith Sharma K S commented on YARN-5611: - bq. Will currentExpiryTime and updatedExpiryTime be in

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15599238#comment-15599238 ] Varun Vasudev commented on YARN-5611: - bq. update Response from RM should be currentExpiryTime and

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15596258#comment-15596258 ] Sunil G commented on YARN-5611: --- Thanks folks for the summary and approach looks fine. Couple of quick

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595938#comment-15595938 ] Rohith Sharma K S commented on YARN-5611: - We (me [~jianhe] and [~vinodkv]) had offline discussion

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593578#comment-15593578 ] Vinod Kumar Vavilapalli commented on YARN-5611: --- HADOOP-11552 may be an easy out as long as

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589343#comment-15589343 ] Jian He commented on YARN-5611: --- As you noted, making it polling is introducing all these complexities. IMO,

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588202#comment-15588202 ] Rohith Sharma K S commented on YARN-5611: - Summary of discussion for supporting update API for

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586506#comment-15586506 ] Jian He commented on YARN-5611: --- Thanks Rohith, - AbstractLivenessMonitor#getMonitorStartTime not used - I

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586199#comment-15586199 ] Hadoop QA commented on YARN-5611: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15582078#comment-15582078 ] Rohith Sharma K S commented on YARN-5611: - bq. The appIdToTimeoutTypeMapping may be not needed. I

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580786#comment-15580786 ] Jian He commented on YARN-5611: --- - The first if condition already checks whether the app is either at new or

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576327#comment-15576327 ] Hadoop QA commented on YARN-5611: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516508#comment-15516508 ] Jian He commented on YARN-5611: --- - I thought the lifetime passed in the updateLifetime API is an absolute

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512376#comment-15512376 ] Sunil G commented on YARN-5611: --- Thanks [~rohithsharma], few high level comments. 1. {code}

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510463#comment-15510463 ] Naganarasimha G R commented on YARN-5611: - Hi [~rohithsharma], Patch does not seem to get applied

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502942#comment-15502942 ] Sunil G commented on YARN-5611: --- Yes. make sense for me too.. > Provide an API to update lifetime of an

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502879#comment-15502879 ] Jian He commented on YARN-5611: --- sounds good to me. we can make sure code reused at server side. > Provide

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502878#comment-15502878 ] Jian He commented on YARN-5611: --- sounds good to me. we can make sure code reused at server side. > Provide

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502830#comment-15502830 ] Rohith Sharma K S commented on YARN-5611: - bq. I'm thinking whether makes sense to have a single

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490929#comment-15490929 ] Sunil G commented on YARN-5611: --- Yes.. Adding few more thoughts: - It makes sense to have this class for

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490568#comment-15490568 ] Sunil G commented on YARN-5611: --- Yes [~rohithsharma]. I also thought in same line.. Then i had seen in some

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490435#comment-15490435 ] Rohith Sharma K S commented on YARN-5611: - I think from server end, this can be handled without any

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490403#comment-15490403 ] Sunil G commented on YARN-5611: --- Make sense to me.. But some of the options may not have any relation with

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490037#comment-15490037 ] Rohith Sharma K S commented on YARN-5611: - +1 for the suggestion. This make sense to me. > Provide

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489888#comment-15489888 ] Jian He commented on YARN-5611: --- Things like priority, timeout, node-label are attributes of application,

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489717#comment-15489717 ] Hadoop QA commented on YARN-5611: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5611) Provide an API to update lifetime of an application.

[ https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489649#comment-15489649 ] Rohith Sharma K S commented on YARN-5611: - Attached v0 patch for API support. Some points need to