[jira] [Comment Edited] (YARN-4761) NMs reconnecting with changed capabilities can lead to wrong cluster resource calculations on fair scheduler

2018-01-30 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346254#comment-16346254 ] Sangjin Lee edited comment on YARN-4761 at 1/31/18 5:12 AM: + [~templedf]

[jira] [Commented] (YARN-4761) NMs reconnecting with changed capabilities can lead to wrong cluster resource calculations on fair scheduler

2018-01-30 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346254#comment-16346254 ] Sangjin Lee commented on YARN-4761: --- + [~templedf] [~yufeigu] > NMs reconnecting with changed

[jira] [Assigned] (YARN-6771) Use classloader inside configuration class to make new classes

2017-09-20 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee reassigned YARN-6771: - Assignee: Jongyoul Lee > Use classloader inside configuration class to make new classes >

[jira] [Commented] (YARN-6771) Use classloader inside configuration class to make new classes

2017-09-20 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174281#comment-16174281 ] Sangjin Lee commented on YARN-6771: --- LGTM. Committing it shortly. > Use classloader inside configuration

[jira] [Commented] (YARN-6466) Provide shaded framework jar for containers

2017-08-11 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124097#comment-16124097 ] Sangjin Lee commented on YARN-6466: --- [~haibochen], I see you reassigned this to yourself. Let's resurrect

[jira] [Commented] (YARN-6771) Use classloader inside configuration class to make new classes

2017-08-02 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111829#comment-16111829 ] Sangjin Lee commented on YARN-6771: --- Thanks for the update. Could you please look at the checkstyle

[jira] [Commented] (YARN-6771) Use classloader inside configuration class to make new classes

2017-07-21 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096454#comment-16096454 ] Sangjin Lee commented on YARN-6771: --- Thanks for linking the ticket. As for wider tests, I think it'd be

[jira] [Commented] (YARN-6771) Use classloader inside configuration class to make new classes

2017-07-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093116#comment-16093116 ] Sangjin Lee commented on YARN-6771: --- Do you have a JIRA on the Zeppelin side that describes the actual

[jira] [Commented] (YARN-6771) Use classloader inside configuration class to make new classes

2017-07-14 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087770#comment-16087770 ] Sangjin Lee commented on YARN-6771: --- Thanks for the contribution [~jongyoul]. It appears that the same

[jira] [Commented] (YARN-574) PrivateLocalizer does not support parallel resource download via ContainerLocalizer

2017-04-21 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979326#comment-15979326 ] Sangjin Lee commented on YARN-574: -- Thanks for your contribution [~ajithshetty]. Regarding the use of

[jira] [Commented] (YARN-6466) Provide shaded framework jar for containers

2017-04-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973649#comment-15973649 ] Sangjin Lee commented on YARN-6466: --- I think the separate discussion that's happening on HADOOP-11656 is

[jira] [Commented] (YARN-6466) Provide shaded framework jar for containers

2017-04-11 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964646#comment-15964646 ] Sangjin Lee commented on YARN-6466: --- Hi [~busbey], thanks for raising this. How would this compare with

[jira] [Assigned] (YARN-4116) refactor ColumnHelper read* methods

2017-03-13 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee reassigned YARN-4116: - Assignee: Vrushali C (was: Sangjin Lee) > refactor ColumnHelper read* methods >

[jira] [Assigned] (YARN-3741) consider nulling member maps/sets of TimelineEntity

2017-03-13 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee reassigned YARN-3741: - Assignee: Vrushali C (was: Sangjin Lee) > consider nulling member maps/sets of TimelineEntity >

[jira] [Assigned] (YARN-3907) create the flow-version table

2017-03-13 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee reassigned YARN-3907: - Assignee: Vrushali C (was: Sangjin Lee) > create the flow-version table >

[jira] [Assigned] (YARN-3512) add more fine-grained metrics that measure write performance

2017-03-13 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee reassigned YARN-3512: - Assignee: Vrushali C (was: Sangjin Lee) > add more fine-grained metrics that measure write

[jira] [Assigned] (YARN-3378) a load test client that can replay a volume of history files

2017-03-13 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee reassigned YARN-3378: - Assignee: Vrushali C (was: Sangjin Lee) > a load test client that can replay a volume of history

[jira] [Assigned] (YARN-3353) provide RPC metrics via JMX for timeline collectors and readers

2017-03-13 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee reassigned YARN-3353: - Assignee: Vrushali C (was: Sangjin Lee) > provide RPC metrics via JMX for timeline collectors

[jira] [Assigned] (YARN-451) Add more metrics to RM page

2017-03-13 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee reassigned YARN-451: Assignee: Joep Rottinghuis (was: Sangjin Lee) > Add more metrics to RM page >

[jira] [Assigned] (YARN-5355) YARN Timeline Service v.2: alpha 2

2017-03-13 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee reassigned YARN-5355: - Assignee: Vrushali C (was: Sangjin Lee) > YARN Timeline Service v.2: alpha 2 >

[jira] [Commented] (YARN-5071) address HBase compatibility issues with trunk

2017-03-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905968#comment-15905968 ] Sangjin Lee commented on YARN-5071: --- I believe this is largely addressed by your work (thanks!). I'm fine

[jira] [Updated] (YARN-6318) timeline service schema creator fails if executed from a remote machine

2017-03-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-6318: -- Attachment: YARN-6318-YARN-5355.02.patch Posted patch v.2 to address the javadoc issue. > timeline

[jira] [Assigned] (YARN-6318) timeline service schema creator fails if executed from a remote machine

2017-03-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee reassigned YARN-6318: - Assignee: Sangjin Lee > timeline service schema creator fails if executed from a remote machine >

[jira] [Updated] (YARN-6318) timeline service schema creator fails if executed from a remote machine

2017-03-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-6318: -- Attachment: YARN-6318-YARN-5355.01.patch Posted patch v.1. Passing in a real {{YarnConfiguration}}

[jira] [Updated] (YARN-6318) timeline service schema creator fails if executed from a remote machine

2017-03-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-6318: -- Priority: Minor (was: Major) Downgrading the issue to minor. Yes, it is true that as long as

[jira] [Created] (YARN-6318) timeline service schema creator fails if executed from a remote machine

2017-03-09 Thread Sangjin Lee (JIRA)
Sangjin Lee created YARN-6318: - Summary: timeline service schema creator fails if executed from a remote machine Key: YARN-6318 URL: https://issues.apache.org/jira/browse/YARN-6318 Project: Hadoop YARN

[jira] [Commented] (YARN-6140) start time key in NM leveldb store should be removed when container is removed

2017-03-07 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899804#comment-15899804 ] Sangjin Lee commented on YARN-6140: --- As mentioned above, This is not reproduced in the trunk version

[jira] [Commented] (YARN-6256) Add FROM_ID info key for timeline entities in reader response.

2017-03-07 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899702#comment-15899702 ] Sangjin Lee commented on YARN-6256: --- +1. Sorry for the late reply. Thanks [~rohithsharma]! > Add FROM_ID

[jira] [Commented] (YARN-6256) Add FROM_ID info key for timeline entities in reader response.

2017-03-03 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895239#comment-15895239 ] Sangjin Lee commented on YARN-6256: --- (TimelineReaderWebServices.java) - l.270: need a space between

[jira] [Comment Edited] (YARN-6256) Add FROM_ID info key for timeline entities in reader response.

2017-03-03 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894621#comment-15894621 ] Sangjin Lee edited comment on YARN-6256 at 3/3/17 4:01 PM: --- Point taken. I know

[jira] [Commented] (YARN-6256) Add FROM_ID info key for timeline entities in reader response.

2017-03-03 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894621#comment-15894621 ] Sangjin Lee commented on YARN-6256: --- Point taken. I know some entity ids and flow name etc. can get quite

[jira] [Comment Edited] (YARN-6256) Add FROM_ID info key for timeline entities in reader response.

2017-03-02 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892935#comment-15892935 ] Sangjin Lee edited comment on YARN-6256 at 3/2/17 8:35 PM: --- Thanks for the patch

[jira] [Commented] (YARN-6256) Add FROM_ID info key for timeline entities in reader response.

2017-03-02 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892935#comment-15892935 ] Sangjin Lee commented on YARN-6256: --- Thanks for the patch [~rohithsharma]! I took a quick look at it, and

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-03-01 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891269#comment-15891269 ] Sangjin Lee commented on YARN-6027: --- Committing the addendum patch to YARN-5355-branch-2. > Support

[jira] [Updated] (YARN-6027) Support fromid(offset) filter for /flows API

2017-03-01 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-6027: -- Attachment: YARN-6027-YARN-5355-branch-2.01.patch The addendum patch for branch-2. This restores the

[jira] [Comment Edited] (YARN-6027) Support fromid(offset) filter for /flows API

2017-03-01 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891235#comment-15891235 ] Sangjin Lee edited comment on YARN-6027 at 3/1/17 10:48 PM: The

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-03-01 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891235#comment-15891235 ] Sangjin Lee commented on YARN-6027: --- The YARN-5355-branch-2 branch is failing compilation at

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-03-01 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890484#comment-15890484 ] Sangjin Lee commented on YARN-6027: --- +1. Thanks [~rohithsharma]! > Support fromid(offset) filter for

[jira] [Commented] (YARN-6253) FlowAcitivityColumnPrefix.store(byte[] rowKey, ...) drops timestamp

2017-02-28 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889125#comment-15889125 ] Sangjin Lee commented on YARN-6253: --- LGTM. Will commit shortly. I think it is fine to merge it to the

[jira] [Updated] (YARN-6253) FlowAcitivityColumnPrefix.store(byte[] rowKey, ...) drops timestamp

2017-02-28 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-6253: -- Labels: yarn-5355-merge-blocker (was: ) > FlowAcitivityColumnPrefix.store(byte[] rowKey, ...) drops

[jira] [Commented] (YARN-4061) [Fault tolerance] Fault tolerant writer for timeline v2

2017-02-28 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888979#comment-15888979 ] Sangjin Lee commented on YARN-4061: --- [~haibochen], is your comment a general comment on what that method

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-02-28 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888630#comment-15888630 ] Sangjin Lee commented on YARN-6027: --- OK how about this? The {{TimelineUIDConverter}} class also uses

[jira] [Updated] (YARN-6140) start time key in NM leveldb store should be removed when container is removed

2017-02-28 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-6140: -- Labels: (was: yarn-5355-merge-blocker) > start time key in NM leveldb store should be removed when

[jira] [Commented] (YARN-6140) start time key in NM leveldb store should be removed when container is removed

2017-02-28 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888607#comment-15888607 ] Sangjin Lee commented on YARN-6140: --- I'm going to remove the blocker label. In reality this issue doesn't

[jira] [Commented] (YARN-6199) Support for listing flows with filter userid

2017-02-28 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888604#comment-15888604 ] Sangjin Lee commented on YARN-6199: --- Quick question: do you think this should be a merge blocker? >

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-02-28 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888594#comment-15888594 ] Sangjin Lee commented on YARN-6027: --- Thanks for the updated patch [~rohithsharma]. I'm not sure what the

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-02-27 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886893#comment-15886893 ] Sangjin Lee commented on YARN-6027: --- To me {{RowKeyConverter}} is really an orthogonal conversion from

[jira] [Commented] (YARN-6140) start time key in NM leveldb store should be removed when container is removed

2017-02-24 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883609#comment-15883609 ] Sangjin Lee commented on YARN-6140: --- Any update on this [~ajithshetty]? > start time key in NM leveldb

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-02-24 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883397#comment-15883397 ] Sangjin Lee commented on YARN-6027: --- Thanks for the clarification. I forgot that this is something that

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-02-23 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881523#comment-15881523 ] Sangjin Lee commented on YARN-6027: --- In addition to [~varun_saxena]'s comments, I have a couple of

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-02-23 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880860#comment-15880860 ] Sangjin Lee commented on YARN-6027: --- Thanks [~rohithsharma] for the updated patch. I'll review it today.

[jira] [Commented] (YARN-4985) Refactor the coprocessor code & other definition classes into independent packages

2017-02-22 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879335#comment-15879335 ] Sangjin Lee commented on YARN-4985: --- Yes, I agree. > Refactor the coprocessor code & other definition

[jira] [Commented] (YARN-4985) Refactor the coprocessor code & other definition classes into independent packages

2017-02-22 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879210#comment-15879210 ] Sangjin Lee commented on YARN-4985: --- I went over the coprocessor code in some detail, and largely

[jira] [Commented] (YARN-4985) Refactor the coprocessor code & other definition classes into independent packages

2017-02-22 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878989#comment-15878989 ] Sangjin Lee commented on YARN-4985: --- Let me look through the code and see what kind of dependencies are

[jira] [Commented] (YARN-4985) Refactor the coprocessor code & other definition classes into independent packages

2017-02-21 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877293#comment-15877293 ] Sangjin Lee commented on YARN-4985: --- Thanks for the update [~haibochen]. bq. With this new module, we do

[jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-16 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871096#comment-15871096 ] Sangjin Lee commented on YARN-4675: --- Thanks Naga. Committed it to YARN-5355 and YARN-5355-branch-2. >

[jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-16 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870590#comment-15870590 ] Sangjin Lee commented on YARN-4675: --- I went ahead and committed it to trunk. I'll wait for the YARN-5355

[jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-15 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869215#comment-15869215 ] Sangjin Lee commented on YARN-4675: --- The latest patch LGTM (v.11). I'll commit it soon. [~Naganarasimha],

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-02-15 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868739#comment-15868739 ] Sangjin Lee commented on YARN-6027: --- On a related note, how would the client provide the value for

[jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-15 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868665#comment-15868665 ] Sangjin Lee commented on YARN-4675: --- It's kind of hard to parse but the javadoc error is related to the

[jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-15 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868554#comment-15868554 ] Sangjin Lee commented on YARN-4675: --- The latest version looks good to me (v.10). I'll wait for the

[jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-13 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864400#comment-15864400 ] Sangjin Lee commented on YARN-4675: --- Thanks for the updated patch [~Naganarasimha]! If it is not too

[jira] [Commented] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

2017-02-11 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862542#comment-15862542 ] Sangjin Lee commented on YARN-6170: --- Thanks! > TimelineReaderServer should wait to join with HttpServer2

[jira] [Commented] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

2017-02-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862063#comment-15862063 ] Sangjin Lee commented on YARN-6170: --- Thanks Varun! It would be great if we can merge this to

[jira] [Commented] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

2017-02-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861841#comment-15861841 ] Sangjin Lee commented on YARN-6170: --- I'd like to add that this doesn't necessarily mean that we do not

[jira] [Commented] (YARN-6027) Improve /flows API for more flexible filters fromid, collapse, userid

2017-02-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861739#comment-15861739 ] Sangjin Lee commented on YARN-6027: --- Absolutely. Thanks for the reminder. The idea of supporting the

[jira] [Updated] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

2017-02-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-6170: -- Attachment: YARN-6170.01.patch v.1 patch posted. > TimelineReaderServer should wait to join with

[jira] [Comment Edited] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

2017-02-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861691#comment-15861691 ] Sangjin Lee edited comment on YARN-6170 at 2/10/17 7:06 PM: Thanks for the info

[jira] [Updated] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

2017-02-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-6170: -- Affects Version/s: 3.0.0-alpha2 > TimelineReaderServer should wait to join with HttpServer2 >

[jira] [Commented] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

2017-02-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861691#comment-15861691 ] Sangjin Lee commented on YARN-6170: --- Thanks for the info Varun. I found HADOOP-11479. I can definitely

[jira] [Updated] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

2017-02-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-6170: -- Labels: (was: yarn-5355-merge-blocker) > TimelineReaderServer should wait to join with HttpServer2 >

[jira] [Created] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

2017-02-09 Thread Sangjin Lee (JIRA)
Sangjin Lee created YARN-6170: - Summary: TimelineReaderServer should wait to join with HttpServer2 Key: YARN-6170 URL: https://issues.apache.org/jira/browse/YARN-6170 Project: Hadoop YARN Issue

[jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860164#comment-15860164 ] Sangjin Lee commented on YARN-4675: --- We should be good to go once you addressed Varun's comments. Should

[jira] [Commented] (YARN-4985) Refactor the coprocessor code & other definition classes into independent packages

2017-02-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860136#comment-15860136 ] Sangjin Lee commented on YARN-4985: --- Thanks for refreshing my memory on this Haibo. Yes, I recall that

[jira] [Commented] (YARN-6027) Improve /flows API for more flexible filters fromid, collapse, userid

2017-02-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860111#comment-15860111 ] Sangjin Lee commented on YARN-6027: --- We discussed this offline during our status call. Just to record

[jira] [Commented] (YARN-4985) Refactor the coprocessor code & other definition classes into independent packages

2017-02-08 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859055#comment-15859055 ] Sangjin Lee commented on YARN-4985: --- [~haibochen] Is it possible to create the hbase-server module so

[jira] [Commented] (YARN-6140) start time key in NM leveldb store should be removed when container is removed

2017-02-03 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852013#comment-15852013 ] Sangjin Lee commented on YARN-6140: --- One interesting thing is that in the current YARN-5355 branch the

[jira] [Commented] (YARN-6140) start time key in NM leveldb store should be removed when container is removed

2017-02-03 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851801#comment-15851801 ] Sangjin Lee commented on YARN-6140: --- Please feel free! > start time key in NM leveldb store should be

[jira] [Created] (YARN-6140) start time key in NM leveldb store should be removed when container is removed

2017-02-03 Thread Sangjin Lee (JIRA)
Sangjin Lee created YARN-6140: - Summary: start time key in NM leveldb store should be removed when container is removed Key: YARN-6140 URL: https://issues.apache.org/jira/browse/YARN-6140 Project: Hadoop

[jira] [Commented] (YARN-4985) Refactor the coprocessor code & other definition classes into independent packages

2017-01-27 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843111#comment-15843111 ] Sangjin Lee commented on YARN-4985: --- At the end of the day, {{TimelineSchemaCreator}} is a standalone

[jira] [Updated] (YARN-3637) Handle localization sym-linking correctly at the YARN level

2017-01-25 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-3637: -- Hadoop Flags: Reviewed > Handle localization sym-linking correctly at the YARN level >

[jira] [Comment Edited] (YARN-6117) SharedCacheManager does not start up

2017-01-25 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838828#comment-15838828 ] Sangjin Lee edited comment on YARN-6117 at 1/25/17 11:39 PM: - Ported it to

[jira] [Updated] (YARN-6117) SharedCacheManager does not start up

2017-01-25 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-6117: -- Fix Version/s: 2.9.0 Ported it to branch-2 as well (2.9.0). > SharedCacheManager does not start up >

[jira] [Commented] (YARN-3637) Handle localization sym-linking correctly at the YARN level

2017-01-24 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837209#comment-15837209 ] Sangjin Lee commented on YARN-3637: --- I'll commit this patch tomorrow unless there is an objection.

[jira] [Commented] (YARN-3637) Handle localization sym-linking correctly at the YARN level

2017-01-20 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832689#comment-15832689 ] Sangjin Lee commented on YARN-3637: --- Thanks [~ctrezzo] for your patch! It looks good for the most part.

[jira] [Commented] (YARN-4675) Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl

2017-01-20 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832483#comment-15832483 ] Sangjin Lee commented on YARN-4675: --- Thanks [~Naganarasimha]! I went over the latest patch, and have some

[jira] [Commented] (YARN-5928) Move ATSv2 HBase backend code into a new module that is only dependent at runtime by yarn servers

2017-01-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831180#comment-15831180 ] Sangjin Lee commented on YARN-5928: --- Since this is targeted for 3.0.0-alpha2, I'm merging this to

[jira] [Commented] (YARN-5928) Move ATSv2 HBase backend code into a new module that is only dependent at runtime by yarn servers

2017-01-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831175#comment-15831175 ] Sangjin Lee commented on YARN-5928: --- The latest patches LGTM. Will commit shortly. > Move ATSv2 HBase

[jira] [Commented] (YARN-5928) Move ATSv2 HBase backend code into a new module that is only dependent at runtime by yarn servers

2017-01-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831135#comment-15831135 ] Sangjin Lee commented on YARN-5928: --- Thanks [~haibochen]! Actually only the former argument needs to be

[jira] [Commented] (YARN-5928) Move ATSv2 HBase backend code into a new module that is only dependent at runtime by yarn servers

2017-01-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830794#comment-15830794 ] Sangjin Lee commented on YARN-5928: --- [~haibochen], now that YARN-6094 has been committed, do you mind

[jira] [Commented] (YARN-6094) Update the coprocessor to be a dynamically loaded one

2017-01-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830782#comment-15830782 ] Sangjin Lee commented on YARN-6094: --- Sounds good. Committing shortly. > Update the coprocessor to be a

[jira] [Commented] (YARN-5304) Ship single node HBase config option with single startup command

2017-01-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830747#comment-15830747 ] Sangjin Lee commented on YARN-5304: --- >From the client perspective, we need to look at some timeout

[jira] [Commented] (YARN-5304) Ship single node HBase config option with single startup command

2017-01-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830702#comment-15830702 ] Sangjin Lee commented on YARN-5304: --- We should review and set some of the recommended properties in the

[jira] [Commented] (YARN-6094) Update the coprocessor to be a dynamically loaded one

2017-01-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830692#comment-15830692 ] Sangjin Lee commented on YARN-6094: --- I see that hfile.format.version = 3 is actually being used in

[jira] [Commented] (YARN-6094) Update the coprocessor to be a dynamically loaded one

2017-01-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830680#comment-15830680 ] Sangjin Lee commented on YARN-6094: --- I went over the latest patch, and noticed one thing (sorry should

[jira] [Commented] (YARN-4985) Refactor the coprocessor code & other definition classes into independent packages

2017-01-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830428#comment-15830428 ] Sangjin Lee commented on YARN-4985: --- As part of this, it would also be good to see if it is feasible to

[jira] [Commented] (YARN-5928) Move ATSv2 HBase backend code into a new module that is only dependent at runtime by yarn servers

2017-01-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829155#comment-15829155 ] Sangjin Lee commented on YARN-5928: --- As mentioned in YARN-6064, the build on the branch is broken and

[jira] [Commented] (YARN-6094) Update the coprocessor to be a dynamically loaded one

2017-01-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829123#comment-15829123 ] Sangjin Lee commented on YARN-6094: --- The build failures are caused by an existing issue on the branch.

[jira] [Commented] (YARN-6064) Support fromId for flowRuns and flow/flowRun apps REST API's

2017-01-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829088#comment-15829088 ] Sangjin Lee commented on YARN-6064: --- I think this commit broke the build on our branch. As part of

[jira] [Commented] (YARN-5928) Move ATSv2 HBase backend code into a new module that is only dependent at runtime by yarn servers

2017-01-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829047#comment-15829047 ] Sangjin Lee commented on YARN-5928: --- That is failing too. This is the compilation error: {noformat}

  1   2   3   4   5   6   7   8   9   10   >