[jira] [Updated] (YARN-4238) correctly set createdTime and remove modifiedTime when publishing entities

2016-01-27 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-4238: -- Summary: correctly set createdTime and remove modifiedTime when publishing entities (was: createdTime an

[jira] [Commented] (YARN-4238) createdTime and modifiedTime is not reported while publishing entities to ATSv2

2016-01-26 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118614#comment-15118614 ] Sangjin Lee commented on YARN-4238: --- +1 LGTM. [~Naganarasimha], please go ahead and commi

[jira] [Commented] (YARN-4238) createdTime and modifiedTime is not reported while publishing entities to ATSv2

2016-01-26 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118416#comment-15118416 ] Sangjin Lee commented on YARN-4238: --- It's reproducible. > createdTime and modifiedTime i

[jira] [Commented] (YARN-4238) createdTime and modifiedTime is not reported while publishing entities to ATSv2

2016-01-26 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118264#comment-15118264 ] Sangjin Lee commented on YARN-4238: --- The latest patch looks good to me. I'm a little puzz

[jira] [Commented] (YARN-4224) Support fetching entities by UID and change the REST interface to conform to current REST APIs' in YARN

2016-01-26 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118254#comment-15118254 ] Sangjin Lee commented on YARN-4224: --- {quote} I have used Long for a reason here. I plan t

[jira] [Commented] (YARN-4238) createdTime and modifiedTime is not reported while publishing entities to ATSv2

2016-01-25 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116438#comment-15116438 ] Sangjin Lee commented on YARN-4238: --- I skimmed through the patch, and it looks good for t

[jira] [Updated] (YARN-4238) createdTime and modifiedTime is not reported while publishing entities to ATSv2

2016-01-25 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-4238: -- Attachment: YARN-4238-YARN-2928.04.patch Patch renamed. > createdTime and modifiedTime is not reported w

[jira] [Commented] (YARN-4577) Enable aux services to have their own custom classpath/jar file

2016-01-25 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116379#comment-15116379 ] Sangjin Lee commented on YARN-4577: --- bq. Do we have any examples for this ? I can only fi

[jira] [Commented] (YARN-4224) Support fetching entities by UID and change the REST interface to conform to current REST APIs' in YARN

2016-01-25 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116331#comment-15116331 ] Sangjin Lee commented on YARN-4224: --- The patch looks mostly good. I only have a few minor

[jira] [Updated] (YARN-4224) Support fetching entities by UID and change the REST interface to conform to current REST APIs' in YARN

2016-01-25 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-4224: -- Attachment: YARN-4224-YARN-2928.05.patch OK the patch doesn't need to change as it is in timelineservice

[jira] [Commented] (YARN-4224) Support fetching entities by UID and change the REST interface to conform to current REST APIs' in YARN

2016-01-25 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115826#comment-15115826 ] Sangjin Lee commented on YARN-4224: --- Let me take a look at it today. [~varun_saxena], doe

[jira] [Commented] (YARN-4062) Add the flush and compaction functionality via coprocessors and scanners for flow run table

2016-01-22 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113484#comment-15113484 ] Sangjin Lee commented on YARN-4062: --- Regarding getting access to YarnConfiguration, gener

[jira] [Commented] (YARN-1593) support out-of-proc AuxiliaryServices

2016-01-15 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102821#comment-15102821 ] Sangjin Lee commented on YARN-1593: --- Just a quick observation that making auxiliary servi

[jira] [Commented] (YARN-4577) Enable aux services to have their own custom classpath/jar file

2016-01-15 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102794#comment-15102794 ] Sangjin Lee commented on YARN-4577: --- Thanks for the updated patch [~xgong]! I had bit of

[jira] [Commented] (YARN-4577) Enable aux services to have their own custom classpath/jar file

2016-01-14 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15099191#comment-15099191 ] Sangjin Lee commented on YARN-4577: --- {quote} The use case here is simple: if we specify t

[jira] [Commented] (YARN-4577) Enable aux services to have their own custom classpath/jar file

2016-01-13 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096584#comment-15096584 ] Sangjin Lee commented on YARN-4577: --- Hi [~xgong], it would be great if you could describe

[jira] [Commented] (YARN-4577) Enable aux services to have their own custom classpath/jar file

2016-01-11 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092543#comment-15092543 ] Sangjin Lee commented on YARN-4577: --- We do have a fairly generic isolated classloader und

[jira] [Commented] (YARN-3995) Some of the NM events are not getting published due race condition when AM container finishes in NM

2016-01-11 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092386#comment-15092386 ] Sangjin Lee commented on YARN-3995: --- I'm +1 on the latest patch too. I'll commit it short

[jira] [Commented] (YARN-3995) Some of the NM events are not getting published due race condition when AM container finishes in NM

2016-01-11 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092274#comment-15092274 ] Sangjin Lee commented on YARN-3995: --- I also thought about shutdownNow. The only reason I

[jira] [Commented] (YARN-4224) Support fetching entities by UID and change the REST interface to conform to current REST APIs' in YARN

2016-01-08 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090270#comment-15090270 ] Sangjin Lee commented on YARN-4224: --- I agree with what you said about escaping the separa

[jira] [Commented] (YARN-3995) Some of the NM events are not getting published due race condition when AM container finishes in NM

2016-01-08 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090213#comment-15090213 ] Sangjin Lee commented on YARN-3995: --- It looks pretty good. Thanks for updating the patch

[jira] [Commented] (YARN-3995) Some of the NM events are not getting published due race condition when AM container finishes in NM

2016-01-07 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088549#comment-15088549 ] Sangjin Lee commented on YARN-3995: --- bq. Yes i wanted to address it as i was trying to po

[jira] [Commented] (YARN-4062) Add the flush and compaction functionality via coprocessors and scanners for flow run table

2016-01-07 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088436#comment-15088436 ] Sangjin Lee commented on YARN-4062: --- Thanks [~vrushalic] for the work! She and I went ove

[jira] [Commented] (YARN-3367) Replace starting a separate thread for post entity with event loop in TimelineClient

2016-01-07 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087811#comment-15087811 ] Sangjin Lee commented on YARN-3367: --- [~Naganarasimha] and I spoke offline about this, but

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2016-01-05 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15084415#comment-15084415 ] Sangjin Lee commented on YARN-4356: --- The current code *does* consider the case where the

[jira] [Commented] (YARN-4224) Change the ATSv2 reader side REST interface to conform to current REST APIs' in YARN

2015-12-24 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070736#comment-15070736 ] Sangjin Lee commented on YARN-4224: --- +1. It is a valid point that we don't want implement

[jira] [Commented] (YARN-3995) Some of the NM events are not getting published due race condition when AM container finishes in NM

2015-12-23 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070723#comment-15070723 ] Sangjin Lee commented on YARN-3995: --- bq. This is true in most of the cases, unless and un

[jira] [Commented] (YARN-3367) Replace starting a separate thread for post entity with event loop in TimelineClient

2015-12-23 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070715#comment-15070715 ] Sangjin Lee commented on YARN-3367: --- I haven't fully digested the code so I might be off-

[jira] [Commented] (YARN-3995) Some of the NM events are not getting published due race condition when AM container finishes in NM

2015-12-23 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070690#comment-15070690 ] Sangjin Lee commented on YARN-3995: --- If I recall, this window of opportunity is going to

[jira] [Commented] (YARN-3995) Some of the NM events are not getting published due race condition when AM container finishes in NM

2015-12-23 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070643#comment-15070643 ] Sangjin Lee commented on YARN-3995: --- That would be [~vrushalic], not me. :) It might be

[jira] [Commented] (YARN-3367) Replace starting a separate thread for post entity with event loop in TimelineClient

2015-12-23 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070611#comment-15070611 ] Sangjin Lee commented on YARN-3367: --- Thanks for the patch [~Naganarasimha]! I took a fair

[jira] [Commented] (YARN-4224) Change the ATSv2 reader side REST interface to conform to current REST APIs' in YARN

2015-12-23 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070575#comment-15070575 ] Sangjin Lee commented on YARN-4224: --- Regarding the ambiguity between /ws/v2/timeline/apps

[jira] [Commented] (YARN-4224) Change the ATSv2 reader side REST interface to conform to current REST APIs' in YARN

2015-12-23 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070006#comment-15070006 ] Sangjin Lee commented on YARN-4224: --- Sorry I am catching up with the discussion. Just to

[jira] [Commented] (YARN-3816) [Aggregation] App-level aggregation and accumulation for YARN system metrics

2015-12-22 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068490#comment-15068490 ] Sangjin Lee commented on YARN-3816: --- Just to clarify, it appears both aggregated (but not

[jira] [Commented] (YARN-4062) Add the flush and compaction functionality via coprocessors and scanners for flow run table

2015-12-22 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068450#comment-15068450 ] Sangjin Lee commented on YARN-4062: --- You'll need to use a name like {{YARN-4062-feature-Y

[jira] [Commented] (YARN-3586) RM only get back addresses of Collectors that NM needs to know.

2015-12-21 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067372#comment-15067372 ] Sangjin Lee commented on YARN-3586: --- The latest patch LGTM. Thanks [~djp]! > RM only get

[jira] [Commented] (YARN-3816) [Aggregation] App-level aggregation and accumulation for YARN system metrics

2015-12-21 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067340#comment-15067340 ] Sangjin Lee commented on YARN-3816: --- Right. There was a discussion around YARN-4053 on th

[jira] [Commented] (YARN-3816) [Aggregation] App-level aggregation and accumulation for YARN system metrics

2015-12-21 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067330#comment-15067330 ] Sangjin Lee commented on YARN-3816: --- Regarding the new entity type "YARN_APPLICATION_AGGR

[jira] [Commented] (YARN-3816) [Aggregation] App-level aggregation and accumulation for YARN system metrics

2015-12-21 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067321#comment-15067321 ] Sangjin Lee commented on YARN-3816: --- It seems the latest patch (v.4.1) is mostly a rebase

[jira] [Commented] (YARN-4224) Change the ATSv2 reader side REST interface to conform to current REST APIs' in YARN

2015-12-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064931#comment-15064931 ] Sangjin Lee commented on YARN-4224: --- Thanks [~gtCarrera9] for the update! Then I'd like

[jira] [Commented] (YARN-4238) createdTime and modifiedTime is not reported while publishing entities to ATSv2

2015-12-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064910#comment-15064910 ] Sangjin Lee commented on YARN-4238: --- Thanks [~varun_saxena] for the summary, and [~Nagana

[jira] [Commented] (YARN-4350) TestDistributedShell fails for V2 scenarios

2015-12-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064457#comment-15064457 ] Sangjin Lee commented on YARN-4350: --- Thanks for digging deep into this [~Naganarasimha].

[jira] [Commented] (YARN-4224) Change the ATSv2 reader side REST interface to conform to current REST APIs' in YARN

2015-12-15 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059420#comment-15059420 ] Sangjin Lee commented on YARN-4224: --- I'm a little late to this thread, and have just star

[jira] [Commented] (YARN-4238) createdTime and modifiedTime is not reported while publishing entities to ATSv2

2015-12-15 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059368#comment-15059368 ] Sangjin Lee commented on YARN-4238: --- The unit test failures are not related to this patch

[jira] [Commented] (YARN-4350) TestDistributedShell fails

2015-12-15 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059360#comment-15059360 ] Sangjin Lee commented on YARN-4350: --- Quick question for [~Naganarasimha]: why is the chan

[jira] [Commented] (YARN-4445) Unify the term flowId and flowName in timeline v2 codebase

2015-12-15 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059353#comment-15059353 ] Sangjin Lee commented on YARN-4445: --- I'm +1 with consolidating one in favor of the other.

[jira] [Commented] (YARN-4450) TestTimelineAuthenticationFilter and TestYarnConfigurationFields fail

2015-12-15 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059320#comment-15059320 ] Sangjin Lee commented on YARN-4450: --- Thanks [~gtCarrera9] and [~Naganarasimha] for your r

[jira] [Commented] (YARN-4460) [Bug fix] RM fails to start when SMP is enabled

2015-12-15 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059211#comment-15059211 ] Sangjin Lee commented on YARN-4460: --- +1 pending jenkins. > [Bug fix] RM fails to start w

[jira] [Commented] (YARN-4247) Deadlock in FSAppAttempt and RMAppAttemptImpl causes RM to stop processing events

2015-12-14 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057190#comment-15057190 ] Sangjin Lee commented on YARN-4247: --- FYI, those who port YARN-2005 without YARN-3361 will

[jira] [Updated] (YARN-4224) Change the ATSv2 reader side REST interface to conform to current REST APIs' in YARN

2015-12-14 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-4224: -- Labels: yarn-2928-1st-milestone (was: ) > Change the ATSv2 reader side REST interface to conform to curr

[jira] [Commented] (YARN-4183) Enabling generic application history forces every job to get a timeline service delegation token

2015-12-14 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056794#comment-15056794 ] Sangjin Lee commented on YARN-4183: --- IMO it is probably acceptable for clients to set yar

[jira] [Commented] (YARN-4450) TestTimelineAuthenticationFilter and TestYarnConfigurationFields fail

2015-12-14 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056458#comment-15056458 ] Sangjin Lee commented on YARN-4450: --- No, it is not an issue with the trunk. What's done i

[jira] [Commented] (YARN-4450) TestTimelineAuthenticationFilter and TestYarnConfigurationFields fail

2015-12-14 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056428#comment-15056428 ] Sangjin Lee commented on YARN-4450: --- Can I use a quick review on this? The changes are ve

[jira] [Commented] (YARN-4450) TestTimelineAuthenticationFilter and TestYarnConfigurationFields fail

2015-12-14 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056297#comment-15056297 ] Sangjin Lee commented on YARN-4450: --- Thanks for noticing the issue. I just posted the pat

[jira] [Updated] (YARN-4450) TestTimelineAuthenticationFilter and TestYarnConfigurationFields fail

2015-12-14 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-4450: -- Attachment: YARN-4450-feature-YARN-2928.01.patch Patch v.1 posted. > TestTimelineAuthenticationFilter an

[jira] [Created] (YARN-4450) TestTimelineAuthenticationFilter and TestYarnConfigurationFields fail

2015-12-12 Thread Sangjin Lee (JIRA)
Sangjin Lee created YARN-4450: - Summary: TestTimelineAuthenticationFilter and TestYarnConfigurationFields fail Key: YARN-4450 URL: https://issues.apache.org/jira/browse/YARN-4450 Project: Hadoop YARN

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-11 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053478#comment-15053478 ] Sangjin Lee commented on YARN-4356: --- Thanks folks for the review! > ensure the timeline

[jira] [Commented] (YARN-4341) add doc about timeline performance tool usage

2015-12-11 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053089#comment-15053089 ] Sangjin Lee commented on YARN-4341: --- +1. Committing it shortly. > add doc about timeline

[jira] [Commented] (YARN-4350) TestDistributedShell fails

2015-12-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052333#comment-15052333 ] Sangjin Lee commented on YARN-4350: --- I pushed that commit. Let me know if you need anythi

[jira] [Commented] (YARN-4350) TestDistributedShell fails

2015-12-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052179#comment-15052179 ] Sangjin Lee commented on YARN-4350: --- You mean commit [f114e728da6e19f3d35ff0cfef9fceea26

[jira] [Updated] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-4356: -- Attachment: YARN-4356-feature-YARN-2928.006.patch Posted patch v.6. Addressed Junping's comment for movi

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051498#comment-15051498 ] Sangjin Lee commented on YARN-4356: --- Thanks for the feedback. Now that YARN-3623 has been

[jira] [Commented] (YARN-3623) We should have a config to indicate the Timeline Service version

2015-12-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051264#comment-15051264 ] Sangjin Lee commented on YARN-3623: --- That's why I asked whether you were OK with the word

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049817#comment-15049817 ] Sangjin Lee commented on YARN-4356: --- Thanks [~djp] for your comments. I addressed most of

[jira] [Updated] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-4356: -- Attachment: YARN-4356-feature-YARN-2928.005.patch Posted patch v.5. Addressed most of Junping's feedback

[jira] [Commented] (YARN-4341) add doc about timeline performance tool usage

2015-12-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049718#comment-15049718 ] Sangjin Lee commented on YARN-4341: --- One remaining issue: - in usage, "Each mappe" -> "Ea

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049638#comment-15049638 ] Sangjin Lee commented on YARN-4356: --- [~djp], I'm working on addressing many of your revie

[jira] [Commented] (YARN-3623) We should have a config to indicate the Timeline Service version

2015-12-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049488#comment-15049488 ] Sangjin Lee commented on YARN-3623: --- I'm obviously +1 as that's exactly what I said. :) [

[jira] [Commented] (YARN-3623) We should have a config to indicate the Timeline Service version

2015-12-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049383#comment-15049383 ] Sangjin Lee commented on YARN-3623: --- I'm +1. Thanks. > We should have a config to indica

[jira] [Updated] (YARN-3586) RM only get back addresses of Collectors that NM needs to know.

2015-12-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-3586: -- Labels: yarn-2928-1st-milestone (was: ) > RM only get back addresses of Collectors that NM needs to know

[jira] [Commented] (YARN-2975) FSLeafQueue app lists are accessed without required locks

2015-12-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049188#comment-15049188 ] Sangjin Lee commented on YARN-2975: --- I cherry-picked the fix to branch-2.6 (2.6.4). > FS

[jira] [Updated] (YARN-2975) FSLeafQueue app lists are accessed without required locks

2015-12-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-2975: -- Fix Version/s: 2.6.4 > FSLeafQueue app lists are accessed without required locks > --

[jira] [Commented] (YARN-3623) We should have a config to indicate the Timeline Service version

2015-12-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049005#comment-15049005 ] Sangjin Lee commented on YARN-3623: --- Thanks for your comment [~djp]. Per comments above,

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-09 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048970#comment-15048970 ] Sangjin Lee commented on YARN-4356: --- The jenkins run above is suspect as it doesn't seem

[jira] [Updated] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-08 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-4356: -- Attachment: YARN-4356-feature-YARN-2928.004.patch Posted patch v.4 that addresses Li's comments. > ensur

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-08 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048067#comment-15048067 ] Sangjin Lee commented on YARN-4356: --- Oh I see. Yes, there is no NM metrics publisher in A

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-08 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048049#comment-15048049 ] Sangjin Lee commented on YARN-4356: --- Thanks for your review [~gtCarrera9]. bq. I noticed

[jira] [Commented] (YARN-4341) add doc about timeline performance tool usage

2015-12-08 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047879#comment-15047879 ] Sangjin Lee commented on YARN-4341: --- Sorry [~lichangleo] it took me a while to get to thi

[jira] [Commented] (YARN-3623) We should have a config to indicate the Timeline Service version

2015-12-08 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047695#comment-15047695 ] Sangjin Lee commented on YARN-3623: --- I agree the rolling upgrade use case from v.1 to v.2

[jira] [Updated] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-08 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-4356: -- Attachment: YARN-4356-feature-YARN-2928.003.patch Posted patch v.3. Addressed the javadoc, findbugs, and

[jira] [Commented] (YARN-4350) TestDistributedShell fails

2015-12-08 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047361#comment-15047361 ] Sangjin Lee commented on YARN-4350: --- I think either way is fine, although all things bein

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-08 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047055#comment-15047055 ] Sangjin Lee commented on YARN-4356: --- The jenkins build didn't fire automatically. Kicking

[jira] [Commented] (YARN-4350) TestDistributedShell fails

2015-12-08 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047052#comment-15047052 ] Sangjin Lee commented on YARN-4350: --- [~Naganarasimha]: {quote} I am not sure how to proce

[jira] [Updated] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-07 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-4356: -- Attachment: YARN-4356-feature-YARN-2928.002.patch Posted patch v.2. This should be a reasonably complete

[jira] [Commented] (YARN-3623) We should have a config to indicate the Timeline Service version

2015-12-07 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045609#comment-15045609 ] Sangjin Lee commented on YARN-3623: --- {quote} 4. Can raise new jira and handle REST interf

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-07 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045528#comment-15045528 ] Sangjin Lee commented on YARN-4356: --- Thanks for your quick comments [~vrushalic]! bq. +1

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-03 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15039753#comment-15039753 ] Sangjin Lee commented on YARN-4356: --- I've run unit tests for the affected projects, and c

[jira] [Updated] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

2015-12-03 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated YARN-4356: -- Attachment: YARN-4356-feature-YARN-2928.poc.001.patch I'm posting a POC patch to get early feedback. I h

[jira] [Commented] (YARN-4238) createdTime and modifiedTime is not reported while publishing entities to ATSv2

2015-12-03 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15039534#comment-15039534 ] Sangjin Lee commented on YARN-4238: --- [~varun_saxena], it seems like it should be relative

[jira] [Commented] (YARN-3862) Support for fetching specific configs and metrics based on prefixes

2015-12-01 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035308#comment-15035308 ] Sangjin Lee commented on YARN-3862: --- They do need to be fixed (sooner than later), but I'

[jira] [Commented] (YARN-3769) Consider user limit when calculating total pending resource for preemption policy in Capacity Scheduler

2015-12-01 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034897#comment-15034897 ] Sangjin Lee commented on YARN-3769: --- I'm fine with 2.6.4. > Consider user limit when cal

[jira] [Commented] (YARN-3769) Consider user limit when calculating total pending resource for preemption policy in Capacity Scheduler

2015-12-01 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034613#comment-15034613 ] Sangjin Lee commented on YARN-3769: --- I'll yield to [~djp] on which version this should ma

[jira] [Commented] (YARN-3862) Support for fetching specific configs and metrics based on prefixes

2015-11-30 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033077#comment-15033077 ] Sangjin Lee commented on YARN-3862: --- We might have to live with the ones about 7 paramete

[jira] [Commented] (YARN-4238) createdTime and modifiedTime is not reported while publishing entities to ATSv2

2015-11-30 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032818#comment-15032818 ] Sangjin Lee commented on YARN-4238: --- Sorry it took me a while to get to this. The change

[jira] [Commented] (YARN-3769) Consider user limit when calculating total pending resource for preemption policy in Capacity Scheduler

2015-11-30 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032709#comment-15032709 ] Sangjin Lee commented on YARN-3769: --- Thanks! cc [~djp] > Consider user limit when calcul

[jira] [Commented] (YARN-3862) Support for fetching specific configs and metrics based on prefixes

2015-11-30 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032672#comment-15032672 ] Sangjin Lee commented on YARN-3862: --- The latest patch looks good to me. Can you please se

[jira] [Commented] (YARN-3862) Support for fetching specific configs and metrics based on prefixes

2015-11-30 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032364#comment-15032364 ] Sangjin Lee commented on YARN-3862: --- Committed HADOOP-12562 and kicked off the jenkins bu

[jira] [Commented] (YARN-3862) Support for fetching specific configs and metrics based on prefixes

2015-11-30 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032339#comment-15032339 ] Sangjin Lee commented on YARN-3862: --- Unless anyone objects, I'm going to cherry-pick thos

[jira] [Commented] (YARN-3862) Support for fetching specific configs and metrics based on prefixes

2015-11-30 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032243#comment-15032243 ] Sangjin Lee commented on YARN-3862: --- Thanks Allen for clarifying the issue. It's great t

[jira] [Commented] (YARN-3862) Support for fetching specific configs and metrics based on prefixes

2015-11-25 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027596#comment-15027596 ] Sangjin Lee commented on YARN-3862: --- Failed for the same reason: {noformat} Step 16 : AD

<    4   5   6   7   8   9   10   11   12   13   >