[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486033#comment-14486033
]
Hitesh Shah commented on YARN-2890:
---
+1. Thanks for patiently addressing review comments.
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485303#comment-14485303
]
Mit Desai commented on YARN-2890:
-
[~hitesh] any comments on the latest patch?
> MiniMRYar
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482488#comment-14482488
]
Mit Desai commented on YARN-2890:
-
These test failures are not related to the patch.
These
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482401#comment-14482401
]
Hadoop QA commented on YARN-2890:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393445#comment-14393445
]
Hitesh Shah commented on YARN-2890:
---
Sorry did not check the last update.
Minor nit: So
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393408#comment-14393408
]
Mit Desai commented on YARN-2890:
-
[~hitesh], did you had any comments on the patch?
> Min
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387513#comment-14387513
]
Hadoop QA commented on YARN-2890:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387464#comment-14387464
]
Mit Desai commented on YARN-2890:
-
[~hitesh], the test failures were due to HADOOP-11754
>
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385546#comment-14385546
]
Hadoop QA commented on YARN-2890:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384468#comment-14384468
]
Hadoop QA commented on YARN-2890:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384275#comment-14384275
]
Mit Desai commented on YARN-2890:
-
The test {{testTimelineServiceStartInMiniCluster}} inclu
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380907#comment-14380907
]
Hitesh Shah commented on YARN-2890:
---
Most of the comments sound fine. As long as there is
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380894#comment-14380894
]
Mit Desai commented on YARN-2890:
-
I'm sorry for taking so long to get back [~hitesh].
bq.
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361084#comment-14361084
]
Hitesh Shah commented on YARN-2890:
---
Thanks [~mitdesai]. In the future, it would be good
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361035#comment-14361035
]
Zhijie Shen commented on YARN-2890:
---
bq. If Timeline is going to be a first class citizen
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360938#comment-14360938
]
Mit Desai commented on YARN-2890:
-
bq. The above ctor was removed. If anyone is using MiniM
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360809#comment-14360809
]
Hitesh Shah commented on YARN-2890:
---
2 issues with the patch:
{code}
public MiniMRYarnC
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360704#comment-14360704
]
Mit Desai commented on YARN-2890:
-
Thats because not everything is using the timeline serve
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360669#comment-14360669
]
Tsuyoshi Ozawa commented on YARN-2890:
--
[~mitdesai] thank you for updating a patch! +1
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360415#comment-14360415
]
Mit Desai commented on YARN-2890:
-
[~hitesh] [~zjshen] Can you guys take a look?
> MiniMRY
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358798#comment-14358798
]
Mit Desai commented on YARN-2890:
-
Verified the test failures are not due to my patch.
Some
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357922#comment-14357922
]
Hadoop QA commented on YARN-2890:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355155#comment-14355155
]
Mit Desai commented on YARN-2890:
-
I was not aware of this Jira being reopened. I will take
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355127#comment-14355127
]
Tsuyoshi Ozawa commented on YARN-2890:
--
{code}
public MiniYARNCluster(
Strin
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248352#comment-14248352
]
Hudson commented on YARN-2890:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #44 (See
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248312#comment-14248312
]
Hudson commented on YARN-2890:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #40 (See
[http
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248295#comment-14248295
]
Hudson commented on YARN-2890:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1975 (See
[https://
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248254#comment-14248254
]
Hudson commented on YARN-2890:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1994 (See
[htt
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248119#comment-14248119
]
Hudson commented on YARN-2890:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #777 (See
[https://b
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248107#comment-14248107
]
Hudson commented on YARN-2890:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #43 (See
[http
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247067#comment-14247067
]
Hudson commented on YARN-2890:
--
ABORTED: Integrated in Hadoop-trunk-Commit #6720 (See
[https:
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247050#comment-14247050
]
Jian He commented on YARN-2890:
---
the easiest to resolve this right away is to revert the patc
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246867#comment-14246867
]
Hitesh Shah commented on YARN-2890:
---
Also, can this be ported back all the way to 2.4.x?
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246865#comment-14246865
]
Hitesh Shah commented on YARN-2890:
---
[~zjshen] [~mitdesai] This broke compatibility with
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231629#comment-14231629
]
Hudson commented on YARN-2890:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #23 (See
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231610#comment-14231610
]
Hudson commented on YARN-2890:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1975 (See
[htt
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231515#comment-14231515
]
Hudson commented on YARN-2890:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #23 (See
[http
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231386#comment-14231386
]
Hudson commented on YARN-2890:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #761 (See
[https://b
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231369#comment-14231369
]
Hudson commented on YARN-2890:
--
ABORTED: Integrated in Hadoop-Hdfs-trunk #1951 (See
[https://
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231346#comment-14231346
]
Hudson commented on YARN-2890:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #23 (See
[http
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230904#comment-14230904
]
Hudson commented on YARN-2890:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6623 (See
[https:
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230890#comment-14230890
]
Zhijie Shen commented on YARN-2890:
---
+1 Will commit the patch
> MiniMRYarnCluster should
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230691#comment-14230691
]
Mit Desai commented on YARN-2890:
-
Verified that the failures are not caused by the patch.
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230632#comment-14230632
]
Hadoop QA commented on YARN-2890:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230422#comment-14230422
]
Mit Desai commented on YARN-2890:
-
Tried running these tests without the patch. They still
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230420#comment-14230420
]
Mit Desai commented on YARN-2890:
-
{quote}
-1 core tests. The patch failed these unit tests
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230378#comment-14230378
]
Zhijie Shen commented on YARN-2890:
---
In the scenario of
{code}
conf.setBoolean(YarnCo
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230364#comment-14230364
]
Hadoop QA commented on YARN-2890:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226633#comment-14226633
]
Zhijie Shen commented on YARN-2890:
---
Thanks for the patch, Mit!
1. It makes sense to rel
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225415#comment-14225415
]
Hadoop QA commented on YARN-2890:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225086#comment-14225086
]
Mit Desai commented on YARN-2890:
-
I was trying out the fix for MiniMRYarnCluster where we
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221859#comment-14221859
]
Varun Saxena commented on YARN-2890:
Oh. I saw it unassigned for several hours so assig
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220971#comment-14220971
]
Mit Desai commented on YARN-2890:
-
Forgot to assign it to me. :P
Thats fine. You can carry
[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220970#comment-14220970
]
Mit Desai commented on YARN-2890:
-
[~varun_saxena] I was already working on the issue.
> M
54 matches
Mail list logo