[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17012080#comment-17012080 ] Eric Yang commented on YARN-9052: - Code clean up and performance optimization usually go hand in hand to

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011384#comment-17011384 ] Sunil G commented on YARN-9052: --- MockRM was one of the confused test class in YARN which was used and

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011005#comment-17011005 ] Eric Badger commented on YARN-9052: --- I'm sure we all agree that there's a balancing art of invasive code

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010779#comment-17010779 ] Ahmed Hussein commented on YARN-9052: - {quote}Yes, these are concerns of mine as well. Whenever very

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010710#comment-17010710 ] Eric Payne commented on YARN-9052: -- {quote}I am a little bit concerned with Jiras that solely opened for

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005503#comment-17005503 ] Ahmed Hussein commented on YARN-9052: - [~sunilg], [~snemeth], [~shuzirra], and [~adam.antal] Thanks

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005493#comment-17005493 ] Ahmed Hussein commented on YARN-9052: - [~sunilg] [~snemeth] > Replace all MockRM submit method

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988833#comment-16988833 ] Szilard Nemeth commented on YARN-9052: -- Hi [~sunilg]! Thanks a lot for the commit! Will monitor

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988605#comment-16988605 ] Hudson commented on YARN-9052: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17724 (See

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988021#comment-16988021 ] Sunil G commented on YARN-9052: --- Looks fine to me. Lets get this in tomorrow if there are no objections. cc

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985027#comment-16985027 ] Szilard Nemeth commented on YARN-9052: -- OK, unit test failure was intermittent. [~sunilg] Please

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984991#comment-16984991 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984816#comment-16984816 ] Szilard Nemeth commented on YARN-9052: -- Re-attaching patch to see if test failure is intermittent or

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984591#comment-16984591 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984454#comment-16984454 ] Szilard Nemeth commented on YARN-9052: -- Hi [~sunilg]! Uploaded patch009. 1. To answer your question

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983846#comment-16983846 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983440#comment-16983440 ] Szilard Nemeth commented on YARN-9052: -- HI [~sunilg]! Thanks for your comments. Triggered a new

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983402#comment-16983402 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983146#comment-16983146 ] Sunil G commented on YARN-9052: --- Thanks [~snemeth] and apologies for delay # MockRMAppSubmitter is now used

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981391#comment-16981391 ] Sunil G commented on YARN-9052: --- Thanks [~snemeth] Thanks [~shuzirra] for spending good time in going

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979322#comment-16979322 ] Szilard Nemeth commented on YARN-9052: -- Hi [~sunilg]! You previously commented you will help

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979319#comment-16979319 ] Gergely Pollak commented on YARN-9052: -- Hi [~snemeth], thank you for the changes, I like your inner

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978736#comment-16978736 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978615#comment-16978615 ] Szilard Nemeth commented on YARN-9052: -- Hi [~shuzirra]! Thanks for your review comments! I think I

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978454#comment-16978454 ] Gergely Pollak commented on YARN-9052: -- Hi [~snemeth], thank you for the patch it was really due to

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978316#comment-16978316 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978314#comment-16978314 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978121#comment-16978121 ] Szilard Nemeth commented on YARN-9052: -- With the latest run there are still 2 test failures: 1.

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978048#comment-16978048 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977947#comment-16977947 ] Szilard Nemeth commented on YARN-9052: -- Thank god, only 5 testcases failed. Thanks to the exception

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974349#comment-16974349 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974347#comment-16974347 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973860#comment-16973860 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973834#comment-16973834 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973390#comment-16973390 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973279#comment-16973279 ] Szilard Nemeth commented on YARN-9052: -- Yes, the basic idea is this. But, I don't need to compare 2k

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973274#comment-16973274 ] Adam Antal commented on YARN-9052: -- I think it is a good idea to do in this way. So if my understanding

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973269#comment-16973269 ] Szilard Nemeth commented on YARN-9052: -- So as of now, we have a successful run for

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973184#comment-16973184 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973176#comment-16973176 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972752#comment-16972752 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972669#comment-16972669 ] Szilard Nemeth commented on YARN-9052: -- Thanks [~sunilg]! Right now, I'm in the process of adding

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972612#comment-16972612 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972552#comment-16972552 ] Sunil G commented on YARN-9052: --- Really appreciate [~snemeth]'s efforts here in cleaning up MockRM with a

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815645#comment-16815645 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815322#comment-16815322 ] Szilard Nemeth commented on YARN-9052: -- Hi [~adam.antal]! Thanks for the review! Yep, I agree that

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815321#comment-16815321 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815311#comment-16815311 ] Adam Antal commented on YARN-9052: -- Thanks for the patch [~snemeth], massive one! I wanted to have some

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698342#comment-16698342 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9052) Replace all MockRM submit method definitions with a builder

[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697924#comment-16697924 ] Hadoop QA commented on YARN-9052: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||