[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-09-01 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150527#comment-16150527 ] Sunil G commented on YARN-6933: --- Yes +1 from me as well. I ll commit shortly >

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147646#comment-16147646 ] Hadoop QA commented on YARN-6933: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-30 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147579#comment-16147579 ] Daniel Templeton commented on YARN-6933: Fine by me. I'll let [~sunilg] have the final say. >

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-30 Thread Manikandan R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147542#comment-16147542 ] Manikandan R commented on YARN-6933: [~sunilg], [~dan...@cloudera.com] Thanks for your review. Modified

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-29 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145670#comment-16145670 ] Daniel Templeton commented on YARN-6933: BTW, I'm otherwise fine with the patch. >

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-29 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145669#comment-16145669 ] Daniel Templeton commented on YARN-6933: Interesting point, [~sunilg]. I kinda think "valid" is

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-29 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145121#comment-16145121 ] Sunil G commented on YARN-6933: --- Thanks [~maniraj...@gmail.com] I think message in latest patch seems fine.

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145079#comment-16145079 ] Hadoop QA commented on YARN-6933: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-29 Thread Manikandan R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144977#comment-16144977 ] Manikandan R commented on YARN-6933: [~dan...@cloudera.com] Attaching a new patch with the changes. New

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142851#comment-16142851 ] Daniel Templeton commented on YARN-6933: The message used for CPUs and the other memory check is:

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138690#comment-16138690 ] Hadoop QA commented on YARN-6933: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-23 Thread Manikandan R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138568#comment-16138568 ] Manikandan R commented on YARN-6933: [~dan...@cloudera.com] Thanks for taking a look. Incorporated your

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137136#comment-16137136 ] Daniel Templeton commented on YARN-6933: Thanks for the patches, [~maniraj...@gmail.com]. I just

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-22 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136452#comment-16136452 ] Sunil G commented on YARN-6933: --- Latest patch seems fine. Committing later today if there are no objections.

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136391#comment-16136391 ] Hadoop QA commented on YARN-6933: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-21 Thread Manikandan R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136309#comment-16136309 ] Manikandan R commented on YARN-6933: Rebasing patch. > ResourceUtils.DISALLOWED_NAMES and

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135165#comment-16135165 ] Hadoop QA commented on YARN-6933: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-21 Thread Manikandan R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135143#comment-16135143 ] Manikandan R commented on YARN-6933: Modified the exception message. Also fixed checkstyle issues and

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-19 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134127#comment-16134127 ] Sunil G commented on YARN-6933: --- [~templedf], could you also please take a look. >

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-18 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133145#comment-16133145 ] Sunil G commented on YARN-6933: --- Latest patch seems fine to me. May be exception message in

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131916#comment-16131916 ] Hadoop QA commented on YARN-6933: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-18 Thread Manikandan R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131872#comment-16131872 ] Manikandan R commented on YARN-6933: [~sunilg] Thanks for very detailed explanation. Uploaded a new

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-16 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129242#comment-16129242 ] Sunil G commented on YARN-6933: --- I think i ll try to rephrase my comment # Ideally we do not want any user

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-16 Thread Manikandan R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129145#comment-16129145 ] Manikandan R commented on YARN-6933: [~sunilg] Currently {{ResourceUtils#checkMandatoryResources}} does

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-16 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129071#comment-16129071 ] Sunil G commented on YARN-6933: --- bq.Shall I define "M" as default for "memory"? I think lets not define any

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-14 Thread Manikandan R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126094#comment-16126094 ] Manikandan R commented on YARN-6933: [~sunilg] Thanks for the review. 1. I was under the impression

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-14 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125515#comment-16125515 ] Sunil G commented on YARN-6933: --- [~maniraj...@gmail.com] Thanks for the patch. Quick comments: # In

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116995#comment-16116995 ] Hadoop QA commented on YARN-6933: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-07 Thread Manikandan R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116909#comment-16116909 ] Manikandan R commented on YARN-6933: [~dan...@cloudera.com] Fixed junit failures by changing the test

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115820#comment-16115820 ] Hadoop QA commented on YARN-6933: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-06 Thread Manikandan R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115805#comment-16115805 ] Manikandan R commented on YARN-6933: [~dan...@cloudera.com] Thanks. {quote}You should also be able to

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115458#comment-16115458 ] Hadoop QA commented on YARN-6933: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115428#comment-16115428 ] Daniel Templeton commented on YARN-6933: Thanks, [~maniraj...@gmail.com]. You should also be able

[jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work

2017-08-05 Thread Manikandan R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115362#comment-16115362 ] Manikandan R commented on YARN-6933: Attached patch for review. Also addressed few more changes -