[
https://issues.apache.org/jira/browse/THRIFT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606041#action_12606041
]
Kevin Clark commented on THRIFT-38:
-----------------------------------
In this case I was taking patches from Ballard, so they already had commit
messages. In retrospect, I probably should have commit --amend 'd the last one
to mention the issue.
In general, I believe that when issues exist _before_ patches (not the reverse,
as it happened this time) we're putting the issue in the commit.
> Ruby lib rewrite and implementation of Thrift::NonblockingServer
> ----------------------------------------------------------------
>
> Key: THRIFT-38
> URL: https://issues.apache.org/jira/browse/THRIFT-38
> Project: Thrift
> Issue Type: Task
> Components: Compiler (Ruby), Library (Ruby), Test Suite
> Reporter: Kevin Ballard
> Assignee: Kevin Clark
> Attachments:
> 0001-rb-require-thrift-first-in-generated-service-defi.patch,
> 0002-rb-Use-defined-JRUBY_VERSION-to-detect-JRuby.patch,
> kballard-thrift.tar.bz2, thrift-gem.patch
>
>
> The attached tarball is a patch series for Kevin Clark's and my changes to
> the ruby libraries, including complete namespacing, rewrite of some of the
> implementation, brand new Thrift::NonblockingServer, complete specs, and
> jruby compatibility.
> This tarball contains 153 patches generated with git-format-patch. git-am
> should be able to re-apply them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
