[
https://issues.apache.org/jira/browse/THRIFT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606141#action_12606141
]
Doug Cutting commented on THRIFT-38:
------------------------------------
> I did attach a patch to JIRA before it was committed.
To be clear, I am not complaining about the process used for this issue (except
for the lack of Jira ids in the commit messages, and that's now been explained
away). I was responding to your more general comment that "JIRA may work
perfectly fine for dealing with small patches, but [...]". Perhaps I
misinterpreted your statement there. It sounded like you were proposing to
bypass Jira entirely, which would be a departure from what's been discussed.
Perhaps instead all that you meant was that patch files need not be attached to
Jira, but could instead pointed to in git from Jira, which is what's been
agreed on as a good practice.
Sorry if I'm a pain. As a mentor for this project, my job is to ensure that
Apache's community principles are observed -- a cop, not a role I relish. Git
is new at Apache and to me. I'm trying to raise questions early, rather than
let things go, which may lead to more short-term pain, but hopefully less
long-term. I don't want to dictate solutions, but rather want to help you
develop your own processes that are in accord with Apache's goals.
> Ruby lib rewrite and implementation of Thrift::NonblockingServer
> ----------------------------------------------------------------
>
> Key: THRIFT-38
> URL: https://issues.apache.org/jira/browse/THRIFT-38
> Project: Thrift
> Issue Type: Task
> Components: Compiler (Ruby), Library (Ruby), Test Suite
> Reporter: Kevin Ballard
> Assignee: Kevin Clark
> Attachments:
> 0001-rb-require-thrift-first-in-generated-service-defi.patch,
> 0002-rb-Use-defined-JRUBY_VERSION-to-detect-JRuby.patch,
> kballard-thrift.tar.bz2, thrift-gem.patch
>
>
> The attached tarball is a patch series for Kevin Clark's and my changes to
> the ruby libraries, including complete namespacing, rewrite of some of the
> implementation, brand new Thrift::NonblockingServer, complete specs, and
> jruby compatibility.
> This tarball contains 153 patches generated with git-format-patch. git-am
> should be able to re-apply them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
