[ 
https://issues.apache.org/jira/browse/THRIFT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606116#action_12606116
 ] 

Doug Cutting commented on THRIFT-38:
------------------------------------

> Kevin C: when issues exist before patches [ ... ]

Issues should always exist before patches, no?  Otherwise how do folks discuss 
the patch?

> Kevin B: It seems fairly redundant to create an issue for the express purpose 
> of committing patches

Folks should have an opportunity to review and comment on things before commit. 
 Jira is the forum we've selected for this, isn't it?

> Ruby lib rewrite and implementation of Thrift::NonblockingServer
> ----------------------------------------------------------------
>
>                 Key: THRIFT-38
>                 URL: https://issues.apache.org/jira/browse/THRIFT-38
>             Project: Thrift
>          Issue Type: Task
>          Components: Compiler (Ruby), Library (Ruby), Test Suite
>            Reporter: Kevin Ballard
>            Assignee: Kevin Clark
>         Attachments: 
> 0001-rb-require-thrift-first-in-generated-service-defi.patch, 
> 0002-rb-Use-defined-JRUBY_VERSION-to-detect-JRuby.patch, 
> kballard-thrift.tar.bz2, thrift-gem.patch
>
>
> The attached tarball is a patch series for Kevin Clark's and my changes to 
> the ruby libraries, including complete namespacing, rewrite of some of the 
> implementation, brand new Thrift::NonblockingServer, complete specs, and 
> jruby compatibility.
> This tarball contains 153 patches generated with git-format-patch. git-am 
> should be able to re-apply them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to