[
https://issues.apache.org/jira/browse/THRIFT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606125#action_12606125
]
Doug Cutting commented on THRIFT-38:
------------------------------------
> JIRA may work perfectly fine for dealing with small patches, but with
> long-running topic branches it's far easier (for everyone) to publish commits
> via git and have other people review them that way.
That works fine if everyone is monitoring your git repo. But the stated goal
for Thrift at Apache is to incorporate non-git-users as first-class citizens.
So, unless that goal is dropped, patches should be introduced via a Jira issue
before commit. The patch need not be attached to the Jira issue, a pointer to
it in git is sufficient. Updates to the patch responding to comments should
also be indicated in Jira with a comment on the issue.
> Ruby lib rewrite and implementation of Thrift::NonblockingServer
> ----------------------------------------------------------------
>
> Key: THRIFT-38
> URL: https://issues.apache.org/jira/browse/THRIFT-38
> Project: Thrift
> Issue Type: Task
> Components: Compiler (Ruby), Library (Ruby), Test Suite
> Reporter: Kevin Ballard
> Assignee: Kevin Clark
> Attachments:
> 0001-rb-require-thrift-first-in-generated-service-defi.patch,
> 0002-rb-Use-defined-JRUBY_VERSION-to-detect-JRuby.patch,
> kballard-thrift.tar.bz2, thrift-gem.patch
>
>
> The attached tarball is a patch series for Kevin Clark's and my changes to
> the ruby libraries, including complete namespacing, rewrite of some of the
> implementation, brand new Thrift::NonblockingServer, complete specs, and
> jruby compatibility.
> This tarball contains 153 patches generated with git-format-patch. git-am
> should be able to re-apply them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
