[
https://issues.apache.org/jira/browse/THRIFT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606143#action_12606143
]
Kevin Ballard commented on THRIFT-38:
-------------------------------------
Ok, it does sound like I didn't explain myself properly. Yes, I'm advocating
doing all the collaboration and review in git, using either git directly (for
git users like me) or the powerful review tools available on the web (for
non-git users). However, nothing would actually be committed to the repo
without going through JIRA. Worst-case is the way this issue worked, where I
attached a tarball of 153 commits. Best-case would be posting a simple commit
hash to JIRA (which references a commit at thrift-rpc.org), which can then be
reviewed and pushed to svn just like a patch.
> Ruby lib rewrite and implementation of Thrift::NonblockingServer
> ----------------------------------------------------------------
>
> Key: THRIFT-38
> URL: https://issues.apache.org/jira/browse/THRIFT-38
> Project: Thrift
> Issue Type: Task
> Components: Compiler (Ruby), Library (Ruby), Test Suite
> Reporter: Kevin Ballard
> Assignee: Kevin Clark
> Attachments:
> 0001-rb-require-thrift-first-in-generated-service-defi.patch,
> 0002-rb-Use-defined-JRUBY_VERSION-to-detect-JRuby.patch,
> kballard-thrift.tar.bz2, thrift-gem.patch
>
>
> The attached tarball is a patch series for Kevin Clark's and my changes to
> the ruby libraries, including complete namespacing, rewrite of some of the
> implementation, brand new Thrift::NonblockingServer, complete specs, and
> jruby compatibility.
> This tarball contains 153 patches generated with git-format-patch. git-am
> should be able to re-apply them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
