[
https://issues.apache.org/jira/browse/THRIFT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606130#action_12606130
]
Kevin Ballard commented on THRIFT-38:
-------------------------------------
> That works fine if everyone is monitoring your git repo. But the stated goal
> for Thrift at Apache is to incorporate non-git-users as first-class citizens.
> So, unless that goal is dropped, patches should be introduced via a Jira
> issue before commit. The patch need not be attached to the Jira issue, a
> pointer to it in git is sufficient. Updates to the patch responding to
> comments should also be indicated in Jira with a comment on the issue.
I did attach a patch to JIRA before it was committed. That's this item right
here, THRIFT-38. A compilation of all my patches to fill 2 goals:
1) check off the box
2) give Kevin Clark a second chance to review all the changes before he
committed them to svn.
And yes, I realize you want to incorporate non-git-users as first-class
citizens, but that doesn't mean not using git. As has been pointed out on the
mailing list, there are plenty of tools for reviewing git commits in the web
browser, both on github and on thrift-rpc.org, and people can download tarballs
of the source. In fact, these tools are far better than trying to post patches
to this list for the ongoing branch and having people review them that way -
not only it is a *lot* more overhead on my part, the tools for reviewing a
patch here just aren't as good as the git web tools are. So using git doesn't
force everybody else to be a "second-class citizen", since they have even
better tools for reviewing than if I wasn't using git.
> Ruby lib rewrite and implementation of Thrift::NonblockingServer
> ----------------------------------------------------------------
>
> Key: THRIFT-38
> URL: https://issues.apache.org/jira/browse/THRIFT-38
> Project: Thrift
> Issue Type: Task
> Components: Compiler (Ruby), Library (Ruby), Test Suite
> Reporter: Kevin Ballard
> Assignee: Kevin Clark
> Attachments:
> 0001-rb-require-thrift-first-in-generated-service-defi.patch,
> 0002-rb-Use-defined-JRUBY_VERSION-to-detect-JRuby.patch,
> kballard-thrift.tar.bz2, thrift-gem.patch
>
>
> The attached tarball is a patch series for Kevin Clark's and my changes to
> the ruby libraries, including complete namespacing, rewrite of some of the
> implementation, brand new Thrift::NonblockingServer, complete specs, and
> jruby compatibility.
> This tarball contains 153 patches generated with git-format-patch. git-am
> should be able to re-apply them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
