[
https://issues.apache.org/jira/browse/THRIFT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606118#action_12606118
]
Kevin Ballard commented on THRIFT-38:
-------------------------------------
I've been going back and forth with Kevin Clark for a while now on these
changes, and he's reviewed them a couple times. If you look, I submitted, in
total, 160 patches. It would have been infeasible to post them all as patches
to JIRA.
Not only did Kevin Clark review them, but I also posted to the ML with links to
the git repos where my work could be found, so anybody who wanted to could
informally review them.
JIRA may work perfectly fine for dealing with small patches, but with
long-running topic branches it's far easier (for everyone) to publish commits
via git and have other people review them that way.
> Ruby lib rewrite and implementation of Thrift::NonblockingServer
> ----------------------------------------------------------------
>
> Key: THRIFT-38
> URL: https://issues.apache.org/jira/browse/THRIFT-38
> Project: Thrift
> Issue Type: Task
> Components: Compiler (Ruby), Library (Ruby), Test Suite
> Reporter: Kevin Ballard
> Assignee: Kevin Clark
> Attachments:
> 0001-rb-require-thrift-first-in-generated-service-defi.patch,
> 0002-rb-Use-defined-JRUBY_VERSION-to-detect-JRuby.patch,
> kballard-thrift.tar.bz2, thrift-gem.patch
>
>
> The attached tarball is a patch series for Kevin Clark's and my changes to
> the ruby libraries, including complete namespacing, rewrite of some of the
> implementation, brand new Thrift::NonblockingServer, complete specs, and
> jruby compatibility.
> This tarball contains 153 patches generated with git-format-patch. git-am
> should be able to re-apply them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
