-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Al 03/08/13 11:18, En/na Cédric Krier ha escrit: > On 02/08/13 20:37 +0200, Albert Cervera i Areny wrote: >>> A Divendres 02 Agost 2013 18:12:42, Sergi Almacellas Abellana >>> va escriure: >>>>> Al 29/07/13 13:49, En/na LAG Robin Baumgartner ha escrit: >>>>>>>>> Corresponding feature request: >>>>>>>>> https://bugs.tryton.org/issue3320 >>>>>>> >>>>>>> I would appreciate some more feedback on this proposal, >>>>>>> especially from the participants of the discussion. >>>>>>> Does it reflect the ideas you had in mind? >>>>> >>>>> I had been reviewing the code and testing the new >>>>> functionalities and for me its a very good improvement in >>>>> the workflow. Congrats! >>>>> >>>>> Another thing I have commented on the codereview, but i >>>>> would like to comment also here to get more audience: >>>>> >>>>> For me every opportunity will have two amount fields: >>>>> >>>>> - Expected amount -> The one that exists nowadays. - Won >>>>> amount -> The sum of the amount of all the confirmed sales. >>>>> This will be a function field and will only be evaluated >>>>> when the state is won. All the reports should use this >>>>> amount for Won amount, and won rates to get the real >>>>> revenue of the sale, not the expected amount (as it's done >>>>> nowadays) >>>>> >>>>> Thoughts? >>> >>> I agree but why should it only be evaluted when the state is >>> won? I think it should simply sum all confirmed sales.
Because when one sale is confirmed the opportunity is marked as won :) > Such summed Function field based on other Function field based on … > are pretty slow (see the sale/purchase amount and invoice amount). > I think it is better to store it and update it when the sale > workflow is triggered. I agree on storing the field and updating it on the sale workflow. - -- Sergi Almacellas Abellana www.koolpi.com Twitter: @pokoli_srk -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJR/RMzAAoJEGRfwiQCVal5NfwH/ik5xyTNTSkyAezvGz5s5xul H6eM7beLSVhEvmXZns1qYvrBP1BVClQvTIQHPg8D2Z8vFHs6mCjPy72TDsZ916tO hiLpIynZTrGETBAl51ikAsnxFhLrOcN19fe/fJeycy4Z+a8jA1XSoUkUHgGwJ3fV EGP5Okcd9owN8VEqH/foBLqyOhW5lnea4MzaGpDb+ti67W972eAr/Dukr+DDaxfX UK5stdbg87HdOcMISF4f2hdTLzYkQJ9tImV4ltYbTgP7yc3cQKOLlu0wGVC4x64I UKmhvhoJCfYZI10Ft0pOrxvWYJudR2cliuX4ha1NkexJG42OYXxxuONUzGniXTY= =RSyq -----END PGP SIGNATURE-----
