On 03.08.2013 11:18, Cédric Krier wrote: > On 02/08/13 20:37 +0200, Albert Cervera i Areny wrote: >> A Divendres 02 Agost 2013 18:12:42, Sergi Almacellas Abellana va >> escriure: >>> Al 29/07/13 13:49, En/na LAG Robin Baumgartner ha escrit: >>>>> Corresponding feature request: >>>>> https://bugs.tryton.org/issue3320 >>>> >>>> I would appreciate some more feedback on this proposal, >>>> especially from the participants of the discussion. Does it >>>> reflect the ideas you had in mind? >>> >>> I had been reviewing the code and testing the new >>> functionalities and for me its a very good improvement in the >>> workflow. Congrats! >>> >>> Another thing I have commented on the codereview, but i would >>> like to comment also here to get more audience: >>> >>> For me every opportunity will have two amount fields: >>> >>> - Expected amount -> The one that exists nowadays. - Won amount >>> -> The sum of the amount of all the confirmed sales. This will >>> be a function field and will only be evaluated when the state >>> is won. All the reports should use this amount for Won amount, >>> and won rates to get the real revenue of the sale, not the >>> expected amount (as it's done nowadays) >>> >>> Thoughts? >> I agree but why should it only be evaluted when the state is won? >> I think it should simply sum all confirmed sales. > > Such summed Function field based on other Function field based on … > are pretty slow (see the sale/purchase amount and invoice amount). > I think it is better to store it and update it when the sale > workflow is triggered.
Agree. To make the difference clear, I renamed the field 'amount' into 'expected_amount'. A new patch set is ready for review.
