* Dan Kenigsberg <dan...@redhat.com> [2012-09-10 06:46]:
> On Sun, Sep 09, 2012 at 12:27:30PM -0500, Adam Litke wrote:
> > Hi,
> > I want to open up a discussion about patch reviews in the vdsm project. I
> > believe everyone will agree that more code review needs to happen for the
> > betterment of the project. I want to ask everyone some questions and also
> > make
> > some observations. I hope to gain some insights and improve my own
> > workflow.
> > And I hope the same for everyone else too.
> > How much time in a week do you spend reviewing patches?
> For me it is a couple of hours every day...
> > We have a lot of open patches in gerrit. When deciding to review some
> > code, how
> > do you select a patch to review. I have heard people say that they only
> > select
> > patches which have named them specifically as a reviewer. How does a new
> > contributor know who to ask?
> I think that `git blame` on the relevant code area would take him a
> long way. I personally add people I trust as reviewers to patches
> written by third parties.
Is there anyway to progamatically do that? running git-blame to collect
developer names, and then adding them on each push via the web seems
like a lot of extra steps a new developer has to do to ensure they get
Ideally our barrier to contributions should be as low as possible.
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
vdsm-devel mailing list