Oh that _does_ look good. Its a shame we didn't patch that in at the time. Lets fix that now.
Tad, can you could update that change to work against the current source tree, and use the request_codereview tool to upload a patch to codereview.waveprotocol.org when you're done? Add me and Doug as reviewers. Doug can comment on the flash websocket bits (since he probably understands how that works). I'll submit the code to the repository when everyone's happy with it. ... I think you shouldn't need the changes to jetty anymore (we're using jetty 7.1.6 now). If its easy, it'd also be a bit cleaner if you took startFlashPolicyServer out of ServerRpcProvider. (The class is getting very kitchen sinky - I'd rather not add to it if we can manage it). Cheers -Joseph On Mon, Sep 27, 2010 at 10:06 AM, James Purser <[email protected]> wrote: > http://code.google.com/r/tadglines-websockets/source/checkout looks good. > > James > > On Mon, Sep 27, 2010 at 8:08 AM, Joseph Gentle <[email protected]> wrote: >> Is the code still kicking around somewhere? >> >> -J >> >> >> On Mon, Sep 27, 2010 at 6:24 AM, Tad Glines <[email protected]> wrote: >>> I created a branch several months ago that had a web-socket-js working. The >>> name of the branch/clone is tadglines-webaockets. It's based off the io2010 >>> branch but it should be trivial to merge. >>> >>> I created it the same day that someone at google wished for it on this >>> list. But I think it got lost in the shuffle. >>> >>> -Tad >>> >>> On Sep 26, 2010, at 3:47 AM, dougx <[email protected]> wrote: >>> >>>> So, >>>> >>>> I've ported http://github.com/gimite/web-socket-js into the wave- >>>> protocol's GWT websocket implementation so the client works with >>>> firefox, etc. >>>> >>>> woo. >>>> >>>> ..but although it seems to talk it doesn't actually work. :( It just >>>> sits on 'Never Connected' status in firefox. >>>> >>>> The console log is showing: >>>> >>>> [WebSocket] policy file: xmlsocket://192.168.1.10:843 >>>> [WebSocket] Flash object is ready >>>> [WebSocket] FABridge initializad >>>> [WebSocket] connected >>>> [WebSocket] request header: GET /socket HTTP/1.1 Upgrade: WebSocket >>>> Connection: Upgrade Host: 192.168.1.10:9898 Origin: >>>> http://192.168.1.10:9898 >>>> Cookie: Sec-WebSocket-Key1: 28 `50e7kptb 6v (35=-1 8U Sec-WebSocket- >>>> Key2: 2i58 5 334H 8 6' E 4' >>>> [WebSocket] sent key3: -µ”£Îªç… >>>> [WebSocket] response header: HTTP/1.1 101 WebSocket Protocol Handshake >>>> Upgrade: WebSocket Connection: Upgrade Sec-WebSocket-Origin: >>>> http://192.168.1.10:9898 Sec-WebSocket-Location: >>>> ws://192.168.1.10:9898/socket >>>> [WebSocket] reply digest: ÿICú�8¼ ‡gPÈ” õî >>>> >>>> O_o I haven't had time to dig into what that might mean on the socket >>>> comm protocol; anyone here have some idea? >>>> >>>> I recall some discussion about protocol versions or something? >>>> >>>> Other things: >>>> >>>> As described here, a policy file service needs to run: >>>> http://www.lightsphere.com/dev/articles/flash_socket_policy.html >>>> >>>> At the moment I'm just running a separate script on the server to >>>> handle that, but it seems like a dumb solution. Seems like Fedone >>>> should handle this, but it's a bit hacky to be opening other port just >>>> for flash websocket support. >>>> >>>> thoughts? >>>> >>>> Also, how should the code base handle the swf source? At the moment >>>> I've just dumped the binary into: >>>> wave-protocol/src/com/google/gwt/websockets/client/binary/ >>>> >>>> ...but that also seems like a poor long term solution. >>>> >>>> ~ >>>> Doug. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "Wave Protocol" group. >>>> To post to this group, send email to [email protected]. >>>> To unsubscribe from this group, send email to >>>> [email protected]. >>>> For more options, visit this group at >>>> http://groups.google.com/group/wave-protocol?hl=en. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "Wave Protocol" group. >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]. >>> For more options, visit this group at >>> http://groups.google.com/group/wave-protocol?hl=en. >>> >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Wave Protocol" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/wave-protocol?hl=en. >> >> > > -- > You received this message because you are subscribed to the Google Groups > "Wave Protocol" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/wave-protocol?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Wave Protocol" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/wave-protocol?hl=en.
