> Tad, can you could update that change to work against the current > source tree, and use the request_codereview tool to upload a patch to > codereview.waveprotocol.org when you're done? Add me and Doug as > reviewers. Doug can comment on the flash websocket bits (since he > probably understands how that works). I'll submit the code to the > repository when everyone's happy with it. >
Doug has already submitted a patch, let's just go with that one. > ... I think you shouldn't need the changes to jetty anymore (we're > using jetty 7.1.6 now). If its easy, it'd also be a bit cleaner if you > took startFlashPolicyServer out of ServerRpcProvider. (The class is > getting very kitchen sinky - I'd rather not add to it if we can manage > it). > Requiring a separate flash socket policy server is a bit clunky. What's wrong with including it in FedOne? The name ServerRpcProvider is no longer accurate since it also contains all the jetty setup code as well. Including the flash policy socket stuff just made sense. I made it configurable so users could turn it on or off if needed. -Tad -- You received this message because you are subscribed to the Google Groups "Wave Protocol" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/wave-protocol?hl=en.
