Follow-up Comment #7, patch #3083 (project wesnoth):
Okay, I've fixed all of the problems that I've been able to find. It turns
out I had accounted for both parties dying, but I had a bunch of problems
related to negative numbers in unsigned variables; now that section of code
has a bunch of signed/unsigned casts. I'm wondering if it would be good to
just change all of those variables representing damage and HP to signed, even
the ones that I don't currently need to contain a negative number, just to
avoid having to switch between signed and unsigned constantly (though I'm
pretty sure there's no performance hit for doing that).
I've been finding drain as a damage modifier very confusing due to the 50%
default needed for backwards compatibility, so I think option #3 ([drain]
value represents a percentage, and [heal_on_hit] is used for fixed amounts) is
the way to go.
I've attached a cumulative patch for all of my changes to date.
(file #15027)
_______________________________________________________
Additional Item Attachment:
File name: extended-drain.patch Size:19 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3083>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
