Follow-up Comment #10, patch #3083 (project wesnoth):

Just a final few things:
Many of compile in strict mode as we try to keep our code free from warnings.


cc1plus: warnings being treated as errors
src/attack_prediction.cpp: In member function
‘void<unnamed>::prob_matrix::shift_cols(unsigned int, unsigned int, unsigned
int, double, int, int)’:
src/attack_prediction.cpp:301: error: suggest braces around empty body in an
‘if’ statement
src/attack_prediction.cpp: In member function
‘void<unnamed>::prob_matrix::shift_rows(unsigned int, unsigned int, unsigned
int, double, int, int)’:
src/attack_prediction.cpp:335: error: suggest braces around empty body in an
‘if’ statement

These especially may seem trivial, but as debug is actually a macro, very
strange things may happen.

And something that actually is trivial (I'd have fixed it myself if it was the
only thing): In WML we use 4 spaces for indentation, no tabs. The wmlindent
tool can fix this for you.

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?3083>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to