On Sat, 14 Sep 2024 12:34:00 +0200 ichthyo <p...@ichthyostega.de> wrote:
>On 13.09.24 13:06, Kristian Amlie wrote: >>> It has nothing to do with MIDI Learn. >>> ...just switch to Legato mode, and play any two notes. >On my rebased "guiconnect" feature this is fixed now. > >I had made a mistake while adapting the constructor of the Filter >baseclass, resulting in only a shallow copy be made when cloning. >Thus the secondary note objects on legato did alias the filter >implementation object, which was then deleted at the end of the >primary note; after that, synth-code went into a use-after-delete, >which caused it to invoke a corrupted this pointer eventually. > > >Will: its seems we're ready for the pull-request? > >-- Hermann Yes, I think so. There is just one minor oddity. I'm not entirely sure it's a problem. There is a change in the behaviour of the the System effects On/Off switch - which is never saved as it's intended purely for a quick comparison of results - similar to the master Mono/Stereo Previously it was always on, unless the user switches it off. Now, at startup it is on, but only for the first effect, and switching between effects will switch it off *unless* the effect is 'occupied'. Similarly it is switched off on resets. This means that from a standing start, you now have to perform two actions instead of one. It's not exactly difficult, but unexpected. It would be especially puzzling for CLI users as they would be able to set effects, and have them active, while the GUI was still showing it as being off. -- Will _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
