On Sun, 15 Sep 2024 16:14:02 +0200 ichthyo <p...@ichthyostega.de> wrote:
>I have just pushed out a draft fix on my "guiconnect" branch, which now >does no longer disable the type select drop-down, and also immediately >sets the checkbox once the user selects an effect type. On later push-updates, >the enabled-checkbox will then be set from the actual enabled-state of the >corresponding slot in the core, which IMHO is the correct behaviour, but >also would give the user the additional convenience. > >Does this look OK for you? Yes. That looks OK. For the sake of consistency the C/P buttons should also remain permanently on. Also in insertion effects we should no longer disable effect selection when set to Off in the destination selector. As an aside, I have no problem with being able to save/load 'No Effect'. Although somewhat pointless, it's perfectly valid as an effect. I try to avoid special cases as much as possible. >Another note: Yesterday I have reworked the build switches on the CMake build >to properly handle the assertions on Release builds. See the corresponding new >changeset. Basically I have now added a new toggle as convenience for us >developers. When selecting BuildForDiagnostic, then even on release builds >the debug info is included and also the assertions remain activated. By default >this new toggle is OFF, meaning that from now on, Release builds will no longer >include the assertion checking code, which could give use a small-ish >performance gain. CMake is something I find mind-numbingly obscure - I tend to leave it to everyone else! -- Will J Godfrey. _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
