On 15.09.24 10:55, Will Godfrey wrote:
On Sat, 14 Sep 2024 13:05:07 +0100
Will Godfrey <willgodf...@musically.me.uk> wrote:
There is a change in the behaviour of the the System effects On/Off switch
-
I've found the commit where this changed. It is 72a4ef2
Hi Will,
glad you could narrow it down already. This commit was in the first feature,
which we landed already this spring. The changeset does "remove UI state
regarding effect number and type", so this is at the point where we have
already integrated the new data connection for the EffectUI and now
all widgets in that part are switched over to the data values sent from core.
Presumably the actual behaviour change happens earlier, somewhere in core,
or maybe it happens indirectly. I'll have a look at this to figure out the
cause.
I have also spotted one change where I likewise want to understand how it
comes about: The Test-Suite shows sonic changes in presumably all Add-Synth
and Sub-Synth test cases. The difference was inaudible in about 6 of those
cases, which I investigated. Yet I am surpised there are any changes, since
I was under the impression that this refactoring did not touch the actual
sound computation path.
-- Hermann
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
