On Tue, Jan 22, 2013 at 4:02 PM, Spencer Oliver <[email protected]> wrote: > I have not renamed anything, your original patch changed the name. > What my cleanup is trying todo is split the actual changes from noise.
What you say is not true - see http://openocd.zylin.com/#/c/1077/13..14/src/jtag/core.c You have renamed oocd_transport_declared() to transports_are_declared(), oocd_transport_allow() to allow_transports(), etc. WTF?! > If you feel this name needs changing then that should be a separate > change, otherwise it is hard for us to review. > I do not see any value in adding oocd_ prefix to names, just more noise. I have done smaller changes like that with comments for example and these were a "noise" for you as well. Because YOU can't see any value it does not mean there is no value. Except there is a new transport capability, I have presented way the code should look also in other places. I had two free weeks to introduce other changes and that time is now wasted. The main problem right now is that we are not working on one commit, but whole bunch of commits which additionally makes things difficult... I guess I should simply wait until your work is done and see the results, then comment, okay? :-) -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
